157598 2016-05-11 16:58:31 -0700 Web Inspector: Unexpected unread notification icon next to Log after clearing via clear() 2016-05-11 18:04:04 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1192155 0 joepeck 2016-05-11 16:58:31 -0700 * SUMMARY Unexpected unread notification icon next to Log after clearing via clear() * STEPS TO REPRODUCE 1. Inspect about:blank 2. Show Console Tab 3. Select Error filter 4. js> clear() or 1+1 => Unread notification icon next to Log doesn't make sense * NOTES - We always show ConsoleCommand and ConsoleCommandResults regardless of filters, so a ConsoleCommandResult should not affect the unread indicators. 1192156 1 278682 joepeck 2016-05-11 16:59:42 -0700 Created attachment 278682 [PATCH] Proposed Fix 1192180 2 278682 commit-queue 2016-05-11 18:04:00 -0700 Comment on attachment 278682 [PATCH] Proposed Fix Clearing flags on attachment: 278682 Committed r200720: <http://trac.webkit.org/changeset/200720> 1192181 3 commit-queue 2016-05-11 18:04:04 -0700 All reviewed patches have been landed. Closing bug. 278682 2016-05-11 16:59:42 -0700 2016-05-11 18:04:00 -0700 [PATCH] Proposed Fix more-console-unread.patch text/plain 2684 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDNhMWY2NWIuLmZkMjUzYTcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE2LTA1LTExICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVW5leHBl Y3RlZCB1bnJlYWQgbm90aWZpY2F0aW9uIGljb24gbmV4dCB0byBMb2cgYWZ0ZXIgY2xlYXJpbmcg dmlhIGNsZWFyKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE1NzU5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdlIGFsd2F5cyBzaG93IENvbnNvbGVDb21tYW5kIGFuZCBDb25zb2xlQ29tbWFuZFJlc3Vs dCBtZXNzYWdlcyBubyBtYXR0ZXIKKyAgICAgICAgd2hhdCB0aGUgZmlsdGVyIGlzLiBTbyBpdCBk b2Vzbid0IG1ha2Ugc2Vuc2UgdG8gbWFyayB0aGUgImxvZyIgZmlsdGVyCisgICAgICAgIGFzIGhh dmluZyBhbiB1bnJlYWQgbm90aWZpY2F0aW9uIGZvciBhIENvbnNvbGVDb21tYW5kUmVzdWx0IHdo ZW4gd2UgY2FuCisgICAgICAgIHNlZSB0aGUgcmVzdWx0LgorCisgICAgICAgICogVXNlckludGVy ZmFjZS9WaWV3cy9Mb2dDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Mb2dD b250ZW50Vmlldy5wcm90b3R5cGUuZGlkQXBwZW5kQ29uc29sZU1lc3NhZ2VWaWV3KToKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5Mb2dDb250ZW50Vmlldy5wcm90b3R5cGUuX21hcmtTY29wZUJhckl0 ZW1VbnJlYWQpOgorCisyMDE2LTA1LTExICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBs ZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogQ29uc29sZSB1bnJlYWQgaW5kaWNhdG9y cyBzaG91bGQgYmUgY2xlYXJlZCBob3dldmVyIHRoZSBjb25zb2xlIGNsZWFycwogICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3NTk0CiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRlbnRW aWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTG9nQ29u dGVudFZpZXcuanMKaW5kZXggODZmZWEzYy4uYTAyYmZiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTG9nQ29udGVudFZpZXcuanMKKysrIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTG9nQ29udGVudFZpZXcu anMKQEAgLTE2Miw3ICsxNjIsOCBAQCBXZWJJbnNwZWN0b3IuTG9nQ29udGVudFZpZXcgPSBjbGFz cyBMb2dDb250ZW50VmlldyBleHRlbmRzIFdlYkluc3BlY3Rvci5Db250ZW50VgogCiAgICAgICAg IGlmICh0eXBlICYmIHR5cGUgIT09IFdlYkluc3BlY3Rvci5Db25zb2xlTWVzc2FnZS5NZXNzYWdl VHlwZS5FbmRHcm91cCkgewogICAgICAgICAgICAgY29uc29sZS5hc3NlcnQobWVzc2FnZVZpZXcu bWVzc2FnZSBpbnN0YW5jZW9mIFdlYkluc3BlY3Rvci5Db25zb2xlTWVzc2FnZSk7Ci0gICAgICAg ICAgICB0aGlzLl9tYXJrU2NvcGVCYXJJdGVtVW5yZWFkKG1lc3NhZ2VWaWV3Lm1lc3NhZ2UubGV2 ZWwpOworICAgICAgICAgICAgaWYgKCEobWVzc2FnZVZpZXcubWVzc2FnZSBpbnN0YW5jZW9mIFdl Ykluc3BlY3Rvci5Db25zb2xlQ29tbWFuZFJlc3VsdE1lc3NhZ2UpKQorICAgICAgICAgICAgICAg IHRoaXMuX21hcmtTY29wZUJhckl0ZW1VbnJlYWQobWVzc2FnZVZpZXcubWVzc2FnZS5sZXZlbCk7 CiAKICAgICAgICAgICAgIGNvbnNvbGUuYXNzZXJ0KG1lc3NhZ2VWaWV3LmVsZW1lbnQgaW5zdGFu Y2VvZiBFbGVtZW50KTsKICAgICAgICAgICAgIHRoaXMuX2ZpbHRlck1lc3NhZ2VFbGVtZW50cyhb bWVzc2FnZVZpZXcuZWxlbWVudF0pOwpAQCAtMzE0LDEzICszMTUsMTEgQEAgV2ViSW5zcGVjdG9y LkxvZ0NvbnRlbnRWaWV3ID0gY2xhc3MgTG9nQ29udGVudFZpZXcgZXh0ZW5kcyBXZWJJbnNwZWN0 b3IuQ29udGVudFYKIAogICAgIF9tYXJrU2NvcGVCYXJJdGVtVW5yZWFkKGxldmVsKQogICAgIHsK LSAgICAgICAgdmFyIG1lc3NhZ2VMZXZlbCA9IHRoaXMuX3Njb3BlRnJvbU1lc3NhZ2VMZXZlbChs ZXZlbCk7Ci0KKyAgICAgICAgbGV0IG1lc3NhZ2VMZXZlbCA9IHRoaXMuX3Njb3BlRnJvbU1lc3Nh Z2VMZXZlbChsZXZlbCk7CiAgICAgICAgIGlmICghbWVzc2FnZUxldmVsKQogICAgICAgICAgICAg cmV0dXJuOwogCi0gICAgICAgIHZhciBpdGVtID0gdGhpcy5fc2NvcGVCYXIuaXRlbShtZXNzYWdl TGV2ZWwpOwotCisgICAgICAgIGxldCBpdGVtID0gdGhpcy5fc2NvcGVCYXIuaXRlbShtZXNzYWdl TGV2ZWwpOwogICAgICAgICBpZiAoaXRlbSAmJiAhaXRlbS5zZWxlY3RlZCAmJiAhdGhpcy5fc2Nv cGVCYXIuaXRlbShXZWJJbnNwZWN0b3IuTG9nQ29udGVudFZpZXcuU2NvcGVzLkFsbCkuc2VsZWN0 ZWQpCiAgICAgICAgICAgICBpdGVtLmVsZW1lbnQuY2xhc3NMaXN0LmFkZCgidW5yZWFkIik7CiAg ICAgfQo=