157594 2016-05-11 16:41:42 -0700 Web Inspector: Console unread indicators should be cleared however the console clears 2016-05-11 17:48:59 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1192145 0 joepeck 2016-05-11 16:41:42 -0700 * SUMMARY Console unread indicators should be cleared however the console clears * TEST <script> console.error("error"); console.warn("warn"); console.log("log"); </script> * STEPS TO REPRODUCE 1. Inspect test page 2. Show Console Tab 3. Select Error Filter 4. Reload => Should have unread indicators for Logs / Warnings 5. Clear console via `clear()` or Cmd+K keyboard shortcut => Unread indicators still exist * NOTES Unread indicators are cleared when using the clear button. 1192146 1 278681 joepeck 2016-05-11 16:42:45 -0700 Created attachment 278681 [PATCH] Proposed Fix 1192147 2 webkit-bug-importer 2016-05-11 16:44:21 -0700 <rdar://problem/26234174> 1192149 3 nvasilyev 2016-05-11 16:47:11 -0700 (In reply to comment #1) > Created attachment 278681 [details] > [PATCH] Proposed Fix Looks good to me! 1192175 4 278681 commit-queue 2016-05-11 17:48:55 -0700 Comment on attachment 278681 [PATCH] Proposed Fix Clearing flags on attachment: 278681 Committed r200719: <http://trac.webkit.org/changeset/200719> 1192176 5 commit-queue 2016-05-11 17:48:59 -0700 All reviewed patches have been landed. Closing bug. 278681 2016-05-11 16:42:45 -0700 2016-05-11 17:48:55 -0700 [PATCH] Proposed Fix clear-unread.patch text/plain 2584 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGE1NGM5OTEuLjNhMWY2NWIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA1LTExICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ29uc29s ZSB1bnJlYWQgaW5kaWNhdG9ycyBzaG91bGQgYmUgY2xlYXJlZCBob3dldmVyIHRoZSBjb25zb2xl IGNsZWFycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTU3NTk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBVc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRlbnRWaWV3LmpzOgorICAgICAgICAoV2ViSW5z cGVjdG9yLkxvZ0NvbnRlbnRWaWV3LnByb3RvdHlwZS5fbG9nQ2xlYXJlZCk6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuTG9nQ29udGVudFZpZXcucHJvdG90eXBlLl9jbGVhckxvZyk6CisgICAgICAg IE1vdmUgY29kZSB0aGF0IGNsZWFycyB1bnJlYWQgaW5kaWNhdG9ycyBmcm9tIGNsZWFyTG9nIHRv IGxvZ0NsZWFyZWQKKyAgICAgICAgdG8gaGFuZGxlIGFsbCBwb3NzaWJsZSBjbGVhciBjYXNlcy4K KwogMjAxNi0wNS0xMSAgTmlraXRhIFZhc2lseWV2ICA8bnZhc2lseWV2QGFwcGxlLmNvbT4KIAog ICAgICAgICBXZWIgSW5zcGVjdG9yOiAiU2VsZWN0ZWQgRWxlbWVudCIgaXMgaGFyZCB0byByZWFk IHdoZW4gc2VhcmNoaW5nIGZvciAiRWxlbWVudCIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRlbnRWaWV3LmpzIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTG9nQ29udGVudFZpZXcuanMKaW5kZXgg NGNhOGUxMS4uODZmZWEzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvTG9nQ29udGVudFZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTG9nQ29udGVudFZpZXcuanMKQEAgLTE2Nyw4ICsxNjcs NiBAQCBXZWJJbnNwZWN0b3IuTG9nQ29udGVudFZpZXcgPSBjbGFzcyBMb2dDb250ZW50VmlldyBl eHRlbmRzIFdlYkluc3BlY3Rvci5Db250ZW50VgogICAgICAgICAgICAgY29uc29sZS5hc3NlcnQo bWVzc2FnZVZpZXcuZWxlbWVudCBpbnN0YW5jZW9mIEVsZW1lbnQpOwogICAgICAgICAgICAgdGhp cy5fZmlsdGVyTWVzc2FnZUVsZW1lbnRzKFttZXNzYWdlVmlldy5lbGVtZW50XSk7CiAgICAgICAg IH0KLQotCiAgICAgfQogCiAgICAgZ2V0IHN1cHBvcnRzU2VhcmNoKCkKQEAgLTYzMyw2ICs2MzEs OSBAQCBXZWJJbnNwZWN0b3IuTG9nQ29udGVudFZpZXcgPSBjbGFzcyBMb2dDb250ZW50VmlldyBl eHRlbmRzIFdlYkluc3BlY3Rvci5Db250ZW50VgogCiAgICAgX2xvZ0NsZWFyZWQoZXZlbnQpCiAg ICAgeworICAgICAgICBmb3IgKGxldCBpdGVtIG9mIHRoaXMuX3Njb3BlQmFyLml0ZW1zKQorICAg ICAgICAgICAgaXRlbS5lbGVtZW50LmNsYXNzTGlzdC5yZW1vdmUoInVucmVhZCIpOworCiAgICAg ICAgIHRoaXMuX2xvZ1ZpZXdDb250cm9sbGVyLmNsZWFyKCk7CiAgICAgICAgIHRoaXMuX25lc3Rp bmdMZXZlbCA9IDA7CiAKQEAgLTY1Myw5ICs2NTQsNiBAQCBXZWJJbnNwZWN0b3IuTG9nQ29udGVu dFZpZXcgPSBjbGFzcyBMb2dDb250ZW50VmlldyBleHRlbmRzIFdlYkluc3BlY3Rvci5Db250ZW50 VgogCiAgICAgX2NsZWFyTG9nKCkKICAgICB7Ci0gICAgICAgIGZvciAodmFyIGl0ZW0gb2YgdGhp cy5fc2NvcGVCYXIuaXRlbXMpCi0gICAgICAgICAgICBpdGVtLmVsZW1lbnQuY2xhc3NMaXN0LnJl bW92ZSgidW5yZWFkIik7Ci0KICAgICAgICAgV2ViSW5zcGVjdG9yLmxvZ01hbmFnZXIucmVxdWVz dENsZWFyTWVzc2FnZXMoKTsKICAgICB9CiAKQEAgLTk5NSw0ICs5OTMsNCBAQCBXZWJJbnNwZWN0 b3IuTG9nQ29udGVudFZpZXcuRmlsdGVyZWRPdXRTdHlsZUNsYXNzTmFtZSA9ICJmaWx0ZXJlZC1v dXQiOwogV2ViSW5zcGVjdG9yLkxvZ0NvbnRlbnRWaWV3LlNlbGVjdGVkU3R5bGVDbGFzc05hbWUg PSAic2VsZWN0ZWQiOwogV2ViSW5zcGVjdG9yLkxvZ0NvbnRlbnRWaWV3LlNlYXJjaEluUHJvZ3Jl c3NTdHlsZUNsYXNzTmFtZSA9ICJzZWFyY2gtaW4tcHJvZ3Jlc3MiOwogV2ViSW5zcGVjdG9yLkxv Z0NvbnRlbnRWaWV3LkZpbHRlcmVkT3V0QnlTZWFyY2hTdHlsZUNsYXNzTmFtZSA9ICJmaWx0ZXJl ZC1vdXQtYnktc2VhcmNoIjsKLVdlYkluc3BlY3Rvci5Mb2dDb250ZW50Vmlldy5IaWdobGlnaHRl ZFN0eWxlQ2xhc3NOYW1lID0gImhpZ2hsaWdodGVkIjsKXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBm aWxlCitXZWJJbnNwZWN0b3IuTG9nQ29udGVudFZpZXcuSGlnaGxpZ2h0ZWRTdHlsZUNsYXNzTmFt ZSA9ICJoaWdobGlnaHRlZCI7Cg==