157562 2016-05-11 02:52:03 -0700 [curl] curl_easy_setopt(CURLOPT_CONNECT_ONLY) should take a long parameter 2016-05-11 09:17:56 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 fujii webkit-unassigned achristensen aestes beidson bfulgham commit-queue darin fpizlo ggaren peavo oldest_to_newest 1191892 0 fujii 2016-05-11 02:52:03 -0700 [curl] curl_easy_setopt(CURLOPT_CONNECT_ONLY) should take a long parameter In Source/WebCore/platform/network/curl/SocketStreamHandleCurl.cpp (SocketStreamHandle::startThread), there is a following code: > curl_easy_setopt(curlHandle, CURLOPT_CONNECT_ONLY) Required third argument is missing. This should be > curl_easy_setopt(curlHandle, CURLOPT_CONNECT_ONLY, 1L) Documentation: https://curl.haxx.se/libcurl/c/CURLOPT_CONNECT_ONLY.html Introduced in Bug 144628. 1191894 1 278610 fujii 2016-05-11 03:03:19 -0700 Created attachment 278610 Patch 1191940 2 278610 commit-queue 2016-05-11 09:17:51 -0700 Comment on attachment 278610 Patch Clearing flags on attachment: 278610 Committed r200687: <http://trac.webkit.org/changeset/200687> 1191941 3 commit-queue 2016-05-11 09:17:56 -0700 All reviewed patches have been landed. Closing bug. 278610 2016-05-11 03:03:19 -0700 2016-05-11 09:17:51 -0700 Patch bug-157562-20160511190407.patch text/plain 1643 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwNjE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjk0NDI4YzlmMTAwMWQ5 NmJmNDg5OTQ1M2I3MzFkODMzZDZkNzZlYy4uMDk1MmRiZWRhNjczMTU1MjFhY2U2NWRiMTM0MDBh NzRiNjhlMzdjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA1LTExICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtjdXJsXSBj dXJsX2Vhc3lfc2V0b3B0KENVUkxPUFRfQ09OTkVDVF9PTkxZKSBzaG91bGQgdGFrZSBhIGxvbmcg cGFyYW1ldGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNTc1NjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGUgdGhpcmQgYXJndW1lbnQgb2YgYSBjYWxsaW5nIGN1cmxfZWFzeV9zZXRvcHQgaXMgbWlz c2luZy4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY3VybC9Tb2NrZXRTdHJlYW1IYW5k bGVDdXJsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNvY2tldFN0cmVhbUhhbmRsZTo6c3RhcnRU aHJlYWQpOiBHaXZlIHRoZSB0aGlyZAorICAgICAgICBhcmd1bWVudCBvZiBjdXJsX2Vhc3lfc2V0 b3B0LgorCiAyMDE2LTA1LTEwICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fu b24uZnI+CiAKICAgICAgICAgTm9kZUxpc3Qgc2hvdWxkIGJlIGl0ZXJhYmxlCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvU29ja2V0U3RyZWFtSGFuZGxl Q3VybC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvU29ja2V0U3Ry ZWFtSGFuZGxlQ3VybC5jcHAKaW5kZXggOGQ3M2U2ZDM4MzIyZjQ0YmMwNTAwNjQ0YmM1MjNjZTE2 NGI5NDNlYy4uZDYwYTNmZjIwNTAzOGU3Y2FlN2NjZGQwNmYzN2ExN2UwOTYzMDUyMSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL1NvY2tldFN0cmVhbUhh bmRsZUN1cmwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9T b2NrZXRTdHJlYW1IYW5kbGVDdXJsLmNwcApAQCAtMjAyLDcgKzIwMiw3IEBAIHZvaWQgU29ja2V0 U3RyZWFtSGFuZGxlOjpzdGFydFRocmVhZCgpCiAKICAgICAgICAgY3VybF9lYXN5X3NldG9wdChj dXJsSGFuZGxlLCBDVVJMT1BUX1VSTCwgbV91cmwuaG9zdCgpLnV0ZjgoKS5kYXRhKCkpOwogICAg ICAgICBjdXJsX2Vhc3lfc2V0b3B0KGN1cmxIYW5kbGUsIENVUkxPUFRfUE9SVCwgbV91cmwucG9y dCgpKTsKLSAgICAgICAgY3VybF9lYXN5X3NldG9wdChjdXJsSGFuZGxlLCBDVVJMT1BUX0NPTk5F Q1RfT05MWSk7CisgICAgICAgIGN1cmxfZWFzeV9zZXRvcHQoY3VybEhhbmRsZSwgQ1VSTE9QVF9D T05ORUNUX09OTFksIDFMKTsKIAogICAgICAgICAvLyBDb25uZWN0IHRvIGhvc3QKICAgICAgICAg aWYgKGN1cmxfZWFzeV9wZXJmb3JtKGN1cmxIYW5kbGUpICE9IENVUkxFX09LKQo=