157559 2016-05-10 21:47:52 -0700 preprocess-idls.pl not ignoring comments during processing 2016-05-11 09:23:46 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rawinder.webkit rawinder.webkit cdumez cgarcia commit-queue oldest_to_newest 1191823 0 278580 rawinder.webkit 2016-05-10 21:47:52 -0700 Created attachment 278580 TestPreprocessIssue.idl During processing of an IDL file with comments in the IDL interface attribute section, I encountered the problem that Source/WebCore/bindings/scripts/preprocess-idls.pl was not ignoring the comments in the attribute section. According to the Web IDL specification, http://www.w3.org/TR/WebIDL/#idl-grammar, comments should be ignored during processing. This patch addresses the issue described above. Steps to reproduce the problem: 1. List test file TestPreprocessIssue.idl in idl_files.tmp: > [ > NoInterfaceObject > // This is a comment >] interface TestPreprocessIssue >}; This test file specifies that the TestPreprocessIssue interface has the 'NoInterfaceObject' attribute. 2. Run preprocess-idls.pl: > perl -I WebCore/bindings/scripts/ WebCore/bindings/scripts/preprocess-idls.pl --defines "" --idlFilesList ./idl_files.tmp --supplementalDependencyFile ./SupplementalDependencies.txt --windowConstructorsFile ./DOMWindowConstructors.idl --workerGlobalScopeConstructorsFile ./WorkerGlobalScopeConstructors.idl --dedicatedWorkerGlobalScopeConstructorsFile ./DedicatedWorkerGlobalScopeConstructors.idl --supplementalMakefileDeps SupplementalDependencies.dep 3. The script produces the following DOMWindowConstructors.idl (that is, a constructor is incorrectly created for interface with 'NoInterfaceObject' attribute): > partial interface DOMWindow { > attribute TestPreprocessIssueConstructor TestPreprocessIssue; > }; * The correct output is: > partial interface DOMWindow { > }; This is caused by preprocess-idls.pl getInterfaceExtendedAttributesFromIDL reading in the key as: 'NoInterfaceObject // This is a comment' and therefore not picking up the 'NoInterfaceObject' interface attribute. 1191831 1 278584 rawinder.webkit 2016-05-10 21:55:56 -0700 Created attachment 278584 Patch 1191868 2 278599 rawinder.webkit 2016-05-11 00:03:23 -0700 Created attachment 278599 Patch 1191946 3 278599 commit-queue 2016-05-11 09:23:41 -0700 Comment on attachment 278599 Patch Clearing flags on attachment: 278599 Committed r200689: <http://trac.webkit.org/changeset/200689> 1191947 4 commit-queue 2016-05-11 09:23:46 -0700 All reviewed patches have been landed. Closing bug. 278580 2016-05-10 21:47:52 -0700 2016-05-10 21:47:52 -0700 TestPreprocessIssue.idl TestPreprocessIssue.idl application/octet-stream 1619 rawinder.webkit LyoKICogQ29weXJpZ2h0IChDKSBDYW5vbiBJbmMuIDIwMTYKICoKICogUmVkaXN0cmlidXRpb24g YW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAqIG1v ZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCwgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNv bmRpdGlvbnMKICogYXJlIHJlcXVpcmVkIHRvIGJlIG1ldDoKICoKICogMS4gUmVkaXN0cmlidXRp b25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKICogbm90 aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVy LgogKiAyLiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhl IGFib3ZlIGNvcHlyaWdodAogKiBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0 aGUgZm9sbG93aW5nIGRpc2NsYWltZXIgaW4gdGhlCiAqIGRvY3VtZW50YXRpb24gYW5kL29yIG90 aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCiAqIDMuIE5laXRo ZXIgdGhlIG5hbWUgb2YgQ2Fub24gSW5jLiBub3IgdGhlIG5hbWVzIG9mCiAqIGl0cyBjb250cmli dXRvcnMgbWF5IGJlIHVzZWQgdG8gZW5kb3JzZSBvciBwcm9tb3RlIHByb2R1Y3RzIGRlcml2ZWQK ICogZnJvbSB0aGlzIHNvZnR3YXJlIHdpdGhvdXQgc3BlY2lmaWMgcHJpb3Igd3JpdHRlbiBwZXJt aXNzaW9uLgogKgogKiBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIENBTk9OIElOQy4gQU5E IElUUyBDT05UUklCVVRPUlMgIkFTIElTIiBBTkQgQU5ZCiAqIEVYUFJFU1MgT1IgSU1QTElFRCBX QVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgVEhFIElNUExJRUQKICog V0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxB UiBQVVJQT1NFIEFSRQogKiBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBDQU5PTiBJTkMu IEFORCBJVFMgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IKICogQU5ZIERJUkVDVCwgSU5ESVJF Q1QsIElOQ0lERU5UQUwsIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTAogKiBE QU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0YgU1VC U1RJVFVURSBHT09EUyBPUgogKiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJ VFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUgogKiBDQVVTRUQgQU5EIE9OIEFO WSBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklM SVRZLAogKiBPUiBUT1JUIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJ TkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQogKiBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElG IEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogKi8KClsKICAgIE5v SW50ZXJmYWNlT2JqZWN0CiAgICAvLyBUaGlzIGlzIGEgY29tbWVudApdIGludGVyZmFjZSAgVGVz dFByZXByb2Nlc3NJc3N1ZSB7Cn07IAo= 278584 2016-05-10 21:55:56 -0700 2016-05-11 00:03:16 -0700 Patch bug-157559-20160511145526.patch text/plain 1733 rawinder.webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwNjY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjc2ZWI1OGQ3Mzc2Y2U3 YjhjNDI5Y2EwNGJmYjBlN2RhNGUyOTJjYi4uOWMwZWYwZDI3MmRiMjQ4Y2E1NDkyOTFjMzNlNTZk ZDJhZDhiMGM4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA1LTEwICBSYXdp bmRlciBTaW5naCAgPHJhd2luZGVyLnNpbmdoLXdlYmtpdEBjaXNyYS5jYW5vbi5jb20uYXU+CisK KyAgICAgICAgcHJlcHJvY2Vzcy1pZGxzLnBsIG5vdCBpZ25vcmluZyBjb21tZW50cyBkdXJpbmcg cHJvY2Vzc2luZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTU3NTU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgUmVtb3ZlIGNvbW1lbnRzIGZyb20gSURMIGZpbGUgYmVmb3JlIHByb2Nlc3NpbmcuCisKKyAg ICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL3ByZXByb2Nlc3MtaWRscy5wbDoKKyAgICAgICAgKGdl dEludGVyZmFjZUV4dGVuZGVkQXR0cmlidXRlc0Zyb21JREwpOgorCiAyMDE2LTA1LTEwICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEhvcml6b250YWxs eS1zY3JvbGxhYmxlIGl0ZW1zIHdpdGggYSAzZCB0cmFuc2Zvcm0gYXJlIHJlbmRlcmVkIGluY29y cmVjdGx5IGluIFJUTCB3aGVuIGNvbnRhaW5lciBoYXMgLXdlYmtpdC1vdmVyZmxvdy1zY3JvbGw6 IHRvdWNoCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3ByZXBy b2Nlc3MtaWRscy5wbCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvcHJlcHJvY2Vz cy1pZGxzLnBsCmluZGV4IDQzZDU2ZDY5ZjE4ZmFkMWMyZmNjMjAyODAxNWU0YTk0Mjg4OTQ0ZTEu LmYwOTMzY2M3MjZiZDk3Y2IwNjFhMjc4MmQ3MmVkNmY1MzY4MTIzY2YgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvcHJlcHJvY2Vzcy1pZGxzLnBsCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvcHJlcHJvY2Vzcy1pZGxzLnBsCkBAIC0yNCw2 ICsyNCw3IEBAIHVzZSBGaWxlOjpCYXNlbmFtZTsKIHVzZSBHZXRvcHQ6Okxvbmc7CiB1c2UgQ3dk OwogdXNlIENvbmZpZzsKK3VzZSBSZWdleHA6OkNvbW1vbiBxdyAvY29tbWVudC87CiAKIG15ICRk ZWZpbmVzOwogbXkgJHByZXByb2Nlc3NvcjsKQEAgLTMxOCw2ICszMTksOSBAQCBzdWIgZ2V0SW50 ZXJmYWNlRXh0ZW5kZWRBdHRyaWJ1dGVzRnJvbUlETAogCiAgICAgbXkgJGV4dGVuZGVkQXR0cmli dXRlcyA9IHt9OwogCisgICAgIyBSZW1vdmUgY29tbWVudHMgZnJvbSBmaWxlQ29udGVudHMgYmVm b3JlIHByb2Nlc3NpbmcuCisgICAgJGZpbGVDb250ZW50cyA9fiBzLyRSRXtjb21tZW50fXtKYXZh U2NyaXB0fS8vZzsKKwogICAgIGlmICgkZmlsZUNvbnRlbnRzID1+IC9cWyguKilcXVxzKyhjYWxs YmFjayBpbnRlcmZhY2V8aW50ZXJmYWNlfGV4Y2VwdGlvbilccysoXHcrKS9ncykgewogICAgICAg ICBteSBAcGFydHMgPSBzcGxpdChtLywoPyFbXigpXSpcKSkvLCAkMSk7CiAgICAgICAgIGZvcmVh Y2ggbXkgJHBhcnQgKEBwYXJ0cykgewo= 278599 2016-05-11 00:03:23 -0700 2016-05-11 09:23:41 -0700 Patch bug-157559-20160511170253.patch text/plain 1671 rawinder.webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwNjc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTIyNWViZTMzMjkwNzVj YzU4ZjhkM2NhN2FiZWU0NTBmYjk2NWQ0Ni4uNDRkMDk2YmFkNWNkMzUzZTM1M2Q0NGU1MmM5OWE5 MWRiMjc4YzM2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA1LTExICBSYXdp bmRlciBTaW5naCAgPHJhd2luZGVyLnNpbmdoLXdlYmtpdEBjaXNyYS5jYW5vbi5jb20uYXU+CisK KyAgICAgICAgcHJlcHJvY2Vzcy1pZGxzLnBsIG5vdCBpZ25vcmluZyBjb21tZW50cyBkdXJpbmcg cHJvY2Vzc2luZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTU3NTU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgUmVtb3ZlIGNvbW1lbnRzIGZyb20gSURMIGZpbGUgYmVmb3JlIHByb2Nlc3NpbmcuCisKKyAg ICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL3ByZXByb2Nlc3MtaWRscy5wbDoKKyAgICAgICAgKGdl dEludGVyZmFjZUV4dGVuZGVkQXR0cmlidXRlc0Zyb21JREwpOgorCiAyMDE2LTA1LTEwICBKZXJl bXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KIAogICAgICAgICBEb24ndCB1cGRhdGUgbWVk aWEgZHVyYXRpb24gYXQgcGxheWJhY2sgZW5kIHdoaWxlIHNlZWtpbmcuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3ByZXByb2Nlc3MtaWRscy5wbCBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvcHJlcHJvY2Vzcy1pZGxzLnBsCmluZGV4IDQzZDU2 ZDY5ZjE4ZmFkMWMyZmNjMjAyODAxNWU0YTk0Mjg4OTQ0ZTEuLmM0MmFhNWQ4NGFlMGIzYzU4ZDMx N2ZlZjA4NjgxZDdkOGMwMWU2MGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvcHJlcHJvY2Vzcy1pZGxzLnBsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvcHJlcHJvY2Vzcy1pZGxzLnBsCkBAIC0zMTgsNiArMzE4LDExIEBAIHN1YiBnZXRJ bnRlcmZhY2VFeHRlbmRlZEF0dHJpYnV0ZXNGcm9tSURMCiAKICAgICBteSAkZXh0ZW5kZWRBdHRy aWJ1dGVzID0ge307CiAKKyAgICAjIFJlbW92ZSBjb21tZW50cyBmcm9tIGZpbGVDb250ZW50cyBi ZWZvcmUgcHJvY2Vzc2luZy4KKyAgICAjIEZJWDogUHJlZmVyZW5jZSB0byB1c2UgUmVnZXg6OkNv bW1vbjo6Y29tbWVudCwgaG93ZXZlciBpdCBpcyBub3QgYXZhaWxhYmxlIG9uCisgICAgIyBhbGwg YnVpbGQgc3lzdGVtcy4KKyAgICAkZmlsZUNvbnRlbnRzID1+IHMvKD86KD86KD86XC9cLykoPzpb XlxuXSopKD86XG4pKXwoPzooPzpcL1wqKSg/Oig/OlteXCpdK3xcKig/IVwvKSkqKSg/OlwqXC8p KSkvL2c7CisKICAgICBpZiAoJGZpbGVDb250ZW50cyA9fiAvXFsoLiopXF1ccysoY2FsbGJhY2sg aW50ZXJmYWNlfGludGVyZmFjZXxleGNlcHRpb24pXHMrKFx3KykvZ3MpIHsKICAgICAgICAgbXkg QHBhcnRzID0gc3BsaXQobS8sKD8hW14oKV0qXCkpLywgJDEpOwogICAgICAgICBmb3JlYWNoIG15 ICRwYXJ0IChAcGFydHMpIHsK