157535 2016-05-10 14:31:47 -0700 Web Inspector: Avoid unnecessary timeout identifier churn in TimelineManager 2016-05-10 18:23:14 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1191656 0 joepeck 2016-05-10 14:31:47 -0700 * SUMMARY Avoid unnecessary timeout identifier churn in TimelineManager. The _deadTimeTimeout can get churned thousands of times (4000+ on theverge.com) because a bunch of records are added at once. Reduce the churn on the timeout identifier (<100), which also slightly reduces the amount of time spent in _resetAutoRecordingDeadTimeTimeout. 1191657 1 278531 joepeck 2016-05-10 14:32:53 -0700 Created attachment 278531 [PATCH] Proposed Fix 1191661 2 278531 joepeck 2016-05-10 14:35:09 -0700 Comment on attachment 278531 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=278531&action=review > Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js:744 > + let now = Date.now(); > + if (now <= this._lastDeadTimeTickle + 10) > + return; > + > + this._lastDeadTimeTickle = now; We could make the this._lastDeadTimeTickle = now + 10. And eliminate the "+ 10", thereby eliminating the add every check. But it felt less clear. Still the time spent in this was only ~5ms on a long recording on theverge, so not very important. 1191670 3 278531 mattbaker 2016-05-10 15:01:33 -0700 Comment on attachment 278531 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=278531&action=review > Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js:741 > + if (now <= this._lastDeadTimeTickle + 10) Magic number: a comment at the end of the line or a const on the line above would help clarify the 10. 1191698 4 278531 timothy 2016-05-10 15:51:36 -0700 Comment on attachment 278531 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=278531&action=review > Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js:740 > + let now = Date.now(); performance.now? >> Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js:744 >> + this._lastDeadTimeTickle = now; > > We could make the this._lastDeadTimeTickle = now + 10. And eliminate the "+ 10", thereby eliminating the add every check. But it felt less clear. Still the time spent in this was only ~5ms on a long recording on theverge, so not very important. I think putting the + 10 here makes more sense. 1191749 5 278555 joepeck 2016-05-10 17:26:33 -0700 Created attachment 278555 [PATCH] For Landing 1191759 6 278555 commit-queue 2016-05-10 17:55:57 -0700 Comment on attachment 278555 [PATCH] For Landing Clearing flags on attachment: 278555 Committed r200661: <http://trac.webkit.org/changeset/200661> 278531 2016-05-10 14:32:53 -0700 2016-05-10 17:26:41 -0700 [PATCH] Proposed Fix reduce-tickle.patch text/plain 2644 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDUzMTRiOWIuLjk1ZmE3MDAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE2LTA1LTEwICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQXZvaWQg dW5uZWNlc3NhcnkgdGltZW91dCBpZGVudGlmaWVyIGNodXJuIGluIFRpbWVsaW5lTWFuYWdlcgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3NTM1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50 ZXJmYWNlL0NvbnRyb2xsZXJzL1RpbWVsaW5lTWFuYWdlci5qczoKKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5UaW1lbGluZU1hbmFnZXIpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lTWFu YWdlci5wcm90b3R5cGUuY2FwdHVyaW5nU3RhcnRlZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu VGltZWxpbmVNYW5hZ2VyLnByb3RvdHlwZS5fcmVzZXRBdXRvUmVjb3JkaW5nRGVhZFRpbWVUaW1l b3V0KToKKyAgICAgICAgRG9uJ3QgcmUtdGlja2xlIGlmIHdlIHRpY2tsZWQgaW4gdGhlIGxhc3Qg MTBtcy4KKworMjAxNi0wNS0xMCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29t PgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEJhY2tlbmQgc2hvdWxkIGluaXRpYXRlIHRpbWVs aW5lIHJlY29yZGluZ3Mgb24gcGFnZSBuYXZpZ2F0aW9ucyB0byBlbnN1cmUgbm90aGluZyBpcyBt aXNzZWQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1 NzUwNAogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjYxODg2NDI+CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9UaW1lbGluZU1hbmFn ZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9U aW1lbGluZU1hbmFnZXIuanMKaW5kZXggOTIyYWIwNC4uYjZiZGYwYyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvVGltZWxpbmVNYW5h Z2VyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xs ZXJzL1RpbWVsaW5lTWFuYWdlci5qcwpAQCAtNTEsNiArNTEsMTAgQEAgV2ViSW5zcGVjdG9yLlRp bWVsaW5lTWFuYWdlciA9IGNsYXNzIFRpbWVsaW5lTWFuYWdlciBleHRlbmRzIFdlYkluc3BlY3Rv ci5PYmplY3QKICAgICAgICAgdGhpcy5fd2ViVGltZWxpbmVTY3JpcHRSZWNvcmRzRXhwZWN0aW5n U2NyaXB0UHJvZmlsZXJFdmVudHMgPSBudWxsOwogICAgICAgICB0aGlzLl9zY3JpcHRQcm9maWxl clJlY29yZHMgPSBudWxsOwogCisgICAgICAgIHRoaXMuX3N0b3BDYXB0dXJpbmdUaW1lb3V0ID0g dW5kZWZpbmVkOworICAgICAgICB0aGlzLl9kZWFkVGltZVRpbWVvdXQgPSB1bmRlZmluZWQ7Cisg ICAgICAgIHRoaXMuX2xhc3REZWFkVGltZVRpY2tsZSA9IDA7CisKICAgICAgICAgdGhpcy5yZXNl dCgpOwogICAgIH0KIApAQCAtMjE5LDYgKzIyMyw4IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZU1h bmFnZXIgPSBjbGFzcyBUaW1lbGluZU1hbmFnZXIgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuT2JqZWN0 CiAKICAgICAgICAgdGhpcy5faXNDYXB0dXJpbmcgPSB0cnVlOwogCisgICAgICAgIHRoaXMuX2xh c3REZWFkVGltZVRpY2tsZSA9IDA7CisKICAgICAgICAgaWYgKHN0YXJ0VGltZSkKICAgICAgICAg ICAgIHRoaXMuYWN0aXZlUmVjb3JkaW5nLmluaXRpYWxpemVUaW1lQm91bmRzSWZOZWNlc3Nhcnko c3RhcnRUaW1lKTsKIApAQCAtNzMwLDYgKzczNiwxMyBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVN YW5hZ2VyID0gY2xhc3MgVGltZWxpbmVNYW5hZ2VyIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVj dAogICAgICAgICBpZiAoIXRoaXMuX2lzQ2FwdHVyaW5nIHx8ICF0aGlzLl9tYWluUmVzb3VyY2VG b3JBdXRvQ2FwdHVyaW5nKQogICAgICAgICAgICAgcmV0dXJuOwogCisgICAgICAgIC8vIEF2b2lk IHVubmVjZXNzYXJ5IGNodXJuaW5nIG9mIHRpbWVvdXQgaWRlbnRpZmllci4KKyAgICAgICAgbGV0 IG5vdyA9IERhdGUubm93KCk7CisgICAgICAgIGlmIChub3cgPD0gdGhpcy5fbGFzdERlYWRUaW1l VGlja2xlICsgMTApCisgICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAgdGhpcy5fbGFzdERl YWRUaW1lVGlja2xlID0gbm93OworCiAgICAgICAgIGlmICh0aGlzLl9kZWFkVGltZVRpbWVvdXQp CiAgICAgICAgICAgICBjbGVhclRpbWVvdXQodGhpcy5fZGVhZFRpbWVUaW1lb3V0KTsKICAgICAg ICAgdGhpcy5fZGVhZFRpbWVUaW1lb3V0ID0gc2V0VGltZW91dCh0aGlzLl9ib3VuZFN0b3BDYXB0 dXJpbmcsIFdlYkluc3BlY3Rvci5UaW1lbGluZU1hbmFnZXIuRGVhZFRpbWVSZXF1aXJlZFRvU3Rv cEF1dG9SZWNvcmRpbmdFYXJseSk7Cg== 278555 2016-05-10 17:26:33 -0700 2016-05-10 17:55:57 -0700 [PATCH] For Landing tickle-2.patch text/plain 2682 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDIxY2NmYmIuLjFlZjhiMTYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE2LTA1LTEwICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQXZvaWQg dW5uZWNlc3NhcnkgdGltZW91dCBpZGVudGlmaWVyIGNodXJuIGluIFRpbWVsaW5lTWFuYWdlcgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3NTM1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgVGltb3RoeSBIYXRjaGVyLgorCisgICAgICAgICogVXNlcklu dGVyZmFjZS9Db250cm9sbGVycy9UaW1lbGluZU1hbmFnZXIuanM6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuVGltZWxpbmVNYW5hZ2VyKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZU1h bmFnZXIucHJvdG90eXBlLmNhcHR1cmluZ1N0YXJ0ZWQpOgorICAgICAgICAoV2ViSW5zcGVjdG9y LlRpbWVsaW5lTWFuYWdlci5wcm90b3R5cGUuX3Jlc2V0QXV0b1JlY29yZGluZ0RlYWRUaW1lVGlt ZW91dCk6CisgICAgICAgIERvbid0IHJlLXRpY2tsZSBpZiB3ZSB0aWNrbGVkIGluIHRoZSBsYXN0 IDEwbXMuCisKKzIwMTYtMDUtMTAgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNv bT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBCYWNrZW5kIHNob3VsZCBpbml0aWF0ZSB0aW1l bGluZSByZWNvcmRpbmdzIG9uIHBhZ2UgbmF2aWdhdGlvbnMgdG8gZW5zdXJlIG5vdGhpbmcgaXMg bWlzc2VkCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NTc1MDQKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI2MTg4NjQyPgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvVGltZWxpbmVNYW5h Z2VyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMv VGltZWxpbmVNYW5hZ2VyLmpzCmluZGV4IDI2ODJhZWEuLmZkNDBhOGEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL1RpbWVsaW5lTWFu YWdlci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9s bGVycy9UaW1lbGluZU1hbmFnZXIuanMKQEAgLTUxLDYgKzUxLDEwIEBAIFdlYkluc3BlY3Rvci5U aW1lbGluZU1hbmFnZXIgPSBjbGFzcyBUaW1lbGluZU1hbmFnZXIgZXh0ZW5kcyBXZWJJbnNwZWN0 b3IuT2JqZWN0CiAgICAgICAgIHRoaXMuX3dlYlRpbWVsaW5lU2NyaXB0UmVjb3Jkc0V4cGVjdGlu Z1NjcmlwdFByb2ZpbGVyRXZlbnRzID0gbnVsbDsKICAgICAgICAgdGhpcy5fc2NyaXB0UHJvZmls ZXJSZWNvcmRzID0gbnVsbDsKIAorICAgICAgICB0aGlzLl9zdG9wQ2FwdHVyaW5nVGltZW91dCA9 IHVuZGVmaW5lZDsKKyAgICAgICAgdGhpcy5fZGVhZFRpbWVUaW1lb3V0ID0gdW5kZWZpbmVkOwor ICAgICAgICB0aGlzLl9sYXN0RGVhZFRpbWVUaWNrbGUgPSAwOworCiAgICAgICAgIHRoaXMucmVz ZXQoKTsKICAgICB9CiAKQEAgLTIxOSw2ICsyMjMsOCBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVN YW5hZ2VyID0gY2xhc3MgVGltZWxpbmVNYW5hZ2VyIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVj dAogCiAgICAgICAgIHRoaXMuX2lzQ2FwdHVyaW5nID0gdHJ1ZTsKIAorICAgICAgICB0aGlzLl9s YXN0RGVhZFRpbWVUaWNrbGUgPSAwOworCiAgICAgICAgIGlmIChzdGFydFRpbWUpCiAgICAgICAg ICAgICB0aGlzLmFjdGl2ZVJlY29yZGluZy5pbml0aWFsaXplVGltZUJvdW5kc0lmTmVjZXNzYXJ5 KHN0YXJ0VGltZSk7CiAKQEAgLTczMCw2ICs3MzYsMTIgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5l TWFuYWdlciA9IGNsYXNzIFRpbWVsaW5lTWFuYWdlciBleHRlbmRzIFdlYkluc3BlY3Rvci5PYmpl Y3QKICAgICAgICAgaWYgKCF0aGlzLl9pc0NhcHR1cmluZyB8fCAhdGhpcy5fbWFpblJlc291cmNl Rm9yQXV0b0NhcHR1cmluZykKICAgICAgICAgICAgIHJldHVybjsKIAorICAgICAgICAvLyBBdm9p ZCB1bm5lY2Vzc2FyeSBjaHVybmluZyBvZiB0aW1lb3V0IGlkZW50aWZpZXIgYnkgbm90IHRpY2ts aW5nIHVudGlsIDEwbXMgaGF2ZSBwYXNzZWQuCisgICAgICAgIGxldCBub3cgPSBEYXRlLm5vdygp OworICAgICAgICBpZiAobm93IDw9IHRoaXMuX2xhc3REZWFkVGltZVRpY2tsZSkKKyAgICAgICAg ICAgIHJldHVybjsKKyAgICAgICAgdGhpcy5fbGFzdERlYWRUaW1lVGlja2xlID0gbm93ICsgMTA7 CisKICAgICAgICAgaWYgKHRoaXMuX2RlYWRUaW1lVGltZW91dCkKICAgICAgICAgICAgIGNsZWFy VGltZW91dCh0aGlzLl9kZWFkVGltZVRpbWVvdXQpOwogICAgICAgICB0aGlzLl9kZWFkVGltZVRp bWVvdXQgPSBzZXRUaW1lb3V0KHRoaXMuX2JvdW5kU3RvcENhcHR1cmluZywgV2ViSW5zcGVjdG9y LlRpbWVsaW5lTWFuYWdlci5EZWFkVGltZVJlcXVpcmVkVG9TdG9wQXV0b1JlY29yZGluZ0Vhcmx5 KTsK