157522 2016-05-10 09:32:59 -0700 [SpeculativeValidation] Do not start a preload if there is already one pending 2016-05-10 10:45:03 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen aestes cgarcia commit-queue koivisto webkit-bug-importer oldest_to_newest 1191539 0 cdumez 2016-05-10 09:32:59 -0700 Do not start a preload if there is already one pending. We failed to check in SpeculativeLoadManager::preloadEntry() if there was already a pending preload. As a result, we would sometimes cancel an already pending preload and start one from scratch which is inefficient. It would also sometimes lead to hitting an assertion in the SpeculativeLoad destructor because we could destroy the SpeculativeLoad without finishing or cancelling the load. 1191540 1 cdumez 2016-05-10 09:33:18 -0700 <rdar://problem/26156083> 1191545 2 278504 cdumez 2016-05-10 09:41:07 -0700 Created attachment 278504 Patch 1191581 3 278504 cdumez 2016-05-10 10:44:59 -0700 Comment on attachment 278504 Patch Clearing flags on attachment: 278504 Committed r200630: <http://trac.webkit.org/changeset/200630> 1191582 4 cdumez 2016-05-10 10:45:03 -0700 All reviewed patches have been landed. Closing bug. 278504 2016-05-10 09:41:07 -0700 2016-05-10 10:44:59 -0700 Patch bug-157522-20160510094155.patch text/plain 2581 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwNjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggM2M2YjFiOGVlMzNiMGZj ZjMwMzQ5NTE5MTYyZTM1MmYzMjI5MGVmZC4uMWMxNDZiNjQyODUxMmZlYTI2YjU5MGZjNmI0ZGQ2 ZjI0YzQ0Yzc2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE2LTA1LTEwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW1NwZWN1bGF0aXZlVmFsaWRh dGlvbl0gRG8gbm90IHN0YXJ0IGEgcHJlbG9hZCBpZiB0aGVyZSBpcyBhbHJlYWR5IG9uZSBwZW5k aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTc1 MjIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI2MTU2MDgzPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvIG5vdCBzdGFydCBhIHByZWxvYWQgaWYg dGhlcmUgaXMgYWxyZWFkeSBvbmUgcGVuZGluZy4gV2UgZmFpbGVkIHRvIGNoZWNrIGluCisgICAg ICAgIFNwZWN1bGF0aXZlTG9hZE1hbmFnZXI6OnByZWxvYWRFbnRyeSgpIGlmIHRoZXJlIHdhcyBh bHJlYWR5IGEgcGVuZGluZyBwcmVsb2FkLgorICAgICAgICBBcyBhIHJlc3VsdCwgd2Ugd291bGQg c29tZXRpbWVzIGNhbmNlbCBhbiBhbHJlYWR5IHBlbmRpbmcgcHJlbG9hZCBhbmQgc3RhcnQKKyAg ICAgICAgb25lIGZyb20gc2NyYXRjaCB3aGljaCBpcyBpbmVmZmljaWVudC4gSXQgd291bGQgYWxz byBzb21ldGltZXMgbGVhZCB0byBoaXR0aW5nCisgICAgICAgIGFuIGFzc2VydGlvbiBpbiB0aGUg U3BlY3VsYXRpdmVMb2FkIGRlc3RydWN0b3IgYmVjYXVzZSB3ZSBjb3VsZCBkZXN0cm95IHRoZQor ICAgICAgICBTcGVjdWxhdGl2ZUxvYWQgd2l0aG91dCBmaW5pc2hpbmcgb3IgY2FuY2VsbGluZyB0 aGUgbG9hZC4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZVNw ZWN1bGF0aXZlTG9hZE1hbmFnZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrQ2FjaGU6 OlNwZWN1bGF0aXZlTG9hZE1hbmFnZXI6OnByZWxvYWRFbnRyeSk6CisKIDIwMTYtMDUtMTAgIE1p Y2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtMaW51 eF0gUmVtb3ZlIHNlY2NvbXAgZmlsdGVycyBzdXBwb3J0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVTcGVjdWxhdGl2ZUxvYWRNYW5h Z2VyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNo ZVNwZWN1bGF0aXZlTG9hZE1hbmFnZXIuY3BwCmluZGV4IGViN2JjNThkYjIwZjAxMGNhMjJjZDdl MTUxYzZkNjdjZGI0NzdiZDQuLmI0NGY1ZTdjNjU5NjQ1M2JjZjE4ZGZhNjFiM2Q5Yzc4MzEwYTg2 MWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdv cmtDYWNoZVNwZWN1bGF0aXZlTG9hZE1hbmFnZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL05l dHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZVNwZWN1bGF0aXZlTG9hZE1hbmFnZXIuY3Bw CkBAIC00ODksMTEgKzQ4OSwxNiBAQCB2b2lkIFNwZWN1bGF0aXZlTG9hZE1hbmFnZXI6OnJldmFs aWRhdGVFbnRyeShzdGQ6OnVuaXF1ZV9wdHI8RW50cnk+IGVudHJ5LCBjb25zdAogCiB2b2lkIFNw ZWN1bGF0aXZlTG9hZE1hbmFnZXI6OnByZWxvYWRFbnRyeShjb25zdCBLZXkmIGtleSwgY29uc3Qg U3VicmVzb3VyY2VJbmZvJiBzdWJSZXNvdXJjZUluZm8sIGNvbnN0IEdsb2JhbEZyYW1lSUQmIGZy YW1lSUQpCiB7CisgICAgaWYgKG1fcGVuZGluZ1ByZWxvYWRzLmNvbnRhaW5zKGtleSkpCisgICAg ICAgIHJldHVybjsKKwogICAgIG1fcGVuZGluZ1ByZWxvYWRzLmFkZChrZXksIG51bGxwdHIpOwog ICAgIGF1dG8qIHN1YlJlc291cmNlSW5mb1B0ciA9IG5ldyBTdWJyZXNvdXJjZUluZm8oc3ViUmVz b3VyY2VJbmZvKTsKICAgICByZXRyaWV2ZUVudHJ5RnJvbVN0b3JhZ2Uoa2V5LCBbdGhpcywga2V5 LCBzdWJSZXNvdXJjZUluZm9QdHIsIGZyYW1lSURdKHN0ZDo6dW5pcXVlX3B0cjxFbnRyeT4gZW50 cnkpIHsKICAgICAgICAgYXV0byBzdWJSZXNvdXJjZUluZm8gPSBzdGQ6OnVuaXF1ZV9wdHI8U3Vi cmVzb3VyY2VJbmZvPihzdWJSZXNvdXJjZUluZm9QdHIpOwotICAgICAgICBtX3BlbmRpbmdQcmVs b2Fkcy5yZW1vdmUoa2V5KTsKKyAgICAgICAgQVNTRVJUKCFtX3BlbmRpbmdQcmVsb2Fkcy5nZXQo a2V5KSk7CisgICAgICAgIGJvb2wgcmVtb3ZlZCA9IG1fcGVuZGluZ1ByZWxvYWRzLnJlbW92ZShr ZXkpOworICAgICAgICBBU1NFUlRfVU5VU0VEKHJlbW92ZWQsIHJlbW92ZWQpOwogCiAgICAgICAg IGlmIChzYXRpc2Z5UGVuZGluZ1JlcXVlc3RzKGtleSwgZW50cnkuZ2V0KCkpKSB7CiAgICAgICAg ICAgICBpZiAoZW50cnkpCg==