157514 2016-05-10 06:54:16 -0700 Fix the !ENABLE(SHADOW_DOM) && !ENABLE(DETAILS_ELEMENT) build 2016-05-10 13:44:44 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy ossy achristensen cdumez cmarcelo commit-queue esprehn+autocc kangil.han rniwa oldest_to_newest 1191499 0 ossy 2016-05-10 06:54:16 -0700 build log: ../../Source/WebCore/dom/Element.cpp:1516:25: error: 'class WebCore::ShadowRoot' has no member named 'hostChildElementDidChange' ../../Source/WebCore/dom/Element.cpp: In member function 'virtual void WebCore::Element::removedFrom(WebCore::ContainerNode&)': ../../Source/WebCore/dom/Element.cpp:1600:25: error: 'class WebCore::ShadowRoot' has no member named 'hostChildElementDidChange' hostChildElementDidChange is declared inside ENABLE(SHADOW_DOM) || ENABLE(DETAILS_ELEMENT) guard, we should use it inside the same if guard. 1191500 1 278489 ossy 2016-05-10 06:56:41 -0700 Created attachment 278489 Patch 1191635 2 278489 commit-queue 2016-05-10 13:44:40 -0700 Comment on attachment 278489 Patch Clearing flags on attachment: 278489 Committed r200642: <http://trac.webkit.org/changeset/200642> 1191636 3 commit-queue 2016-05-10 13:44:44 -0700 All reviewed patches have been landed. Closing bug. 278489 2016-05-10 06:56:41 -0700 2016-05-10 13:44:40 -0700 Patch bug-157514-20160510065727.patch text/plain 1839 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwNjIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjRhMmQ3ZjBmNDE2NmZj MjNiMWQ4MzJiY2VjMzZjN2I5ZGFiNjc2Mi4uOTIyMmI2OGU5YzE2YWQxN2ViNGE2MTdiYTI5ZWIz YjcxZTg3YmIxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE2LTA1LTEwICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHRoZSAhRU5B QkxFKFNIQURPV19ET00pICYmICFFTkFCTEUoREVUQUlMU19FTEVNRU5UKSBidWlsZAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3NTE0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkb20vRWxlbWVudC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpFbGVtZW50OjppbnNlcnRlZEludG8pOgorICAgICAgICAo V2ViQ29yZTo6RWxlbWVudDo6cmVtb3ZlZEZyb20pOgorCiAyMDE2LTA1LTA5ICBEZWFuIEphY2tz b24gIDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSA8c2VsZWN0PiBlbGVtZW50cyBz aG91bGQgcmVuZGVyIHJpZ2h0LWFsaWduZWQgd2hlbiBpbiBSVEwgbW9kZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1l bnQuY3BwCmluZGV4IDdkZGM1OGFkMjgzYTI3N2FlODU0MGE3OWZkMGUxNTI1YmQyODFiZGUuLjI2 NjEyYTNhNmIwYmJkNWY2NzBiZTY1NjAzZDZlMjdiYjk4YTU3NzMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVu dC5jcHAKQEAgLTE1MTEsMTAgKzE1MTEsMTIgQEAgTm9kZTo6SW5zZXJ0aW9uTm90aWZpY2F0aW9u UmVxdWVzdCBFbGVtZW50OjppbnNlcnRlZEludG8oQ29udGFpbmVyTm9kZSYgaW5zZXJ0aW8KICAg ICAgICAgc2V0Q29udGFpbnNGdWxsU2NyZWVuRWxlbWVudE9uQW5jZXN0b3JzQ3Jvc3NpbmdGcmFt ZUJvdW5kYXJpZXModHJ1ZSk7CiAjZW5kaWYKIAorI2lmIEVOQUJMRShTSEFET1dfRE9NKSB8fCBF TkFCTEUoREVUQUlMU19FTEVNRU5UKQogICAgIGlmIChwYXJlbnROb2RlKCkgPT0gJmluc2VydGlv blBvaW50KSB7CiAgICAgICAgIGlmIChhdXRvKiBzaGFkb3dSb290ID0gcGFyZW50Tm9kZSgpLT5z aGFkb3dSb290KCkpCiAgICAgICAgICAgICBzaGFkb3dSb290LT5ob3N0Q2hpbGRFbGVtZW50RGlk Q2hhbmdlKCp0aGlzKTsKICAgICB9CisjZW5kaWYKIAogICAgIGlmICghaW5zZXJ0aW9uUG9pbnQu aXNJblRyZWVTY29wZSgpKQogICAgICAgICByZXR1cm4gSW5zZXJ0aW9uRG9uZTsKQEAgLTE1OTUs MTAgKzE1OTcsMTIgQEAgdm9pZCBFbGVtZW50OjpyZW1vdmVkRnJvbShDb250YWluZXJOb2RlJiBp bnNlcnRpb25Qb2ludCkKICAgICAgICAgfQogICAgIH0KIAorI2lmIEVOQUJMRShTSEFET1dfRE9N KSB8fCBFTkFCTEUoREVUQUlMU19FTEVNRU5UKQogICAgIGlmICghcGFyZW50Tm9kZSgpKSB7CiAg ICAgICAgIGlmIChhdXRvKiBzaGFkb3dSb290ID0gaW5zZXJ0aW9uUG9pbnQuc2hhZG93Um9vdCgp KQogICAgICAgICAgICAgc2hhZG93Um9vdC0+aG9zdENoaWxkRWxlbWVudERpZENoYW5nZSgqdGhp cyk7CiAgICAgfQorI2VuZGlmCiAKICAgICBDb250YWluZXJOb2RlOjpyZW1vdmVkRnJvbShpbnNl cnRpb25Qb2ludCk7CiAK