157513 2016-05-10 06:35:21 -0700 Fix the !ENABLE(ES6_ARROWFUNCTION_SYNTAX) build after r198927 2016-05-11 03:10:32 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 155988 1 ossy webkit-unassigned benjamin caitp ggaren ossy saam oldest_to_newest 1191493 0 ossy 2016-05-10 06:35:21 -0700 http://trac.webkit.org/changeset/192661 broke the !ENABLE(ES6_ARROW_SYNTAX) build build log: ../../Source/JavaScriptCore/parser/Parser.cpp: In member function 'typename TreeBuilder::Expression JSC::Parser<LexerType>::parseAssignmentExpression(TreeBuilder&, JSC::Parser<LexerType>::ExpressionErrorClassifier&)': ../../Source/JavaScriptCore/parser/Parser.cpp:3090:26: error: 'savePoint' was not declared in this scope savePoint is defined inside ENABLE(ES6_ARROWFUNCTION_SYNTAX) guard, but used without guards. r192661 is a half year old change and nobody noticed this breakage since then. Should we fix this error or should we remove these broken guards? 1191496 1 caitp 2016-05-10 06:46:34 -0700 It's broken in trunk, but that changeset does not have this issue. The savePoint was put inside the ENABLE(ES6_ARROW_SYNTAX) guards in http://trac.webkit.org/changeset/198927 several weeks ago. /CC sbarati@apple.com 1191497 2 ossy 2016-05-10 06:48:48 -0700 (In reply to comment #1) > It's broken in trunk, but that changeset does not have this issue. > > The savePoint was put inside the ENABLE(ES6_ARROW_SYNTAX) guards in > http://trac.webkit.org/changeset/198927 several weeks ago. > > /CC sbarati@apple.com Really, you're right. 1191526 3 saam 2016-05-10 08:49:23 -0700 We should just get rid of ENABLE_ES6_ARROW_SYNTAX It's stable now and shouldn't be behind a compile time flag. 1191896 4 ossy 2016-05-11 03:10:32 -0700 Filed a new bug report to remove this guard - bug157564 .