157492 2016-05-09 15:31:10 -0700 CallObjectConstructor should not call operationToThis in the FTL 2016-05-09 16:50:36 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller commit-queue mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1191337 0 keith_miller 2016-05-09 15:31:10 -0700 CallObjectConstructor should not call operationToThis in the FTL 1191339 1 278444 keith_miller 2016-05-09 15:34:43 -0700 Created attachment 278444 Patch 1191341 2 keith_miller 2016-05-09 15:37:18 -0700 rdar://problem/26149904 1191352 3 278444 simon.fraser 2016-05-09 15:50:45 -0700 Comment on attachment 278444 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278444&action=review > Source/JavaScriptCore/ChangeLog:4 > + CallObjectConstructor should not call operationToThis in the FTL > + https://bugs.webkit.org/show_bug.cgi?id=157492 You should have a radar number here, and mention the web site that broke. 1191353 4 278444 mark.lam 2016-05-09 15:57:05 -0700 Comment on attachment 278444 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278444&action=review r=me > Source/JavaScriptCore/ChangeLog:8 > + At some point when I was working on intrinsicifying the Object typo: /intrinsicifying/intrinsifying/. I'm not sure "intrinsifying" is an actual word, but I think it's better than "intrinsicifying". > Source/JavaScriptCore/ChangeLog:9 > + constructor I realized that the Object constructor was different Add a comma after constructor? 1191355 5 mark.lam 2016-05-09 16:00:34 -0700 Keith, can you also address Simon's feedback? 1191356 6 278444 keith_miller 2016-05-09 16:04:59 -0700 Comment on attachment 278444 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278444&action=review >> Source/JavaScriptCore/ChangeLog:4 >> + https://bugs.webkit.org/show_bug.cgi?id=157492 > > You should have a radar number here, and mention the web site that broke. Ah, I didn't know that was a thing. Fixed. >> Source/JavaScriptCore/ChangeLog:8 >> + At some point when I was working on intrinsicifying the Object > > typo: /intrinsicifying/intrinsifying/. I'm not sure "intrinsifying" is an actual word, but I think it's better than "intrinsicifying". changed. >> Source/JavaScriptCore/ChangeLog:9 >> + constructor I realized that the Object constructor was different > > Add a comma after constructor? fixed. 1191360 7 278453 keith_miller 2016-05-09 16:20:31 -0700 Created attachment 278453 Patch for landing 1191375 8 278453 commit-queue 2016-05-09 16:50:33 -0700 Comment on attachment 278453 Patch for landing Clearing flags on attachment: 278453 Committed r200597: <http://trac.webkit.org/changeset/200597> 1191376 9 commit-queue 2016-05-09 16:50:36 -0700 All reviewed patches have been landed. Closing bug. 278444 2016-05-09 15:34:43 -0700 2016-05-09 16:20:27 -0700 Patch bug-157492-20160509153530.patch text/plain 2700 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwNTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl NjRkNzg3ZDRkYjQzMzBiZDkzOWVmNzlkZWFjZDJjOGE0YzBlMTI4Li5iMzQxYTcyNWEyODIzMzI3 N2UwMzJiYmVmMzQ2NDcwZGM3MmJjMTlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxNi0wNS0wOSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBDYWxsT2JqZWN0Q29uc3RydWN0b3Igc2hvdWxkIG5vdCBjYWxsIG9w ZXJhdGlvblRvVGhpcyBpbiB0aGUgRlRMCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNTc0OTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBdCBzb21lIHBvaW50IHdoZW4gSSB3YXMgd29ya2luZyBvbiBpbnRy aW5zaWNpZnlpbmcgdGhlIE9iamVjdAorICAgICAgICBjb25zdHJ1Y3RvciBJIHJlYWxpemVkIHRo YXQgdGhlIE9iamVjdCBjb25zdHJ1Y3RvciB3YXMgZGlmZmVyZW50CisgICAgICAgIGZyb20gdGhl IFRvT2JqZWN0IG9wZXJhdGlvbi4gSSBmaXhlZCB0aGUgREZHIGJ1dCBJIGd1ZXNzIEkgZGlkbid0 CisgICAgICAgIGZpeCB0aGUgRlRMLgorCisgICAgICAgICogZnRsL0ZUTExvd2VyREZHVG9CMy5j cHA6CisgICAgICAgIChKU0M6OkZUTDo6REZHOjpMb3dlckRGR1RvQjM6OmNvbXBpbGVDYWxsT2Jq ZWN0Q29uc3RydWN0b3IpOgorICAgICAgICAqIHRlc3RzL3N0cmVzcy9jYWxsLW9iamVjdC1jb25z dHJ1Y3Rvci13aXRoLW51bGwuanM6IEFkZGVkLgorICAgICAgICAodGVzdCk6CisKIDIwMTYtMDUt MDkgIFNhYW0gYmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgR2V0dGVyIGFu ZCBzZXR0ZXIgb24gc3VwZXIgYXJlIGNhbGxlZCB3aXRoIHdyb25nICJ0aGlzIiBvYmplY3QKZGlm ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0IzLmNwcCBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0IzLmNwcAppbmRleCA4Yjcz ZGExZWEyNjVkZTdhYzU5ZGZiNGU1MWU3MjViNDQ1Yzc0Njg2Li5mNDM3N2Y4M2JmYjZhMzQyMTg4 YjIyN2VhNmJhYWY1MzBiNTEyM2IyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv ZnRsL0ZUTExvd2VyREZHVG9CMy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9G VExMb3dlckRGR1RvQjMuY3BwCkBAIC0xNDU4LDYgKzE0NTgsNyBAQCBwcml2YXRlOgogCiAgICAg dm9pZCBjb21waWxlQ2FsbE9iamVjdENvbnN0cnVjdG9yKCkKICAgICB7CisgICAgICAgIEpTR2xv YmFsT2JqZWN0KiBnbG9iYWxPYmplY3QgPSBtX2dyYXBoLmdsb2JhbE9iamVjdEZvcihtX25vZGUt Pm9yaWdpbi5zZW1hbnRpYyk7CiAgICAgICAgIExWYWx1ZSB2YWx1ZSA9IGxvd0pTVmFsdWUobV9u b2RlLT5jaGlsZDEoKSk7CiAKICAgICAgICAgTEJhc2ljQmxvY2sgaXNDZWxsQ2FzZSA9IG1fb3V0 Lm5ld0Jsb2NrKCk7CkBAIC0xNDcxLDcgKzE0NzIsNyBAQCBwcml2YXRlOgogICAgICAgICBtX291 dC5icmFuY2goaXNPYmplY3QodmFsdWUpLCB1c3VhbGx5KGNvbnRpbnVhdGlvbiksIHJhcmVseShz bG93Q2FzZSkpOwogCiAgICAgICAgIG1fb3V0LmFwcGVuZFRvKHNsb3dDYXNlLCBjb250aW51YXRp b24pOwotICAgICAgICBWYWx1ZUZyb21CbG9jayBzbG93UmVzdWx0ID0gbV9vdXQuYW5jaG9yKHZt Q2FsbChtX291dC5pbnQ2NCwgbV9vdXQub3BlcmF0aW9uKG9wZXJhdGlvblRvT2JqZWN0KSwgbV9j YWxsRnJhbWUsIHZhbHVlKSk7CisgICAgICAgIFZhbHVlRnJvbUJsb2NrIHNsb3dSZXN1bHQgPSBt X291dC5hbmNob3Iodm1DYWxsKG1fb3V0LmludDY0LCBtX291dC5vcGVyYXRpb24ob3BlcmF0aW9u T2JqZWN0Q29uc3RydWN0b3IpLCBtX2NhbGxGcmFtZSwgbV9vdXQuY29uc3RJbnRQdHIoZ2xvYmFs T2JqZWN0KSwgdmFsdWUpKTsKICAgICAgICAgbV9vdXQuanVtcChjb250aW51YXRpb24pOwogCiAg ICAgICAgIG1fb3V0LmFwcGVuZFRvKGNvbnRpbnVhdGlvbiwgbGFzdE5leHQpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9jYWxsLW9iamVjdC1jb25zdHJ1 Y3Rvci13aXRoLW51bGwuanMgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL2Nh bGwtb2JqZWN0LWNvbnN0cnVjdG9yLXdpdGgtbnVsbC5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4yODZiZmNhMTI5 NWIxNTFhYjY4ODY5MWRiMjJlNzNlOWQ2M2U0NzRlCi0tLSAvZGV2L251bGwKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9jYWxsLW9iamVjdC1jb25zdHJ1Y3Rvci13aXRo LW51bGwuanMKQEAgLTAsMCArMSw3IEBACitmdW5jdGlvbiB0ZXN0KG4pIHsKKyAgICBuID09PSBP YmplY3QobikKK30KK25vSW5saW5lKHRlc3QpOworCitmb3IgKGkgPSAwOyBpIDwgMTAwMDAwOyBp KyspCisgICAgdGVzdChudWxsKTsK 278453 2016-05-09 16:20:31 -0700 2016-05-09 16:50:33 -0700 Patch for landing bug-157492-20160509162117.patch text/plain 3089 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwNTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl NjRkNzg3ZDRkYjQzMzBiZDkzOWVmNzlkZWFjZDJjOGE0YzBlMTI4Li4xZDY5OTNiZDc5NTFiZDAw OTJlYWY4MDliMjAwYjNmOTVhZjNjNWRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNSBAQAorMjAxNi0wNS0wOSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBDYWxsT2JqZWN0Q29uc3RydWN0b3Igc2hvdWxkIG5vdCBjYWxsIG9w ZXJhdGlvblRvVGhpcyBpbiB0aGUgRlRMCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNTc0OTIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI2MTQ5OTA0 PgorCisgICAgICAgIFJldmlld2VkIGJ5IE1hcmsgTGFtLgorCisgICAgICAgIEF0IHNvbWUgcG9p bnQgd2hlbiBJIHdhcyB3b3JraW5nIG9uIGludHJpbnNpZnlpbmcgdGhlIE9iamVjdAorICAgICAg ICBjb25zdHJ1Y3RvciwgSSByZWFsaXplZCB0aGF0IHRoZSBPYmplY3QgY29uc3RydWN0b3Igd2Fz IGRpZmZlcmVudAorICAgICAgICBmcm9tIHRoZSBUb09iamVjdCBvcGVyYXRpb24uIEkgZml4ZWQg dGhlIERGRyBidXQgSSBndWVzcyBJIGRpZG4ndAorICAgICAgICBmaXggdGhlIEZUTC4KKworICAg ICAgICBUaGlzIHBhdGNoIGZpeGVzIGFuIGlzc3VlIHdpdGggd3d3Lnd1bmRlcmdyb3VuZC5jb20g bm90IGxvYWRpbmcKKyAgICAgICAgdGhlIDEwLWRheSBmb3JlY2FzdCBhbmQgbG9jYWwgbWFwLgor CisgICAgICAgICogZnRsL0ZUTExvd2VyREZHVG9CMy5jcHA6CisgICAgICAgIChKU0M6OkZUTDo6 REZHOjpMb3dlckRGR1RvQjM6OmNvbXBpbGVDYWxsT2JqZWN0Q29uc3RydWN0b3IpOgorICAgICAg ICAqIHRlc3RzL3N0cmVzcy9jYWxsLW9iamVjdC1jb25zdHJ1Y3Rvci5qczogQWRkZWQuCisgICAg ICAgICh0ZXN0KToKKyAgICAgICAgKGFzc2VydCk6CisKIDIwMTYtMDUtMDkgIFNhYW0gYmFyYXRp ICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgR2V0dGVyIGFuZCBzZXR0ZXIgb24gc3Vw ZXIgYXJlIGNhbGxlZCB3aXRoIHdyb25nICJ0aGlzIiBvYmplY3QKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0IzLmNwcCBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0IzLmNwcAppbmRleCA4YjczZGExZWEyNjVkZTdhYzU5 ZGZiNGU1MWU3MjViNDQ1Yzc0Njg2Li5mNDM3N2Y4M2JmYjZhMzQyMTg4YjIyN2VhNmJhYWY1MzBi NTEyM2IyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZH VG9CMy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvQjMu Y3BwCkBAIC0xNDU4LDYgKzE0NTgsNyBAQCBwcml2YXRlOgogCiAgICAgdm9pZCBjb21waWxlQ2Fs bE9iamVjdENvbnN0cnVjdG9yKCkKICAgICB7CisgICAgICAgIEpTR2xvYmFsT2JqZWN0KiBnbG9i YWxPYmplY3QgPSBtX2dyYXBoLmdsb2JhbE9iamVjdEZvcihtX25vZGUtPm9yaWdpbi5zZW1hbnRp Yyk7CiAgICAgICAgIExWYWx1ZSB2YWx1ZSA9IGxvd0pTVmFsdWUobV9ub2RlLT5jaGlsZDEoKSk7 CiAKICAgICAgICAgTEJhc2ljQmxvY2sgaXNDZWxsQ2FzZSA9IG1fb3V0Lm5ld0Jsb2NrKCk7CkBA IC0xNDcxLDcgKzE0NzIsNyBAQCBwcml2YXRlOgogICAgICAgICBtX291dC5icmFuY2goaXNPYmpl Y3QodmFsdWUpLCB1c3VhbGx5KGNvbnRpbnVhdGlvbiksIHJhcmVseShzbG93Q2FzZSkpOwogCiAg ICAgICAgIG1fb3V0LmFwcGVuZFRvKHNsb3dDYXNlLCBjb250aW51YXRpb24pOwotICAgICAgICBW YWx1ZUZyb21CbG9jayBzbG93UmVzdWx0ID0gbV9vdXQuYW5jaG9yKHZtQ2FsbChtX291dC5pbnQ2 NCwgbV9vdXQub3BlcmF0aW9uKG9wZXJhdGlvblRvT2JqZWN0KSwgbV9jYWxsRnJhbWUsIHZhbHVl KSk7CisgICAgICAgIFZhbHVlRnJvbUJsb2NrIHNsb3dSZXN1bHQgPSBtX291dC5hbmNob3Iodm1D YWxsKG1fb3V0LmludDY0LCBtX291dC5vcGVyYXRpb24ob3BlcmF0aW9uT2JqZWN0Q29uc3RydWN0 b3IpLCBtX2NhbGxGcmFtZSwgbV9vdXQuY29uc3RJbnRQdHIoZ2xvYmFsT2JqZWN0KSwgdmFsdWUp KTsKICAgICAgICAgbV9vdXQuanVtcChjb250aW51YXRpb24pOwogCiAgICAgICAgIG1fb3V0LmFw cGVuZFRvKGNvbnRpbnVhdGlvbiwgbGFzdE5leHQpOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9jYWxsLW9iamVjdC1jb25zdHJ1Y3Rvci5qcyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3MvY2FsbC1vYmplY3QtY29uc3RydWN0b3IuanMK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uZWUxZmVhMTliZGYwY2JjMDE3YzE3ZGM2ZjA4NGI2Y2RkOGE1NTVlNwotLS0g L2Rldi9udWxsCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3MvY2FsbC1v YmplY3QtY29uc3RydWN0b3IuanMKQEAgLTAsMCArMSwxOCBAQAorZnVuY3Rpb24gdGVzdChuKSB7 CisgICAgcmV0dXJuIG4gPT09IE9iamVjdChuKTsKK30KK25vSW5saW5lKHRlc3QpOworCitmdW5j dGlvbiBhc3NlcnQoY29uZGl0aW9uKSB7CisgICAgaWYgKCFjb25kaXRpb24pCisgICAgICAgIHRo cm93IG5ldyBFcnJvcigiYXNzZXJ0aW9uIGZhaWxlZCIpOworfQorCitmb3IgKGkgPSAwOyBpIDwg MTAwMDAwOyBpKyspIHsKKyAgICBhc3NlcnQoIXRlc3QobnVsbCkpOworICAgIGFzc2VydCghdGVz dCh1bmRlZmluZWQpKTsKKyAgICBhc3NlcnQoIXRlc3QoMSkpOworICAgIGFzc2VydCghdGVzdCgi IikpOworICAgIGFzc2VydCghdGVzdChTeW1ib2wuaXRlcmF0b3IpKTsKKyAgICBhc3NlcnQodGVz dCh7fSkpOworfQo=