157491 2016-05-09 14:48:57 -0700 Crash beneath ObjCCallbackFunctionImpl::call 2016-05-09 20:21:56 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 msaboff msaboff commit-queue keith_miller mark.lam saam oldest_to_newest 1191321 0 msaboff 2016-05-09 14:48:57 -0700 It appears that some Promise builtin code is throwing an exception. The exception is still set in the VM when we later call tryUnwrapObjcObject() from ObjCCallbackFunctionImpl::call(). 1191322 1 msaboff 2016-05-09 14:49:21 -0700 <rdar://problem/25867374> 1191410 2 278469 msaboff 2016-05-09 18:55:21 -0700 Created attachment 278469 Patch 1191414 3 278469 saam 2016-05-09 19:12:29 -0700 Comment on attachment 278469 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278469&action=review > Source/JavaScriptCore/ChangeLog:11 > + Tried creating a test case, but I don't have source for the app. > + I can't seem to find the right combination of Promises and ObjC code. What about just regular JS code? Like you have two schedules promises. The first throws The second should still run. Would we start running the second with an exception in the VM? 1191415 4 msaboff 2016-05-09 19:17:15 -0700 (In reply to comment #3) > Comment on attachment 278469 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=278469&action=review > > > Source/JavaScriptCore/ChangeLog:11 > > + Tried creating a test case, but I don't have source for the app. > > + I can't seem to find the right combination of Promises and ObjC code. > > What about just regular JS code? > Like you have two schedules promises. > The first throws > The second should still run. Would we start running the second with an > exception in the VM? The bug here is when we try to invoke a callback that is an instance function on a wrapped ObjC object. 1191429 5 278469 commit-queue 2016-05-09 20:21:52 -0700 Comment on attachment 278469 Patch Clearing flags on attachment: 278469 Committed r200610: <http://trac.webkit.org/changeset/200610> 1191430 6 commit-queue 2016-05-09 20:21:56 -0700 All reviewed patches have been landed. Closing bug. 278469 2016-05-09 18:55:21 -0700 2016-05-09 20:21:52 -0700 Patch 157491.patch text/plain 1490 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAwNjA1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE2LTA1LTA5ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIENyYXNoIGJlbmVhdGggT2JqQ0NhbGxiYWNrRnVuY3Rpb25JbXBsOjpjYWxsCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTc0OTEKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDbGVhciBhbnkgZXhjZXB0 aW9ucyBhZnRlciB0aGUgbWljcm8gdGFzayBydW5zLgorCisgICAgICAgIFRyaWVkIGNyZWF0aW5n IGEgdGVzdCBjYXNlLCBidXQgSSBkb24ndCBoYXZlIHNvdXJjZSBmb3IgdGhlIGFwcC4KKyAgICAg ICAgSSBjYW4ndCBzZWVtIHRvIGZpbmQgdGhlIHJpZ2h0IGNvbWJpbmF0aW9uIG9mIFByb21pc2Vz IGFuZCBPYmpDIGNvZGUuCisKKyAgICAgICAgKiBydW50aW1lL0pTSm9iLmNwcDoKKyAgICAgICAg KEpTQzo6SlNKb2JNaWNyb3Rhc2s6OnJ1bik6CisKIDIwMTYtMDUtMDkgIEtlaXRoIE1pbGxlciAg PGtlaXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgQ2FsbE9iamVjdENvbnN0cnVjdG9y IHNob3VsZCBub3QgY2FsbCBvcGVyYXRpb25Ub1RoaXMgaW4gdGhlIEZUTApJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNKb2IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTSm9iLmNwcAkocmV2aXNpb24gMjAwMzk0KQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNKb2IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03 MSw2ICs3MSw3IEBAIHZvaWQgSlNKb2JNaWNyb3Rhc2s6OnJ1bihFeGVjU3RhdGUqIGV4ZWMKICAg ICBmb3IgKHVuc2lnbmVkIGluZGV4ID0gMCwgbGVuZ3RoID0gbV9hcmd1bWVudHMtPmxlbmd0aCgp OyBpbmRleCA8IGxlbmd0aDsgKytpbmRleCkKICAgICAgICAgaGFuZGxlckFyZ3VtZW50cy5hcHBl bmQobV9hcmd1bWVudHMtPkpTQXJyYXk6OmdldChleGVjLCBpbmRleCkpOwogICAgIHByb2ZpbGVk Q2FsbChleGVjLCBQcm9maWxpbmdSZWFzb246Ok1pY3JvdGFzaywgbV9qb2IuZ2V0KCksIGhhbmRs ZXJDYWxsVHlwZSwgaGFuZGxlckNhbGxEYXRhLCBqc1VuZGVmaW5lZCgpLCBoYW5kbGVyQXJndW1l bnRzKTsKKyAgICBleGVjLT52bSgpLmNsZWFyRXhjZXB0aW9uKCk7CiB9CiAKIH0gLy8gbmFtZXNw YWNlIEpTQwo=