15746 2007-10-28 22:38:02 -0700 #ifndef ASSERT_DISABLED is no good! 2007-10-28 23:04:55 -0700 1 1 1 Unclassified WebKit JavaScriptCore 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 ggaren ggaren mjs oldest_to_newest 59770 0 ggaren 2007-10-28 22:38:02 -0700 ASSERT_DISABLED is always defined in Mac OS X builds, so code that relies on #ifndef ASSERT_DISABLED to do debugging won't work. We have code like this in, for example, HashTable.h 59772 1 16933 ggaren 2007-10-28 22:46:34 -0700 Created attachment 16933 Patch Mac debug and release builds succeed. 59774 2 ggaren 2007-10-28 23:04:55 -0700 Committed revision 27211. 16933 2007-10-28 22:46:34 -0700 2007-10-28 22:47:32 -0700 Patch patch.txt text/plain 2910 ggaren SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI3MjEw KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDctMTAt MjggIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIEZpeGVkIGh0dHA6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NzQ2CisgICAgICAgICNpZm5kZWYgQVNTRVJU X0RJU0FCTEVEIGlzIG5vIGdvb2QhCisgICAgICAgIAorICAgICAgICBSZXBsYWNlZCB3aXRoICNp ZiAhQVNTRVJUX0RJU0FCTEVELgorCisgICAgICAgICogd3RmL0hhc2hUYWJsZS5oOgorICAgICAg ICAoV1RGOjo6Omxvb2t1cCk6CisgICAgICAgIChXVEY6Ojo6bG9va3VwRm9yV3JpdGluZyk6Cisg ICAgICAgIChXVEY6Ojo6ZnVsbExvb2t1cEZvcldyaXRpbmcpOgorICAgICAgICAoV1RGOjo6OmFk ZCk6CisKIDIwMDctMTAtMjggIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IHd0Zi9IYXNoVGFibGUuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSB3dGYvSGFzaFRhYmxlLmgJKHJldmlzaW9uIDI3MjA5KQorKysgd3RmL0hh c2hUYWJsZS5oCSh3b3JraW5nIGNvcHkpCkBAIC00MDIsNyArNDAyLDcgQEAgbmFtZXNwYWNlIFdU RiB7CiAgICAgaW5saW5lIFZhbHVlKiBIYXNoVGFibGU8S2V5LCBWYWx1ZSwgRXh0cmFjdG9yLCBI YXNoRnVuY3Rpb25zLCBUcmFpdHMsIEtleVRyYWl0cz46Omxvb2t1cChjb25zdCBUJiBrZXkpCiAg ICAgewogICAgICAgICBBU1NFUlQobV90YWJsZSk7Ci0jaWZuZGVmIEFTU0VSVF9ESVNBQkxFRAor I2lmICFBU1NFUlRfRElTQUJMRUQKICAgICAgICAgaWYgKEhhc2hGdW5jdGlvbnM6OnNhZmVUb0Nv bXBhcmVUb0VtcHR5T3JEZWxldGVkKSB7CiAgICAgICAgICAgICBBU1NFUlQoIUhhc2hUcmFuc2xh dG9yOjplcXVhbChLZXlUcmFpdHM6OmVtcHR5VmFsdWUoKSwga2V5KSk7CiAgICAgICAgICAgICBB U1NFUlQoIUhhc2hUcmFuc2xhdG9yOjplcXVhbChLZXlUcmFpdHM6OmRlbGV0ZWRWYWx1ZSgpLCBr ZXkpKTsKQEAgLTQ1Miw3ICs0NTIsNyBAQCBuYW1lc3BhY2UgV1RGIHsKICAgICBpbmxpbmUgdHlw ZW5hbWUgSGFzaFRhYmxlPEtleSwgVmFsdWUsIEV4dHJhY3RvciwgSGFzaEZ1bmN0aW9ucywgVHJh aXRzLCBLZXlUcmFpdHM+OjpMb29rdXBUeXBlIEhhc2hUYWJsZTxLZXksIFZhbHVlLCBFeHRyYWN0 b3IsIEhhc2hGdW5jdGlvbnMsIFRyYWl0cywgS2V5VHJhaXRzPjo6bG9va3VwRm9yV3JpdGluZyhj b25zdCBUJiBrZXkpCiAgICAgewogICAgICAgICBBU1NFUlQobV90YWJsZSk7Ci0jaWZuZGVmIEFT U0VSVF9ESVNBQkxFRAorI2lmICFBU1NFUlRfRElTQUJMRUQKICAgICAgICAgaWYgKEhhc2hGdW5j dGlvbnM6OnNhZmVUb0NvbXBhcmVUb0VtcHR5T3JEZWxldGVkKSB7CiAgICAgICAgICAgICBBU1NF UlQoIUhhc2hUcmFuc2xhdG9yOjplcXVhbChLZXlUcmFpdHM6OmVtcHR5VmFsdWUoKSwga2V5KSk7 CiAgICAgICAgICAgICBBU1NFUlQoIUhhc2hUcmFuc2xhdG9yOjplcXVhbChLZXlUcmFpdHM6OmRl bGV0ZWRWYWx1ZSgpLCBrZXkpKTsKQEAgLTUwOSw3ICs1MDksNyBAQCBuYW1lc3BhY2UgV1RGIHsK ICAgICBpbmxpbmUgdHlwZW5hbWUgSGFzaFRhYmxlPEtleSwgVmFsdWUsIEV4dHJhY3RvciwgSGFz aEZ1bmN0aW9ucywgVHJhaXRzLCBLZXlUcmFpdHM+OjpGdWxsTG9va3VwVHlwZSBIYXNoVGFibGU8 S2V5LCBWYWx1ZSwgRXh0cmFjdG9yLCBIYXNoRnVuY3Rpb25zLCBUcmFpdHMsIEtleVRyYWl0cz46 OmZ1bGxMb29rdXBGb3JXcml0aW5nKGNvbnN0IFQmIGtleSkKICAgICB7CiAgICAgICAgIEFTU0VS VChtX3RhYmxlKTsKLSNpZm5kZWYgQVNTRVJUX0RJU0FCTEVECisjaWYgIUFTU0VSVF9ESVNBQkxF RAogICAgICAgICBpZiAoSGFzaEZ1bmN0aW9uczo6c2FmZVRvQ29tcGFyZVRvRW1wdHlPckRlbGV0 ZWQpIHsKICAgICAgICAgICAgIEFTU0VSVCghSGFzaFRyYW5zbGF0b3I6OmVxdWFsKEtleVRyYWl0 czo6ZW1wdHlWYWx1ZSgpLCBrZXkpKTsKICAgICAgICAgICAgIEFTU0VSVCghSGFzaFRyYW5zbGF0 b3I6OmVxdWFsKEtleVRyYWl0czo6ZGVsZXRlZFZhbHVlKCksIGtleSkpOwpAQCAtNTY1LDcgKzU2 NSw3IEBAIG5hbWVzcGFjZSBXVEYgewogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQsIHR5cGVuYW1l IEV4dHJhLCB0eXBlbmFtZSBIYXNoVHJhbnNsYXRvcj4KICAgICBpbmxpbmUgcGFpcjx0eXBlbmFt ZSBIYXNoVGFibGU8S2V5LCBWYWx1ZSwgRXh0cmFjdG9yLCBIYXNoRnVuY3Rpb25zLCBUcmFpdHMs IEtleVRyYWl0cz46Oml0ZXJhdG9yLCBib29sPiBIYXNoVGFibGU8S2V5LCBWYWx1ZSwgRXh0cmFj dG9yLCBIYXNoRnVuY3Rpb25zLCBUcmFpdHMsIEtleVRyYWl0cz46OmFkZChjb25zdCBUJiBrZXks IGNvbnN0IEV4dHJhJiBleHRyYSkKICAgICB7Ci0jaWZuZGVmIEFTU0VSVF9ESVNBQkxFRAorI2lm ICFBU1NFUlRfRElTQUJMRUQKICAgICAgICAgaWYgKEhhc2hGdW5jdGlvbnM6OnNhZmVUb0NvbXBh cmVUb0VtcHR5T3JEZWxldGVkKSB7CiAgICAgICAgICAgICBBU1NFUlQoIUhhc2hUcmFuc2xhdG9y OjplcXVhbChLZXlUcmFpdHM6OmVtcHR5VmFsdWUoKSwga2V5KSk7CiAgICAgICAgICAgICBBU1NF UlQoIUhhc2hUcmFuc2xhdG9yOjplcXVhbChLZXlUcmFpdHM6OmRlbGV0ZWRWYWx1ZSgpLCBrZXkp KTsK