15745 2007-10-28 22:16:18 -0700 [GTK] Arrow keys do not Scroll 2007-11-24 18:57:32 -0800 1 1 1 Unclassified WebKit WebKitGTK 523.x (Safari 3) PC Linux RESOLVED FIXED Gtk P2 Normal --- 0 naiem.shaik webkit-unassigned oldest_to_newest 59766 0 naiem.shaik 2007-10-28 22:16:18 -0700 I have cross compiled the Webkit+Gtk port onto a linux box. There is no mouse in the development environment. When a page is launched, scrollbar is displayed as display window is set to 400x300. But the page cannot be scrolled, as there is no mouse to drag the scrollbar. Arrow keys cannot be used to scroll the page. 60860 1 17175 xan.lopez 2007-11-10 16:09:55 -0800 Created attachment 17175 0001-Handle-scrolling-for-Up-Down-Right-Left-in-WebKitPag.patch Subject: [PATCH] Handle scrolling for Up/Down/Right/Left in WebKitPage. The Qt port does the same, not sure why is it needed. --- WebKit/gtk/Api/webkitgtkpage.cpp | 26 +++++++++++++++++++++++++- WebKit/gtk/ChangeLog | 11 +++++++++++ 2 files changed, 36 insertions(+), 1 deletions(-) 60978 2 17175 alp 2007-11-12 04:41:42 -0800 Comment on attachment 17175 0001-Handle-scrolling-for-Up-Down-Right-Left-in-WebKitPag.patch Will be good to get this fixed. However, the constant should be defined in one place, if there needs to be a constant at all. I think the correct fix is actually to use the scroll granularity and direction enumerations just like the Win port does. Perhaps it's even just a copy-and-paste job. 61003 3 xan.lopez 2007-11-12 11:44:31 -0800 For the record, I tried copying the windows code and the scroll method of our scrollbars fails to work for some reason... Will look into it. 62216 4 17491 xan.lopez 2007-11-24 16:31:31 -0800 Created attachment 17491 0001-Support-arrow-keys-for-scrolling.patch From a3d09e941a186cba64789878b727bfe245bd039d Mon Sep 17 00:00:00 2001 From: Xan Lopez <xan@gnome.org> Date: Sun, 25 Nov 2007 02:29:54 +0200 Subject: [PATCH] Support arrow keys for scrolling. Also fix warning in gtk_message_dialog_new. --- WebKit/gtk/Api/webkitgtkpage.cpp | 40 ++++++++++++++++++++++++++++++++++++- WebKit/gtk/ChangeLog | 14 +++++++++++++ 2 files changed, 52 insertions(+), 2 deletions(-) 62227 5 17491 alp 2007-11-24 18:51:46 -0800 Comment on attachment 17491 0001-Support-arrow-keys-for-scrolling.patch gtk_message_dialog_new() has already been fixed. Good with the flow control change we discussed. 62230 6 alp 2007-11-24 18:57:32 -0800 Landed in r28009. We'll need to re-write this properly at some point of course. (The content editable regression turned out to be due to a missing 'break' in EditorClientGtk.) 17175 2007-11-10 16:09:55 -0800 2007-11-24 16:31:31 -0800 0001-Handle-scrolling-for-Up-Down-Right-Left-in-WebKitPag.patch 0001-Handle-scrolling-for-Up-Down-Right-Left-in-WebKitPag.patch text/plain 2699 xan.lopez RnJvbSAxYWE1MmZjMmI2OWMyZDEwNTRiMTc5NWEwYWY2YTcwZjk3YmQ4MzVmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhhbkBnbm9tZS5vcmc+CkRhdGU6IFN1biwg MTEgTm92IDIwMDcgMDI6MDc6NTcgKzAyMDAKU3ViamVjdDogW1BBVENIXSBIYW5kbGUgc2Nyb2xs aW5nIGZvciBVcC9Eb3duL1JpZ2h0L0xlZnQgaW4gV2ViS2l0UGFnZS4KClRoZSBRdCBwb3J0IGRv ZXMgdGhlIHNhbWUsIG5vdCBzdXJlIHdoeSBpcyBpdCBuZWVkZWQuCi0tLQogV2ViS2l0L2d0ay9B cGkvd2Via2l0Z3RrcGFnZS5jcHAgfCAgIDI2ICsrKysrKysrKysrKysrKysrKysrKysrKystCiBX ZWJLaXQvZ3RrL0NoYW5nZUxvZyAgICAgICAgICAgICB8ICAgMTEgKysrKysrKysrKysKIDIgZmls ZXMgY2hhbmdlZCwgMzYgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9XZWJLaXQvZ3RrL0FwaS93ZWJraXRndGtwYWdlLmNwcCBiL1dlYktpdC9ndGsvQXBpL3dlYmtp dGd0a3BhZ2UuY3BwCmluZGV4IGRhYmM2ODUuLjA0YjlkYWQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9n dGsvQXBpL3dlYmtpdGd0a3BhZ2UuY3BwCisrKyBiL1dlYktpdC9ndGsvQXBpL3dlYmtpdGd0a3Bh Z2UuY3BwCkBAIC0xLDUgKzEsNiBAQAogLyoKICAqIENvcHlyaWdodCAoQykgMjAwNyBIb2xnZXIg SGFucyBQZXRlciBGcmV5dGhlcgorICogQ29weXJpZ2h0IChDKSAyMDA3IFhhbiBMb3BlegogICoK ICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdp dGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRo YXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC00OCw2ICs0OSw3IEBACiAjaW5jbHVkZSAi UGxhdGZvcm1XaGVlbEV2ZW50LmgiCiAjaW5jbHVkZSAiU3Vic3RpdHV0ZURhdGEuaCIKIAorI2lu Y2x1ZGUgPGdkay9nZGtrZXlzeW1zLmg+CiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CiB1c2lu ZyBuYW1lc3BhY2UgV2ViQ29yZTsKQEAgLTkwLDggKzkyLDMwIEBAIHN0YXRpYyBnYm9vbGVhbiB3 ZWJraXRfcGFnZV9leHBvc2VfZXZlbnQoR3RrV2lkZ2V0KiB3aWRnZXQsIEdka0V2ZW50RXhwb3Nl KiBldmVuCiAKIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRfcGFnZV9rZXlfZXZlbnQoR3RrV2lkZ2V0 KiB3aWRnZXQsIEdka0V2ZW50S2V5KiBldmVudCkKIHsKKyAgICBnYm9vbGVhbiBoYW5kbGVkID0g ZmFsc2U7CiAgICAgRnJhbWUqIGZyYW1lID0gY29yZShnZXRGcmFtZUZyb21QYWdlKFdFQktJVF9Q QUdFKHdpZGdldCkpKTsKLSAgICByZXR1cm4gZnJhbWUtPmV2ZW50SGFuZGxlcigpLT5rZXlFdmVu dChQbGF0Zm9ybUtleWJvYXJkRXZlbnQoZXZlbnQpKTsKKworICAgIGhhbmRsZWQgPSBmcmFtZS0+ ZXZlbnRIYW5kbGVyKCktPmtleUV2ZW50KFBsYXRmb3JtS2V5Ym9hcmRFdmVudChldmVudCkpOwor ICAgIGlmICghIGhhbmRsZWQpIHsKKyAgICAgIEZyYW1lVmlldyogdmlldyA9IGNvcmUoZ2V0RnJh bWVGcm9tUGFnZShXRUJLSVRfUEFHRSh3aWRnZXQpKSktPnZpZXcoKTsKKworICAgICAgaWYgKGV2 ZW50LT5rZXl2YWwgPT0gR0RLX0Rvd24pIHsKKyAgICAgICAgdmlldy0+c2Nyb2xsQnkoMCwgMTAp OworICAgICAgICBoYW5kbGVkID0gdHJ1ZTsKKyAgICAgIH0gZWxzZSBpZiAoZXZlbnQtPmtleXZh bCA9PSBHREtfVXApIHsKKyAgICAgICAgdmlldy0+c2Nyb2xsQnkoMCwgLTEwKTsKKyAgICAgICAg aGFuZGxlZCA9IHRydWU7CisgICAgICB9IGVsc2UgaWYgKGV2ZW50LT5rZXl2YWwgPT0gR0RLX1Jp Z2h0KSB7CisgICAgICAgIHZpZXctPnNjcm9sbEJ5KDEwLCAwKTsKKyAgICAgICAgaGFuZGxlZCA9 IHRydWU7CisgICAgICB9IGVsc2UgaWYgKGV2ZW50LT5rZXl2YWwgPT0gR0RLX0xlZnQpIHsKKyAg ICAgICAgdmlldy0+c2Nyb2xsQnkoLTEwLCAwKTsKKyAgICAgICAgaGFuZGxlZCA9IHRydWU7Cisg ICAgICB9IGVsc2UKKyAgICAgICAgaGFuZGxlZCA9IGZhbHNlOworICAgIH0KKworICAgIHJldHVy biBoYW5kbGVkOwogfQogCiBzdGF0aWMgZ2Jvb2xlYW4gd2Via2l0X3BhZ2VfYnV0dG9uX2V2ZW50 KEd0a1dpZGdldCogd2lkZ2V0LCBHZGtFdmVudEJ1dHRvbiogZXZlbnQpCmRpZmYgLS1naXQgYS9X ZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IDliZmJmOTIu LmVlYWNlNjggMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9n dGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDctMTEtMTAgIFhhbiBMb3BleiAgPHhh bkBnbm9tZS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3NDUKKyAgICAg ICAgW0dUS10gQXJyb3cga2V5cyBkbyBub3QgU2Nyb2xsCisgICAgICAgIAorICAgICAgICAqIEFw aS93ZWJraXRndGtwYWdlLmNwcDoKKyAgICAgICAgSGFuZGxlIHNjcm9sbGluZyBmb3IgVXAvRG93 bi9SaWdodC9MZWZ0IGhlcmUsCisgICAgICAgIHNhbWUgdGhlIFF0IHBvcnQgZG9lcy4KKwogMjAw Ny0xMS0wOSAgWGFuIExvcGV6ICA8eGFuQGdub21lLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBBbHAuCi0tIAoxLjUuMy40Cgo= 17491 2007-11-24 16:31:31 -0800 2007-11-24 18:51:46 -0800 0001-Support-arrow-keys-for-scrolling.patch 0001-Support-arrow-keys-for-scrolling.patch text/plain 3962 xan.lopez RnJvbSBhM2QwOWU5NDFhMTg2Y2JhNjQ3ODk4NzhiNzI3YmZlMjQ1YmQwMzlkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhhbkBnbm9tZS5vcmc+CkRhdGU6IFN1biwg MjUgTm92IDIwMDcgMDI6Mjk6NTQgKzAyMDAKU3ViamVjdDogW1BBVENIXSBTdXBwb3J0IGFycm93 IGtleXMgZm9yIHNjcm9sbGluZy4KCi0tLQogV2ViS2l0L2d0ay9BcGkvd2Via2l0Z3RrcGFnZS5j cHAgfCAgIDQwICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0KIFdlYktpdC9n dGsvQ2hhbmdlTG9nICAgICAgICAgICAgIHwgICAxNCArKysrKysrKysrKysrCiAyIGZpbGVzIGNo YW5nZWQsIDUyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2Vi S2l0L2d0ay9BcGkvd2Via2l0Z3RrcGFnZS5jcHAgYi9XZWJLaXQvZ3RrL0FwaS93ZWJraXRndGtw YWdlLmNwcAppbmRleCA4NDRjNTIxLi4zMmUyYzQyIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL0Fw aS93ZWJraXRndGtwYWdlLmNwcAorKysgYi9XZWJLaXQvZ3RrL0FwaS93ZWJraXRndGtwYWdlLmNw cApAQCAtMSw2ICsxLDcgQEAKIC8qCiAgKiBDb3B5cmlnaHQgKEMpIDIwMDcgSG9sZ2VyIEhhbnMg UGV0ZXIgRnJleXRoZXIKICAqIENvcHlyaWdodCAoQykgMjAwNyBDaHJpc3RpYW4gRHl3YW4gPGNo cmlzdGlhbkB0d290b2FzdHMuZGU+CisgKiBDb3B5cmlnaHQgKEMpIDIwMDcgWGFuIExvcGV6IDx4 YW5AZ25vbWUub3JnPgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFu ZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVy bWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC00OSw2ICs1 MCw3IEBACiAjaW5jbHVkZSAiUGxhdGZvcm1XaGVlbEV2ZW50LmgiCiAjaW5jbHVkZSAiU3Vic3Rp dHV0ZURhdGEuaCIKIAorI2luY2x1ZGUgPGdkay9nZGtrZXlzeW1zLmg+CiAKIHVzaW5nIG5hbWVz cGFjZSBXZWJLaXQ7CiB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKQEAgLTk2LDggKzk4LDQyIEBA IHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRfcGFnZV9leHBvc2VfZXZlbnQoR3RrV2lkZ2V0KiB3aWRn ZXQsIEdka0V2ZW50RXhwb3NlKiBldmVuCiAKIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRfcGFnZV9r ZXlfZXZlbnQoR3RrV2lkZ2V0KiB3aWRnZXQsIEdka0V2ZW50S2V5KiBldmVudCkKIHsKKyAgICBn Ym9vbGVhbiBoYW5kbGVkID0gZmFsc2U7CiAgICAgRnJhbWUqIGZyYW1lID0gY29yZShnZXRGcmFt ZUZyb21QYWdlKFdFQktJVF9QQUdFKHdpZGdldCkpKTsKLSAgICByZXR1cm4gZnJhbWUtPmV2ZW50 SGFuZGxlcigpLT5rZXlFdmVudChQbGF0Zm9ybUtleWJvYXJkRXZlbnQoZXZlbnQpKTsKKyAgICBQ bGF0Zm9ybUtleWJvYXJkRXZlbnQga2V5Ym9hcmRFdmVudChldmVudCk7CisKKyAgICBoYW5kbGVk ID0gZnJhbWUtPmV2ZW50SGFuZGxlcigpLT5rZXlFdmVudChrZXlib2FyZEV2ZW50KTsKKyAgICBp ZiAoIWhhbmRsZWQgJiYgZXZlbnQtPnR5cGUgPT0gR0RLX0tFWV9QUkVTUykgeworICAgICAgICBG cmFtZVZpZXcgKnZpZXcgPSBmcmFtZS0+dmlldygpOworCisgICAgICAgIC8qIEZJWE1FOiBhdCB0 aGUgdmVyeSBsZWFzdCB3ZSBzaG91bGQgYmUgdXNpbmcgdGhlIHNhbWUgY29kZSB0aGFuIHRoZQor ICAgICAgICAgICBXaW5kb3dzIHBvcnQgaGVyZSwgYnV0IG91ciBTY3JvbGxWaWV3IGZpbGUgZGl2 ZXJnZXMgZW5vdWdoIHRvIG1ha2UKKyAgICAgICAgICAgdGhhdCBpbXBvc3NpYmxlLiBBIHNob3J0 IHRlcm0gc29sdXRpb24gd291bGQgYmUgdG8gdW5pZnkgU2Nyb2xsVmlld1dpbgorICAgICAgICAg ICBhbmQgU2Nyb2xsVmlld0d0ay4gTG9uZy10ZXJtIFNjcm9sbFZpZXcgYW5kIEZyYW1lVmlldyBz aG91bGQgYmUKKyAgICAgICAgICAgdW5pZmllZCBhbmQgdXNlZCBldmVyeXdoZXJlIGZvciBzY3Jv bGxiYXJzICovCisKKyAgICAgICAgaGFuZGxlZCA9IHRydWU7CisKKyAgICAgICAgc3dpdGNoIChl dmVudC0+a2V5dmFsKSB7CisgICAgICAgICAgICBjYXNlIChHREtfRG93bik6CisgICAgICAgICAg ICAgICAgdmlldy0+c2Nyb2xsQnkoMCwgTElORV9TVEVQKTsKKyAgICAgICAgICAgICAgICBicmVh azsKKyAgICAgICAgICAgIGNhc2UgKEdES19VcCk6CisgICAgICAgICAgICAgICAgdmlldy0+c2Ny b2xsQnkoMCwgLUxJTkVfU1RFUCk7CisgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAg ICBjYXNlIChHREtfUmlnaHQpOgorICAgICAgICAgICAgICAgIHZpZXctPnNjcm9sbEJ5KExJTkVf U1RFUCwgMCk7CisgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICBjYXNlIChHREtf TGVmdCk6CisgICAgICAgICAgICAgICAgdmlldy0+c2Nyb2xsQnkoLUxJTkVfU1RFUCwgMCk7Cisg ICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICBkZWZhdWx0OgorICAgICAgICAgICAg ICAgIGhhbmRsZWQgPSBmYWxzZTsKKyAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgfQor ICAgIH0KKworICAgIHJldHVybiBoYW5kbGVkOwogfQogCiBzdGF0aWMgZ2Jvb2xlYW4gd2Via2l0 X3BhZ2VfYnV0dG9uX2V2ZW50KEd0a1dpZGdldCogd2lkZ2V0LCBHZGtFdmVudEJ1dHRvbiogZXZl bnQpCkBAIC0yNTksNyArMjk1LDcgQEAgc3RhdGljIGdib29sZWFuIHdlYmtpdF9wYWdlX3Njcmlw dF9kaWFsb2coV2ViS2l0UGFnZSogcGFnZSwgV2ViS2l0RnJhbWUqIGZyYW1lLAogICAgIH0KIAog ICAgIHdpbmRvdyA9IGd0a193aWRnZXRfZ2V0X3RvcGxldmVsKEdUS19XSURHRVQocGFnZSkpOwot ICAgIGRpYWxvZyA9IGd0a19tZXNzYWdlX2RpYWxvZ19uZXcoR1RLX1dJREdFVF9UT1BMRVZFTCh3 aW5kb3cpID8gR1RLX1dJTkRPVyh3aW5kb3cpIDogMCwgR1RLX0RJQUxPR19ERVNUUk9ZX1dJVEhf UEFSRU5ULCBtZXNzYWdlVHlwZSwgYnV0dG9ucywgbWVzc2FnZSk7CisgICAgZGlhbG9nID0gZ3Rr X21lc3NhZ2VfZGlhbG9nX25ldyhHVEtfV0lER0VUX1RPUExFVkVMKHdpbmRvdykgPyBHVEtfV0lO RE9XKHdpbmRvdykgOiAwLCBHVEtfRElBTE9HX0RFU1RST1lfV0lUSF9QQVJFTlQsIG1lc3NhZ2VU eXBlLCBidXR0b25zLCAiJXMiLCBtZXNzYWdlKTsKICAgICBnY2hhciogdGl0bGUgPSBnX3N0cmNv bmNhdCgiSmF2YVNjcmlwdCAtICIsIHdlYmtpdF9mcmFtZV9nZXRfbG9jYXRpb24oZnJhbWUpLCBO VUxMKTsKICAgICBndGtfd2luZG93X3NldF90aXRsZShHVEtfV0lORE9XKGRpYWxvZyksIHRpdGxl KTsKICAgICBnX2ZyZWUodGl0bGUpOwpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cg Yi9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCA0NTRlNjk3Li4yMWQ2NjRlIDEwMDY0NAotLS0g YS9XZWJLaXQvZ3RrL0NoYW5nZUxvZworKysgYi9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE3IEBACisyMDA3LTExLTI0ICBYYW4gTG9wZXogIDx4YW5AZ25vbWUub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHA6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NzQ1CisgICAgICAgIFtHVEtdIEFycm93IGtleXMg ZG8gbm90IFNjcm9sbAorICAgICAgICAKKyAgICAgICAgKiBBcGkvd2Via2l0Z3RrcGFnZS5jcHA6 CisKKyAgICAgICAgU3VwcG9ydCBVcC9Eb3duL1JpZ2h0L0xlZnQga2V5cyB0byBzY3JvbGwuIFNs aWdodAorICAgICAgICBoYWNrLCBzZWUgRklYTUUgZm9yIGRldGFpbHMuCisKKyAgICAgICAgQWxz byBmaXggdXNhZ2Ugb2YgZ3RrX21lc3NhZ2VfZGlhbG9nX25ldy4KKwogMjAwNy0xMS0yNCAgQ2hy aXN0aWFuIER5d2FuICA8Y2hyaXN0aWFuQHR3b3RvYXN0cy5kZT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBBbHAgVG9rZXIuCi0tIAoxLjUuMy40Cgo=