157446 2016-05-06 21:22:35 -0700 Web Inspector: Inspect Element and Element Selection searching should work with Shadow DOM Nodes 2016-05-06 22:51:37 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue esprehn+autocc glenn graouts joepeck koivisto kondapallykalyan mattbaker nvasilyev rniwa timothy webkit-bug-importer oldest_to_newest 1190891 0 joepeck 2016-05-06 21:22:35 -0700 * SUMMARY Inspect Element searching and selection should work with Shadow DOM Nodes. * STEPS TO REPRODUCE 1. Open a page with Shadow DOM Nodes 2. Right Click and Inspect Element => Expected inner shadow element to be selected in Web Inspector DOM Tree, it is not 3. Enable Node Selection mode from inspector 4. Hover elements in a Shadow DOM => Expected inner shadow elements to be highlighted, they are not 5. Click to select an element in a Shadow DOM => Expected inner shadow element to be selected in Web Inspector DOM Tree, it is not 1190892 1 joepeck 2016-05-06 21:22:45 -0700 <rdar://problem/24688447> 1190895 2 278314 joepeck 2016-05-06 21:35:15 -0700 Created attachment 278314 [PATCH] Proposed Fix 1190898 3 278314 rniwa 2016-05-06 21:41:23 -0700 Comment on attachment 278314 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=278314&action=review > Source/WebCore/rendering/HitTestResult.cpp:135 > void HitTestResult::setToNonShadowAncestor() Please rename this to moveInnerNodeOutOfUserAgentShadowTree or something so that the semantics is clear. 1190924 4 joepeck 2016-05-06 22:46:41 -0700 > Please rename this to moveInnerNodeOutOfUserAgentShadowTree or something so > that the semantics is clear. Renaming will be handled by Bug 157447. 1190925 5 joepeck 2016-05-06 22:51:37 -0700 <http://trac.webkit.org/changeset/200539> 278314 2016-05-06 21:35:15 -0700 2016-05-06 21:49:17 -0700 [PATCH] Proposed Fix inspect-element.patch text/plain 6463 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1ZjlmODdlLi5kNjIxMjI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTYtMDUtMDYgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBJbnNwZWN0IEVsZW1lbnQgYW5kIEVsZW1lbnQgU2VsZWN0 aW9uIHNlYXJjaGluZyBzaG91bGQgd29yayB3aXRoIFNoYWRvdyBET00gTm9kZXMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NzQ0NgorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vMjQ2ODg0NDc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yRE9NQWdlbnQ6OmlubmVyUGFyZW50Tm9kZSk6CisgICAg ICAgIFRoZSBJbnNwZWN0b3IgYmFja2VuZCB3YXMgaW5mb3JtaW5nIHRoZSBmcm9udGVuZCB0aGF0 IGFsbCBTaGFkb3dSb290cworICAgICAgICB3ZXJlIGZsb2F0aW5nIGFuZCBoYWQgbm8gcGFyZW50 LiBHZXQgdGhlIGhvc3QgZWxlbWVudCBmb3IgU2hhZG93Um9vdHMuCisKKyAgICAgICAgKiByZW5k ZXJpbmcvSGl0VGVzdFJlc3VsdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjptb3ZlT3V0T2ZVc2Vy QWdlbnRTaGFkb3dUcmVlKToKKyAgICAgICAgKFdlYkNvcmU6OkhpdFRlc3RSZXN1bHQ6OnNldFRv Tm9uU2hhZG93QW5jZXN0b3IpOgorICAgICAgICBFdmVudEhhbmRsZXI6Om1vdXNlTW92ZWQgaXMg Y2FsbGluZyBzZXRUb05vblNoYWRvd0FuY2VzdG9yIGJlZm9yZQorICAgICAgICBub3RpZnlpbmcg UGFnZTo6Y2hyb21lIC8gSW5zcGVjdG9yIGFib3V0IHRoZSBtb3VzZWQgb3ZlciBlbGVtZW50Lgor ICAgICAgICBUaGlzIHNob3VsZCBiZSB0aGUgZGVlcGVzdCBub24tdXNlci1hZ2VudC1zaGFkb3cg bm9kZS4KKwogMjAxNi0wNS0wNSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29t PgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IENvbnNvbGU6IFZhcmlhYmxlcyBkZWZpbmVkIHdp dGggbGV0L2NvbnN0IGFyZW4ndCBhY2Nlc3NpYmxlIG91dHNpZGUgb2YgY29uc29sZSdzIHNjb3Bl CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQu Y3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcAppbmRl eCA0YWMxM2I5Li43ODE0NzViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv SW5zcGVjdG9yRE9NQWdlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNw ZWN0b3JET01BZ2VudC5jcHAKQEAgLTE4NTAsNiArMTg1MCw4IEBAIE5vZGUqIEluc3BlY3RvckRP TUFnZW50Ojppbm5lclBhcmVudE5vZGUoTm9kZSogbm9kZSkKICAgICBBU1NFUlQobm9kZSk7CiAg ICAgaWYgKGlzPERvY3VtZW50Pigqbm9kZSkpCiAgICAgICAgIHJldHVybiBkb3duY2FzdDxEb2N1 bWVudD4oKm5vZGUpLm93bmVyRWxlbWVudCgpOworICAgIGlmIChpczxTaGFkb3dSb290Pigqbm9k ZSkpCisgICAgICAgIHJldHVybiBkb3duY2FzdDxTaGFkb3dSb290Pigqbm9kZSkuaG9zdCgpOwog ICAgIHJldHVybiBub2RlLT5wYXJlbnROb2RlKCk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9IaXRUZXN0UmVzdWx0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9IaXRUZXN0UmVzdWx0LmNwcAppbmRleCA2NDBkMTM4Li5mNjIzNzI2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSGl0VGVzdFJlc3VsdC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL0hpdFRlc3RSZXN1bHQuY3BwCkBAIC0xMjEsMTYgKzEyMSwyNyBA QCBIaXRUZXN0UmVzdWx0JiBIaXRUZXN0UmVzdWx0OjpvcGVyYXRvcj0oY29uc3QgSGl0VGVzdFJl c3VsdCYgb3RoZXIpCiAgICAgcmV0dXJuICp0aGlzOwogfQogCitzdGF0aWMgTm9kZSogbW92ZU91 dE9mVXNlckFnZW50U2hhZG93VHJlZShOb2RlJiBub2RlKQoreworICAgIGlmIChub2RlLmlzSW5T aGFkb3dUcmVlKCkpIHsKKyAgICAgICAgaWYgKFNoYWRvd1Jvb3QqIHJvb3QgPSBub2RlLmNvbnRh aW5pbmdTaGFkb3dSb290KCkpIHsKKyAgICAgICAgICAgIGlmIChyb290LT50eXBlKCkgPT0gU2hh ZG93Um9vdDo6VHlwZTo6VXNlckFnZW50KQorICAgICAgICAgICAgICAgIHJldHVybiByb290LT5o b3N0KCk7CisgICAgICAgIH0KKyAgICB9CisgICAgcmV0dXJuICZub2RlOworfQorCiB2b2lkIEhp dFRlc3RSZXN1bHQ6OnNldFRvTm9uU2hhZG93QW5jZXN0b3IoKQogewotICAgIE5vZGUqIG5vZGUg PSBpbm5lck5vZGUoKTsKLSAgICBpZiAobm9kZSkKLSAgICAgICAgbm9kZSA9IG5vZGUtPmRvY3Vt ZW50KCkuYW5jZXN0b3JJblRoaXNTY29wZShub2RlKTsKLSAgICBzZXRJbm5lck5vZGUobm9kZSk7 Ci0gICAgbm9kZSA9IGlubmVyTm9uU2hhcmVkTm9kZSgpOwotICAgIGlmIChub2RlKQotICAgICAg ICBub2RlID0gbm9kZS0+ZG9jdW1lbnQoKS5hbmNlc3RvckluVGhpc1Njb3BlKG5vZGUpOwotICAg IHNldElubmVyTm9uU2hhcmVkTm9kZShub2RlKTsKKyAgICBpZiAoTm9kZSogbm9kZSA9IGlubmVy Tm9kZSgpKSB7CisgICAgICAgIG5vZGUgPSBtb3ZlT3V0T2ZVc2VyQWdlbnRTaGFkb3dUcmVlKCpu b2RlKTsKKyAgICAgICAgc2V0SW5uZXJOb2RlKG5vZGUpOworICAgIH0KKyAgICBpZiAoTm9kZSAq bm9kZSA9IGlubmVyTm9uU2hhcmVkTm9kZSgpKSB7CisgICAgICAgIG5vZGUgPSBtb3ZlT3V0T2ZV c2VyQWdlbnRTaGFkb3dUcmVlKCpub2RlKTsKKyAgICAgICAgc2V0SW5uZXJOb25TaGFyZWROb2Rl KG5vZGUpOworICAgIH0KIH0KIAogdm9pZCBIaXRUZXN0UmVzdWx0OjpzZXRJbm5lck5vZGUoTm9k ZSogbm9kZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDBkZDk3MGIuLjMyZWU1ZDggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDE2LTA1LTA2ICBKb3Nl cGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogSW5zcGVjdCBFbGVtZW50IGFuZCBFbGVtZW50IFNlbGVjdGlvbiBzZWFyY2hpbmcgc2hvdWxk IHdvcmsgd2l0aCBTaGFkb3cgRE9NIE5vZGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNTc0NDYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI0Njg4 NDQ3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog VXNlckludGVyZmFjZS9Nb2RlbHMvRE9NTm9kZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5E T01Ob2RlKToKKyAgICAgICAgU2hhZG93IERPTSBub2RlcyBkaWQgbm90IGhhdmUgYSBwYXJlbnQs IGFuZCBzbyB3aGVuIGF0dGVtcHRpbmcKKyAgICAgICAgdG8gY3JlYXRlIERPTSBUcmVlIGVsZW1l bnRzIHVwIHRoZSBjaGFpbiwgd2Ugd2VyZSBmYWlsaW5nIGF0CisgICAgICAgIHNoYWRvdyBib3Vu ZGFyaWVzLiBDcmVhdGUgdGhlIHBhcmVudCByZWxhdGlvbnNoaXAsIHRoZSBwYXJlbnQKKyAgICAg ICAgYWxyZWFkeSB0cmVhdHMgaXQgYXMgYSBjaGlsZC4KKworICAgICAgICAqIFVzZXJJbnRlcmZh Y2UvVmlld3MvRE9NVHJlZU91dGxpbmUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRE9NVHJl ZU91dGxpbmUucHJvdG90eXBlLl9yZXZlYWxBbmRTZWxlY3ROb2RlKToKKyAgICAgICAgV2hlbmV2 ZXIgd2UgdHJ5IHRvIHJldmVhbCBhbmQgc2VsZWN0IGFuIGVsZW1lbnQgaW4gYSBzaGFkb3cgdHJl ZQorICAgICAgICBidXQgdGhlIHNldHRpbmcgdG8gc2hvdyBzaGFkb3cgRE9NIGlzIGRpc2FibGVk LCB3YWxrIHVwIHVudGlsCisgICAgICAgIHdlIGFyZSBvdXQgb2YgdGhlIHNoYWRvdyB0cmVlLgor CisyMDE2LTA1LTA2ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAg ICAgICAgV2ViIEluc3BlY3RvcjogUmVtb3ZlIEhlYXBTbmFwc2hvdCBTdW1tYXJ5IFZpZXcKICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NzM4NQogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvRE9N Tm9kZS5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9ET01O b2RlLmpzCmluZGV4IDQ5NjQzYjkuLmJlNGQ3YWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9ET01Ob2RlLmpzCisrKyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9ET01Ob2RlLmpzCkBAIC03MSwxMSArNzEs MTMgQEAgV2ViSW5zcGVjdG9yLkRPTU5vZGUgPSBjbGFzcyBET01Ob2RlIGV4dGVuZHMgV2ViSW5z cGVjdG9yLk9iamVjdAogCiAgICAgICAgIHRoaXMuX2VuYWJsZWRQc2V1ZG9DbGFzc2VzID0gW107 CiAKKyAgICAgICAgLy8gRklYTUU6IFRoZSBsb2dpYyBhcm91bmQgdGhpcy5fc2hhZG93Um9vdHMg YW5kIHRoaXMuX2NoaWxkcmVuIGlzIHZlcnkgY29uZnVzaW5nLgogICAgICAgICB0aGlzLl9zaGFk b3dSb290cyA9IFtdOwogICAgICAgICBpZiAocGF5bG9hZC5zaGFkb3dSb290cykgewogICAgICAg ICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBwYXlsb2FkLnNoYWRvd1Jvb3RzLmxlbmd0aDsgKytp KSB7CiAgICAgICAgICAgICAgICAgdmFyIHJvb3QgPSBwYXlsb2FkLnNoYWRvd1Jvb3RzW2ldOwog ICAgICAgICAgICAgICAgIHZhciBub2RlID0gbmV3IFdlYkluc3BlY3Rvci5ET01Ob2RlKHRoaXMu X2RvbVRyZWVNYW5hZ2VyLCB0aGlzLm93bmVyRG9jdW1lbnQsIHRydWUsIHJvb3QpOworICAgICAg ICAgICAgICAgIG5vZGUucGFyZW50Tm9kZSA9IHRoaXM7CiAgICAgICAgICAgICAgICAgdGhpcy5f c2hhZG93Um9vdHMucHVzaChub2RlKTsKICAgICAgICAgICAgIH0KICAgICAgICAgfQpAQCAtODcs NiArODksOCBAQCBXZWJJbnNwZWN0b3IuRE9NTm9kZSA9IGNsYXNzIERPTU5vZGUgZXh0ZW5kcyBX ZWJJbnNwZWN0b3IuT2JqZWN0CiAKICAgICAgICAgaWYgKHBheWxvYWQuY2hpbGRyZW4pCiAgICAg ICAgICAgICB0aGlzLl9zZXRDaGlsZHJlblBheWxvYWQocGF5bG9hZC5jaGlsZHJlbik7CisgICAg ICAgIGVsc2UgaWYgKCF0aGlzLl9jaGlsZHJlbiAmJiB0aGlzLl9zaGFkb3dSb290cy5sZW5ndGgp CisgICAgICAgICAgICB0aGlzLl9jaGlsZHJlbiA9IHRoaXMuX3NoYWRvd1Jvb3RzLnNsaWNlKCk7 CiAKICAgICAgICAgdGhpcy5fcHNldWRvRWxlbWVudHMgPSBuZXcgTWFwOwogICAgICAgICBpZiAo cGF5bG9hZC5wc2V1ZG9FbGVtZW50cykgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZU91dGxpbmUuanMgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlT3V0bGluZS5qcwppbmRleCAyZGQ4 YmNiLi43ZGM0NzUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9ET01UcmVlT3V0bGluZS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlT3V0bGluZS5qcwpAQCAtMjgyLDYgKzI4MiwxMyBA QCBXZWJJbnNwZWN0b3IuRE9NVHJlZU91dGxpbmUgPSBjbGFzcyBET01UcmVlT3V0bGluZSBleHRl bmRzIFdlYkluc3BlY3Rvci5UcmVlT3V0bAogICAgICAgICBpZiAoIW5vZGUgfHwgdGhpcy5fc3Vw cHJlc3NSZXZlYWxBbmRTZWxlY3QpCiAgICAgICAgICAgICByZXR1cm47CiAKKyAgICAgICAgaWYg KCFXZWJJbnNwZWN0b3Iuc2hvd1NoYWRvd0RPTVNldHRpbmcudmFsdWUpIHsKKyAgICAgICAgICAg IHdoaWxlIChub2RlICYmIG5vZGUuaXNJblNoYWRvd1RyZWUoKSkKKyAgICAgICAgICAgICAgICBu b2RlID0gbm9kZS5wYXJlbnROb2RlOworICAgICAgICAgICAgaWYgKCFub2RlKQorICAgICAgICAg ICAgICAgIHJldHVybjsKKyAgICAgICAgfQorCiAgICAgICAgIHZhciB0cmVlRWxlbWVudCA9IHRo aXMuY3JlYXRlVHJlZUVsZW1lbnRGb3Iobm9kZSk7CiAgICAgICAgIGlmICghdHJlZUVsZW1lbnQp CiAgICAgICAgICAgICByZXR1cm47Cg==