157418 2016-05-06 02:39:24 -0700 [Win] Skip failing INTL test. 2016-05-09 19:33:57 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned achristensen bfulgham commit-queue lforschler ossy oldest_to_newest 1190664 0 peavo 2016-05-06 02:39:24 -0700 Temporarily skip js/string-localeCompare.html, because AppleWin currently does not have INTL enabled. 1190665 1 278248 peavo 2016-05-06 02:47:52 -0700 Created attachment 278248 Patch 1190673 2 achristensen 2016-05-06 06:46:36 -0700 These shouldn't both be necessary 1190676 3 ossy 2016-05-06 07:30:16 -0700 (In reply to comment #2) > These shouldn't both be necessary Why not? TestExpectations is used by run-webkit-tests, the "//@ skip" magic is used by run-javascriptcore-tests. The proposed patch is the proper way to skip a LayoutTests/js test. 1190888 4 278248 achristensen 2016-05-06 21:04:01 -0700 Comment on attachment 278248 Patch Sure enough 1190893 5 278248 commit-queue 2016-05-06 21:25:06 -0700 Comment on attachment 278248 Patch Clearing flags on attachment: 278248 Committed r200537: <http://trac.webkit.org/changeset/200537> 1190894 6 commit-queue 2016-05-06 21:25:10 -0700 All reviewed patches have been landed. Closing bug. 1191419 7 peavo 2016-05-09 19:33:57 -0700 Thanks for reviewing! 278248 2016-05-06 02:47:52 -0700 2016-05-06 21:25:06 -0700 Patch bug-157418-20160506114833.patch text/plain 1779 peavo SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIwMDUxMCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA1LTA2ICBQZXIgQXJuZSBWb2xsYW4g IDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luXSBTa2lwIGZhaWxpbmcgSU5UTCB0 ZXN0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3 NDE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVt cG9yYXJpbHkgc2tpcCBzdHJpbmctbG9jYWxlQ29tcGFyZS5qcywgYmVjYXVzZSBBcHBsZVdpbiBj dXJyZW50bHkgZG9lcyBub3QgaGF2ZSBJTlRMIGVuYWJsZWQuCisKKyAgICAgICAgKiBqcy9zY3Jp cHQtdGVzdHMvc3RyaW5nLWxvY2FsZUNvbXBhcmUuanM6CisgICAgICAgICogcGxhdGZvcm0vd2lu L1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTYtMDUtMDYgIE1hbnVlbCBSZWdvIENhc2Fzbm92YXMg IDxyZWdvQGlnYWxpYS5jb20+CiAKICAgICAgICAgW2Nzcy1ncmlkXSBVbnByZWZpeCBDU1MgR3Jp ZCBMYXlvdXQgcHJvcGVydGllcwpJbmRleDogTGF5b3V0VGVzdHMvanMvc2NyaXB0LXRlc3RzL3N0 cmluZy1sb2NhbGVDb21wYXJlLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2pzL3Njcmlw dC10ZXN0cy9zdHJpbmctbG9jYWxlQ29tcGFyZS5qcwkocmV2aXNpb24gMjAwNDI2KQorKysgTGF5 b3V0VGVzdHMvanMvc2NyaXB0LXRlc3RzL3N0cmluZy1sb2NhbGVDb21wYXJlLmpzCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsNCBAQAorLy9AIHNraXAgaWYgJGhvc3RPUyA9PSAid2luZG93cyIK IGRlc2NyaXB0aW9uKCJUaGlzIHRlc3QgY2hlY2tzIHRoZSBiZWhhdmlvciBvZiBTdHJpbmcucHJv dG90eXBlLmxvY2FsZUNvbXBhcmUgYXMgZGVzY3JpYmVkIGluIHRoZSBFQ01BU2NyaXB0IEludGVy bmF0aW9uYWxpemF0aW9uIEFQSSBTcGVjaWZpY2F0aW9uIChFQ01BLTQwMiAyLjApLiIpOwogCiBz aG91bGRCZSgiU3RyaW5nLnByb3RvdHlwZS5sb2NhbGVDb21wYXJlLmxlbmd0aCIsICIxIik7Cklu ZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vVGVzdEV4cGVjdGF0aW9ucwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vVGVzdEV4cGVjdGF0aW9ucwkocmV2aXNpb24g MjAwNDI2KQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1Rlc3RFeHBlY3RhdGlvbnMJKHdv cmtpbmcgY29weSkKQEAgLTI0ODQsNiArMjQ4NCw3IEBAIGpzL2ludGwtZGF0ZXRpbWVmb3JtYXQu aHRtbCBbIFNraXAgXQoganMvaW50bC1udW1iZXJmb3JtYXQuaHRtbCBbIFNraXAgXQoganMvaW50 bC5odG1sIFsgU2tpcCBdCiBqcy9udW1iZXItdG9Mb2NhbGVTdHJpbmcuaHRtbCBbIFNraXAgXQor anMvc3RyaW5nLWxvY2FsZUNvbXBhcmUuaHRtbCBbIFNraXAgXQoganMvc3RyaW5nLXRvTG9jYWxl TG93ZXJDYXNlLmh0bWwgWyBTa2lwIF0KIGpzL3N0cmluZy10b0xvY2FsZVVwcGVyQ2FzZS5odG1s IFsgU2tpcCBdCiAK