157402 2016-05-05 18:01:37 -0700 4 and 8 digit color attributes should use the crazypants algorithm, not the CSS one. 2016-05-05 18:26:13 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino cdumez commit-queue esprehn+autocc gyuyoung.kim webkit-bug-importer oldest_to_newest 1190545 0 dino 2016-05-05 18:01:37 -0700 4 and 8 digit color attributes should use the crazypants algorithm, not the CSS one. 1190546 1 278213 dino 2016-05-05 18:06:35 -0700 Created attachment 278213 Patch 1190547 2 webkit-bug-importer 2016-05-05 18:07:49 -0700 <rdar://problem/26131142> 1190554 3 278213 simon.fraser 2016-05-05 18:17:24 -0700 Comment on attachment 278213 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278213&action=review > Source/WebCore/html/HTMLElement.cpp:1150 > + if ((colorString.length() == 4 || colorString.length() == 7) && colorString[0] == '#') > + color = Color(colorString); > + if (!color.isValid()) > + color.setNamedColor(colorString); Should there be an 'else' here since a named color will never start with a '#' ? 1190557 4 278213 dino 2016-05-05 18:22:51 -0700 Comment on attachment 278213 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278213&action=review >> Source/WebCore/html/HTMLElement.cpp:1150 >> + color.setNamedColor(colorString); > > Should there be an 'else' here since a named color will never start with a '#' ? No. If it is a named color, it didn't pass the conditional above, which means it is still its default value (invalid). However, if it *is* something like "#abc" and it fails Color(colorString) then we want the next condition to execute. This is because "#fzz" is actually an ok value in HTML color attributes - it becomes rgb(15, 0, 0)!!! Yes, the whole thing is crazy. I don't even understand how this behaviour happened in the first place. 1190561 5 dino 2016-05-05 18:26:13 -0700 Committed r200501: <http://trac.webkit.org/changeset/200501> 278213 2016-05-05 18:06:35 -0700 2016-05-05 18:17:24 -0700 Patch bug-157402-20160506110715.patch text/plain 6897 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwNDc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGYxNWI0MDRhMjQ0NDcw ZDM2OTkzMTA1M2RmZWY5YjU4ODE3NmI5NC4uNWUyNjgxM2I5MGM1MTIyNTIxZmI2OGNiYTE5YjNl ZThlM2ExOGZkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE2LTA1LTA1ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICA0IGFuZCA4IGRpZ2l0IGNvbG9y IGF0dHJpYnV0ZXMgc2hvdWxkIHVzZSB0aGUgY3JhenlwYW50cyBhbGdvcml0aG0sIG5vdCB0aGUg Q1NTIG9uZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE1NzQwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE5vZWwgYW5kIFRhYiBmcm9tIEdvb2dsZSBhbGVydGVkIG1lIHRvIHRoZSBmYWN0IEkgYnJva2Ug c29tZSBsZWdhY3kKKyAgICAgICAgSFRNTCBjb2xvciBhdHRyaWJ1dGVzIHdoZW4gSSBhZGRlZCBz dXBwb3J0IGZvciA0IGFuZCA4IGRpZ2l0IGhleCBjb2xvcnMKKyAgICAgICAgaW4gQ1NTLiBUaGUg Zml4IGlzIHRvIGZhdm9yIHRoZSAiY3JhenkiIHBhcnNpbmcgdW5sZXNzIHdlIGtub3cgaXQgaXMg YSAzIG9yIDYKKyAgICAgICAgZGlnaXQgaGV4IHZhbHVlIChpbiB3aGljaCBjYXNlIHdlIHRyeSB0 aGUgQ1NTIGFsZ29yaXRobSBmaXJzdCkuCisKKyAgICAgICAgQ292ZXJlZCBieSByZXZlcnRpbmcg YW4gZXhpc3RpbmcgdGVzdC4KKworICAgICAgICAqIGh0bWwvSFRNTEVsZW1lbnQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6SFRNTEVsZW1lbnQ6OmFkZEhUTUxDb2xvclRvU3R5bGUpOgorCiAyMDE2 LTA1LTA1ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAg IFJldmVydCByMjAwMzkwLCB0aHVzIHB1dHRpbmcgcjE5OTI1OSBhbmQgcjIwMDE2MSBhbmQgYmFj ay4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEVsZW1lbnQuY3BwIGIvU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MRWxlbWVudC5jcHAKaW5kZXggNjAxNzc3ZDJlNjUzZWQxOThm NTdkMTEzMWU2NzE0ZjVlM2ZlNTFjMy4uMTg4MThlMzc5ZDg0YzU0MDZlZTQwMDRhM2UyYjhiYmQy MGJjZTc0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRWxlbWVudC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRWxlbWVudC5jcHAKQEAgLTExMzksMTEgKzEx MzksMTkgQEAgdm9pZCBIVE1MRWxlbWVudDo6YWRkSFRNTENvbG9yVG9TdHlsZShNdXRhYmxlU3R5 bGVQcm9wZXJ0aWVzJiBzdHlsZSwgQ1NTUHJvcGVydHkKICAgICAgICAgcmV0dXJuOwogCiAgICAg Ly8gSWYgdGhlIHN0cmluZyBpcyBhIG5hbWVkIENTUyBjb2xvciBvciBhIDMvNi1kaWdpdCBoZXgg Y29sb3IsIHVzZSB0aGF0LgotICAgIENvbG9yIHBhcnNlZENvbG9yKGNvbG9yU3RyaW5nKTsKLSAg ICBpZiAoIXBhcnNlZENvbG9yLmlzVmFsaWQoKSkKLSAgICAgICAgcGFyc2VkQ29sb3Iuc2V0UkdC KHBhcnNlQ29sb3JTdHJpbmdXaXRoQ3JhenlMZWdhY3lSdWxlcyhjb2xvclN0cmluZykpOworICAg IC8vIFdlIGNhbid0IHVzZSB0aGUgZGVmYXVsdCBDb2xvciBjb25zdHJ1Y3RvciBiZWNhdXNlIGl0 IGFjY2VwdHMKKyAgICAvLyA0LzgtZGlnaXQgaGV4LCB3aGljaCBjb25mbGljdCB3aXRoIHNvbWUg bGVnYWN5IEhUTUwgY29udGVudCB1c2luZyBhdHRyaWJ1dGVzLgogCi0gICAgc3R5bGUuc2V0UHJv cGVydHkocHJvcGVydHlJRCwgQ1NTVmFsdWVQb29sOjpzaW5nbGV0b24oKS5jcmVhdGVDb2xvclZh bHVlKHBhcnNlZENvbG9yLnJnYigpKSk7CisgICAgQ29sb3IgY29sb3I7CisKKyAgICBpZiAoKGNv bG9yU3RyaW5nLmxlbmd0aCgpID09IDQgfHwgY29sb3JTdHJpbmcubGVuZ3RoKCkgPT0gNykgJiYg Y29sb3JTdHJpbmdbMF0gPT0gJyMnKQorICAgICAgICBjb2xvciA9IENvbG9yKGNvbG9yU3RyaW5n KTsKKyAgICBpZiAoIWNvbG9yLmlzVmFsaWQoKSkKKyAgICAgICAgY29sb3Iuc2V0TmFtZWRDb2xv cihjb2xvclN0cmluZyk7CisgICAgaWYgKCFjb2xvci5pc1ZhbGlkKCkpCisgICAgICAgIGNvbG9y LnNldFJHQihwYXJzZUNvbG9yU3RyaW5nV2l0aENyYXp5TGVnYWN5UnVsZXMoY29sb3JTdHJpbmcp KTsKKworICAgIHN0eWxlLnNldFByb3BlcnR5KHByb3BlcnR5SUQsIENTU1ZhbHVlUG9vbDo6c2lu Z2xldG9uKCkuY3JlYXRlQ29sb3JWYWx1ZShjb2xvci5yZ2IoKSkpOwogfQogCiBib29sIEhUTUxF bGVtZW50Ojp3aWxsUmVzcG9uZFRvTW91c2VNb3ZlRXZlbnRzKCkKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAwNzYwMzcxYjFh MTAxN2RiOWI3N2M0Y2NmNjMwYTVlM2Q1YTY4YTM4Li4wNWI1YmNiMzQyODgyNzg4NDA5ZDQ0MTdj MzNhNzdhNWE1NDQzNGFjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTYtMDUtMDUgIERlYW4g SmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIDQgYW5kIDggZGlnaXQgY29sb3Ig YXR0cmlidXRlcyBzaG91bGQgdXNlIHRoZSBjcmF6eXBhbnRzIGFsZ29yaXRobSwgbm90IHRoZSBD U1Mgb25lLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTU3NDAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UmVzdG9yZSB0aGUgdmVyc2lvbiB0aGF0IHdhcyB0aGVyZSBiZWZvcmUgSSBhZGRlZCBzdXBwb3J0 IGZvcgorICAgICAgICA0IGFuZCA4IGRpZ2l0IGhleCBjb2xvcnMgaW4gQ1NTLgorCisgICAgICAg ICogZmFzdC9kb20vYXR0cmlidXRlLWxlZ2FjeS1jb2xvcnMtZXhwZWN0ZWQudHh0OgorICAgICAg ICAqIGZhc3QvZG9tL3NjcmlwdC10ZXN0cy9hdHRyaWJ1dGUtbGVnYWN5LWNvbG9ycy5qczoKKwog MjAxNi0wNS0wNSAgQ2FybG9zIEFsYmVydG8gTG9wZXogUGVyZXogIDxjbG9wZXpAaWdhbGlhLmNv bT4KIAogICAgICAgICBbR1RLXSBVbnJldmlld2VkIGdhcmRlbmluZy4KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2Zhc3QvZG9tL2F0dHJpYnV0ZS1sZWdhY3ktY29sb3JzLWV4cGVjdGVkLnR4dCBi L0xheW91dFRlc3RzL2Zhc3QvZG9tL2F0dHJpYnV0ZS1sZWdhY3ktY29sb3JzLWV4cGVjdGVkLnR4 dAppbmRleCA1MmZiNzQwNzUwNTBmZGUxMTljMWQ1MTVhOTc5YmMzMWU2ZDU5MjZlLi42NDgwNWY1 N2FlODFjMmZiNjI2YmYxNTBjNTgzYmFmYzQxM2U2MTM2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9mYXN0L2RvbS9hdHRyaWJ1dGUtbGVnYWN5LWNvbG9ycy1leHBlY3RlZC50eHQKKysrIGIvTGF5 b3V0VGVzdHMvZmFzdC9kb20vYXR0cmlidXRlLWxlZ2FjeS1jb2xvcnMtZXhwZWN0ZWQudHh0CkBA IC0xNiw2ICsxNiw3IEBAIFBBU1MgZG9jdW1lbnQuYm9keS5iZ0NvbG9yPScjZnp6JztnZXRDb21w dXRlZFN0eWxlKGRvY3VtZW50LmJvZHkpLmJhY2tncm91bmRDb2xvCiBQQVNTIGRvY3VtZW50LmJv ZHkuYmdDb2xvcj0nI2Zmenp6eic7Z2V0Q29tcHV0ZWRTdHlsZShkb2N1bWVudC5ib2R5KS5iYWNr Z3JvdW5kQ29sb3I7IGlzICdyZ2IoMjU1LCAwLCAwKScKIFBBU1MgZG9jdW1lbnQuYm9keS5iZ0Nv bG9yPSdmMDAnO2dldENvbXB1dGVkU3R5bGUoZG9jdW1lbnQuYm9keSkuYmFja2dyb3VuZENvbG9y OyBpcyAncmdiKDE1LCAwLCAwKScKIFBBU1MgZG9jdW1lbnQuYm9keS5iZ0NvbG9yPSdmZjAwMDAn O2dldENvbXB1dGVkU3R5bGUoZG9jdW1lbnQuYm9keSkuYmFja2dyb3VuZENvbG9yOyBpcyAncmdi KDI1NSwgMCwgMCknCitQQVNTIGRvY3VtZW50LmJvZHkuYmdDb2xvcj0nIzAwMDAwMDAwJztnZXRD b21wdXRlZFN0eWxlKGRvY3VtZW50LmJvZHkpLmJhY2tncm91bmRDb2xvcjsgaXMgJ3JnYigwLCAw LCAwKScKIFBBU1MgZG9jdW1lbnQuYm9keS5iZ0NvbG9yPSdmb28nO2dldENvbXB1dGVkU3R5bGUo ZG9jdW1lbnQuYm9keSkuYmFja2dyb3VuZENvbG9yOyBpcyAncmdiKDE1LCAwLCAwKScKIFBBU1Mg ZG9jdW1lbnQuYm9keS5iZ0NvbG9yPSdjaGVlc2UnO2dldENvbXB1dGVkU3R5bGUoZG9jdW1lbnQu Ym9keSkuYmFja2dyb3VuZENvbG9yOyBpcyAncmdiKDE5MiwgMjM4LCAxNCknCiBQQVNTIGRvY3Vt ZW50LmJvZHkuYmdDb2xvcj0nZmbygL+/ZmYnO2dldENvbXB1dGVkU3R5bGUoZG9jdW1lbnQuYm9k eSkuYmFja2dyb3VuZENvbG9yOyBpcyAncmdiKDI1NSwgMCwgMjU1KScKQEAgLTM0LDkgKzM1LDEx IEBAIFBBU1MgZG9jdW1lbnQuYm9keS5iZ0NvbG9yPScjJztnZXRDb21wdXRlZFN0eWxlKGRvY3Vt ZW50LmJvZHkpLmJhY2tncm91bmRDb2xvcjsKIFBBU1MgZG9jdW1lbnQuYm9keS5iZ0NvbG9yPScj NSc7Z2V0Q29tcHV0ZWRTdHlsZShkb2N1bWVudC5ib2R5KS5iYWNrZ3JvdW5kQ29sb3I7IGlzICdy Z2IoNSwgMCwgMCknCiBQQVNTIGRvY3VtZW50LmJvZHkuYmdDb2xvcj0nIzU1JztnZXRDb21wdXRl ZFN0eWxlKGRvY3VtZW50LmJvZHkpLmJhY2tncm91bmRDb2xvcjsgaXMgJ3JnYig1LCA1LCAwKScK IFBBU1MgZG9jdW1lbnQuYm9keS5iZ0NvbG9yPScjNTU1JztnZXRDb21wdXRlZFN0eWxlKGRvY3Vt ZW50LmJvZHkpLmJhY2tncm91bmRDb2xvcjsgaXMgJ3JnYig4NSwgODUsIDg1KScKK1BBU1MgZG9j dW1lbnQuYm9keS5iZ0NvbG9yPScjNTU1NSc7Z2V0Q29tcHV0ZWRTdHlsZShkb2N1bWVudC5ib2R5 KS5iYWNrZ3JvdW5kQ29sb3I7IGlzICdyZ2IoODUsIDg1LCAwKScKIFBBU1MgZG9jdW1lbnQuYm9k eS5iZ0NvbG9yPScjNTU1NTUnO2dldENvbXB1dGVkU3R5bGUoZG9jdW1lbnQuYm9keSkuYmFja2dy b3VuZENvbG9yOyBpcyAncmdiKDg1LCA4NSwgODApJwogUEFTUyBkb2N1bWVudC5ib2R5LmJnQ29s b3I9JyM1NTU1NTUnO2dldENvbXB1dGVkU3R5bGUoZG9jdW1lbnQuYm9keSkuYmFja2dyb3VuZENv bG9yOyBpcyAncmdiKDg1LCA4NSwgODUpJwogUEFTUyBkb2N1bWVudC5ib2R5LmJnQ29sb3I9JyM1 NTU1NTU1JztnZXRDb21wdXRlZFN0eWxlKGRvY3VtZW50LmJvZHkpLmJhY2tncm91bmRDb2xvcjsg aXMgJ3JnYig4NSwgODUsIDgwKScKK1BBU1MgZG9jdW1lbnQuYm9keS5iZ0NvbG9yPScjNTU1NTU1 NTUnO2dldENvbXB1dGVkU3R5bGUoZG9jdW1lbnQuYm9keSkuYmFja2dyb3VuZENvbG9yOyBpcyAn cmdiKDg1LCA4NSwgODUpJwogUEFTUyBkb2N1bWVudC5ib2R5LmJnQ29sb3I9JzUnO2dldENvbXB1 dGVkU3R5bGUoZG9jdW1lbnQuYm9keSkuYmFja2dyb3VuZENvbG9yOyBpcyAncmdiKDUsIDAsIDAp JwogUEFTUyBkb2N1bWVudC5ib2R5LmJnQ29sb3I9JzU1JztnZXRDb21wdXRlZFN0eWxlKGRvY3Vt ZW50LmJvZHkpLmJhY2tncm91bmRDb2xvcjsgaXMgJ3JnYig1LCA1LCAwKScKIFBBU1MgZG9jdW1l bnQuYm9keS5iZ0NvbG9yPSc1NTUnO2dldENvbXB1dGVkU3R5bGUoZG9jdW1lbnQuYm9keSkuYmFj a2dyb3VuZENvbG9yOyBpcyAncmdiKDUsIDUsIDUpJwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC9kb20vc2NyaXB0LXRlc3RzL2F0dHJpYnV0ZS1sZWdhY3ktY29sb3JzLmpzIGIvTGF5b3V0 VGVzdHMvZmFzdC9kb20vc2NyaXB0LXRlc3RzL2F0dHJpYnV0ZS1sZWdhY3ktY29sb3JzLmpzCmlu ZGV4IDVkZTY4MmFiZmRiOWIxOTJmNDk5YWI3ZTc2YWVkZjRmODA2MDdkMzcuLjE0NTgwMDkyMWRj ZDI5NTkzMzkzNTRlMGE1Njg2Nzc1OWVmMjMyZGMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zh c3QvZG9tL3NjcmlwdC10ZXN0cy9hdHRyaWJ1dGUtbGVnYWN5LWNvbG9ycy5qcworKysgYi9MYXlv dXRUZXN0cy9mYXN0L2RvbS9zY3JpcHQtdGVzdHMvYXR0cmlidXRlLWxlZ2FjeS1jb2xvcnMuanMK QEAgLTE1LDYgKzE1LDcgQEAgdmFyIHRlc3RzID0gWwogCXsndGVzdCc6JyNmZnp6enonLCAnZXhw ZWN0ZWQnOlsyNTUsIDAsIDBdfSwKIAl7J3Rlc3QnOidmMDAnLCAnZXhwZWN0ZWQnOlsxNSwgMCwg MF19LAogCXsndGVzdCc6J2ZmMDAwMCcsICdleHBlY3RlZCc6WzI1NSwgMCwgMF19LAorCXsndGVz dCc6JyMwMDAwMDAwMCcsICdleHBlY3RlZCc6WzAsIDAsIDBdfSwKIAl7J3Rlc3QnOidmb28nLCAn ZXhwZWN0ZWQnOlsxNSwgMCwgMF19LAogCXsndGVzdCc6J2NoZWVzZScsICdleHBlY3RlZCc6WzE5 MiwgMjM4LCAxNF19LAogCXsndGVzdCc6J2Zm8oC/v2ZmJywgJ2V4cGVjdGVkJzpbMjU1LCAwLCAy NTVdfSwKQEAgLTMzLDkgKzM0LDExIEBAIHZhciB0ZXN0cyA9IFsKIAl7J3Rlc3QnOicjNScsICdl eHBlY3RlZCc6WzUsIDAsIDBdfSwKIAl7J3Rlc3QnOicjNTUnLCAnZXhwZWN0ZWQnOls1LCA1LCAw XX0sCiAJeyd0ZXN0JzonIzU1NScsICdleHBlY3RlZCc6Wzg1LCA4NSwgODVdfSwKKwl7J3Rlc3Qn OicjNTU1NScsICdleHBlY3RlZCc6Wzg1LCA4NSwgMF19LAogCXsndGVzdCc6JyM1NTU1NScsICdl eHBlY3RlZCc6Wzg1LCA4NSwgODBdfSwKIAl7J3Rlc3QnOicjNTU1NTU1JywgJ2V4cGVjdGVkJzpb ODUsIDg1LCA4NV19LAogCXsndGVzdCc6JyM1NTU1NTU1JywgJ2V4cGVjdGVkJzpbODUsIDg1LCA4 MF19LAorCXsndGVzdCc6JyM1NTU1NTU1NScsICdleHBlY3RlZCc6Wzg1LCA4NSwgODVdfSwKIAl7 J3Rlc3QnOic1JywgJ2V4cGVjdGVkJzpbNSwgMCwgMF19LAogCXsndGVzdCc6JzU1JywgJ2V4cGVj dGVkJzpbNSwgNSwgMF19LAogCXsndGVzdCc6JzU1NScsICdleHBlY3RlZCc6WzUsIDUsIDVdfSwK