157390 2016-05-05 14:34:52 -0700 Add WebKitAdditions extension points in media controls related code in RenderThemeMac 2016-05-05 16:31:40 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 adachan adachan commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 1190462 0 adachan 2016-05-05 14:34:52 -0700 Add WebKitAdditions extension points in media controls related code in RenderThemeMac. For <rdar://problem/25837401> 1190470 1 278195 adachan 2016-05-05 15:11:04 -0700 Created attachment 278195 Patch 1190495 2 278195 andersca 2016-05-05 16:09:16 -0700 Comment on attachment 278195 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278195&action=review > Source/WebCore/rendering/RenderThemeMac.mm:238 > +#if USE(APPLE_INTERNAL_SDK) > +#import <WebKitAdditions/RenderThemeMacMediaControlsStyleSheetAdditions.mm> > +#endif I'd put newlines before and after this to make it look less crowded. > Source/WebCore/rendering/RenderThemeMac.mm:256 > +#if USE(APPLE_INTERNAL_SDK) > +#import <WebKitAdditions/RenderThemeMacMediaControlsScriptAdditions.mm> > +#endif Same here! 1190514 3 adachan 2016-05-05 16:31:40 -0700 (In reply to comment #2) > Comment on attachment 278195 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=278195&action=review > > > Source/WebCore/rendering/RenderThemeMac.mm:238 > > +#if USE(APPLE_INTERNAL_SDK) > > +#import <WebKitAdditions/RenderThemeMacMediaControlsStyleSheetAdditions.mm> > > +#endif > > I'd put newlines before and after this to make it look less crowded. > > > Source/WebCore/rendering/RenderThemeMac.mm:256 > > +#if USE(APPLE_INTERNAL_SDK) > > +#import <WebKitAdditions/RenderThemeMacMediaControlsScriptAdditions.mm> > > +#endif > > Same here! Newlines added. Thanks for the review! Committed: http://trac.webkit.org/changeset/200491 278195 2016-05-05 15:11:04 -0700 2016-05-05 16:09:16 -0700 Patch bug-157390-20160505151146.patch text/plain 2935 adachan U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwNDYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWYwMmVjMmZmNDk5ZWVk NzE3NjNiZDQwMTZlNmQwYzc4NGY4NTFkNy4uODg5NTA3NDY0YzQzN2U1NWRiMTExMDNlNWEyZTc5 OTI1MmQ2YzM1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE2LTA1LTA1ICBBZGEg Q2hhbiAgPGFkYWNoYW5AYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBXZWJLaXRBZGRpdGlvbnMg ZXh0ZW5zaW9uIHBvaW50cyBpbiBtZWRpYSBjb250cm9scyByZWxhdGVkIGNvZGUgaW4gUmVuZGVy VGhlbWVNYWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE1NzM5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVy VGhlbWVNYWM6Om1lZGlhQ29udHJvbHNTdHlsZVNoZWV0KToKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlclRoZW1lTWFjOjptZWRpYUNvbnRyb2xzU2NyaXB0KToKKwogMjAxNi0wNS0wNCAgQWRhIENo YW4gIDxhZGFjaGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBXaGVuIGV4aXRpbmcgZnVsbHNjcmVl biwgY2FsbCBhIEpTIG1ldGhvZCBpbW1lZGlhdGVseSB0byBpbXBsZW1lbnQgdGhlIHN0eWxlIGNo YW5nZXMgZm9yIHRoZSBwcmVzZW50YXRpb24gbW9kZSBjaGFuZ2UgcmlnaHQgYXdheQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tCmluZGV4IDBhMjIxMTllMTJlYTIx OTNlMTkwYjhjYzYyNzczNWEyYzM1ZTNmNGIuLjIxMmU5M2NlMzgzZTZlN2JiZDQxZTI4ZTEwZjcw MDRlZjVlYmIzYzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJU aGVtZU1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMu bW0KQEAgLTIzMCw4ICsyMzAsMTQgQEAgTlNWaWV3KiBSZW5kZXJUaGVtZU1hYzo6ZG9jdW1lbnRW aWV3Rm9yKGNvbnN0IFJlbmRlck9iamVjdCYgbykgY29uc3QKIFN0cmluZyBSZW5kZXJUaGVtZU1h Yzo6bWVkaWFDb250cm9sc1N0eWxlU2hlZXQoKQogewogI2lmIEVOQUJMRShNRURJQV9DT05UUk9M U19TQ1JJUFQpCi0gICAgaWYgKG1fbWVkaWFDb250cm9sc1N0eWxlU2hlZXQuaXNFbXB0eSgpKQot ICAgICAgICBtX21lZGlhQ29udHJvbHNTdHlsZVNoZWV0ID0gW05TU3RyaW5nIHN0cmluZ1dpdGhD b250ZW50c09mRmlsZTpbW05TQnVuZGxlIGJ1bmRsZUZvckNsYXNzOltXZWJDb3JlUmVuZGVyVGhl bWVCdW5kbGUgY2xhc3NdXSBwYXRoRm9yUmVzb3VyY2U6QCJtZWRpYUNvbnRyb2xzQXBwbGUiIG9m VHlwZTpAImNzcyJdIGVuY29kaW5nOk5TVVRGOFN0cmluZ0VuY29kaW5nIGVycm9yOm5pbF07Cisg ICAgaWYgKG1fbWVkaWFDb250cm9sc1N0eWxlU2hlZXQuaXNFbXB0eSgpKSB7CisgICAgICAgIFN0 cmluZ0J1aWxkZXIgc3R5bGVTaGVldEJ1aWxkZXI7CisgICAgICAgIHN0eWxlU2hlZXRCdWlsZGVy LmFwcGVuZChbTlNTdHJpbmcgc3RyaW5nV2l0aENvbnRlbnRzT2ZGaWxlOltbTlNCdW5kbGUgYnVu ZGxlRm9yQ2xhc3M6W1dlYkNvcmVSZW5kZXJUaGVtZUJ1bmRsZSBjbGFzc11dIHBhdGhGb3JSZXNv dXJjZTpAIm1lZGlhQ29udHJvbHNBcHBsZSIgb2ZUeXBlOkAiY3NzIl0gZW5jb2Rpbmc6TlNVVEY4 U3RyaW5nRW5jb2RpbmcgZXJyb3I6bmlsXSk7CisjaWYgVVNFKEFQUExFX0lOVEVSTkFMX1NESykK KyNpbXBvcnQgPFdlYktpdEFkZGl0aW9ucy9SZW5kZXJUaGVtZU1hY01lZGlhQ29udHJvbHNTdHls ZVNoZWV0QWRkaXRpb25zLm1tPgorI2VuZGlmCisgICAgICAgIG1fbWVkaWFDb250cm9sc1N0eWxl U2hlZXQgPSBzdHlsZVNoZWV0QnVpbGRlci50b1N0cmluZygpOworICAgIH0KICAgICByZXR1cm4g bV9tZWRpYUNvbnRyb2xzU3R5bGVTaGVldDsKICNlbHNlCiAgICAgcmV0dXJuIGVtcHR5U3RyaW5n KCk7CkBAIC0yNDUsNiArMjUxLDkgQEAgU3RyaW5nIFJlbmRlclRoZW1lTWFjOjptZWRpYUNvbnRy b2xzU2NyaXB0KCkKICAgICAgICAgU3RyaW5nQnVpbGRlciBzY3JpcHRCdWlsZGVyOwogICAgICAg ICBzY3JpcHRCdWlsZGVyLmFwcGVuZChbTlNTdHJpbmcgc3RyaW5nV2l0aENvbnRlbnRzT2ZGaWxl OltbTlNCdW5kbGUgYnVuZGxlRm9yQ2xhc3M6W1dlYkNvcmVSZW5kZXJUaGVtZUJ1bmRsZSBjbGFz c11dIHBhdGhGb3JSZXNvdXJjZTpAIm1lZGlhQ29udHJvbHNMb2NhbGl6ZWRTdHJpbmdzIiBvZlR5 cGU6QCJqcyJdIGVuY29kaW5nOk5TVVRGOFN0cmluZ0VuY29kaW5nIGVycm9yOm5pbF0pOwogICAg ICAgICBzY3JpcHRCdWlsZGVyLmFwcGVuZChbTlNTdHJpbmcgc3RyaW5nV2l0aENvbnRlbnRzT2ZG aWxlOltbTlNCdW5kbGUgYnVuZGxlRm9yQ2xhc3M6W1dlYkNvcmVSZW5kZXJUaGVtZUJ1bmRsZSBj bGFzc11dIHBhdGhGb3JSZXNvdXJjZTpAIm1lZGlhQ29udHJvbHNBcHBsZSIgb2ZUeXBlOkAianMi XSBlbmNvZGluZzpOU1VURjhTdHJpbmdFbmNvZGluZyBlcnJvcjpuaWxdKTsKKyNpZiBVU0UoQVBQ TEVfSU5URVJOQUxfU0RLKQorI2ltcG9ydCA8V2ViS2l0QWRkaXRpb25zL1JlbmRlclRoZW1lTWFj TWVkaWFDb250cm9sc1NjcmlwdEFkZGl0aW9ucy5tbT4KKyNlbmRpZgogICAgICAgICBtX21lZGlh Q29udHJvbHNTY3JpcHQgPSBzY3JpcHRCdWlsZGVyLnRvU3RyaW5nKCk7CiAgICAgfQogICAgIHJl dHVybiBtX21lZGlhQ29udHJvbHNTY3JpcHQ7Cg==