157389 2016-05-05 14:25:54 -0700 Improve HTTP test names in WebKitTestRunner's crash report information 2016-05-05 23:06:52 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue ddkilzer lforschler mitz ryanhaddad simon.fraser youennf oldest_to_newest 1190457 0 ap 2016-05-05 14:25:54 -0700 A couple issues: 1. WebKitTestRunner doesn't update the path when switching to a WPT based test, because it doesn't whitelist its port numbers. 2. For other HTTP tests, we get just the path, which is confusing (e.g. /misc/BOM-override-script.html instead of http://127.0.0.1:8000/misc/BOM-override-script.html of http/tests/misc/BOM-override-script.html). 1190458 1 278189 ap 2016-05-05 14:28:07 -0700 Created attachment 278189 proposed patch 1190587 2 278189 commit-queue 2016-05-05 19:40:11 -0700 Comment on attachment 278189 proposed patch Clearing flags on attachment: 278189 Committed r200504: <http://trac.webkit.org/changeset/200504> 1190588 3 commit-queue 2016-05-05 19:40:16 -0700 All reviewed patches have been landed. Closing bug. 1190628 4 ap 2016-05-05 23:06:52 -0700 > 2. For other HTTP tests, we get just the path, which is confusing (e.g. /misc/BOM-override-script.html instead of http://127.0.0.1:8000/misc/BOM-override-script.html of http/tests/misc/BOM-override-script.html). Turns out that full URLs don't work. Rolled out this part in r200506. 278189 2016-05-05 14:28:07 -0700 2016-05-05 19:40:11 -0700 proposed patch HTTPPath.txt text/plain 3152 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwMDQ3NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE2LTA1LTA1ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIEltcHJvdmUgSFRUUCB0ZXN0IG5hbWVzIGluIFdlYktpdFRlc3RSdW5uZXIn cyBjcmFzaCByZXBvcnQgaW5mb3JtYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE1NzM4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9jb2Nv YS9JbmplY3RlZEJ1bmRsZVBhZ2VDb2NvYS5tbToKKyAgICAgICAgKFdUUjo6SW5qZWN0ZWRCdW5k bGVQYWdlOjpwbGF0Zm9ybURpZFN0YXJ0UHJvdmlzaW9uYWxMb2FkRm9yRnJhbWUpOiBBZGRlZCBh IEZJWE1FLgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9jb2NvYS9DcmFzaFJlcG9ydGVy SW5mby5tbToKKyAgICAgICAgKFdUUjo6dGVzdERlc2NyaXB0aW9uKTogRG9uJ3QgYmFpbCBvdXQg aWYgdGhlIHBvcnQgaXMgbmVpdGhlciA4MDAwIG5vciA4NDQzOyB3ZQorICAgICAgICB1c2Ugb3Ro ZXIgcG9ydCBudW1iZXJzIHRvby4gRm9yIGh0dHAgdGVzdHMsIHJldHVybiB0aGUgY29tcGxldGUg VVJMIHN0cmluZywgbm90CisgICAgICAgIGp1c3QgdGhlIHBhdGguCisKIDIwMTYtMDUtMDQgIEFs ZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBCbG9j a2VkIHJlZGlyZWN0ZWQgbWFpbiByZXNvdXJjZSByZXF1ZXN0cyBuZWVkIGRlc2NyaXB0aXZlIGVy cm9ycwpJbmRleDogVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9jb2NvYS9J bmplY3RlZEJ1bmRsZVBhZ2VDb2NvYS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9XZWJLaXRUZXN0 UnVubmVyL0luamVjdGVkQnVuZGxlL2NvY29hL0luamVjdGVkQnVuZGxlUGFnZUNvY29hLm1tCShy ZXZpc2lvbiAyMDA0MjgpCisrKyBUb29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxl L2NvY29hL0luamVjdGVkQnVuZGxlUGFnZUNvY29hLm1tCSh3b3JraW5nIGNvcHkpCkBAIC00Miw2 ICs0Miw4IEBAIHZvaWQgSW5qZWN0ZWRCdW5kbGVQYWdlOjpwbGF0Zm9ybURpZFN0YXIKICAgICBp ZiAoIVdLQnVuZGxlRnJhbWVJc01haW5GcmFtZShmcmFtZSkpCiAgICAgICAgIHJldHVybjsKIAor ICAgIC8vIEZJWE1FOiBXZSBzaG91bGQgbm90IGJlIGNoYW5naW5nIHRlc3QgVVJMIGV2ZXJ5IHRp bWUgdGhlIHRlc3QgbmF2aWdhdGVzLiBUaGUgY3VycmVudCBVUkwgY291bGQgYmUKKyAgICAvLyBh ZGl0aW9uYWwgaW5mb3JtYXRpb24sIGJ1dCBpdCBzaG91bGRuJ3QgcmVwbGFjZSB0aGUgaW5pdGlh bCB0ZXN0IFVSTC4KICAgICBzZXRDcmFzaFJlcG9ydEFwcGxpY2F0aW9uU3BlY2lmaWNJbmZvcm1h dGlvblRvVVJMKEluamVjdGVkQnVuZGxlOjpzaW5nbGV0b24oKS50ZXN0UnVubmVyKCktPnRlc3RV UkwoKSk7CiB9CiAKSW5kZXg6IFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvY29jb2EvQ3Jhc2hSZXBv cnRlckluZm8ubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9jb2NvYS9D cmFzaFJlcG9ydGVySW5mby5tbQkocmV2aXNpb24gMjAwNDI4KQorKysgVG9vbHMvV2ViS2l0VGVz dFJ1bm5lci9jb2NvYS9DcmFzaFJlcG9ydGVySW5mby5tbQkod29ya2luZyBjb3B5KQpAQCAtMzMs NyArMzMsNyBAQAogCiBuYW1lc3BhY2UgV1RSIHsKIAotc3RhdGljIFN0cmluZyB0ZXN0UGF0aEZy b21VUkwoV0tVUkxSZWYgdXJsKQorc3RhdGljIFN0cmluZyB0ZXN0RGVzY3JpcHRpb24oV0tVUkxS ZWYgdXJsKQogewogICAgIFJldGFpblB0cjxDRlVSTFJlZj4gY2ZVUkwgPSBhZG9wdENGKFdLVVJM Q29weUNGVVJMKGtDRkFsbG9jYXRvckRlZmF1bHQsIHVybCkpOwogICAgIGlmICghY2ZVUkwpCkBA IC01OSwxOCArNTksMTggQEAgc3RhdGljIFN0cmluZyB0ZXN0UGF0aEZyb21VUkwoV0tVUkxSZWYg dQogCiAgICAgUmV0YWluUHRyPENGU3RyaW5nUmVmPiBob3N0Q0ZTdHJpbmcgPSBhZG9wdENGKENG VVJMQ29weUhvc3ROYW1lKGNmVVJMLmdldCgpKSk7CiAgICAgU3RyaW5nIGhvc3RTdHJpbmcoaG9z dENGU3RyaW5nLmdldCgpKTsKLSAgICBpZiAoaG9zdFN0cmluZyA9PSAiMTI3LjAuMC4xIiAgJiYg KENGVVJMR2V0UG9ydE51bWJlcihjZlVSTC5nZXQoKSkgPT0gODAwMCB8fCBDRlVSTEdldFBvcnRO dW1iZXIoY2ZVUkwuZ2V0KCkpID09IDg0NDMpKQotICAgICAgICByZXR1cm4gcGF0aFN0cmluZzsK KyAgICBpZiAoaG9zdFN0cmluZyAhPSAiMTI3LjAuMC4xIikKKyAgICAgICAgcmV0dXJuIFN0cmlu ZygpOwogCi0gICAgcmV0dXJuIFN0cmluZygpOworICAgIHJldHVybiBDRlVSTEdldFN0cmluZyhj ZlVSTC5nZXQoKSk7CiB9CiAKIHZvaWQgc2V0Q3Jhc2hSZXBvcnRBcHBsaWNhdGlvblNwZWNpZmlj SW5mb3JtYXRpb25Ub1VSTChXS1VSTFJlZiB1cmwpCiB7Ci0gICAgU3RyaW5nIHRlc3RQYXRoID0g dGVzdFBhdGhGcm9tVVJMKHVybCk7Ci0gICAgaWYgKCF0ZXN0UGF0aC5pc051bGwoKSkgeworICAg IFN0cmluZyBkZXNjcmlwdGlvbiA9IHRlc3REZXNjcmlwdGlvbih1cmwpOworICAgIGlmICghZGVz Y3JpcHRpb24uaXNOdWxsKCkpIHsKICAgICAgICAgU3RyaW5nIG1lc3NhZ2UoIkNSQVNISU5HIFRF U1Q6ICIpOwotICAgICAgICBtZXNzYWdlID0gbWVzc2FnZSArIHRlc3RQYXRoOworICAgICAgICBt ZXNzYWdlID0gbWVzc2FnZSArIGRlc2NyaXB0aW9uOwogICAgICAgICBXS1NldENyYXNoUmVwb3J0 QXBwbGljYXRpb25TcGVjaWZpY0luZm9ybWF0aW9uKG1lc3NhZ2UuY3JlYXRlQ0ZTdHJpbmcoKS5n ZXQoKSk7CiAgICAgfQogfQo=