157377 2016-05-05 09:55:31 -0700 [iOS] Media information is sometimes not shown in Control Center 2016-05-06 09:30:40 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=156243 InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue ddkilzer jer.noble webkit-bug-importer oldest_to_newest 1190372 0 eric.carlson 2016-05-05 09:55:31 -0700 Media information is sometimes not shown in Control Center 1190374 1 278171 eric.carlson 2016-05-05 09:58:15 -0700 Created attachment 278171 Proposed patch. 1190404 2 278171 commit-queue 2016-05-05 11:51:11 -0700 Comment on attachment 278171 Proposed patch. Clearing flags on attachment: 278171 Committed r200466: <http://trac.webkit.org/changeset/200466> 1190405 3 commit-queue 2016-05-05 11:51:16 -0700 All reviewed patches have been landed. Closing bug. 1190666 4 ddkilzer 2016-05-06 03:23:18 -0700 Is this a regression from r199351 for Bug 156243? Bug 156243: [iOS] media title sometimes remain in Control Center after tab is closed ​<https://bugs.webkit.org/show_bug.cgi?id=156243> <http://trac.webkit.org/changeset/199351> 1190667 5 webkit-bug-importer 2016-05-06 03:25:55 -0700 <rdar://problem/26137383> 1190688 6 eric.carlson 2016-05-06 09:30:40 -0700 (In reply to comment #4) > Is this a regression from r199351 for Bug 156243? > > Bug 156243: [iOS] media title sometimes remain in Control Center after tab > is closed > ​<https://bugs.webkit.org/show_bug.cgi?id=156243> > <http://trac.webkit.org/changeset/199351> It isn't a regression, I didn't completely fix the problem in r199351. 278171 2016-05-05 09:58:15 -0700 2016-05-05 11:51:11 -0700 Proposed patch. cleanup_patch_1.txt text/plain 4532 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMDQ1NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA1LTA1ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIE1lZGlhIGlu Zm9ybWF0aW9uIGlzIHNvbWV0aW1lcyBub3Qgc2hvd24gaW4gQ29udHJvbCBDZW50ZXIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NzM3NworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vYXVk aW8vaW9zL01lZGlhU2Vzc2lvbk1hbmFnZXJJT1MuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9hdWRp by9pb3MvTWVkaWFTZXNzaW9uTWFuYWdlcklPUy5tbToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlh U2Vzc2lvbk1hbmFnZXJpT1M6OnVwZGF0ZU5vd1BsYXlpbmdJbmZvKTogU3RvcmUgdmFsdWVzIHBh c3NlZCB0byBNUE5vd1BsYXlpbmdJbmZvQ2VudGVyCisgICAgICAgICAgaW5kaXZpZHVhbGx5IGlu c3RlYWQgb2YgaW4gYSBkaWN0aW9uYXJ5LgorCiAyMDE2LTA1LTA1ICBaYW4gRG9iZXJzZWsgIDx6 ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBGaXggYXNzZXJ0aW9ucyBpbiBkZWJ1ZyBi dWlsZHMgZm9yIHRoZSBHVEsrIHBvcnQuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9h dWRpby9pb3MvTWVkaWFTZXNzaW9uTWFuYWdlcklPUy5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL2lvcy9NZWRpYVNlc3Npb25NYW5hZ2VySU9TLmgJKHJldmlz aW9uIDIwMDM2OCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL2lvcy9NZWRpYVNl c3Npb25NYW5hZ2VySU9TLmgJKHdvcmtpbmcgY29weSkKQEAgLTczLDcgKzczLDEwIEBAIHByaXZh dGU6CiAgICAgUGxhdGZvcm1NZWRpYVNlc3Npb24qIG5vd1BsYXlpbmdFbGlnaWJsZVNlc3Npb24o KTsKICAgICAKICAgICBSZXRhaW5QdHI8V2ViTWVkaWFTZXNzaW9uSGVscGVyPiBtX29iamNPYnNl cnZlcjsKLSAgICBSZXRhaW5QdHI8TlNNdXRhYmxlRGljdGlvbmFyeT4gbV9ub3dQbGF5aW5nSW5m bzsKKyAgICBkb3VibGUgbV9yZXBvcnRlZFJhdGUgeyAwIH07CisgICAgZG91YmxlIG1fcmVwb3J0 ZWREdXJhdGlvbiB7IDAgfTsKKyAgICBTdHJpbmcgbV9yZXBvcnRlZFRpdGxlOworICAgIGJvb2wg bV9ub3dQbGF5aW5nQWN0aXZlIHsgZmFsc2UgfTsKICAgICBib29sIG1faXNJbkJhY2tncm91bmQg eyBmYWxzZSB9OwogfTsKIApJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vaW9z L01lZGlhU2Vzc2lvbk1hbmFnZXJJT1MubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vYXVkaW8vaW9zL01lZGlhU2Vzc2lvbk1hbmFnZXJJT1MubW0JKHJldmlzaW9uIDIw MDM2OCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL2lvcy9NZWRpYVNlc3Npb25N YW5hZ2VySU9TLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yNDAsNDAgKzI0MCw0MiBAQCB2b2lkIE1l ZGlhU2Vzc2lvbk1hbmFnZXJpT1M6OnVwZGF0ZU5vd1BsCiAgICAgTE9HKE1lZGlhLCAiTWVkaWFT ZXNzaW9uTWFuYWdlcmlPUzo6dXBkYXRlTm93UGxheWluZ0luZm8gLSBjdXJyZW50U2Vzc2lvbiA9 ICVwIiwgY3VycmVudFNlc3Npb24pOwogCiAgICAgaWYgKCFjdXJyZW50U2Vzc2lvbikgewotICAg ICAgICBpZiAobV9ub3dQbGF5aW5nSW5mbykgeworICAgICAgICBpZiAobV9ub3dQbGF5aW5nQWN0 aXZlKSB7CiAgICAgICAgICAgICBMT0coTWVkaWEsICJNZWRpYVNlc3Npb25NYW5hZ2VyaU9TOjp1 cGRhdGVOb3dQbGF5aW5nSW5mbyAtIGNsZWFyaW5nIG5vdyBwbGF5aW5nIGluZm8iKTsKICAgICAg ICAgICAgIFtub3dQbGF5aW5nIHNldE5vd1BsYXlpbmdJbmZvOm5pbF07Ci0gICAgICAgICAgICBt X25vd1BsYXlpbmdJbmZvID0gbmlsOworICAgICAgICAgICAgbV9ub3dQbGF5aW5nQWN0aXZlID0g ZmFsc2U7CiAgICAgICAgIH0KIAogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgUmV0YWlu UHRyPE5TTXV0YWJsZURpY3Rpb25hcnk+IGluZm8gPSBhZG9wdE5TKFtbTlNNdXRhYmxlRGljdGlv bmFyeSBhbGxvY10gaW5pdF0pOwotCiAgICAgU3RyaW5nIHRpdGxlID0gY3VycmVudFNlc3Npb24t PnRpdGxlKCk7Ci0gICAgaWYgKCF0aXRsZS5pc0VtcHR5KCkpCi0gICAgICAgIFtpbmZvIHNldFZh bHVlOnN0YXRpY19jYXN0PE5TU3RyaW5nICo+KHRpdGxlKSBmb3JLZXk6TVBNZWRpYUl0ZW1Qcm9w ZXJ0eVRpdGxlXTsKLQogICAgIGRvdWJsZSBkdXJhdGlvbiA9IGN1cnJlbnRTZXNzaW9uLT5kdXJh dGlvbigpOwotICAgIGlmIChzdGQ6OmlzZmluaXRlKGR1cmF0aW9uKSAmJiBkdXJhdGlvbiAhPSBN ZWRpYVBsYXllcjo6aW52YWxpZFRpbWUoKSkKLSAgICAgICAgW2luZm8gc2V0VmFsdWU6QChkdXJh dGlvbikgZm9yS2V5Ok1QTWVkaWFJdGVtUHJvcGVydHlQbGF5YmFja0R1cmF0aW9uXTsKLQotICAg IFtpbmZvIHNldFZhbHVlOihjdXJyZW50U2Vzc2lvbi0+c3RhdGUoKSA9PSBQbGF0Zm9ybU1lZGlh U2Vzc2lvbjo6UGxheWluZyA/IEBZRVMgOiBATk8pIGZvcktleTpNUE5vd1BsYXlpbmdJbmZvUHJv cGVydHlQbGF5YmFja1JhdGVdOwotCi0gICAgaWYgKFttX25vd1BsYXlpbmdJbmZvLmdldCgpIGlz RXF1YWxUb0RpY3Rpb25hcnk6aW5mby5nZXQoKV0pIHsKKyAgICBkb3VibGUgcmF0ZSA9IGN1cnJl bnRTZXNzaW9uLT5zdGF0ZSgpID09IFBsYXRmb3JtTWVkaWFTZXNzaW9uOjpQbGF5aW5nID8gMSA6 IDA7CisgICAgaWYgKG1fcmVwb3J0ZWRUaXRsZSA9PSB0aXRsZSAmJiBtX3JlcG9ydGVkUmF0ZSA9 PSByYXRlICYmIG1fcmVwb3J0ZWREdXJhdGlvbiA9PSBkdXJhdGlvbikgewogICAgICAgICBMT0co TWVkaWEsICJNZWRpYVNlc3Npb25NYW5hZ2VyaU9TOjp1cGRhdGVOb3dQbGF5aW5nSW5mbyAtIG5v dGhpbmcgbmV3IHRvIHNob3ciKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAgIG1fbm93 UGxheWluZ0luZm8gPSBpbmZvOworICAgIG1fcmVwb3J0ZWRSYXRlID0gcmF0ZTsKKyAgICBtX3Jl cG9ydGVkRHVyYXRpb24gPSBkdXJhdGlvbjsKKyAgICBtX3JlcG9ydGVkVGl0bGUgPSB0aXRsZTsK KworICAgIGF1dG8gaW5mbyA9IGFkb3B0TlMoW1tOU011dGFibGVEaWN0aW9uYXJ5IGFsbG9jXSBp bml0XSk7CisgICAgaWYgKCF0aXRsZS5pc0VtcHR5KCkpCisgICAgICAgIGluZm8uZ2V0KClbTVBN ZWRpYUl0ZW1Qcm9wZXJ0eVRpdGxlXSA9IHN0YXRpY19jYXN0PE5TU3RyaW5nICo+KHRpdGxlKTsK KyAgICBpZiAoc3RkOjppc2Zpbml0ZShkdXJhdGlvbikgJiYgZHVyYXRpb24gIT0gTWVkaWFQbGF5 ZXI6OmludmFsaWRUaW1lKCkpCisgICAgICAgIGluZm8uZ2V0KClbTVBNZWRpYUl0ZW1Qcm9wZXJ0 eVBsYXliYWNrRHVyYXRpb25dID0gQChkdXJhdGlvbik7CisgICAgaW5mby5nZXQoKVtNUE5vd1Bs YXlpbmdJbmZvUHJvcGVydHlQbGF5YmFja1JhdGVdID0gQChyYXRlKTsKIAogICAgIGRvdWJsZSBj dXJyZW50VGltZSA9IGN1cnJlbnRTZXNzaW9uLT5jdXJyZW50VGltZSgpOwogICAgIGlmIChzdGQ6 OmlzZmluaXRlKGN1cnJlbnRUaW1lKSAmJiBjdXJyZW50VGltZSAhPSBNZWRpYVBsYXllcjo6aW52 YWxpZFRpbWUoKSkKLSAgICAgICAgW2luZm8gc2V0VmFsdWU6QChjdXJyZW50VGltZSkgZm9yS2V5 Ok1QTm93UGxheWluZ0luZm9Qcm9wZXJ0eUVsYXBzZWRQbGF5YmFja1RpbWVdOworICAgICAgICBp bmZvLmdldCgpW01QTm93UGxheWluZ0luZm9Qcm9wZXJ0eUVsYXBzZWRQbGF5YmFja1RpbWVdID0g QChjdXJyZW50VGltZSk7CiAKLSAgICBMT0coTWVkaWEsICJNZWRpYVNlc3Npb25NYW5hZ2VyaU9T Ojp1cGRhdGVOb3dQbGF5aW5nSW5mbyAtIHRpdGxlID0gXCIlc1wiIiwgW1tpbmZvLmdldCgpIHZh bHVlRm9yS2V5Ok1QTWVkaWFJdGVtUHJvcGVydHlUaXRsZV0gVVRGOFN0cmluZ10pOworICAgIExP RyhNZWRpYSwgIk1lZGlhU2Vzc2lvbk1hbmFnZXJpT1M6OnVwZGF0ZU5vd1BsYXlpbmdJbmZvIC0g dGl0bGUgPSBcIiVzXCIsIHJhdGUgPSAlZiwgZHVyYXRpb24gPSAlZiwgbm93ID0gJWYiLAorICAg ICAgICB0aXRsZS51dGY4KCkuZGF0YSgpLCByYXRlLCBkdXJhdGlvbiwgY3VycmVudFRpbWUpOwog CisgICAgbV9ub3dQbGF5aW5nQWN0aXZlID0gdHJ1ZTsKICAgICBbbm93UGxheWluZyBzZXROb3dQ bGF5aW5nSW5mbzppbmZvLmdldCgpXTsKIH0KIAo=