157367 2016-05-04 17:13:32 -0700 Add HLE locks and synchronic TTAS locks to the ToyLocks benchmark suite 2016-05-04 17:17:53 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo commit-queue oldest_to_newest 1190278 0 fpizlo 2016-05-04 17:13:32 -0700 Patch forthcoming. 1190279 1 278145 fpizlo 2016-05-04 17:16:01 -0700 Created attachment 278145 the patch 1190280 2 commit-queue 2016-05-04 17:17:26 -0700 Attachment 278145 did not pass style-queue: ERROR: Source/WTF/benchmarks/ToyLocks.h:113: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/benchmarks/ToyLocks.h:116: Wrong number of spaces before statement. (expected: 20) [whitespace/indent] [4] ERROR: Source/WTF/benchmarks/ToyLocks.h:117: Wrong number of spaces before statement. (expected: 20) [whitespace/indent] [4] ERROR: Source/WTF/benchmarks/ToyLocks.h:121: Wrong number of spaces before statement. (expected: 20) [whitespace/indent] [4] ERROR: Source/WTF/benchmarks/ToyLocks.h:125: Wrong number of spaces before statement. (expected: 20) [whitespace/indent] [4] ERROR: Source/WTF/benchmarks/ToyLocks.h:117: Wrong number of spaces before statement. (expected: 20) [whitespace/indent] [4] ERROR: Source/WTF/benchmarks/ToyLocks.h:121: Wrong number of spaces before statement. (expected: 20) [whitespace/indent] [4] ERROR: Source/WTF/benchmarks/ToyLocks.h:125: Wrong number of spaces before statement. (expected: 20) [whitespace/indent] [4] ERROR: Source/WTF/benchmarks/ToyLocks.h:127: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/benchmarks/ToyLocks.h:130: Wrong number of spaces before statement. (expected: 16) [whitespace/indent] [4] ERROR: Source/WTF/benchmarks/ToyLocks.h:134: Wrong number of spaces before statement. (expected: 16) [whitespace/indent] [4] ERROR: Source/WTF/benchmarks/ToyLocks.h:130: Wrong number of spaces before statement. (expected: 16) [whitespace/indent] [4] ERROR: Source/WTF/benchmarks/ToyLocks.h:134: Wrong number of spaces before statement. (expected: 16) [whitespace/indent] [4] Total errors found: 13 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1190281 3 fpizlo 2016-05-04 17:17:53 -0700 Landed in http://trac.webkit.org/changeset/200444 278145 2016-05-04 17:16:01 -0700 2016-05-04 17:16:36 -0700 the patch blah.patch text/plain 3673 fpizlo SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMDA0NDIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA1LTA0ICBGaWxpcCBQaXpsbyAgPGZwaXps b0BhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIEhMRSBsb2NrcyBhbmQgc3luY2hyb25pYyBUVEFT IGxvY2tzIHRvIHRoZSBUb3lMb2NrcyBiZW5jaG1hcmsgc3VpdGUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NzM2NworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgVHVybnMgb3V0IHRoZXkgYXJl IGJvdGggYSBsb3Qgc2xvd2VyIHRoYW4gV1RGOjpMb2NrLiBUaGUgSExFIGxvY2sgaXMgd3JpdHRl biBhY2NvcmRpbmcgdG8gSW50ZWwncworICAgICAgICBkb2N1bWVudGF0aW9uLiBUaGUgc3luY2hy b25pYyBsb2NrIGZvbGxvd3MgdGhlIGFsZ29yaXRobSBvZiB0aGUgInR0YXNfbG9jayIgaW4gdGhl IHN5bmNocm9uaWMKKyAgICAgICAgdGVzdC5ocHAuCisKKyAgICAgICAgKiBiZW5jaG1hcmtzL1Rv eUxvY2tzLmg6CisKIDIwMTYtMDUtMDQgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4K IAogICAgICAgICBBZGQgYSBmZXcgbW9yZSBXVEYgbG9ja2luZyBiZW5jaG1hcmtzCkluZGV4OiBT b3VyY2UvV1RGL2JlbmNobWFya3MvVG95TG9ja3MuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RG L2JlbmNobWFya3MvVG95TG9ja3MuaAkocmV2aXNpb24gMjAwNDM4KQorKysgU291cmNlL1dURi9i ZW5jaG1hcmtzL1RveUxvY2tzLmgJKHdvcmtpbmcgY29weSkKQEAgLTMyLDYgKzMyLDEwIEBACiAj aW5jbHVkZSA8d3RmL1BhcmtpbmdMb3QuaD4KICNpbmNsdWRlIDx3dGYvV29yZExvY2suaD4KIAor I2lmIGRlZmluZWQoRVhUUkFfTE9DS1MpICYmIEVYVFJBX0xPQ0tTCisjaW5jbHVkZSA8c3luY2hy b25pYz4KKyNlbmRpZgorCiBuYW1lc3BhY2UgewogCiB1bnNpZ25lZCB0b3lMb2NrU3BpbkxpbWl0 ID0gNDA7CkBAIC05Miw2ICs5Niw4MyBAQCBwcml2YXRlOgogICAgIEF0b21pYzx1bnNpZ25lZD4g bV9sb2NrOwogfTsKIAorI2lmIGRlZmluZWQoRVhUUkFfTE9DS1MpICYmIEVYVFJBX0xPQ0tTCitj bGFzcyBUcmFuc2FjdGlvbmFsU3BpbkxvY2sgeworcHVibGljOgorICAgIFRyYW5zYWN0aW9uYWxT cGluTG9jaygpCisgICAgeworICAgICAgICBtX2xvY2sgPSAwOworICAgIH0KKworICAgIHZvaWQg bG9jaygpCisgICAgeworICAgICAgICBmb3IgKDs7KSB7CisgICAgICAgICAgICB1bnNpZ25lZCBj aGFyIHJlc3VsdDsKKyAgICAgICAgICAgIHVuc2lnbmVkIGV4cGVjdGVkID0gMDsKKyAgICAgICAg ICAgIHVuc2lnbmVkIGRlc2lyZWQgPSAxOworICAgICAgICAgICAgYXNtIHZvbGF0aWxlICgKKyAg ICAgICAgICAgICAgICAieGFjcXVpcmU7IGxvY2s7IGNtcHhjaGdsICUzLCAlMlxuXHQiCisgICAg ICAgICAgICAgICAgInNldGUgJTEiCisgICAgICAgICAgICAgICAgOiAiK2EiKGV4cGVjdGVkKSwg Ij1xIihyZXN1bHQpLCAiK20iKG1fbG9jaykKKyAgICAgICAgICAgICAgICA6ICJyIihkZXNpcmVk KQorICAgICAgICAgICAgICAgIDogIm1lbW9yeSIpOworICAgICAgICAgICAgaWYgKHJlc3VsdCkK KyAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICBzdGQ6OnRoaXNfdGhyZWFkOjp5 aWVsZCgpOworICAgICAgICB9CisgICAgfQorCisgICAgdm9pZCB1bmxvY2soKQorICAgIHsKKyAg ICAgICAgYXNtIHZvbGF0aWxlICgKKyAgICAgICAgICAgICJ4cmVsZWFzZTsgbW92bCAkMCwgJTAi CisgICAgICAgICAgICA6CisgICAgICAgICAgICA6ICJtIihtX2xvY2spCisgICAgICAgICAgICA6 ICJtZW1vcnkiKTsKKyAgICB9CisKKyAgICBib29sIGlzTG9ja2VkKCkgY29uc3QKKyAgICB7Cisg ICAgICAgIHJldHVybiBtX2xvY2s7CisgICAgfQorCitwcml2YXRlOgorICAgIHVuc2lnbmVkIG1f bG9jazsKK307CisKK2NsYXNzIFN5bmNocm9uaWNMb2NrIHsKK3B1YmxpYzoKKyAgICBTeW5jaHJv bmljTG9jaygpCisgICAgICAgIDogbV9sb2NrZWQoMCkKKyAgICB7CisgICAgfQorICAgIAorICAg IHZvaWQgbG9jaygpCisgICAgeworICAgICAgICBmb3IgKDs7KSB7CisgICAgICAgICAgICBpbnQg c3RhdGUgPSAwOworICAgICAgICAgICAgaWYgKG1fbG9ja2VkLmNvbXBhcmVfZXhjaGFuZ2Vfd2Vh ayhzdGF0ZSwgMSwgc3RkOjptZW1vcnlfb3JkZXJfYWNxdWlyZSkpCisgICAgICAgICAgICAgICAg cmV0dXJuOworICAgICAgICAgICAgbV9zeW5jLndhaXRfZm9yX2NoYW5nZShtX2xvY2tlZCwgc3Rh dGUsIHN0ZDo6bWVtb3J5X29yZGVyX3JlbGF4ZWQpOworICAgICAgICB9CisgICAgfQorICAgIAor ICAgIHZvaWQgdW5sb2NrKCkKKyAgICB7CisgICAgICAgIG1fc3luYy5ub3RpZnlfb25lKG1fbG9j a2VkLCAwLCBzdGQ6Om1lbW9yeV9vcmRlcl9yZWxlYXNlKTsKKyAgICB9CisgICAgCisgICAgYm9v bCBpc0xvY2tlZCgpCisgICAgeworICAgICAgICByZXR1cm4gbV9sb2NrZWQubG9hZCgpOworICAg IH0KKworcHJpdmF0ZToKKyAgICBzdGQ6OmF0b21pYzxpbnQ+IG1fbG9ja2VkOworICAgIHN0ZDo6 ZXhwZXJpbWVudGFsOjpzeW5jaHJvbmljPGludD4gbV9zeW5jOworfTsKKyNlbmRpZgorCiB0ZW1w bGF0ZTx0eXBlbmFtZSBTdGF0ZVR5cGU+CiBjbGFzcyBCYXJnaW5nTG9jayB7CiBwdWJsaWM6CkBA IC0zOTIsNiArNDczLDEyIEBAIHZvaWQgcnVuRXZlcnl0aGluZyhjb25zdCBjaGFyKiB3aGF0KQog ICAgICAgICBCZW5jaG1hcms6OnRlbXBsYXRlIHJ1bjxZaWVsZFNwaW5Mb2NrPigiWWllbGRTcGlu TG9jayIpOwogICAgIGlmICghc3RyY21wKHdoYXQsICJwYXVzZXNwaW5sb2NrIikgfHwgIXN0cmNt cCh3aGF0LCAiYWxsIikpCiAgICAgICAgIEJlbmNobWFyazo6dGVtcGxhdGUgcnVuPFBhdXNlU3Bp bkxvY2s+KCJQYXVzZVNwaW5Mb2NrIik7CisjaWYgZGVmaW5lZChFWFRSQV9MT0NLUykgJiYgRVhU UkFfTE9DS1MKKyAgICBpZiAoIXN0cmNtcCh3aGF0LCAidHJhbnNhY3Rpb25hbHNwaW5sb2NrIikg fHwgIXN0cmNtcCh3aGF0LCAiYWxsIikpCisgICAgICAgIEJlbmNobWFyazo6dGVtcGxhdGUgcnVu PFRyYW5zYWN0aW9uYWxTcGluTG9jaz4oIlRyYW5zYWN0aW9uYWxTcGluTG9jayIpOworICAgIGlm ICghc3RyY21wKHdoYXQsICJzeW5jaHJvbmljbG9jayIpIHx8ICFzdHJjbXAod2hhdCwgImFsbCIp KQorICAgICAgICBCZW5jaG1hcms6OnRlbXBsYXRlIHJ1bjxTeW5jaHJvbmljTG9jaz4oIlN5bmNo cm9uaWNMb2NrIik7CisjZW5kaWYKICAgICBpZiAoIXN0cmNtcCh3aGF0LCAid29yZGxvY2siKSB8 fCAhc3RyY21wKHdoYXQsICJhbGwiKSkKICAgICAgICAgQmVuY2htYXJrOjp0ZW1wbGF0ZSBydW48 V29yZExvY2s+KCJXVEZXb3JkTG9jayIpOwogICAgIGlmICghc3RyY21wKHdoYXQsICJsb2NrIikg fHwgIXN0cmNtcCh3aGF0LCAiYWxsIikpCg==