157363 2016-05-04 15:39:26 -0700 Experimental Features don't need an "Experimental" prefix 2016-05-04 16:41:57 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino webkit-bug-importer oldest_to_newest 1190243 0 dino 2016-05-04 15:39:26 -0700 Experimental Features don't need an "Experimental" prefix 1190245 1 webkit-bug-importer 2016-05-04 15:41:49 -0700 <rdar://problem/26100630> 1190246 2 278136 dino 2016-05-04 15:41:59 -0700 Created attachment 278136 Patch 1190247 3 278136 andersca 2016-05-04 15:46:37 -0700 Comment on attachment 278136 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278136&action=review > Source/WebKit2/Shared/WebPreferencesDefinitions.h:296 > + macro(cssGridLayoutEnabled, cssGridLayoutEnabled, Bool, bool, false, "CSS Grid", "CSS Grid Layout Module support") \ > + macro(customElementsEnabled, customElementsEnabled, Bool, bool, false, "Custom Elements", "HTML Custom Elements prototype") \ > + macro(shadowDOMEnabled, shadowDOMEnabled, Bool, bool, false, "Shadow DOM", "HTML Shadow DOM prototype") \ > + macro(webGL2Enabled, webGL2Enabled, Bool, bool, false, "WebGL 2.0", "WebGL 2 prototype") \ Did you intend to make the keys lower case here? 1190251 4 dino 2016-05-04 15:57:34 -0700 (In reply to comment #3) > Did you intend to make the keys lower case here? I did not. Thank you. 1190271 5 dino 2016-05-04 16:41:57 -0700 Committed r200440: <http://trac.webkit.org/changeset/200440> 278136 2016-05-04 15:41:59 -0700 2016-05-04 15:46:37 -0700 Patch bug-157363-20160505084238.patch text/plain 6303 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwNDM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZmFkNzk4ZDlmOGJhOGM2 ODFiNjYyZmNhYmRmMDg5YmE5YmM1OWUxMS4uNWNjZTY1YWMwZWJmZWMxZDM2ODEzNGM1MzdjMzNi YzdjMzllNDk4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDE2LTA1LTA0ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAorICAgICAgICBFeHBlcmltZW50YWwgRmVhdHVy ZXMgZG9uJ3QgbmVlZCBhbiAiRXhwZXJpbWVudGFsIiBwcmVmaXgKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NzM2MworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbmNlIHdlJ3JlIG5vdCBwZXJzaXN0aW5n IHRoZSB2YWx1ZSBvZiB0aGUgZXhwZXJpbWVudGFsCisgICAgICAgIGZlYXR1cmVzLCBpdCdzIHVu bGlrZWx5IHRoZXJlIHdpbGwgZXZlciBiZSB0aGUgY2FzZQorICAgICAgICB3aGVyZSB3ZSBtb3Zl IGEgUHJlZmVyZW5jZSBmcm9tIGV4cGVyaW1lbnRhbCB0byBub3JtYWwKKyAgICAgICAgYW5kIHVz ZSBhIHN0b3JlZCB2YWx1ZS4KKworICAgICAgICAqIFNoYXJlZC9XZWJQcmVmZXJlbmNlc0RlZmlu aXRpb25zLmg6CisgICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1 bmRsZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OkluamVjdGVkQnVuZGxlOjpvdmVycmlkZUJvb2xQ cmVmZXJlbmNlRm9yVGVzdFJ1bm5lcik6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dl YlBhZ2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjp1cGRhdGVQcmVmZXJlbmNlcyk6 CisKKzIwMTYtMDUtMDQgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCiAgICAgICAg IEV4cGVyaW1lbnRhbCBmZWF0dXJlcyBzaG91bGQgdG9nZ2xlIHJ1bnRpbWUgZmxhZ3MKICAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NzM1MwogICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMjM2MjE2MDM+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9T aGFyZWQvV2ViUHJlZmVyZW5jZXNEZWZpbml0aW9ucy5oIGIvU291cmNlL1dlYktpdDIvU2hhcmVk L1dlYlByZWZlcmVuY2VzRGVmaW5pdGlvbnMuaAppbmRleCAxY2QyYzhkYjllNzVkNTJmMjg0OGE5 MmZmMmQzZGRiZmJjNDFhZDkwLi5iNDk4ZTFkOWNlOGQ0NDRkYjZhYjZjZWNlNGIyNzBiMGQ2MjU3 MDUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViUHJlZmVyZW5jZXNEZWZp bml0aW9ucy5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJQcmVmZXJlbmNlc0RlZmlu aXRpb25zLmgKQEAgLTI4NywxNSArMjg3LDEzIEBACiAvLyAtIFlvdSBtdXN0IHByb3ZpZGUgdGhl IGxhc3QgdHdvIHBhcmFtZXRlcnMgZm9yIGFsbCBleHBlcmltZW50YWwgZmVhdHVyZXMuIFRoZXkK IC8vICAgYXJlIHRoZSB0ZXh0IGV4cG9zZWQgdG8gdGhlIHVzZXIgZnJvbSB0aGUgV2ViS2l0IGNs aWVudC4KIC8vIC0gVGhleSBzaG91bGQgYmUgYWxwaGFiZXRpY2FsbHkgb3JkZXJlZCBieSB0aGUg aHVtYW4gcmVhZGFibGUgdGV4dC4KLS8vIC0gVGhlIGtleSBzaG91bGQgYmUgcHJlZml4ZWQgd2l0 aCAiZXhwZXJpbWVudGFsIiBzbyB0aGF0IGl0IGRvZXNuJ3QgY2xhc2ggaWYvd2hlbiB0aGUgZmVh dHVyZQotLy8gICBiZWNvbWVzIHN0YWJsZS4KIC8vIC0gVGhleSBzaG91bGQgYmUgZmFsc2UgYnkg ZGVmYXVsdC4gVGhlIGNsaWVudCBpcyByZXNwb25zaWJsZSBmb3IgZW5hYmxpbmcgdGhlbS4KIAog I2RlZmluZSBGT1JfRUFDSF9XRUJLSVRfRVhQRVJJTUVOVEFMX0ZFQVRVUkVfUFJFRkVSRU5DRSht YWNybykgXAotICAgIG1hY3JvKEV4cGVyaW1lbnRhbENTU0dyaWRMYXlvdXRFbmFibGVkLCBleHBl cmltZW50YWxDU1NHcmlkTGF5b3V0RW5hYmxlZCwgQm9vbCwgYm9vbCwgZmFsc2UsICJDU1MgR3Jp ZCIsICJDU1MgR3JpZCBMYXlvdXQgTW9kdWxlIHN1cHBvcnQiKSBcCi0gICAgbWFjcm8oRXhwZXJp bWVudGFsQ3VzdG9tRWxlbWVudHNFbmFibGVkLCBleHBlcmltZW50YWxDdXN0b21FbGVtZW50c0Vu YWJsZWQsIEJvb2wsIGJvb2wsIGZhbHNlLCAiQ3VzdG9tIEVsZW1lbnRzIiwgIkhUTUwgQ3VzdG9t IEVsZW1lbnRzIHByb3RvdHlwZSIpIFwKLSAgICBtYWNybyhFeHBlcmltZW50YWxTaGFkb3dET01F bmFibGVkLCBleHBlcmltZW50YWxTaGFkb3dET01FbmFibGVkLCBCb29sLCBib29sLCBmYWxzZSwg IlNoYWRvdyBET00iLCAiSFRNTCBTaGFkb3cgRE9NIHByb3RvdHlwZSIpIFwKLSAgICBtYWNybyhF eHBlcmltZW50YWxXZWJHTDJFbmFibGVkLCBleHBlcmltZW50YWxXZWJHTDJFbmFibGVkLCBCb29s LCBib29sLCBmYWxzZSwgIldlYkdMIDIuMCIsICJXZWJHTCAyIHByb3RvdHlwZSIpIFwKKyAgICBt YWNybyhjc3NHcmlkTGF5b3V0RW5hYmxlZCwgY3NzR3JpZExheW91dEVuYWJsZWQsIEJvb2wsIGJv b2wsIGZhbHNlLCAiQ1NTIEdyaWQiLCAiQ1NTIEdyaWQgTGF5b3V0IE1vZHVsZSBzdXBwb3J0Iikg XAorICAgIG1hY3JvKGN1c3RvbUVsZW1lbnRzRW5hYmxlZCwgY3VzdG9tRWxlbWVudHNFbmFibGVk LCBCb29sLCBib29sLCBmYWxzZSwgIkN1c3RvbSBFbGVtZW50cyIsICJIVE1MIEN1c3RvbSBFbGVt ZW50cyBwcm90b3R5cGUiKSBcCisgICAgbWFjcm8oc2hhZG93RE9NRW5hYmxlZCwgc2hhZG93RE9N RW5hYmxlZCwgQm9vbCwgYm9vbCwgZmFsc2UsICJTaGFkb3cgRE9NIiwgIkhUTUwgU2hhZG93IERP TSBwcm90b3R5cGUiKSBcCisgICAgbWFjcm8od2ViR0wyRW5hYmxlZCwgd2ViR0wyRW5hYmxlZCwg Qm9vbCwgYm9vbCwgZmFsc2UsICJXZWJHTCAyLjAiLCAiV2ViR0wgMiBwcm90b3R5cGUiKSBcCiAg ICAgXAogCiAjaWYgUExBVEZPUk0oQ09DT0EpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlLmNwcCBiL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuY3BwCmluZGV4IGMx YTMzYzdkMzZiOTM2YmFhMGE1MjhhZGIyZDFjYjMzMjI4ZWRlYWYuLmY0YjQ0ZTUzODVlZWM4ZGVj N2YxNDdjZjVmZjBiNTJkMjhiZDNiZTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuY3BwCkBAIC0yMDQs MjIgKzIwNCwyMiBAQCB2b2lkIEluamVjdGVkQnVuZGxlOjpvdmVycmlkZUJvb2xQcmVmZXJlbmNl Rm9yVGVzdFJ1bm5lcihXZWJQYWdlR3JvdXBQcm94eSogcGFnZQogI2VuZGlmCiAKICNpZiBFTkFC TEUoQ1NTX0dSSURfTEFZT1VUKQotICAgIGlmIChwcmVmZXJlbmNlID09ICJXZWJLaXRFeHBlcmlt ZW50YWxDU1NHcmlkTGF5b3V0RW5hYmxlZCIpCisgICAgaWYgKHByZWZlcmVuY2UgPT0gIldlYktp dENTU0dyaWRMYXlvdXRFbmFibGVkIikKICAgICAgICAgUnVudGltZUVuYWJsZWRGZWF0dXJlczo6 c2hhcmVkRmVhdHVyZXMoKS5zZXRDU1NHcmlkTGF5b3V0RW5hYmxlZChlbmFibGVkKTsKICNlbmRp ZgogCiAjaWYgRU5BQkxFKENVU1RPTV9FTEVNRU5UUykKLSAgICBpZiAocHJlZmVyZW5jZSA9PSAi V2ViS2l0RXhwZXJpbWVudGFsQ3VzdG9tRWxlbWVudHNFbmFibGVkIikKKyAgICBpZiAocHJlZmVy ZW5jZSA9PSAiV2ViS2l0Q3VzdG9tRWxlbWVudHNFbmFibGVkIikKICAgICAgICAgUnVudGltZUVu YWJsZWRGZWF0dXJlczo6c2hhcmVkRmVhdHVyZXMoKS5zZXRDdXN0b21FbGVtZW50c0VuYWJsZWQo ZW5hYmxlZCk7CiAjZW5kaWYKIAogI2lmIEVOQUJMRShTSEFET1dfRE9NKQotICAgIGlmIChwcmVm ZXJlbmNlID09ICJXZWJLaXRFeHBlcmltZW50YWxTaGFkb3dET01FbmFibGVkIikKKyAgICBpZiAo cHJlZmVyZW5jZSA9PSAiV2ViS2l0U2hhZG93RE9NRW5hYmxlZCIpCiAgICAgICAgIFJ1bnRpbWVF bmFibGVkRmVhdHVyZXM6OnNoYXJlZEZlYXR1cmVzKCkuc2V0U2hhZG93RE9NRW5hYmxlZChlbmFi bGVkKTsKICNlbmRpZgogCiAjaWYgRU5BQkxFKFdFQkdMMikKLSAgICBpZiAocHJlZmVyZW5jZSA9 PSAiV2ViS2l0RXhwZXJpbWVudGFsV2ViR0wyRW5hYmxlZCIpCisgICAgaWYgKHByZWZlcmVuY2Ug PT0gIldlYktpdFdlYkdMMkVuYWJsZWQiKQogICAgICAgICBSdW50aW1lRW5hYmxlZEZlYXR1cmVz OjpzaGFyZWRGZWF0dXJlcygpLnNldFdlYkdMMkVuYWJsZWQoZW5hYmxlZCk7CiAjZW5kaWYKIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3Bw IGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCmluZGV4IDgw NThlMzBhM2RlNjM1OTA1MzY4YWFjYzcyZjk5ZTBjMzFkMzI3MjAuLjk5MTE5Y2ZjYjJhMDk5MzQy ZTQ5ZDY5M2E0MzY1YmJkMzU4NTc4ODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYlBhZ2UvV2ViUGFnZS5jcHAKQEAgLTMxMTEsMTkgKzMxMTEsMTkgQEAgdm9pZCBXZWJQYWdl Ojp1cGRhdGVQcmVmZXJlbmNlcyhjb25zdCBXZWJQcmVmZXJlbmNlc1N0b3JlJiBzdG9yZSkKICAg ICAvLyBFeHBlcmltZW50YWwgRmVhdHVyZXMuCiAKICNpZiBFTkFCTEUoQ1NTX0dSSURfTEFZT1VU KQotICAgIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OnNoYXJlZEZlYXR1cmVzKCkuc2V0Q1NTR3Jp ZExheW91dEVuYWJsZWQoc3RvcmUuZ2V0Qm9vbFZhbHVlRm9yS2V5KFdlYlByZWZlcmVuY2VzS2V5 OjpleHBlcmltZW50YWxDU1NHcmlkTGF5b3V0RW5hYmxlZEtleSgpKSk7CisgICAgUnVudGltZUVu YWJsZWRGZWF0dXJlczo6c2hhcmVkRmVhdHVyZXMoKS5zZXRDU1NHcmlkTGF5b3V0RW5hYmxlZChz dG9yZS5nZXRCb29sVmFsdWVGb3JLZXkoV2ViUHJlZmVyZW5jZXNLZXk6OmNzc0dyaWRMYXlvdXRF bmFibGVkS2V5KCkpKTsKICNlbmRpZgogCiAjaWYgRU5BQkxFKENVU1RPTV9FTEVNRU5UUykKLSAg ICBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpzaGFyZWRGZWF0dXJlcygpLnNldEN1c3RvbUVsZW1l bnRzRW5hYmxlZChzdG9yZS5nZXRCb29sVmFsdWVGb3JLZXkoV2ViUHJlZmVyZW5jZXNLZXk6OmV4 cGVyaW1lbnRhbEN1c3RvbUVsZW1lbnRzRW5hYmxlZEtleSgpKSk7CisgICAgUnVudGltZUVuYWJs ZWRGZWF0dXJlczo6c2hhcmVkRmVhdHVyZXMoKS5zZXRDdXN0b21FbGVtZW50c0VuYWJsZWQoc3Rv cmUuZ2V0Qm9vbFZhbHVlRm9yS2V5KFdlYlByZWZlcmVuY2VzS2V5OjpjdXN0b21FbGVtZW50c0Vu YWJsZWRLZXkoKSkpOwogI2VuZGlmCiAKICNpZiBFTkFCTEUoU0hBRE9XX0RPTSkKLSAgICBSdW50 aW1lRW5hYmxlZEZlYXR1cmVzOjpzaGFyZWRGZWF0dXJlcygpLnNldFNoYWRvd0RPTUVuYWJsZWQo c3RvcmUuZ2V0Qm9vbFZhbHVlRm9yS2V5KFdlYlByZWZlcmVuY2VzS2V5OjpleHBlcmltZW50YWxT aGFkb3dET01FbmFibGVkS2V5KCkpKTsKKyAgICBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpzaGFy ZWRGZWF0dXJlcygpLnNldFNoYWRvd0RPTUVuYWJsZWQoc3RvcmUuZ2V0Qm9vbFZhbHVlRm9yS2V5 KFdlYlByZWZlcmVuY2VzS2V5OjpzaGFkb3dET01FbmFibGVkS2V5KCkpKTsKICNlbmRpZgogCiAj aWYgRU5BQkxFKFdFQkdMMikKLSAgICBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpzaGFyZWRGZWF0 dXJlcygpLnNldFdlYkdMMkVuYWJsZWQoc3RvcmUuZ2V0Qm9vbFZhbHVlRm9yS2V5KFdlYlByZWZl cmVuY2VzS2V5OjpleHBlcmltZW50YWxXZWJHTDJFbmFibGVkS2V5KCkpKTsKKyAgICBSdW50aW1l RW5hYmxlZEZlYXR1cmVzOjpzaGFyZWRGZWF0dXJlcygpLnNldFdlYkdMMkVuYWJsZWQoc3RvcmUu Z2V0Qm9vbFZhbHVlRm9yS2V5KFdlYlByZWZlcmVuY2VzS2V5Ojp3ZWJHTDJFbmFibGVkS2V5KCkp KTsKICNlbmRpZgogCiAgICAgYm9vbCBwcm9jZXNzU3VwcHJlc3Npb25FbmFibGVkID0gc3RvcmUu Z2V0Qm9vbFZhbHVlRm9yS2V5KFdlYlByZWZlcmVuY2VzS2V5OjpwYWdlVmlzaWJpbGl0eUJhc2Vk UHJvY2Vzc1N1cHByZXNzaW9uRW5hYmxlZEtleSgpKTsK