157359 2016-05-04 15:07:12 -0700 When exiting fullscreen, call a JS method immediately to implement the style changes for the presentation mode change right away 2016-05-05 11:15:03 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 adachan adachan oldest_to_newest 1190227 0 adachan 2016-05-04 15:07:12 -0700 When exiting fullscreen, call a JS method immediately to implement the style changes for the presentation mode change right away. This should help with the flash in <rdar://problem/24476949>. 1190290 1 278146 adachan 2016-05-04 17:37:31 -0700 Created attachment 278146 Patch 1190355 2 278146 eric.carlson 2016-05-05 07:18:20 -0700 Comment on attachment 278146 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278146&action=review > Source/WebCore/html/HTMLMediaElement.cpp:5399 > + updateMediaControlsAfterPresentationModeChanged(); Nit: I think "updateMediaControlsAfterPresentationModeChange" would be a slightly better name. > Source/WebCore/html/HTMLMediaElement.cpp:6570 > + JSC::CallData callData; > + JSC::CallType callType = function->methodTable()->getCallData(function, callData); > + JSC::MarkedArgumentBuffer argList; > + if (callType == JSC::CallType::None) > + return; Nit: I see that this is based on existing code, but callData and argList should be declared after the potential early return. 1190391 3 adachan 2016-05-05 10:48:21 -0700 (In reply to comment #2) > Comment on attachment 278146 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=278146&action=review > > > Source/WebCore/html/HTMLMediaElement.cpp:5399 > > + updateMediaControlsAfterPresentationModeChanged(); > > Nit: I think "updateMediaControlsAfterPresentationModeChange" would be a > slightly better name. Renamed. > > > Source/WebCore/html/HTMLMediaElement.cpp:6570 > > + JSC::CallData callData; > > + JSC::CallType callType = function->methodTable()->getCallData(function, callData); > > + JSC::MarkedArgumentBuffer argList; > > + if (callType == JSC::CallType::None) > > + return; > > Nit: I see that this is based on existing code, but callData and argList > should be declared after the potential early return. callData is actually used in the call to getCallData(), so I'll keep that there. I've moved the declaration of argList down. Thanks for the review! 1190395 4 adachan 2016-05-05 11:15:03 -0700 Committed: http://trac.webkit.org/changeset/200462 278146 2016-05-04 17:37:31 -0700 2016-05-05 07:18:20 -0700 Patch bug-157359-20160504173811.patch text/plain 3879 adachan U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwNDMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTFjYWVhZTg4M2NhMzUx YWEzM2NjZjY3M2U5YTY5MTYyZTcyNWZhNy4uYjdkNDI1ZGZjNTdlMDk2NzZjNjgxYjE0MjRkYzE5 ZTE0Njk5NTUzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTA1LTA0ICBBZGEg Q2hhbiAgPGFkYWNoYW5AYXBwbGUuY29tPgorCisgICAgICAgIFdoZW4gZXhpdGluZyBmdWxsc2Ny ZWVuLCBjYWxsIGEgSlMgbWV0aG9kIGltbWVkaWF0ZWx5IHRvIGltcGxlbWVudCB0aGUgc3R5bGUg Y2hhbmdlcyBmb3IgdGhlIHByZXNlbnRhdGlvbiBtb2RlIGNoYW5nZSByaWdodCBhd2F5CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTczNTkKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMg YXMgdGhpcyBpcyBkb25lIHRvIGp1c3QgbWl0aWdhdGUgYSB2aXN1YWwgZ2xpdGNoLgorCisgICAg ICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxN ZWRpYUVsZW1lbnQ6OmV4aXRGdWxsc2NyZWVuKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRp YUVsZW1lbnQ6OnVwZGF0ZU1lZGlhQ29udHJvbHNBZnRlclByZXNlbnRhdGlvbk1vZGVDaGFuZ2Vk KToKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuaDoKKwogMjAxNi0wNS0wNCAgQ2hy aXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIE1lZGlhIGVsZW1lbnRzIHNo b3VsZCBub3QgYmUgcGF1c2VkIHJpZ2h0IGF3YXkgd2hlbiByZW1vdmVkIGZyb20gdGhlIGRvY3Vt ZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3Bw IGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAppbmRleCA5MDQwMGQy N2VmMGQ1MDUzMGYyMTY3NWI3MjI2MzllODg1MWZkZDEzLi4xYzcwMWQ4MjAxMzQ3YjQyYzE0Nzg4 YjhhNGFkMjlhZWRkOTE3ZTA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxN ZWRpYUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVu dC5jcHAKQEAgLTUzOTUsNiArNTM5NSw5IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6ZXhpdEZ1 bGxzY3JlZW4oKQogICAgIEFTU0VSVChtX3ZpZGVvRnVsbHNjcmVlbk1vZGUgIT0gVmlkZW9GdWxs c2NyZWVuTW9kZU5vbmUpOwogICAgIFZpZGVvRnVsbHNjcmVlbk1vZGUgb2xkVmlkZW9GdWxsc2Ny ZWVuTW9kZSA9IG1fdmlkZW9GdWxsc2NyZWVuTW9kZTsKICAgICBmdWxsc2NyZWVuTW9kZUNoYW5n ZWQoVmlkZW9GdWxsc2NyZWVuTW9kZU5vbmUpOworI2lmIEVOQUJMRShNRURJQV9DT05UUk9MU19T Q1JJUFQpCisgICAgdXBkYXRlTWVkaWFDb250cm9sc0FmdGVyUHJlc2VudGF0aW9uTW9kZUNoYW5n ZWQoKTsKKyNlbmRpZgogICAgIGlmIChoYXNNZWRpYUNvbnRyb2xzKCkpCiAgICAgICAgIG1lZGlh Q29udHJvbHMoKS0+ZXhpdGVkRnVsbHNjcmVlbigpOwogICAgIGlmIChkb2N1bWVudCgpLnBhZ2Uo KSAmJiBpczxIVE1MVmlkZW9FbGVtZW50PigqdGhpcykpIHsKQEAgLTY1NDAsNiArNjU0MywzNSBA QCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OnNldE1lZGlhQ29udHJvbHNEZXBlbmRPblBhZ2VTY2Fs ZUZhY3Rvcihib29sIGRlcGVuZHNPblBhZwogICAgICAgICBkb2N1bWVudCgpLnVucmVnaXN0ZXJG b3JQYWdlU2NhbGVGYWN0b3JDaGFuZ2VkQ2FsbGJhY2tzKHRoaXMpOwogfQogCit2b2lkIEhUTUxN ZWRpYUVsZW1lbnQ6OnVwZGF0ZU1lZGlhQ29udHJvbHNBZnRlclByZXNlbnRhdGlvbk1vZGVDaGFu Z2VkKCkKK3sKKyAgICBET01XcmFwcGVyV29ybGQmIHdvcmxkID0gZW5zdXJlSXNvbGF0ZWRXb3Js ZCgpOworICAgIFNjcmlwdENvbnRyb2xsZXImIHNjcmlwdENvbnRyb2xsZXIgPSBkb2N1bWVudCgp LmZyYW1lKCktPnNjcmlwdCgpOworICAgIEpTRE9NR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3Qg PSBKU0M6OmpzQ2FzdDxKU0RPTUdsb2JhbE9iamVjdCo+KHNjcmlwdENvbnRyb2xsZXIuZ2xvYmFs T2JqZWN0KHdvcmxkKSk7CisgICAgSlNDOjpFeGVjU3RhdGUqIGV4ZWMgPSBnbG9iYWxPYmplY3Qt Pmdsb2JhbEV4ZWMoKTsKKyAgICBKU0M6OkpTTG9ja0hvbGRlciBsb2NrKGV4ZWMpOworCisgICAg SlNDOjpKU1ZhbHVlIGNvbnRyb2xsZXJWYWx1ZSA9IGNvbnRyb2xsZXJKU1ZhbHVlKCpleGVjLCAq Z2xvYmFsT2JqZWN0LCAqdGhpcyk7CisgICAgSlNDOjpKU09iamVjdCogY29udHJvbGxlck9iamVj dCA9IGNvbnRyb2xsZXJWYWx1ZS50b09iamVjdChleGVjKTsKKworICAgIGlmIChleGVjLT5oYWRF eGNlcHRpb24oKSkKKyAgICAgICAgcmV0dXJuOworCisgICAgSlNDOjpKU1ZhbHVlIGZ1bmN0aW9u VmFsdWUgPSBjb250cm9sbGVyT2JqZWN0LT5nZXQoZXhlYywgSlNDOjpJZGVudGlmaWVyOjpmcm9t U3RyaW5nKGV4ZWMsICJoYW5kbGVQcmVzZW50YXRpb25Nb2RlQ2hhbmdlIikpOworICAgIGlmIChl eGVjLT5oYWRFeGNlcHRpb24oKSB8fCBmdW5jdGlvblZhbHVlLmlzVW5kZWZpbmVkT3JOdWxsKCkp CisgICAgICAgIHJldHVybjsKKworICAgIEpTQzo6SlNPYmplY3QqIGZ1bmN0aW9uID0gZnVuY3Rp b25WYWx1ZS50b09iamVjdChleGVjKTsKKyAgICBBU1NFUlQoIWV4ZWMtPmhhZEV4Y2VwdGlvbigp KTsKKyAgICBKU0M6OkNhbGxEYXRhIGNhbGxEYXRhOworICAgIEpTQzo6Q2FsbFR5cGUgY2FsbFR5 cGUgPSBmdW5jdGlvbi0+bWV0aG9kVGFibGUoKS0+Z2V0Q2FsbERhdGEoZnVuY3Rpb24sIGNhbGxE YXRhKTsKKyAgICBKU0M6Ok1hcmtlZEFyZ3VtZW50QnVmZmVyIGFyZ0xpc3Q7CisgICAgaWYgKGNh bGxUeXBlID09IEpTQzo6Q2FsbFR5cGU6Ok5vbmUpCisgICAgICAgIHJldHVybjsKKworICAgIEpT Qzo6Y2FsbChleGVjLCBmdW5jdGlvbiwgY2FsbFR5cGUsIGNhbGxEYXRhLCBjb250cm9sbGVyT2Jq ZWN0LCBhcmdMaXN0KTsKK30KKwogdm9pZCBIVE1MTWVkaWFFbGVtZW50OjpwYWdlU2NhbGVGYWN0 b3JDaGFuZ2VkKCkKIHsKICAgICBQYWdlKiBwYWdlID0gZG9jdW1lbnQoKS5wYWdlKCk7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaCBiL1NvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCmluZGV4IDE0MjU2MmNkMzJmNmU4NjhiM2Jh N2U0MzAzMjZkYTIwNmNkOTA4YzQuLjkxMDI3NWUzZGFiZjUxYjVhN2ZjOWYxYzAyMGIxNDY2NjFl NzY2YzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCkBAIC00ODMsNiAr NDgzLDcgQEAgcHJvdGVjdGVkOgogI2lmIEVOQUJMRShNRURJQV9DT05UUk9MU19TQ1JJUFQpCiAg ICAgYm9vbCBtZWRpYUNvbnRyb2xzRGVwZW5kT25QYWdlU2NhbGVGYWN0b3IoKSBjb25zdCB7IHJl dHVybiBtX21lZGlhQ29udHJvbHNEZXBlbmRPblBhZ2VTY2FsZUZhY3RvcjsgfQogICAgIHZvaWQg c2V0TWVkaWFDb250cm9sc0RlcGVuZE9uUGFnZVNjYWxlRmFjdG9yKGJvb2wpOworICAgIHZvaWQg dXBkYXRlTWVkaWFDb250cm9sc0FmdGVyUHJlc2VudGF0aW9uTW9kZUNoYW5nZWQoKTsKICNlbmRp ZgogCiAgICAgdm9pZCBzY2hlZHVsZUV2ZW50KGNvbnN0IEF0b21pY1N0cmluZyYgZXZlbnROYW1l KTsK