157356 2016-05-04 13:54:16 -0700 REGRESSION (r200401): Web Inspector: TypeError: undefined is not an object (evaluating 'messageElement.classList') 2016-05-04 16:35:53 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1190207 0 nvasilyev 2016-05-04 13:54:16 -0700 [Error] Uncaught exception in inspector page while handling event Page.frameNavigated TypeError: undefined is not an object (evaluating 'messageElement.classList') (anonymous function) — LogContentView.js:688 forEach _filterMessageElements — LogContentView.js:679 _reappendProvisionalMessages — LogContentView.js:976 _sessionStarted — LogContentView.js:287 dispatch — Object.js:161 dispatchEventToListeners — Object.js:168 _mainResourceDidChange — LogManager.js:118 dispatch — Object.js:161 dispatchEventToListeners — Object.js:176 _dispatchMainResourceDidChangeEvent — Frame.js:497 commitProvisionalLoad — Frame.js:140 frameDidNavigate — FrameResourceManager.js:105 frameNavigated — PageObserver.js:42 dispatchEvent — InspectorBackend.js:448 _dispatchEvent — InspectorBackend.js:342 dispatch — InspectorBackend.js:151 dispatchNextQueuedMessageFromBackend — MessageDispatcher.js:42 _dispatchEvent (InspectorBackend.js:344) dispatch (InspectorBackend.js:151) dispatchNextQueuedMessageFromBackend (MessageDispatcher.js:42) 1190208 1 webkit-bug-importer 2016-05-04 13:55:14 -0700 <rdar://problem/26097424> 1190209 2 nvasilyev 2016-05-04 13:59:13 -0700 https://github.com/WebKit/webkit/blob/2f5ab3dcd0f5d3b6bc36bf46582cee8f76226db4/Source/WebInspectorUI/UserInterface/Views/LogContentView.js#L976 messageView.element doesn't exist when the console hasn't been shown yet. Now that I moved _filterMessageElements to didAppendConsoleMessageView, we should be able to just remove it here. 1190244 3 278135 nvasilyev 2016-05-04 15:41:11 -0700 Created attachment 278135 Patch 1190267 4 278135 commit-queue 2016-05-04 16:35:48 -0700 Comment on attachment 278135 Patch Clearing flags on attachment: 278135 Committed r200439: <http://trac.webkit.org/changeset/200439> 1190268 5 commit-queue 2016-05-04 16:35:53 -0700 All reviewed patches have been landed. Closing bug. 278135 2016-05-04 15:41:11 -0700 2016-05-04 16:35:48 -0700 Patch patch.txt text/plain 1844 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGRhZmNhZWUuLjdhM2I4YzQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA1LTA0ICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyMDA0MDEp OiBXZWIgSW5zcGVjdG9yOiBUeXBlRXJyb3I6IHVuZGVmaW5lZCBpcyBub3QgYW4gb2JqZWN0IChl dmFsdWF0aW5nICdtZXNzYWdlRWxlbWVudC5jbGFzc0xpc3QnKQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3MzU2CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS8yNjA5NzQyND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvTG9nQ29udGVudFZpZXcuanM6CisgICAgICAg IChXZWJJbnNwZWN0b3IuTG9nQ29udGVudFZpZXcucHJvdG90eXBlLl9yZWFwcGVuZFByb3Zpc2lv bmFsTWVzc2FnZXMpOgorICAgICAgICBEb24ndCBmaWx0ZXIgbWVzc2FnZXMgc2luY2Ugd2UgYWxy ZWFkeSBkbyB0aGF0IGluIGRpZEFwcGVuZENvbnNvbGVNZXNzYWdlVmlldy4KKwogMjAxNi0wNS0w NCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJ bnNwZWN0b3I6IEdDIFJvb3QgUGF0aCBzb21ldGltZXMgZG9lcyBub3QgZ28gdXAgdG8gV2luZG93 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9M b2dDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL0xvZ0NvbnRlbnRWaWV3LmpzCmluZGV4IGY2MjliMjUuLjRjYThlMTEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRlbnRWaWV3 LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0Nv bnRlbnRWaWV3LmpzCkBAIC05NzAsMTEgKzk3MCw4IEBAIFdlYkluc3BlY3Rvci5Mb2dDb250ZW50 VmlldyA9IGNsYXNzIExvZ0NvbnRlbnRWaWV3IGV4dGVuZHMgV2ViSW5zcGVjdG9yLkNvbnRlbnRW CiAKICAgICAgICAgdGhpcy5fc3RhcnRlZFByb3Zpc2lvbmFsTG9hZCA9IGZhbHNlOwogCi0gICAg ICAgIGZvciAodmFyIHByb3Zpc2lvbmFsTWVzc2FnZSBvZiB0aGlzLl9wcm92aXNpb25hbE1lc3Nh Z2VzKSB7Ci0gICAgICAgICAgICB2YXIgbWVzc2FnZVZpZXcgPSB0aGlzLl9sb2dWaWV3Q29udHJv bGxlci5hcHBlbmRDb25zb2xlTWVzc2FnZShwcm92aXNpb25hbE1lc3NhZ2UpOwotICAgICAgICAg ICAgaWYgKG1lc3NhZ2VWaWV3Lm1lc3NhZ2UudHlwZSAhPT0gV2ViSW5zcGVjdG9yLkNvbnNvbGVN ZXNzYWdlLk1lc3NhZ2VUeXBlLkVuZEdyb3VwKQotICAgICAgICAgICAgICAgIHRoaXMuX2ZpbHRl ck1lc3NhZ2VFbGVtZW50cyhbbWVzc2FnZVZpZXcuZWxlbWVudF0pOwotICAgICAgICB9CisgICAg ICAgIGZvciAobGV0IHByb3Zpc2lvbmFsTWVzc2FnZSBvZiB0aGlzLl9wcm92aXNpb25hbE1lc3Nh Z2VzKQorICAgICAgICAgICAgdGhpcy5fbG9nVmlld0NvbnRyb2xsZXIuYXBwZW5kQ29uc29sZU1l c3NhZ2UocHJvdmlzaW9uYWxNZXNzYWdlKTsKIAogICAgICAgICB0aGlzLl9wcm92aXNpb25hbE1l c3NhZ2VzID0gW107CiAgICAgfQo=