157352 2016-05-04 13:11:09 -0700 Disabling WebGL2 should mean no context is created 2016-05-06 11:10:18 -0700 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino cdumez commit-queue dino esprehn+autocc graouts gyuyoung.kim kondapallykalyan webkit-bug-importer oldest_to_newest 1190182 0 dino 2016-05-04 13:11:09 -0700 When the runtime flag for WebGL2 is off, we should not create a context. 1190184 1 webkit-bug-importer 2016-05-04 13:12:27 -0700 <rdar://problem/26096346> 1190189 2 278117 dino 2016-05-04 13:15:13 -0700 Created attachment 278117 Patch 1190238 3 dino 2016-05-04 15:29:44 -0700 Committed r200435: <http://trac.webkit.org/changeset/200435> 1190705 4 278117 darin 2016-05-06 11:10:18 -0700 Comment on attachment 278117 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278117&action=review > Source/WebCore/testing/Internals.idl:459 > +#if defined(ENABLE_WEBGL2) && ENABLE_WEBGL2 > + boolean webGL2Enabled(); > + void setWebGL2Enabled(boolean enable); > +#endif Can we use [Conditional] instead of #if here? 278117 2016-05-04 13:15:13 -0700 2016-05-04 13:19:02 -0700 Patch bug-157352-20160505061551.patch text/plain 6779 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwMzg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTZhMDUzMGZiYjEwOGYz NjM3OTRjMGVkMGMwY2NhMGU2NmQ0ZjQxZC4uNzg1MjY2YjA2MTBmODg3OTU2YjYwYmZiN2Y2MDc2 ZmJmMmM1NDNmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE2LTA1LTA0ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBEaXNhYmxpbmcgV2ViR0wyIHNo b3VsZCBtZWFuIG5vIGNvbnRleHQgaXMgY3JlYXRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3MzUyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8y NjA5NjM0Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBJZiBXZWJHTDIgaXMgZGlzYWJsZWQgYnkgdGhlIHJ1bnRpbWUgZmxhZywgd2Ugc2hvdWxkCisg ICAgICAgIG5vdCBjcmVhdGUgYSBjb250ZXh0LgorCisgICAgICAgIFRlc3Q6IGZhc3QvY2FudmFz L3dlYmdsL3dlYmdsMi1ydW50aW1lLWZsYWcuaHRtbAorCisgICAgICAgICogaHRtbC9jYW52YXMv V2ViR0xSZW5kZXJpbmdDb250ZXh0QmFzZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXZWJHTFJl bmRlcmluZ0NvbnRleHRCYXNlOjpjcmVhdGUpOgorICAgICAgICAqIHRlc3RpbmcvSW50ZXJuYWxz LmNwcDogQWRkZWQgc29tZSBoZWxwZXJzIHRvIHRvZ2dsZSB0aGUgcnVudGltZSBzZXR0aW5nLgor ICAgICAgICAoV2ViQ29yZTo6SW50ZXJuYWxzOjp3ZWJHTDJFbmFibGVkKToKKyAgICAgICAgKFdl YkNvcmU6OkludGVybmFsczo6c2V0V2ViR0wyRW5hYmxlZCk6CisgICAgICAgICogdGVzdGluZy9J bnRlcm5hbHMuaDoKKyAgICAgICAgKiB0ZXN0aW5nL0ludGVybmFscy5pZGw6CisKIDIwMTYtMDUt MDMgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBTcGVlZCB1cCBK U0dsb2JhbE9iamVjdCBpbml0aWFsaXphdGlvbiBieSBtYWtpbmcgc29tZSBwcm9wZXJ0aWVzIGxh enkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5n Q29udGV4dEJhc2UuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJp bmdDb250ZXh0QmFzZS5jcHAKaW5kZXggNjk3Y2M4MjI4MjIzOGExMTU4ZjBkNGVkNjMxMGZiNTU4 YWNkYjNiZS4uYTRhZjA3ZDg3ODQ2NTkyMTU4MTQ5NDkzMmJhODAzY2QxOTJmZGFiYyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0QmFz ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250 ZXh0QmFzZS5jcHAKQEAgLTYyLDYgKzYyLDcgQEAKICNpbmNsdWRlICJPRVNWZXJ0ZXhBcnJheU9i amVjdC5oIgogI2luY2x1ZGUgIlBhZ2UuaCIKICNpbmNsdWRlICJSZW5kZXJCb3guaCIKKyNpbmNs dWRlICJSdW50aW1lRW5hYmxlZEZlYXR1cmVzLmgiCiAjaW5jbHVkZSAiU2V0dGluZ3MuaCIKICNp bmNsdWRlICJXZWJHTDJSZW5kZXJpbmdDb250ZXh0LmgiCiAjaW5jbHVkZSAiV2ViR0xBY3RpdmVJ bmZvLmgiCkBAIC0zNDgsNyArMzQ5LDEwIEBAIHByaXZhdGU6CiAKIHN0ZDo6dW5pcXVlX3B0cjxX ZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNlPiBXZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNlOjpjcmVh dGUoSFRNTENhbnZhc0VsZW1lbnQqIGNhbnZhcywgV2ViR0xDb250ZXh0QXR0cmlidXRlcyogYXR0 cnMsIGNvbnN0IFN0cmluZyYgdHlwZSkKIHsKLSNpZiAhRU5BQkxFKFdFQkdMMikKKyNpZiBFTkFC TEUoV0VCR0wyKQorICAgIGlmICh0eXBlID09ICJ3ZWJnbDIiICYmICFSdW50aW1lRW5hYmxlZEZl YXR1cmVzOjpzaGFyZWRGZWF0dXJlcygpLndlYkdMMkVuYWJsZWQoKSkKKyAgICAgICAgcmV0dXJu IG51bGxwdHI7CisjZWxzZQogICAgIFVOVVNFRF9QQVJBTSh0eXBlKTsKICNlbmRpZgogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAKaW5kZXggNTZmZGE2OTQzMDc0YTQyZmIwODM1NjIy OWQ5NmUxNTYwZDI2ZWYwZC4uYTRjZTdlMDhmN2QwYzY0NTZjNDU5OWRlNjljNTk0ZTYxNTE4NGVj MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcApAQCAtMzMxNiw2ICszMzE2LDE4 IEBAIHZvaWQgSW50ZXJuYWxzOjpzZXRDU1NHcmlkTGF5b3V0RW5hYmxlZChib29sIGVuYWJsZSkK IH0KICNlbmRpZgogCisjaWYgRU5BQkxFKFdFQkdMMikKK2Jvb2wgSW50ZXJuYWxzOjp3ZWJHTDJF bmFibGVkKCkgY29uc3QKK3sKKyAgICByZXR1cm4gUnVudGltZUVuYWJsZWRGZWF0dXJlczo6c2hh cmVkRmVhdHVyZXMoKS53ZWJHTDJFbmFibGVkKCk7Cit9CisKK3ZvaWQgSW50ZXJuYWxzOjpzZXRX ZWJHTDJFbmFibGVkKGJvb2wgZW5hYmxlKQoreworICAgIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6 OnNoYXJlZEZlYXR1cmVzKCkuc2V0V2ViR0wyRW5hYmxlZChlbmFibGUpOworfQorI2VuZGlmCisK IHZvaWQgSW50ZXJuYWxzOjpzZXRSZXNvdXJjZVRpbWluZ1N1cHBvcnQoYm9vbCBlbmFibGUpCiB7 CiAgICAgUnVudGltZUVuYWJsZWRGZWF0dXJlczo6c2hhcmVkRmVhdHVyZXMoKS5zZXRSZXNvdXJj ZVRpbWluZ0VuYWJsZWQoZW5hYmxlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Rlc3Rp bmcvSW50ZXJuYWxzLmggYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5oCmluZGV4 IDExZjhjODhiZDliZTUzOTMyNmNjNzVkZGE4ODgyYTFmMjdlZDIxZDMuLjVmMmFiYjNjYzdmN2Jh YjY3ZDZkYTFhMWY5YzIyYmUwYmExNWIyNzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Rl c3RpbmcvSW50ZXJuYWxzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMu aApAQCAtNDc4LDYgKzQ3OCwxMSBAQCBwdWJsaWM6CiAgICAgdm9pZCBzZXRDU1NHcmlkTGF5b3V0 RW5hYmxlZChib29sKTsKICNlbmRpZgogCisjaWYgRU5BQkxFKFdFQkdMMikKKyAgICBib29sIHdl YkdMMkVuYWJsZWQoKSBjb25zdDsKKyAgICB2b2lkIHNldFdlYkdMMkVuYWJsZWQoYm9vbCk7Cisj ZW5kaWYKKwogcHJpdmF0ZToKICAgICBleHBsaWNpdCBJbnRlcm5hbHMoRG9jdW1lbnQmKTsKICAg ICBEb2N1bWVudCogY29udGV4dERvY3VtZW50KCkgY29uc3Q7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5pZGwgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0lu dGVybmFscy5pZGwKaW5kZXggYjM0ODk3Yzk2ZDRlMGE5MDk1MGUxMTllNDZkMDY5ODI3MjAzNGVj MS4uNGRjNDAzMTZiNzNlNDY4M2ZkYmRiMzc4MGNlNzI2MDdlNWNkOThjMyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3Rlc3RpbmcvSW50ZXJuYWxzLmlkbApAQCAtNDUzLDUgKzQ1MywxMCBAQCBlbnVtIEF1dG9GaWxs QnV0dG9uVHlwZSB7CiAgICAgdm9pZCBzZXRDU1NHcmlkTGF5b3V0RW5hYmxlZChib29sZWFuIGVu YWJsZSk7CiAjZW5kaWYKIAorI2lmIGRlZmluZWQoRU5BQkxFX1dFQkdMMikgJiYgRU5BQkxFX1dF QkdMMgorICAgIGJvb2xlYW4gd2ViR0wyRW5hYmxlZCgpOworICAgIHZvaWQgc2V0V2ViR0wyRW5h YmxlZChib29sZWFuIGVuYWJsZSk7CisjZW5kaWYKKwogICAgIHZvaWQgc2V0UmVzb3VyY2VUaW1p bmdTdXBwb3J0KGJvb2xlYW4gc2NhbGFibGUpOwogfTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA0ZjkzZGVlMTI0M2ViMDQ5 ZWE0MjdjMmIzMjJiNDdlZTUwOTgwOGQ1Li5hNjIyZjk3Yzk2OTgwYzNlNTFmYWQ4NDVkNzFmOTQ3 OGQ2ZGU1NTQ4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTYtMDUtMDQgIERlYW4gSmFja3Nv biAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIERpc2FibGluZyBXZWJHTDIgc2hvdWxkIG1l YW4gbm8gY29udGV4dCBpcyBjcmVhdGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNTczNTIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI2MDk2MzQ2 PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENoZWNr IHRoYXQgdG9nZ2xpbmcgdGhlIHJ1bnRpbWUgZmxhZyBlbmFibGVzL2Rpc2FibGVzIFdlYkdMIDIu MC4KKworICAgICAgICAqIGZhc3QvY2FudmFzL3dlYmdsL3dlYmdsMi1ydW50aW1lLWZsYWctZXhw ZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2NhbnZhcy93ZWJnbC93ZWJnbDItcnVu dGltZS1mbGFnLmh0bWw6IEFkZGVkLgorCiAyMDE2LTA1LTAyICBBbnR0aSBLb2l2aXN0byAgPGFu dHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMTk4OTQzKTogVHJhbnNpdGlv bnMgZG9uJ3Qgd29yayBpZiB0aGV5IGFuaW1hdGUgZGlzcGxheSBwcm9wZXJ0eQpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvd2ViZ2wyLXJ1bnRpbWUtZmxhZy1leHBl Y3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC93ZWJnbDItcnVudGltZS1m bGFnLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43OWJhY2FjODJiZDllNTFjNWE5NWNjOTRhOTZj YjkyODM2NGE4MDFjCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMv d2ViZ2wvd2ViZ2wyLXJ1bnRpbWUtZmxhZy1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwyIEBACitQ QVNTOiBXZWJHTCAyLjAgd2FzIGF2YWlsYWJsZSB3aGVuIGVuYWJsZWQuCitQQVNTOiBXZWJHTCAy LjAgd2FzIG5vdCBhdmFpbGFibGUgd2hlbiBkaXNhYmxlZC4KZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2Zhc3QvY2FudmFzL3dlYmdsL3dlYmdsMi1ydW50aW1lLWZsYWcuaHRtbCBiL0xheW91dFRl c3RzL2Zhc3QvY2FudmFzL3dlYmdsL3dlYmdsMi1ydW50aW1lLWZsYWcuaHRtbApuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Li4xYjk0NTc2ZGZiZDU2NWZjZjQxYjEzNjFmOWIzZmUxMzQ0Y2I1OGI2Ci0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvd2ViZ2wyLXJ1bnRpbWUtZmxhZy5o dG1sCkBAIC0wLDAgKzEsNDYgQEAKKzxzY3JpcHQ+CisKK2lmICh3aW5kb3cudGVzdFJ1bm5lcikK KyAgICB3aW5kb3cudGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisKK2Z1bmN0aW9uIGdldENvbnRl eHQobmFtZSkgeworICAgIHZhciBjID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiY2FudmFzIik7 CisgICAgcmV0dXJuIGMuZ2V0Q29udGV4dChuYW1lKTsKK30KKworZnVuY3Rpb24gcnVuKCkgewor ICAgIHZhciBvdXRwdXQ7CisKKyAgICBvdXRwdXQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgi b3V0cHV0MSIpOworCisgICAgaWYgKCF3aW5kb3cudGVzdFJ1bm5lcikgeworICAgICAgICBvdXRw dXQudGV4dENvbnRlbnQgPSAiVGhpcyB0ZXN0IG9ubHkgcnVucyBpbnNpZGUgRFJUL1dLVFIuIjsK KyAgICAgICAgcmV0dXJuOworICAgIH0KKworICAgIHZhciBvcmlnaW5hbFNldHRpbmcgPSB3aW5k b3cuaW50ZXJuYWxzLndlYkdMMkVuYWJsZWQoKTsKKworICAgIHdpbmRvdy5pbnRlcm5hbHMuc2V0 V2ViR0wyRW5hYmxlZCh0cnVlKTsKKyAgICB2YXIgY3R4ID0gZ2V0Q29udGV4dCgid2ViZ2wyIik7 CisgICAgaWYgKGN0eCkKKyAgICAgICAgb3V0cHV0LnRleHRDb250ZW50ID0gIlBBU1M6IFdlYkdM IDIuMCB3YXMgYXZhaWxhYmxlIHdoZW4gZW5hYmxlZC4iOworICAgIGVsc2UKKyAgICAgICAgb3V0 cHV0LnRleHRDb250ZW50ID0gIkZBSUw6IFdlYkdMIDIuMCB3YXMgbm90IGF2YWlsYWJsZSB3aGVu IGVuYWJsZWQuIjsKKworICAgIG91dHB1dCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJvdXRw dXQyIik7CisKKyAgICB3aW5kb3cuaW50ZXJuYWxzLnNldFdlYkdMMkVuYWJsZWQoZmFsc2UpOwor ICAgIHZhciBjdHggPSBnZXRDb250ZXh0KCJ3ZWJnbDIiKTsKKyAgICBpZiAoY3R4KQorICAgICAg ICBvdXRwdXQudGV4dENvbnRlbnQgPSAiRkFJTDogV2ViR0wgMi4wIHdhcyBhdmFpbGFibGUgd2hl biBkaXNhYmxlZC4iOworICAgIGVsc2UKKyAgICAgICAgb3V0cHV0LnRleHRDb250ZW50ID0gIlBB U1M6IFdlYkdMIDIuMCB3YXMgbm90IGF2YWlsYWJsZSB3aGVuIGRpc2FibGVkLiI7CisKKyAgICB3 aW5kb3cuaW50ZXJuYWxzLnNldFdlYkdMMkVuYWJsZWQob3JpZ2luYWxTZXR0aW5nKTsKK30KKwor d2luZG93LmFkZEV2ZW50TGlzdGVuZXIoImxvYWQiLCBydW4sIGZhbHNlKTsKKworPC9zY3JpcHQ+ Cis8ZGl2IGlkPSJvdXRwdXQxIj48L2Rpdj4KKzxkaXYgaWQ9Im91dHB1dDIiPjwvZGl2Pgo=