157342 2016-05-04 04:57:31 -0700 [css-grid] Refactor information stored related to column positions 2016-05-04 13:31:33 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60731 1 rego rego commit-queue esprehn+autocc glenn jfernandez kondapallykalyan simon.fraser svillar oldest_to_newest 1190039 0 rego 2016-05-04 04:57:31 -0700 [css-grid] Refactor information stored related to column positions 1190040 1 278079 rego 2016-05-04 04:59:24 -0700 Created attachment 278079 Patch 1190041 2 rego 2016-05-04 05:00:37 -0700 This comes from 2 patches in Blink: * https://codereview.chromium.org/1915903002/ * https://codereview.chromium.org/1945203002/ 1190198 3 278079 commit-queue 2016-05-04 13:31:29 -0700 Comment on attachment 278079 Patch Clearing flags on attachment: 278079 Committed r200427: <http://trac.webkit.org/changeset/200427> 1190199 4 commit-queue 2016-05-04 13:31:33 -0700 All reviewed patches have been landed. Closing bug. 278079 2016-05-04 04:59:24 -0700 2016-05-04 13:31:29 -0700 Patch bug-157342-20160504140003.patch text/plain 5769 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwMzY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTQzOTgwNzRmMmY5NTNm ZGU3NjliN2FhMTEyYzUxOGFlYTgyYzY0OS4uMTlmODNiZGMwNDZiYzBjZGNjYTVmZmIyOWE4ZTNl YmVlZDEzZDE2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMzIEBACisyMDE2LTA1LTA0ICBNYW51 ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtjc3MtZ3Jp ZF0gUmVmYWN0b3IgaW5mb3JtYXRpb24gc3RvcmVkIHJlbGF0ZWQgdG8gY29sdW1uIHBvc2l0aW9u cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3MzQy CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gbV9j b2x1bW5Qb3NpdGlvbnMgd2Ugd2VyZSBzdG9yaW5nIHBvc2l0aW9uIG9mIGVhY2ggY29sdW1uCisg ICAgICAgIGluY2x1ZGluZyB0aGUgYWxpZ25tZW50IG9mZnNldCwgYWx3YXlzIGZyb20gdGhlIGxv Z2ljYWwgbGVmdCwKKyAgICAgICAgYW5kIHRoZSBib3JkZXIgYW5kIHBhZGRpbmcsIGRlcGVuZGlu ZyBvbiB0aGUgZGlyZWN0aW9uLgorCisgICAgICAgIFRoaXMgd2FzIHJlYWxseSBjb25mdXNpbmcg YXMgaW4gdGhlIGNhc2Ugb2YgUlRMIGRpcmVjdGlvbgorICAgICAgICB3ZSB3ZXJlIGFkZGluZyB0 aGUgb2Zmc2V0IGZyb20gdGhlIGxlZnQgYW5kCisgICAgICAgIHRoZSByaWdodCBib3JkZXIgYW5k IHBhZGRpbmcuCisKKyAgICAgICAgVGhpcyBwYXRjaGVzIGNoYW5nZXMgaXQgdG8gc3RvcmUgYWx3 YXlzIHRoZSBpbmZvIGZyb20gdGhlIGxlZnQsCisgICAgICAgIHNvIGV2ZW4gaW4gUlRMIGRpcmVj dGlvbiB3ZSB1c2UgdGhlIGxlZnQgYm9yZGVyIGFuZCBwYWRkaW5nLgorCisgICAgICAgIFRoaXMg YWxsb3dzIHVzIHRvIHNpbXBsaWZ5IHRyYW5zbGF0ZVJUTENvb3JkaW5hdGUoKSBhcworICAgICAg ICBpdCBkb2Vzbid0IG5lZWQgdG8gY2FyZSBhYm91dCBib3JkZXIgYW5kIHBhZGRpbmcgYW55bW9y ZS4KKyAgICAgICAgQW5kIGFsc28gdG8gcmVmYWN0b3Igb2Zmc2V0QW5kQnJlYWR0aEZvclBvc2l0 aW9uZWRDaGlsZCgpCisgICAgICAgIHdoaWNoIGJlY2FtZSByZWFsbHkgY29tcGxleCBhZnRlciBh ZGRpbmcgUlRMIHN1cHBvcnQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBjaGFuZ2Ugb2Yg YmVoYXZpb3IuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyR3JpZC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpSZW5kZXJHcmlkOjpvZmZzZXRBbmRCcmVhZHRoRm9yUG9zaXRpb25lZENoaWxk KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckdyaWQ6OnBvcHVsYXRlR3JpZFBvc2l0aW9ucyk6 CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJHcmlkOjp0cmFuc2xhdGVSVExDb29yZGluYXRlKToK KwogMjAxNi0wNS0wMyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+ CiAKICAgICAgICAgVW5yZXZpZXdlZC4gRml4IEdPYmplY3QgRE9NIGJpbmRpbmdzIEFQSSBicmVh ayBhZnRlciByMjAwMzE2LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckdyaWQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckdyaWQuY3BwCmlu ZGV4IDQyODg5YWM3YmRlYTU5MzY2NzY0N2Y2YTE0NDRjOGJmZjA5YjdlOTEuLmU5MDBlMjBhNGFh ODZhNWRmMjIyZWFlZTA1ZWUxMGY0N2U2OTFmYWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJHcmlkLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyR3JpZC5jcHAKQEAgLTE1NTAsMTggKzE1NTAsMjQgQEAgdm9pZCBSZW5kZXJHcmlkOjpv ZmZzZXRBbmRCcmVhZHRoRm9yUG9zaXRpb25lZENoaWxkKGNvbnN0IFJlbmRlckJveCYgY2hpbGQs IEdyaWQKICAgICAvLyBXZSdyZSBub3JtYWxpemluZyB0aGUgcG9zaXRpb25zIHRvIGF2b2lkIGlz c3VlcyB3aXRoIFJUTCAoYXMgdGhleSdyZSBzdG9yZWQgaW4gdGhlIHNhbWUgb3JkZXIgdGhhbiBM VFIgYnV0IGFkZGluZyBhbiBvZmZzZXQpLgogICAgIExheW91dFVuaXQgc3RhcnQ7CiAgICAgaWYg KCFzdGFydElzQXV0bykgewotICAgICAgICBpZiAoaXNSb3dBeGlzKQotICAgICAgICAgICAgc3Rh cnQgPSBtX2NvbHVtblBvc2l0aW9uc1tzdGFydExpbmVdIC0gbV9jb2x1bW5Qb3NpdGlvbnNbMF0g KyBwYWRkaW5nU3RhcnQoKTsKLSAgICAgICAgZWxzZQotICAgICAgICAgICAgc3RhcnQgPSBtX3Jv d1Bvc2l0aW9uc1tzdGFydExpbmVdIC0gbV9yb3dQb3NpdGlvbnNbMF0gKyBwYWRkaW5nQmVmb3Jl KCk7CisgICAgICAgIGlmIChpc1Jvd0F4aXMpIHsKKyAgICAgICAgICAgIGlmIChzdHlsZSgpLmlz TGVmdFRvUmlnaHREaXJlY3Rpb24oKSkKKyAgICAgICAgICAgICAgICBzdGFydCA9IG1fY29sdW1u UG9zaXRpb25zW3N0YXJ0TGluZV0gLSBib3JkZXJMb2dpY2FsTGVmdCgpOworICAgICAgICAgICAg ZWxzZQorICAgICAgICAgICAgICAgIHN0YXJ0ID0gbG9naWNhbFdpZHRoKCkgLSB0cmFuc2xhdGVS VExDb29yZGluYXRlKG1fY29sdW1uUG9zaXRpb25zW3N0YXJ0TGluZV0pIC0gYm9yZGVyTG9naWNh bFJpZ2h0KCk7CisgICAgICAgIH0gZWxzZQorICAgICAgICAgICAgc3RhcnQgPSBtX3Jvd1Bvc2l0 aW9uc1tzdGFydExpbmVdIC0gYm9yZGVyQmVmb3JlKCk7CiAgICAgfQogCiAgICAgTGF5b3V0VW5p dCBlbmQgPSBpc1Jvd0F4aXMgPyBjbGllbnRMb2dpY2FsV2lkdGgoKSA6IGNsaWVudExvZ2ljYWxI ZWlnaHQoKTsKICAgICBpZiAoIWVuZElzQXV0bykgewotICAgICAgICBpZiAoaXNSb3dBeGlzKQot ICAgICAgICAgICAgZW5kID0gbV9jb2x1bW5Qb3NpdGlvbnNbZW5kTGluZV0gLSBtX2NvbHVtblBv c2l0aW9uc1swXSArIHBhZGRpbmdTdGFydCgpOwotICAgICAgICBlbHNlCi0gICAgICAgICAgICBl bmQgPSBtX3Jvd1Bvc2l0aW9uc1tlbmRMaW5lXSAtIG1fcm93UG9zaXRpb25zWzBdICsgcGFkZGlu Z0JlZm9yZSgpOworICAgICAgICBpZiAoaXNSb3dBeGlzKSB7CisgICAgICAgICAgICBpZiAoc3R5 bGUoKS5pc0xlZnRUb1JpZ2h0RGlyZWN0aW9uKCkpCisgICAgICAgICAgICAgICAgZW5kID0gbV9j b2x1bW5Qb3NpdGlvbnNbZW5kTGluZV0gLSBib3JkZXJMb2dpY2FsTGVmdCgpOworICAgICAgICAg ICAgZWxzZQorICAgICAgICAgICAgICAgIGVuZCA9IGxvZ2ljYWxXaWR0aCgpIC0gdHJhbnNsYXRl UlRMQ29vcmRpbmF0ZShtX2NvbHVtblBvc2l0aW9uc1tlbmRMaW5lXSkgLSBib3JkZXJMb2dpY2Fs UmlnaHQoKTsKKyAgICAgICAgfSBlbHNlCisgICAgICAgICAgICBlbmQgPSBtX3Jvd1Bvc2l0aW9u c1tlbmRMaW5lXSAtIGJvcmRlckJlZm9yZSgpOwogCiAgICAgICAgIC8vIFRoZXNlIHZlY3RvcnMg c3RvcmUgbGluZSBwb3NpdGlvbnMgaW5jbHVkaW5nIGdhcHMsIGJ1dCB3ZSBzaG91bGRuJ3QgY29u c2lkZXIgdGhlbSBmb3IgdGhlIGVkZ2VzIG9mIHRoZSBncmlkLgogICAgICAgICBpZiAoZW5kTGlu ZSA+IGZpcnN0RXhwbGljaXRMaW5lICYmIGVuZExpbmUgPCBsYXN0RXhwbGljaXRMaW5lKSB7CkBA IC0xNTcwLDE1ICsxNTc2LDYgQEAgdm9pZCBSZW5kZXJHcmlkOjpvZmZzZXRBbmRCcmVhZHRoRm9y UG9zaXRpb25lZENoaWxkKGNvbnN0IFJlbmRlckJveCYgY2hpbGQsIEdyaWQKICAgICAgICAgfQog ICAgIH0KIAotICAgIExheW91dFVuaXQgYWxpZ25tZW50T2Zmc2V0ID0gaXNSb3dBeGlzID8gbV9j b2x1bW5Qb3NpdGlvbnNbMF0gLSBib3JkZXJBbmRQYWRkaW5nU3RhcnQoKSA6IG1fcm93UG9zaXRp b25zWzBdIC0gYm9yZGVyQW5kUGFkZGluZ0JlZm9yZSgpOwotICAgIGlmIChpc1Jvd0F4aXMgJiYg IXN0eWxlKCkuaXNMZWZ0VG9SaWdodERpcmVjdGlvbigpKQotICAgICAgICBhbGlnbm1lbnRPZmZz ZXQgPSBjb250ZW50TG9naWNhbFdpZHRoKCkgLSAobV9jb2x1bW5Qb3NpdGlvbnNbbV9jb2x1bW5Q b3NpdGlvbnMuc2l6ZSgpIC0gMV0gLSBib3JkZXJBbmRQYWRkaW5nU3RhcnQoKSk7Ci0KLSAgICBp ZiAoIXN0YXJ0SXNBdXRvKQotICAgICAgICBzdGFydCArPSBhbGlnbm1lbnRPZmZzZXQ7Ci0gICAg aWYgKCFlbmRJc0F1dG8pCi0gICAgICAgIGVuZCArPSBhbGlnbm1lbnRPZmZzZXQ7Ci0KICAgICBi cmVhZHRoID0gZW5kIC0gc3RhcnQ7CiAgICAgb2Zmc2V0ID0gc3RhcnQ7CiAKQEAgLTE2NjIsNyAr MTY1OSw3IEBAIHZvaWQgUmVuZGVyR3JpZDo6cG9wdWxhdGVHcmlkUG9zaXRpb25zKEdyaWRTaXpp bmdEYXRhJiBzaXppbmdEYXRhKQogICAgIENvbnRlbnRBbGlnbm1lbnREYXRhIG9mZnNldCA9IGNv bXB1dGVDb250ZW50UG9zaXRpb25BbmREaXN0cmlidXRpb25PZmZzZXQoRm9yQ29sdW1ucywgc2l6 aW5nRGF0YS5mcmVlU3BhY2VGb3JEaXJlY3Rpb24oRm9yQ29sdW1ucykudmFsdWUoKSwgbnVtYmVy T2ZUcmFja3MpOwogICAgIExheW91dFVuaXQgdHJhY2tHYXAgPSBndXR0ZXJzU2l6ZShGb3JDb2x1 bW5zLCAyKTsKICAgICBtX2NvbHVtblBvc2l0aW9ucy5yZXNpemUobnVtYmVyT2ZMaW5lcyk7Ci0g ICAgbV9jb2x1bW5Qb3NpdGlvbnNbMF0gPSBib3JkZXJBbmRQYWRkaW5nU3RhcnQoKSArIG9mZnNl dC5wb3NpdGlvbk9mZnNldDsKKyAgICBtX2NvbHVtblBvc2l0aW9uc1swXSA9IGJvcmRlckFuZFBh ZGRpbmdMb2dpY2FsTGVmdCgpICsgb2Zmc2V0LnBvc2l0aW9uT2Zmc2V0OwogICAgIGZvciAodW5z aWduZWQgaSA9IDA7IGkgPCBuZXh0VG9MYXN0TGluZTsgKytpKQogICAgICAgICBtX2NvbHVtblBv c2l0aW9uc1tpICsgMV0gPSBtX2NvbHVtblBvc2l0aW9uc1tpXSArIG9mZnNldC5kaXN0cmlidXRp b25PZmZzZXQgKyBzaXppbmdEYXRhLmNvbHVtblRyYWNrc1tpXS5iYXNlU2l6ZSgpICsgdHJhY2tH YXA7CiAgICAgbV9jb2x1bW5Qb3NpdGlvbnNbbGFzdExpbmVdID0gbV9jb2x1bW5Qb3NpdGlvbnNb bmV4dFRvTGFzdExpbmVdICsgc2l6aW5nRGF0YS5jb2x1bW5UcmFja3NbbmV4dFRvTGFzdExpbmVd LmJhc2VTaXplKCk7CkBAIC0yMDg4LDkgKzIwODUsOSBAQCBMYXlvdXRVbml0IFJlbmRlckdyaWQ6 OnRyYW5zbGF0ZVJUTENvb3JkaW5hdGUoTGF5b3V0VW5pdCBjb29yZGluYXRlKSBjb25zdAogewog ICAgIEFTU0VSVCghc3R5bGUoKS5pc0xlZnRUb1JpZ2h0RGlyZWN0aW9uKCkpOwogCi0gICAgTGF5 b3V0VW5pdCBhbGlnbm1lbnRPZmZzZXQgPSBtX2NvbHVtblBvc2l0aW9uc1swXSAtIGJvcmRlckFu ZFBhZGRpbmdTdGFydCgpOworICAgIExheW91dFVuaXQgYWxpZ25tZW50T2Zmc2V0ID0gbV9jb2x1 bW5Qb3NpdGlvbnNbMF07CiAgICAgTGF5b3V0VW5pdCByaWdodEdyaWRFZGdlUG9zaXRpb24gPSBt X2NvbHVtblBvc2l0aW9uc1ttX2NvbHVtblBvc2l0aW9ucy5zaXplKCkgLSAxXTsKLSAgICByZXR1 cm4gYm9yZGVyQW5kUGFkZGluZ0xvZ2ljYWxMZWZ0KCkgKyByaWdodEdyaWRFZGdlUG9zaXRpb24g KyBhbGlnbm1lbnRPZmZzZXQgLSBjb29yZGluYXRlOworICAgIHJldHVybiByaWdodEdyaWRFZGdl UG9zaXRpb24gKyBhbGlnbm1lbnRPZmZzZXQgLSBjb29yZGluYXRlOwogfQogCiBMYXlvdXRQb2lu dCBSZW5kZXJHcmlkOjpmaW5kQ2hpbGRMb2dpY2FsUG9zaXRpb24oY29uc3QgUmVuZGVyQm94JiBj aGlsZCkgY29uc3QK