<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>157326</bug_id>
          
          <creation_ts>2016-05-03 14:15:03 -0700</creation_ts>
          <short_desc>[WK2][DiskCache] Store common HTTP header names as strings</short_desc>
          <delta_ts>2016-05-03 16:25:29 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>andersca</cc>
    
    <cc>koivisto</cc>
    
    <cc>sam</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1189852</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-05-03 14:15:03 -0700</bug_when>
    <thetext>Store common HTTP header names as strings instead of their integer representation inside the HTTPHeaderName enumeration. Otherwise, updating HTTPHeaderNames.in renders the data in the disk cache invalid.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1189853</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2016-05-03 14:16:03 -0700</bug_when>
    <thetext>&lt;rdar://problem/26073498&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1189854</commentid>
    <comment_count>2</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-05-03 14:18:17 -0700</bug_when>
    <thetext>XD</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1189873</commentid>
    <comment_count>3</comment_count>
      <attachid>278033</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-05-03 15:11:48 -0700</bug_when>
    <thetext>Created attachment 278033
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1189900</commentid>
    <comment_count>4</comment_count>
      <attachid>278033</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-05-03 16:25:24 -0700</bug_when>
    <thetext>Comment on attachment 278033
Patch

Clearing flags on attachment: 278033

Committed r200394: &lt;http://trac.webkit.org/changeset/200394&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1189901</commentid>
    <comment_count>5</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-05-03 16:25:29 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>278033</attachid>
            <date>2016-05-03 15:11:48 -0700</date>
            <delta_ts>2016-05-03 16:25:24 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-157326-20160503151226.patch</filename>
            <type>text/plain</type>
            <size>5240</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwMzg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTM2MjBlOWU3NTZjOTNl
ODViMjA0OTUyMTI2OTRmZjViM2UwYTliYi4uNDVlMzEyNmRjNDVmNWI3YzIzYTU1NGI0Njg0ODE5
ZDc1NjU5NjgwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE2LTA1LTAzICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW1dLMl1bRGlza0NhY2hlXSBT
dG9yZSBjb21tb24gSFRUUCBoZWFkZXIgbmFtZXMgYXMgc3RyaW5ncworICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3MzI2CisgICAgICAgIDxyZGFyOi8v
cHJvYmxlbS8yNjA3MzQ5OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K
KworICAgICAgICBTdG9yZSBjb21tb24gSFRUUCBoZWFkZXIgbmFtZXMgYXMgc3RyaW5ncyBpbiB0
aGUgZGlzayBjYWNoZSBpbnN0ZWFkIG9mCisgICAgICAgIHVzaW5nIHRoZWlyIHZhbHVlIGluIHRo
ZSBIVFRQSGVhZGVyTmFtZSBlbnVtZXJhdGlvbi4gSGF2aW5nIHRoZSBkaXNrCisgICAgICAgIGNh
Y2hlIHJlbHkgaW4gdGhlIEhUVFBIZWFkZXJOYW1lIGVudW1lcmF0aW9uIGlzIHJpc2t5IGJlY29t
ZXMgaXQgbWVhbnMKKyAgICAgICAgdGhlIGNhY2hlZCBkYXRhIHdvdWxkIGJlY29tZSBpbnZhbGlk
IGV2ZXJ5IHRpbWUgc29tZW9uZSB1cGRhdGVzCisgICAgICAgIEhUVFBIZWFkZXJOYW1lcy5pbiBp
biBXZWJDb3JlLiBJZiBzb21lb25lIHdlcmUgdG8gdXBkYXRlCisgICAgICAgIEhUVFBIZWFkZXJO
YW1lcy5pbiB3aXRob3V0IGJ1bXBpbmcgdGhlIGRpc2sgY2FjaGUgdmVyc2lvbiwgd2Ugd291bGQg
ZW5kCisgICAgICAgIHVwIHdpdGggd3JvbmdseSByZWNvZ25pemVkIEhUVFAgaGVhZGVyIG5hbWVz
IGFmdGVyIGxvYWRpbmcgcmVzcG9uc2VzCisgICAgICAgIGZyb20gdGhlIGNhY2hlLgorCisgICAg
ICAgICogTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlQ29kZXJzLmNwcDoKKyAgICAg
ICAgKFdlYktpdDo6TmV0d29ya0NhY2hlOjpDb2RlcjxXZWJDb3JlOjpIVFRQSGVhZGVyTWFwPjo6
ZW5jb2RlKToKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya0NhY2hlOjpDb2RlcjxXZWJDb3JlOjpI
VFRQSGVhZGVyTWFwPjo6ZGVjb2RlKToKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jYWNoZS9O
ZXR3b3JrQ2FjaGVDb2RlcnMuaDoKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3
b3JrQ2FjaGVTdG9yYWdlLmg6CisKIDIwMTYtMDUtMDIgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBw
bGUuY29tPgogCiAgICAgICAgIENoYW5nZSBJREwgZW51bWVyYXRpb25zIHRvIGJlIG5lc3RlZCBp
biB0aGVpciBDKysgY2xhc3MgaW5zdGVhZCBvZiBhdCBXZWJDb3JlIG5hbWVzcGFjZSBsZXZlbApk
aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9IVFRQSGVhZGVyTWFw
LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0hUVFBIZWFkZXJNYXAuaAppbmRl
eCA0MjM1YTYzZmQwY2RkZGZlMzNiZmU3MDk2YmFiNzcwYmVlODk5YmQyLi5kMzQ1Njk3NTUyYjZh
NTM5YTc1NWJjZjgyZTJhNjMyNDMwZTNkN2E2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w
bGF0Zm9ybS9uZXR3b3JrL0hUVFBIZWFkZXJNYXAuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0
Zm9ybS9uZXR3b3JrL0hUVFBIZWFkZXJNYXAuaApAQCAtMTM4LDcgKzEzOCw3IEBAIHB1YmxpYzoK
IAogICAgIFdFQkNPUkVfRVhQT1JUIFN0cmluZyBnZXQoY29uc3QgU3RyaW5nJiBuYW1lKSBjb25z
dDsKICAgICBXRUJDT1JFX0VYUE9SVCB2b2lkIHNldChjb25zdCBTdHJpbmcmIG5hbWUsIGNvbnN0
IFN0cmluZyYgdmFsdWUpOwotICAgIHZvaWQgYWRkKGNvbnN0IFN0cmluZyYgbmFtZSwgY29uc3Qg
U3RyaW5nJiB2YWx1ZSk7CisgICAgV0VCQ09SRV9FWFBPUlQgdm9pZCBhZGQoY29uc3QgU3RyaW5n
JiBuYW1lLCBjb25zdCBTdHJpbmcmIHZhbHVlKTsKICAgICBXRUJDT1JFX0VYUE9SVCBib29sIGNv
bnRhaW5zKGNvbnN0IFN0cmluZyYpIGNvbnN0OwogICAgIGJvb2wgcmVtb3ZlKGNvbnN0IFN0cmlu
ZyYpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9O
ZXR3b3JrQ2FjaGVDb2RlcnMuY3BwIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2Fj
aGUvTmV0d29ya0NhY2hlQ29kZXJzLmNwcAppbmRleCAyZmIzNGVkMjkxNTBhOGNjZTA4ZTI2ZTdj
MWVjN2Q0YjQ5OWYxMjdmLi4xMDlmZGEyMzFjZmE1NjQyNGFlMjUzNGE0YTZkMmI3ZmQxYWIyMWJi
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3Jr
Q2FjaGVDb2RlcnMuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hl
L05ldHdvcmtDYWNoZUNvZGVycy5jcHAKQEAgLTE5MCw2ICsxOTAsMzQgQEAgYm9vbCBDb2RlcjxT
SEExOjpEaWdlc3Q+OjpkZWNvZGUoRGVjb2RlciYgZGVjb2RlciwgU0hBMTo6RGlnZXN0JiBkaWdl
c3QpCiAgICAgcmV0dXJuIGRlY29kZXIuZGVjb2RlRml4ZWRMZW5ndGhEYXRhKGRpZ2VzdC5kYXRh
KCksIHNpemVvZihkaWdlc3QpKTsKIH0KIAorLy8gU3RvcmUgY29tbW9uIEhUVFAgaGVhZGVycyBh
cyBzdHJpbmdzIGluc3RlYWQgb2YgdXNpbmcgdGhlaXIgdmFsdWUgaW4gdGhlIEhUVFBIZWFkZXJO
YW1lIGVudW1lcmF0aW9uCisvLyBzbyB0aGF0IHRoZSBoZWFkZXJzIHN0b3JlZCBpbiB0aGUgY2Fj
aGUgc3RheXMgdmFsaWQgZXZlbiBhZnRlciBIVFRQSGVhZGVyTmFtZS5pbiBnZXRzIHVwZGF0ZWQu
Cit2b2lkIENvZGVyPFdlYkNvcmU6OkhUVFBIZWFkZXJNYXA+OjplbmNvZGUoRW5jb2RlciYgZW5j
b2RlciwgY29uc3QgV2ViQ29yZTo6SFRUUEhlYWRlck1hcCYgaGVhZGVycykKK3sKKyAgICBlbmNv
ZGVyIDw8IHN0YXRpY19jYXN0PHVpbnQ2NF90PihoZWFkZXJzLnNpemUoKSk7CisgICAgZm9yIChh
dXRvJiBrZXlWYWx1ZSA6IGhlYWRlcnMpIHsKKyAgICAgICAgZW5jb2RlciA8PCBrZXlWYWx1ZS5r
ZXk7CisgICAgICAgIGVuY29kZXIgPDwga2V5VmFsdWUudmFsdWU7CisgICAgfQorfQorCitib29s
IENvZGVyPFdlYkNvcmU6OkhUVFBIZWFkZXJNYXA+OjpkZWNvZGUoRGVjb2RlciYgZGVjb2Rlciwg
V2ViQ29yZTo6SFRUUEhlYWRlck1hcCYgaGVhZGVycykKK3sKKyAgICB1aW50NjRfdCBoZWFkZXJz
U2l6ZTsKKyAgICBpZiAoIWRlY29kZXIuZGVjb2RlKGhlYWRlcnNTaXplKSkKKyAgICAgICAgcmV0
dXJuIGZhbHNlOworICAgIGZvciAodWludDY0X3QgaSA9IDA7IGkgPCBoZWFkZXJzU2l6ZTsgKytp
KSB7CisgICAgICAgIFN0cmluZyBuYW1lOworICAgICAgICBpZiAoIWRlY29kZXIuZGVjb2RlKG5h
bWUpKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICBTdHJpbmcgdmFsdWU7Cisg
ICAgICAgIGlmICghZGVjb2Rlci5kZWNvZGUodmFsdWUpKQorICAgICAgICAgICAgcmV0dXJuIGZh
bHNlOworICAgICAgICBoZWFkZXJzLmFkZChuYW1lLCB2YWx1ZSk7CisgICAgfQorICAgIHJldHVy
biB0cnVlOworfQorCiB9CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQ
cm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZUNvZGVycy5oIGIvU291cmNlL1dlYktpdDIvTmV0d29y
a1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlQ29kZXJzLmgKaW5kZXggMDA3NmQ4MjhiNDg0MGRm
NDU3ODgxNTk4MTlhZWU1ZGY5YWIyYWQxYS4uMmQ5MWI4ZWU2NzU0YmFhN2JlZDlhODZlNGI3MjE0
ZTVmYzk2MjA0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2Fj
aGUvTmV0d29ya0NhY2hlQ29kZXJzLmgKKysrIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nl
c3MvY2FjaGUvTmV0d29ya0NhY2hlQ29kZXJzLmgKQEAgLTMxLDYgKzMxLDcgQEAKICNpbmNsdWRl
ICJOZXR3b3JrQ2FjaGVEZWNvZGVyLmgiCiAjaW5jbHVkZSAiTmV0d29ya0NhY2hlRW5jb2Rlci5o
IgogI2luY2x1ZGUgPFdlYkNvcmUvQ2VydGlmaWNhdGVJbmZvLmg+CisjaW5jbHVkZSA8V2ViQ29y
ZS9IVFRQSGVhZGVyTWFwLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9VUkwuaD4KICNpbmNsdWRlIDx1
dGlsaXR5PgogI2luY2x1ZGUgPHd0Zi9Gb3J3YXJkLmg+CkBAIC0yNjQsNiArMjY1LDExIEBAIHRl
bXBsYXRlPD4gc3RydWN0IENvZGVyPFNIQTE6OkRpZ2VzdD4gewogICAgIHN0YXRpYyBib29sIGRl
Y29kZShEZWNvZGVyJiwgU0hBMTo6RGlnZXN0Jik7CiB9OwogCit0ZW1wbGF0ZTw+IHN0cnVjdCBD
b2RlcjxXZWJDb3JlOjpIVFRQSGVhZGVyTWFwPiB7CisgICAgc3RhdGljIHZvaWQgZW5jb2RlKEVu
Y29kZXImLCBjb25zdCBXZWJDb3JlOjpIVFRQSGVhZGVyTWFwJik7CisgICAgc3RhdGljIGJvb2wg
ZGVjb2RlKERlY29kZXImLCBXZWJDb3JlOjpIVFRQSGVhZGVyTWFwJik7Cit9OworCiB9CiB9CiAj
ZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hlL05l
dHdvcmtDYWNoZVN0b3JhZ2UuaCBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hl
L05ldHdvcmtDYWNoZVN0b3JhZ2UuaAppbmRleCBjNGRkNmRlN2JmZmZiOTNhOTQ4ZDdmN2Q3OWY5
Y2U2YjNmMzBkNWQ3Li44ZjVlYmI1ZDgxNjY0Mjk1NzA4NjM2NGNmMGMyMzFhYTk1YTFkMTRiIDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2Fj
aGVTdG9yYWdlLmgKKysrIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0
d29ya0NhY2hlU3RvcmFnZS5oCkBAIC04Niw3ICs4Niw3IEBAIHB1YmxpYzoKICAgICBzaXplX3Qg
Y2FwYWNpdHkoKSBjb25zdCB7IHJldHVybiBtX2NhcGFjaXR5OyB9CiAgICAgc2l6ZV90IGFwcHJv
eGltYXRlU2l6ZSgpIGNvbnN0OwogCi0gICAgc3RhdGljIGNvbnN0IHVuc2lnbmVkIHZlcnNpb24g
PSA2OworICAgIHN0YXRpYyBjb25zdCB1bnNpZ25lZCB2ZXJzaW9uID0gNzsKIAogICAgIFN0cmlu
ZyBiYXNlUGF0aCgpIGNvbnN0OwogICAgIFN0cmluZyB2ZXJzaW9uUGF0aCgpIGNvbnN0Owo=
</data>

          </attachment>
      

    </bug>

</bugzilla>