157301 2016-05-02 22:17:55 -0700 Web Inspector: Remove unused parameter of ScriptArguments::getFirstArgumentAsString 2016-05-03 18:05:30 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck keith_miller mark.lam mattbaker msaboff nvasilyev saam timothy webkit-bug-importer oldest_to_newest 1189683 0 joepeck 2016-05-02 22:17:55 -0700 * SUMMARY Remove unused parameter of ScriptArguments::getFirstArgumentAsString. ScriptArguments::getFirstArgumentAsString(String& result, bool checkForNullOrUndefined = false); checkForNullOrUndefined is never used. 1189684 1 277981 joepeck 2016-05-02 22:19:12 -0700 Created attachment 277981 [PATCH] Proposed Fix 1189926 2 277981 commit-queue 2016-05-03 18:05:26 -0700 Comment on attachment 277981 [PATCH] Proposed Fix Clearing flags on attachment: 277981 Committed r200398: <http://trac.webkit.org/changeset/200398> 1189927 3 commit-queue 2016-05-03 18:05:30 -0700 All reviewed patches have been landed. Closing bug. 277981 2016-05-02 22:19:12 -0700 2016-05-03 18:05:26 -0700 [PATCH] Proposed Fix unused.patch text/plain 3460 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDE4MmIwY2EuLjU2OTg3YzYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE2LTA1LTAyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVtb3Zl IHVudXNlZCBwYXJhbWV0ZXIgb2YgU2NyaXB0QXJndW1lbnRzOjpnZXRGaXJzdEFyZ3VtZW50QXNT dHJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1 NzMwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog aW5zcGVjdG9yL1NjcmlwdEFyZ3VtZW50cy5jcHA6CisgICAgICAgIChJbnNwZWN0b3I6OlNjcmlw dEFyZ3VtZW50czo6Z2V0Rmlyc3RBcmd1bWVudEFzU3RyaW5nKToKKyAgICAgICAgKiBpbnNwZWN0 b3IvU2NyaXB0QXJndW1lbnRzLmg6CisgICAgICAgIFJlbW92ZSB1bnVzZWQgYXJndW1lbnQgYW5k IHJlbGF0ZWQgY29kZS4KKworICAgICAgICAqIHJ1bnRpbWUvQ29uc29sZUNsaWVudC5jcHA6Cisg ICAgICAgIChKU0M6OkNvbnNvbGVDbGllbnQ6OnByaW50Q29uc29sZU1lc3NhZ2VXaXRoQXJndW1l bnRzKToKKyAgICAgICAgRHJpdmUgYnkgcmVtb3ZlIHVubmVjZXNzYXJ5IGNhc3QuCisKKzIwMTYt MDUtMDIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBF bGltaW5hdGUgUGFzc1JlZlB0ciBjb252ZXJzaW9uIGZyb20gQ29uc29sZU9iamVjdAogICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3MzAwCiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvU2NyaXB0QXJndW1lbnRzLmNw cCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvU2NyaXB0QXJndW1lbnRzLmNwcApp bmRleCA1MWQxZmU2Li40YjFkYWRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv aW5zcGVjdG9yL1NjcmlwdEFyZ3VtZW50cy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2luc3BlY3Rvci9TY3JpcHRBcmd1bWVudHMuY3BwCkBAIC01Miw3ICs1Miw3IEBAIFNjcmlwdEFy Z3VtZW50czo6flNjcmlwdEFyZ3VtZW50cygpCiB7CiB9CiAKLWNvbnN0IERlcHJlY2F0ZWQ6OlNj cmlwdFZhbHVlICZTY3JpcHRBcmd1bWVudHM6OmFyZ3VtZW50QXQoc2l6ZV90IGluZGV4KSBjb25z dAorY29uc3QgRGVwcmVjYXRlZDo6U2NyaXB0VmFsdWUmIFNjcmlwdEFyZ3VtZW50czo6YXJndW1l bnRBdChzaXplX3QgaW5kZXgpIGNvbnN0CiB7CiAgICAgQVNTRVJUKG1fYXJndW1lbnRzLnNpemUo KSA+IGluZGV4KTsKICAgICByZXR1cm4gbV9hcmd1bWVudHNbaW5kZXhdOwpAQCAtNjYsMjEgKzY2 LDE3IEBAIEpTQzo6RXhlY1N0YXRlKiBTY3JpcHRBcmd1bWVudHM6Omdsb2JhbFN0YXRlKCkgY29u c3QKICAgICByZXR1cm4gbnVsbHB0cjsKIH0KIAotYm9vbCBTY3JpcHRBcmd1bWVudHM6OmdldEZp cnN0QXJndW1lbnRBc1N0cmluZyhTdHJpbmcmIHJlc3VsdCwgYm9vbCBjaGVja0Zvck51bGxPclVu ZGVmaW5lZCkKK2Jvb2wgU2NyaXB0QXJndW1lbnRzOjpnZXRGaXJzdEFyZ3VtZW50QXNTdHJpbmco U3RyaW5nJiByZXN1bHQpCiB7CiAgICAgaWYgKCFhcmd1bWVudENvdW50KCkpCiAgICAgICAgIHJl dHVybiBmYWxzZTsKIAotICAgIGNvbnN0IERlcHJlY2F0ZWQ6OlNjcmlwdFZhbHVlJiB2YWx1ZSA9 IGFyZ3VtZW50QXQoMCk7Ci0gICAgaWYgKGNoZWNrRm9yTnVsbE9yVW5kZWZpbmVkICYmICh2YWx1 ZS5pc051bGwoKSB8fCB2YWx1ZS5pc1VuZGVmaW5lZCgpKSkKLSAgICAgICAgcmV0dXJuIGZhbHNl OwotCiAgICAgaWYgKCFnbG9iYWxTdGF0ZSgpKSB7CiAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hF RCgpOwogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQogCi0gICAgcmVzdWx0ID0gdmFsdWUu dG9TdHJpbmcoZ2xvYmFsU3RhdGUoKSk7CisgICAgcmVzdWx0ID0gYXJndW1lbnRBdCgwKS50b1N0 cmluZyhnbG9iYWxTdGF0ZSgpKTsKICAgICByZXR1cm4gdHJ1ZTsKIH0KIApkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9TY3JpcHRBcmd1bWVudHMuaCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvU2NyaXB0QXJndW1lbnRzLmgKaW5kZXggNzIwMGFi NC4uYjc5M2E0OSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9T Y3JpcHRBcmd1bWVudHMuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL1Nj cmlwdEFyZ3VtZW50cy5oCkBAIC01OSw3ICs1OSw3IEBAIHB1YmxpYzoKIAogICAgIEpTQzo6RXhl Y1N0YXRlKiBnbG9iYWxTdGF0ZSgpIGNvbnN0OwogCi0gICAgYm9vbCBnZXRGaXJzdEFyZ3VtZW50 QXNTdHJpbmcoU3RyaW5nJiByZXN1bHQsIGJvb2wgY2hlY2tGb3JOdWxsT3JVbmRlZmluZWQgPSBm YWxzZSk7CisgICAgYm9vbCBnZXRGaXJzdEFyZ3VtZW50QXNTdHJpbmcoU3RyaW5nJiByZXN1bHQp OwogICAgIGJvb2wgaXNFcXVhbChTY3JpcHRBcmd1bWVudHMqKSBjb25zdDsKIAogcHJpdmF0ZToK ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbnNvbGVDbGllbnQu Y3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29uc29sZUNsaWVudC5jcHAKaW5k ZXggM2VjNTRmMy4uZGU0NDA4OCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvQ29uc29sZUNsaWVudC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvQ29uc29sZUNsaWVudC5jcHAKQEAgLTE3OCw3ICsxNzgsNyBAQCB2b2lkIENvbnNvbGVDbGll bnQ6OnByaW50Q29uc29sZU1lc3NhZ2VXaXRoQXJndW1lbnRzKE1lc3NhZ2VTb3VyY2Ugc291cmNl LCBNZXNzYQogICAgICAgICAgICAgICAgIGZ1bmN0aW9uTmFtZSA9IEFTQ0lJTGl0ZXJhbCgiKHVu a25vd24pIik7CiAKICAgICAgICAgICAgIFN0cmluZ0J1aWxkZXIgY2FsbEZyYW1lQnVpbGRlcjsK LSAgICAgICAgICAgIGNhbGxGcmFtZUJ1aWxkZXIuYXBwZW5kTnVtYmVyKHN0YXRpY19jYXN0PHVu c2lnbmVkIGxvbmc+KGkpKTsKKyAgICAgICAgICAgIGNhbGxGcmFtZUJ1aWxkZXIuYXBwZW5kTnVt YmVyKGkpOwogICAgICAgICAgICAgY2FsbEZyYW1lQnVpbGRlci5hcHBlbmRMaXRlcmFsKCI6ICIp OwogICAgICAgICAgICAgY2FsbEZyYW1lQnVpbGRlci5hcHBlbmQoZnVuY3Rpb25OYW1lKTsKICAg ICAgICAgICAgIGNhbGxGcmFtZUJ1aWxkZXIuYXBwZW5kKCcoJyk7Cg==