157300 2016-05-02 21:24:02 -0700 Eliminate PassRefPtr conversion from ConsoleObject 2016-05-03 11:41:23 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue joepeck timothy oldest_to_newest 1189669 0 joepeck 2016-05-02 21:24:02 -0700 * SUMMARY Eliminate PassRefPtr conversion from ConsoleObject No need for this here, the callers take a RefPtr<T>&&. 1189670 1 277975 joepeck 2016-05-02 21:25:53 -0700 Created attachment 277975 [PATCH] Proposed Fix Might not apply until other patches land. 1189746 2 277975 commit-queue 2016-05-03 08:23:53 -0700 Comment on attachment 277975 [PATCH] Proposed Fix Rejecting attachment 277975 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 277975, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: FAILED at 209. Hunk #8 succeeded at 217 (offset -3 lines). Hunk #9 succeeded at 322 (offset -3 lines). Hunk #10 succeeded at 333 (offset -3 lines). Hunk #11 succeeded at 344 (offset -3 lines). Hunk #12 succeeded at 355 (offset -3 lines). 1 out of 12 hunks FAILED -- saving rejects to file Source/JavaScriptCore/runtime/ConsoleObject.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/1261259 1189812 3 joepeck 2016-05-03 11:41:23 -0700 <http://trac.webkit.org/changeset/200384> 277975 2016-05-02 21:25:53 -0700 2016-05-03 08:23:53 -0700 [PATCH] Proposed Fix move.patch text/plain 6155 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDRmMzVhN2YuLjE4MmIwY2EgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3IEBACiAyMDE2LTA1LTAyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgRWxpbWluYXRlIFBhc3NSZWZQdHIg Y29udmVyc2lvbiBmcm9tIENvbnNvbGVPYmplY3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NzMwMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogcnVudGltZS9Db25zb2xlT2JqZWN0LmNwcDoKKyAgICAg ICAgKEpTQzo6Y29uc29sZUxvZ1dpdGhMZXZlbCk6CisgICAgICAgIChKU0M6OmNvbnNvbGVQcm90 b0Z1bmNDbGVhcik6CisgICAgICAgIChKU0M6OmNvbnNvbGVQcm90b0Z1bmNEaXIpOgorICAgICAg ICAoSlNDOjpjb25zb2xlUHJvdG9GdW5jRGlyWE1MKToKKyAgICAgICAgKEpTQzo6Y29uc29sZVBy b3RvRnVuY1RhYmxlKToKKyAgICAgICAgKEpTQzo6Y29uc29sZVByb3RvRnVuY1RyYWNlKToKKyAg ICAgICAgKEpTQzo6Y29uc29sZVByb3RvRnVuY0Fzc2VydCk6CisgICAgICAgIChKU0M6OmNvbnNv bGVQcm90b0Z1bmNDb3VudCk6CisgICAgICAgIChKU0M6OmNvbnNvbGVQcm90b0Z1bmNUaW1lU3Rh bXApOgorICAgICAgICAoSlNDOjpjb25zb2xlUHJvdG9GdW5jR3JvdXApOgorICAgICAgICAoSlND Ojpjb25zb2xlUHJvdG9GdW5jR3JvdXBDb2xsYXBzZWQpOgorICAgICAgICAoSlNDOjpjb25zb2xl UHJvdG9GdW5jR3JvdXBFbmQpOgorICAgICAgICBObyBuZWVkIHRvIHJlbGVhc2UgdG8gYSBQYXNz UmVmUHRyLCB3ZSBjYW4ganVzdCBtb3ZlIGludG8gdGhlIFJlZlB0cjw+JiYuCisKKzIwMTYtMDUt MDIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIg SW5zcGVjdG9yOiBjb25zb2xlLmFzc2VydCBzaG91bGQgZG8gZmFyIGxlc3Mgd29yayB3aGVuIHRo ZSBhc3NlcnRpb24gaXMgdHJ1ZQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTU3Mjk3CiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNjA1NjU1Nj4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbnNvbGVPYmplY3QuY3Bw IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29uc29sZU9iamVjdC5jcHAKaW5kZXgg NTdhNGE0OS4uYTJhZjk4OCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvQ29uc29sZU9iamVjdC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv Q29uc29sZU9iamVjdC5jcHAKQEAgLTExMSw3ICsxMTEsNyBAQCBzdGF0aWMgRW5jb2RlZEpTVmFs dWUgY29uc29sZUxvZ1dpdGhMZXZlbChFeGVjU3RhdGUqIGV4ZWMsIE1lc3NhZ2VMZXZlbCBsZXZl bCkKICAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1VuZGVmaW5lZCgpKTsKIAogICAg IFJlZlB0cjxJbnNwZWN0b3I6OlNjcmlwdEFyZ3VtZW50cz4gYXJndW1lbnRzKEluc3BlY3Rvcjo6 Y3JlYXRlU2NyaXB0QXJndW1lbnRzKGV4ZWMsIDApKTsKLSAgICBjbGllbnQtPmxvZ1dpdGhMZXZl bChleGVjLCBhcmd1bWVudHMucmVsZWFzZSgpLCBsZXZlbCk7CisgICAgY2xpZW50LT5sb2dXaXRo TGV2ZWwoZXhlYywgV1RGTW92ZShhcmd1bWVudHMpLCBsZXZlbCk7CiAgICAgcmV0dXJuIEpTVmFs dWU6OmVuY29kZShqc1VuZGVmaW5lZCgpKTsKIH0KIApAQCAtMTQ3LDcgKzE0Nyw3IEBAIHN0YXRp YyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGNvbnNvbGVQcm90b0Z1bmNDbGVhcihFeGVj U3RhdGUqIGV4ZWMpCiAgICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNVbmRlZmluZWQo KSk7CiAKICAgICBSZWZQdHI8SW5zcGVjdG9yOjpTY3JpcHRBcmd1bWVudHM+IGFyZ3VtZW50cyhJ bnNwZWN0b3I6OmNyZWF0ZVNjcmlwdEFyZ3VtZW50cyhleGVjLCAwKSk7Ci0gICAgY2xpZW50LT5j bGVhcihleGVjLCBhcmd1bWVudHMucmVsZWFzZSgpKTsKKyAgICBjbGllbnQtPmNsZWFyKGV4ZWMs IFdURk1vdmUoYXJndW1lbnRzKSk7CiAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1VuZGVm aW5lZCgpKTsKIH0KIApAQCAtMTU4LDcgKzE1OCw3IEBAIHN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBK U0NfSE9TVF9DQUxMIGNvbnNvbGVQcm90b0Z1bmNEaXIoRXhlY1N0YXRlKiBleGVjKQogICAgICAg ICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzVW5kZWZpbmVkKCkpOwogCiAgICAgUmVmUHRyPElu c3BlY3Rvcjo6U2NyaXB0QXJndW1lbnRzPiBhcmd1bWVudHMoSW5zcGVjdG9yOjpjcmVhdGVTY3Jp cHRBcmd1bWVudHMoZXhlYywgMCkpOwotICAgIGNsaWVudC0+ZGlyKGV4ZWMsIGFyZ3VtZW50cy5y ZWxlYXNlKCkpOworICAgIGNsaWVudC0+ZGlyKGV4ZWMsIFdURk1vdmUoYXJndW1lbnRzKSk7CiAg ICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1VuZGVmaW5lZCgpKTsKIH0KIApAQCAtMTY5LDcg KzE2OSw3IEBAIHN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGNvbnNvbGVQcm90 b0Z1bmNEaXJYTUwoRXhlY1N0YXRlKiBleGVjKQogICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5j b2RlKGpzVW5kZWZpbmVkKCkpOwogCiAgICAgUmVmUHRyPEluc3BlY3Rvcjo6U2NyaXB0QXJndW1l bnRzPiBhcmd1bWVudHMoSW5zcGVjdG9yOjpjcmVhdGVTY3JpcHRBcmd1bWVudHMoZXhlYywgMCkp OwotICAgIGNsaWVudC0+ZGlyWE1MKGV4ZWMsIGFyZ3VtZW50cy5yZWxlYXNlKCkpOworICAgIGNs aWVudC0+ZGlyWE1MKGV4ZWMsIFdURk1vdmUoYXJndW1lbnRzKSk7CiAgICAgcmV0dXJuIEpTVmFs dWU6OmVuY29kZShqc1VuZGVmaW5lZCgpKTsKIH0KIApAQCAtMTgwLDcgKzE4MCw3IEBAIHN0YXRp YyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGNvbnNvbGVQcm90b0Z1bmNUYWJsZShFeGVj U3RhdGUqIGV4ZWMpCiAgICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNVbmRlZmluZWQo KSk7CiAKICAgICBSZWZQdHI8SW5zcGVjdG9yOjpTY3JpcHRBcmd1bWVudHM+IGFyZ3VtZW50cyhJ bnNwZWN0b3I6OmNyZWF0ZVNjcmlwdEFyZ3VtZW50cyhleGVjLCAwKSk7Ci0gICAgY2xpZW50LT50 YWJsZShleGVjLCBhcmd1bWVudHMucmVsZWFzZSgpKTsKKyAgICBjbGllbnQtPnRhYmxlKGV4ZWMs IFdURk1vdmUoYXJndW1lbnRzKSk7CiAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1VuZGVm aW5lZCgpKTsKIH0KIApAQCAtMTkxLDcgKzE5MSw3IEBAIHN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBK U0NfSE9TVF9DQUxMIGNvbnNvbGVQcm90b0Z1bmNUcmFjZShFeGVjU3RhdGUqIGV4ZWMpCiAgICAg ICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNVbmRlZmluZWQoKSk7CiAKICAgICBSZWZQdHI8 SW5zcGVjdG9yOjpTY3JpcHRBcmd1bWVudHM+IGFyZ3VtZW50cyhJbnNwZWN0b3I6OmNyZWF0ZVNj cmlwdEFyZ3VtZW50cyhleGVjLCAwKSk7Ci0gICAgY2xpZW50LT50cmFjZShleGVjLCBhcmd1bWVu dHMucmVsZWFzZSgpKTsKKyAgICBjbGllbnQtPnRyYWNlKGV4ZWMsIFdURk1vdmUoYXJndW1lbnRz KSk7CiAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1VuZGVmaW5lZCgpKTsKIH0KIApAQCAt MjA5LDcgKzIwOSw3IEBAIHN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGNvbnNv bGVQcm90b0Z1bmNBc3NlcnQoRXhlY1N0YXRlKiBleGVjKQogICAgICAgICByZXR1cm4gSlNWYWx1 ZTo6ZW5jb2RlKGpzVW5kZWZpbmVkKCkpOwogCiAgICAgUmVmUHRyPEluc3BlY3Rvcjo6U2NyaXB0 QXJndW1lbnRzPiBhcmd1bWVudHMoSW5zcGVjdG9yOjpjcmVhdGVTY3JpcHRBcmd1bWVudHMoZXhl YywgMSkpOwotICAgIGNsaWVudC0+YXNzZXJ0aW9uKGV4ZWMsIGFyZ3VtZW50cy5yZWxlYXNlKCkp OworICAgIGNsaWVudC0+YXNzZXJ0aW9uKGV4ZWMsIFdURk1vdmUoYXJndW1lbnRzKSk7CiAgICAg cmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1VuZGVmaW5lZCgpKTsKIH0KIApAQCAtMjIwLDcgKzIy MCw3IEBAIHN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGNvbnNvbGVQcm90b0Z1 bmNDb3VudChFeGVjU3RhdGUqIGV4ZWMpCiAgICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUo anNVbmRlZmluZWQoKSk7CiAKICAgICBSZWZQdHI8SW5zcGVjdG9yOjpTY3JpcHRBcmd1bWVudHM+ IGFyZ3VtZW50cyhJbnNwZWN0b3I6OmNyZWF0ZVNjcmlwdEFyZ3VtZW50cyhleGVjLCAwKSk7Ci0g ICAgY2xpZW50LT5jb3VudChleGVjLCBhcmd1bWVudHMucmVsZWFzZSgpKTsKKyAgICBjbGllbnQt PmNvdW50KGV4ZWMsIFdURk1vdmUoYXJndW1lbnRzKSk7CiAgICAgcmV0dXJuIEpTVmFsdWU6OmVu Y29kZShqc1VuZGVmaW5lZCgpKTsKIH0KIApAQCAtMzI1LDcgKzMyNSw3IEBAIHN0YXRpYyBFbmNv ZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGNvbnNvbGVQcm90b0Z1bmNUaW1lU3RhbXAoRXhlY1N0 YXRlKiBleGVjKQogICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzVW5kZWZpbmVkKCkp OwogCiAgICAgUmVmUHRyPEluc3BlY3Rvcjo6U2NyaXB0QXJndW1lbnRzPiBhcmd1bWVudHMoSW5z cGVjdG9yOjpjcmVhdGVTY3JpcHRBcmd1bWVudHMoZXhlYywgMCkpOwotICAgIGNsaWVudC0+dGlt ZVN0YW1wKGV4ZWMsIGFyZ3VtZW50cy5yZWxlYXNlKCkpOworICAgIGNsaWVudC0+dGltZVN0YW1w KGV4ZWMsIFdURk1vdmUoYXJndW1lbnRzKSk7CiAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShq c1VuZGVmaW5lZCgpKTsKIH0KIApAQCAtMzM2LDcgKzMzNiw3IEBAIHN0YXRpYyBFbmNvZGVkSlNW YWx1ZSBKU0NfSE9TVF9DQUxMIGNvbnNvbGVQcm90b0Z1bmNHcm91cChFeGVjU3RhdGUqIGV4ZWMp CiAgICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNVbmRlZmluZWQoKSk7CiAKICAgICBS ZWZQdHI8SW5zcGVjdG9yOjpTY3JpcHRBcmd1bWVudHM+IGFyZ3VtZW50cyhJbnNwZWN0b3I6OmNy ZWF0ZVNjcmlwdEFyZ3VtZW50cyhleGVjLCAwKSk7Ci0gICAgY2xpZW50LT5ncm91cChleGVjLCBh cmd1bWVudHMucmVsZWFzZSgpKTsKKyAgICBjbGllbnQtPmdyb3VwKGV4ZWMsIFdURk1vdmUoYXJn dW1lbnRzKSk7CiAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1VuZGVmaW5lZCgpKTsKIH0K IApAQCAtMzQ3LDcgKzM0Nyw3IEBAIHN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxM IGNvbnNvbGVQcm90b0Z1bmNHcm91cENvbGxhcHNlZChFeGVjU3RhdGUqIGV4CiAgICAgICAgIHJl dHVybiBKU1ZhbHVlOjplbmNvZGUoanNVbmRlZmluZWQoKSk7CiAKICAgICBSZWZQdHI8SW5zcGVj dG9yOjpTY3JpcHRBcmd1bWVudHM+IGFyZ3VtZW50cyhJbnNwZWN0b3I6OmNyZWF0ZVNjcmlwdEFy Z3VtZW50cyhleGVjLCAwKSk7Ci0gICAgY2xpZW50LT5ncm91cENvbGxhcHNlZChleGVjLCBhcmd1 bWVudHMucmVsZWFzZSgpKTsKKyAgICBjbGllbnQtPmdyb3VwQ29sbGFwc2VkKGV4ZWMsIFdURk1v dmUoYXJndW1lbnRzKSk7CiAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1VuZGVmaW5lZCgp KTsKIH0KIApAQCAtMzU4LDcgKzM1OCw3IEBAIHN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9T VF9DQUxMIGNvbnNvbGVQcm90b0Z1bmNHcm91cEVuZChFeGVjU3RhdGUqIGV4ZWMpCiAgICAgICAg IHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNVbmRlZmluZWQoKSk7CiAKICAgICBSZWZQdHI8SW5z cGVjdG9yOjpTY3JpcHRBcmd1bWVudHM+IGFyZ3VtZW50cyhJbnNwZWN0b3I6OmNyZWF0ZVNjcmlw dEFyZ3VtZW50cyhleGVjLCAwKSk7Ci0gICAgY2xpZW50LT5ncm91cEVuZChleGVjLCBhcmd1bWVu dHMucmVsZWFzZSgpKTsKKyAgICBjbGllbnQtPmdyb3VwRW5kKGV4ZWMsIFdURk1vdmUoYXJndW1l bnRzKSk7CiAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1VuZGVmaW5lZCgpKTsKIH0KIAo=