157297 2016-05-02 20:50:36 -0700 Web Inspector: console.assert should do far less work when the assertion is true 2016-05-03 08:32:36 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned bburg commit-queue graouts joepeck keith_miller mark.lam mattbaker nvasilyev saam timothy webkit-bug-importer oldest_to_newest 1189656 0 joepeck 2016-05-02 20:50:36 -0700 * SUMMARY console.assert should do far less work when the assertion is true. * TEST <script> (function() { function bench(name, f, arg) { var warmup = f(); var start = Date.now(); var result = f(); var end = Date.now(); console.log(name, (end-start)+"ms"); } bench("console.assert...", function() { for (var i = 0; i < 1e6; ++i) console.assert(true, "message"); }); })(); </script> * RESULTS • Safari - console.assert... – "119ms" • Chrome - console.assert... 22ms • Firefox - console.assert... 44ms We do a lot of work in the case where the assert doesn't fire. After a quick fix: • Safari - console.assert... – "9ms" 1189657 1 webkit-bug-importer 2016-05-02 20:52:01 -0700 <rdar://problem/26056556> 1189659 2 277972 joepeck 2016-05-02 20:55:19 -0700 Created attachment 277972 [PATCH] Proposed Fix We could make assert an intrinsic in the future, but I'm not sure it really needs it. This alone was a 10x speedup. 1189676 3 277972 timothy 2016-05-02 21:52:29 -0700 Comment on attachment 277972 [PATCH] Proposed Fix Nice! 1189747 4 277972 commit-queue 2016-05-03 08:24:00 -0700 Comment on attachment 277972 [PATCH] Proposed Fix Clearing flags on attachment: 277972 Committed r200371: <http://trac.webkit.org/changeset/200371> 1189748 5 commit-queue 2016-05-03 08:24:05 -0700 All reviewed patches have been landed. Closing bug. 1189756 6 277972 darin 2016-05-03 08:32:36 -0700 Comment on attachment 277972 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=277972&action=review > Source/JavaScriptCore/runtime/ConsoleClient.h:53 > + void assertion(ExecState*, RefPtr<Inspector::ScriptArguments>&&); The right name for this seems to be "assertionFailed". Longer term, really puzzled about the fact that ScriptArguments is a reference counted object. 277972 2016-05-02 20:55:19 -0700 2016-05-03 08:24:00 -0700 [PATCH] Proposed Fix assert-1.patch text/plain 3702 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGFhMzZiMzMuLjRmMzVhN2YgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDE2LTA1LTAyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogY29uc29s ZS5hc3NlcnQgc2hvdWxkIGRvIGZhciBsZXNzIHdvcmsgd2hlbiB0aGUgYXNzZXJ0aW9uIGlzIHRy dWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NzI5 NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjYwNTY1NTY+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBydW50aW1lL0NvbnNvbGVDbGllbnQuaDoK KyAgICAgICAgKiBydW50aW1lL0NvbnNvbGVDbGllbnQuY3BwOgorICAgICAgICAoSlNDOjpDb25z b2xlQ2xpZW50Ojphc3NlcnRpb24pOgorICAgICAgICAoSlNDOjpDb25zb2xlQ2xpZW50Ojphc3Nl cnRDb25kaXRpb24pOiBEZWxldGVkLgorICAgICAgICBSZW5hbWUsIG5vdyB0aGF0IHRoaXMgd2ls bCBvbmx5IGdldCBjYWxsZWQgd2hlbiB0aGUgYXNzZXJ0aW9uIGZhaWxlZC4KKworICAgICAgICAq IHJ1bnRpbWUvQ29uc29sZU9iamVjdC5jcHA6CisgICAgICAgIChKU0M6OmNvbnNvbGVQcm90b0Z1 bmNBc3NlcnQpOgorICAgICAgICBBdm9pZCBkb2luZyBhbnkgd29yayBpZiB0aGUgYXNzZXJ0aW9u IHN1Y2NlZWRlZC4KKworMjAxNi0wNS0wMiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBw bGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJlZmxlY3QudG9TdHJpbmcoKSBzaG91 bGQgYmUgW29iamVjdCBPYmplY3RdIG5vdCBbb2JqZWN0IFJlZmxlY3RdCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTcyODgKIApkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29uc29sZUNsaWVudC5jcHAgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9Db25zb2xlQ2xpZW50LmNwcAppbmRleCAwNTlmZDMzLi4z ZWM1NGYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db25zb2xl Q2xpZW50LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db25zb2xlQ2xp ZW50LmNwcApAQCAtMjI4LDExICsyMjgsOCBAQCB2b2lkIENvbnNvbGVDbGllbnQ6OnRyYWNlKEV4 ZWNTdGF0ZSogZXhlYywgUmVmUHRyPFNjcmlwdEFyZ3VtZW50cz4mJiBhcmd1bWVudHMpCiAgICAg aW50ZXJuYWxNZXNzYWdlV2l0aFR5cGVBbmRMZXZlbChNZXNzYWdlVHlwZTo6VHJhY2UsIE1lc3Nh Z2VMZXZlbDo6TG9nLCBleGVjLCBXVEZNb3ZlKGFyZ3VtZW50cyksIEFyZ3VtZW50Tm90UmVxdWly ZWQpOwogfQogCi12b2lkIENvbnNvbGVDbGllbnQ6OmFzc2VydENvbmRpdGlvbihFeGVjU3RhdGUq IGV4ZWMsIFJlZlB0cjxTY3JpcHRBcmd1bWVudHM+JiYgYXJndW1lbnRzLCBib29sIGNvbmRpdGlv bikKK3ZvaWQgQ29uc29sZUNsaWVudDo6YXNzZXJ0aW9uKEV4ZWNTdGF0ZSogZXhlYywgUmVmUHRy PFNjcmlwdEFyZ3VtZW50cz4mJiBhcmd1bWVudHMpCiB7Ci0gICAgaWYgKGNvbmRpdGlvbikKLSAg ICAgICAgcmV0dXJuOwotCiAgICAgaW50ZXJuYWxNZXNzYWdlV2l0aFR5cGVBbmRMZXZlbChNZXNz YWdlVHlwZTo6QXNzZXJ0LCBNZXNzYWdlTGV2ZWw6OkVycm9yLCBleGVjLCBXVEZNb3ZlKGFyZ3Vt ZW50cyksIEFyZ3VtZW50Tm90UmVxdWlyZWQpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9Db25zb2xlQ2xpZW50LmggYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9Db25zb2xlQ2xpZW50LmgKaW5kZXggYTlmYWE1Ni4uNzIzMDRlMyAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29uc29sZUNsaWVudC5oCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbnNvbGVDbGllbnQuaApAQCAtNTAsNyAr NTAsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBkaXJYTUwoRXhlY1N0YXRlKiwgUmVmUHRyPEluc3Bl Y3Rvcjo6U2NyaXB0QXJndW1lbnRzPiYmKTsKICAgICB2b2lkIHRhYmxlKEV4ZWNTdGF0ZSosIFJl ZlB0cjxJbnNwZWN0b3I6OlNjcmlwdEFyZ3VtZW50cz4mJik7CiAgICAgdm9pZCB0cmFjZShFeGVj U3RhdGUqLCBSZWZQdHI8SW5zcGVjdG9yOjpTY3JpcHRBcmd1bWVudHM+JiYpOwotICAgIHZvaWQg YXNzZXJ0Q29uZGl0aW9uKEV4ZWNTdGF0ZSosIFJlZlB0cjxJbnNwZWN0b3I6OlNjcmlwdEFyZ3Vt ZW50cz4mJiwgYm9vbCBjb25kaXRpb24pOworICAgIHZvaWQgYXNzZXJ0aW9uKEV4ZWNTdGF0ZSos IFJlZlB0cjxJbnNwZWN0b3I6OlNjcmlwdEFyZ3VtZW50cz4mJik7CiAgICAgdm9pZCBncm91cChF eGVjU3RhdGUqLCBSZWZQdHI8SW5zcGVjdG9yOjpTY3JpcHRBcmd1bWVudHM+JiYpOwogICAgIHZv aWQgZ3JvdXBDb2xsYXBzZWQoRXhlY1N0YXRlKiwgUmVmUHRyPEluc3BlY3Rvcjo6U2NyaXB0QXJn dW1lbnRzPiYmKTsKICAgICB2b2lkIGdyb3VwRW5kKEV4ZWNTdGF0ZSosIFJlZlB0cjxJbnNwZWN0 b3I6OlNjcmlwdEFyZ3VtZW50cz4mJik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9Db25zb2xlT2JqZWN0LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0NvbnNvbGVPYmplY3QuY3BwCmluZGV4IDEzYmIzN2YuLjU3YTRhNDkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbnNvbGVPYmplY3QuY3BwCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbnNvbGVPYmplY3QuY3BwCkBAIC0yMDEsMTIg KzIwMSwxNSBAQCBzdGF0aWMgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBjb25zb2xlUHJv dG9GdW5jQXNzZXJ0KEV4ZWNTdGF0ZSogZXhlYykKICAgICBpZiAoIWNsaWVudCkKICAgICAgICAg cmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1VuZGVmaW5lZCgpKTsKIAotICAgIGJvb2wgY29uZGl0 aW9uKGV4ZWMtPmFyZ3VtZW50KDApLnRvQm9vbGVhbihleGVjKSk7CisgICAgYm9vbCBjb25kaXRp b24gPSBleGVjLT5hcmd1bWVudCgwKS50b0Jvb2xlYW4oZXhlYyk7CiAgICAgaWYgKGV4ZWMtPmhh ZEV4Y2VwdGlvbigpKQogICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzVW5kZWZpbmVk KCkpOwogCisgICAgaWYgKGNvbmRpdGlvbikKKyAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29k ZShqc1VuZGVmaW5lZCgpKTsKKwogICAgIFJlZlB0cjxJbnNwZWN0b3I6OlNjcmlwdEFyZ3VtZW50 cz4gYXJndW1lbnRzKEluc3BlY3Rvcjo6Y3JlYXRlU2NyaXB0QXJndW1lbnRzKGV4ZWMsIDEpKTsK LSAgICBjbGllbnQtPmFzc2VydENvbmRpdGlvbihleGVjLCBhcmd1bWVudHMucmVsZWFzZSgpLCBj b25kaXRpb24pOworICAgIGNsaWVudC0+YXNzZXJ0aW9uKGV4ZWMsIGFyZ3VtZW50cy5yZWxlYXNl KCkpOwogICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNVbmRlZmluZWQoKSk7CiB9CiAK