157288 2016-05-02 17:08:07 -0700 Web Inspector: Reflect.toString() should be [object Object] not [object Reflect] 2016-05-02 18:59:51 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1189569 0 joepeck 2016-05-02 17:08:07 -0700 * SUMMARY Web Inspector: Reflect.toString() should be [object Object] not [object Reflect] <https://github.com/tc39/ecma262/issues/495> <https://github.com/tc39/ecma262/issues/495#issuecomment-201909471> > No, this was intentional decision. > > [snip] > > Reflect isn't a "class", it is just namespace defined using an ordinary object. > Such name space objects are now widely used in JS code and typically don't have > custom toString behavior. So we followed the precedent of ECMA-402 Intl and did > not give Reflect its own @@toStringTag > > Part of the motivation, was a desire during ES6 that we should minimize the > specialness of builtins. In general, we wanted built-ins to be as much as > possible just ordinary objects that might be implemented by everyday JS > programmers and hence the builtins should generally follow the same > conventions as we expect ordinary JS programmers to follow. For the > class-like buildins we established a new convention of using @@toString on > the prototype to name class instances. Hopefully that is a convention that > will catch on with JS programmers. For namespace objects like Reflect we > expect JS programmers to continue to use direct object instance (often > constructed via object literals) and that they typically won't give them > unique @@toStringTag properties. So most name spaces including Intl and > Reflect will print as "[object Object]". 1189570 1 277947 joepeck 2016-05-02 17:08:40 -0700 Created attachment 277947 [PATCH] Proposed Fix 1189622 2 277947 commit-queue 2016-05-02 18:59:46 -0700 Comment on attachment 277947 [PATCH] Proposed Fix Clearing flags on attachment: 277947 Committed r200355: <http://trac.webkit.org/changeset/200355> 1189623 3 commit-queue 2016-05-02 18:59:51 -0700 All reviewed patches have been landed. Closing bug. 277947 2016-05-02 17:08:40 -0700 2016-05-02 18:59:46 -0700 [PATCH] Proposed Fix reflect-1.patch text/plain 1974 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGIwNzI2M2UuLmVjYWI4N2IgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDE2LTA1LTAyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVmbGVj dC50b1N0cmluZygpIHNob3VsZCBiZSBbb2JqZWN0IE9iamVjdF0gbm90IFtvYmplY3QgUmVmbGVj dF0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NzI4 OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcnVu dGltZS9SZWZsZWN0T2JqZWN0LmNwcDoKKyAgICAgICAgKiB0ZXN0cy9zdHJlc3MvcmVmbGVjdC5q czogQWRkZWQuCisKKzIwMTYtMDUtMDIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxl LmNvbT4KKwogICAgICAgICBNYWtlIGNvbnNvbGUgYSBuYW1lc3BhY2Ugb2JqZWN0IChsaWtlIE1h dGgvSlNPTiksIGFsbG93aW5nIGZ1bmN0aW9ucyB0byBiZSBjYWxsZWQgdW5ib3VuZAogICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3Mjg2CiAgICAgICAg IDxyZGFyOi8vcHJvYmxlbS8yNjA1MjgzMD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL1JlZmxlY3RPYmplY3QuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvUmVmbGVjdE9iamVjdC5jcHAKaW5kZXggYTVlMTg3Yi4uNGVjM2Q5OSAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUmVmbGVjdE9iamVjdC5jcHAKKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUmVmbGVjdE9iamVjdC5jcHAKQEAgLTU0LDcg KzU0LDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAKIFNUQVRJQ19BU1NFUlRfSVNfVFJJVklBTExZX0RF U1RSVUNUSUJMRShSZWZsZWN0T2JqZWN0KTsKIAotY29uc3QgQ2xhc3NJbmZvIFJlZmxlY3RPYmpl Y3Q6OnNfaW5mbyA9IHsgIlJlZmxlY3QiLCAmQmFzZTo6c19pbmZvLCAmcmVmbGVjdE9iamVjdFRh YmxlLCBDUkVBVEVfTUVUSE9EX1RBQkxFKFJlZmxlY3RPYmplY3QpIH07Citjb25zdCBDbGFzc0lu Zm8gUmVmbGVjdE9iamVjdDo6c19pbmZvID0geyAiT2JqZWN0IiwgJkJhc2U6OnNfaW5mbywgJnJl ZmxlY3RPYmplY3RUYWJsZSwgQ1JFQVRFX01FVEhPRF9UQUJMRShSZWZsZWN0T2JqZWN0KSB9Owog CiAvKiBTb3VyY2UgZm9yIFJlZmxlY3RPYmplY3QubHV0LmgKIEBiZWdpbiByZWZsZWN0T2JqZWN0 VGFibGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3MvcmVm bGVjdC5qcyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3MvcmVmbGVjdC5qcwpu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi4xZjE0ZWEwCi0tLSAvZGV2L251bGwK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9yZWZsZWN0LmpzCkBAIC0w LDAgKzEsOSBAQAorZnVuY3Rpb24gc2hvdWxkQmUoYWN0dWFsLCBleHBlY3RlZCkgeworICAgIGlm IChhY3R1YWwgIT09IGV4cGVjdGVkKQorICAgICAgICB0aHJvdyBuZXcgRXJyb3IoJ2JhZCB2YWx1 ZTogJyArIGFjdHVhbCk7Cit9CisKK3Nob3VsZEJlKHR5cGVvZiBSZWZsZWN0LCAib2JqZWN0Iik7 CitzaG91bGRCZShSZWZsZWN0LCBSZWZsZWN0KTsKK3Nob3VsZEJlKE9iamVjdC5nZXRQcm90b3R5 cGVPZihSZWZsZWN0KSwgT2JqZWN0LmdldFByb3RvdHlwZU9mKHt9KSk7CitzaG91bGRCZShSZWZs ZWN0LnRvU3RyaW5nKCksICJbb2JqZWN0IE9iamVjdF0iKTsK