157280 2016-05-02 14:20:12 -0700 Web Inspector: Unexpected "Script Element #" resources in Debugger Sidebar 2016-05-10 17:20:35 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1189511 0 joepeck 2016-05-02 14:20:12 -0700 * SUMMARY Unexpected "Script Element #" resources in Debugger Sidebar * STEPS TO REPRODUCE 1. Inspect apple.com 2. Reload 3. Show Debugger tab => Unexpected "Script Element 1" and 2 in the sidebar 1189512 1 277934 joepeck 2016-05-02 14:21:49 -0700 Created attachment 277934 [PATCH] Proposed Fix 1189532 2 277934 timothy 2016-05-02 15:17:08 -0700 Comment on attachment 277934 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=277934&action=review > Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:456 > + if (script.dynamicallyAddedScriptElement) > + return null; Does this need to allow them with a sourceURL? 1189575 3 joepeck 2016-05-02 17:16:37 -0700 (In reply to comment #2) > Comment on attachment 277934 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=277934&action=review > > > Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:456 > > + if (script.dynamicallyAddedScriptElement) > > + return null; > > Does this need to allow them with a sourceURL? Yes, it probably should!! Good catch. 1189576 4 277949 joepeck 2016-05-02 17:19:29 -0700 Created attachment 277949 [PATCH] For Landing 1189608 5 277949 commit-queue 2016-05-02 18:33:57 -0700 Comment on attachment 277949 [PATCH] For Landing Clearing flags on attachment: 277949 Committed r200353: <http://trac.webkit.org/changeset/200353> 277934 2016-05-02 14:21:49 -0700 2016-05-02 17:19:14 -0700 [PATCH] Proposed Fix less-script-elem.patch text/plain 1674 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGU4MGY0MGIuLjI2NGUyYTYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE2LTA1LTAyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVW5leHBl Y3RlZCAiU2NyaXB0IEVsZW1lbnQgIyIgcmVzb3VyY2VzIGluIERlYnVnZ2VyIFNpZGViYXIKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NzI4MAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVy ZmFjZS9WaWV3cy9EZWJ1Z2dlclNpZGViYXJQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5EZWJ1Z2dlclNpZGViYXJQYW5lbC5wcm90b3R5cGUuX2FkZFNjcmlwdCk6CisgICAgICAgIERv bid0IGluY2x1ZGUgU2NyaXB0IEVsZW1lbnQgcmVzb3VyY2VzIGluIHRoZSBkZWJ1Z2dlciBzaWRl YmFyIGJ5IGRlZmF1bHQuCisKKzIwMTYtMDUtMDIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJv QGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBQcmVmZXIgIkNvbnNvbGUgRXZh bHVhdGlvbiIgdG8gIkV2YWwgQ29kZSIgaWYgd2Uga25vdyBpdCB3YXMgYSBjb25zb2xlIGV2YWx1 YXRpb24KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1 NzI3OAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9EZWJ1Z2dlclNpZGViYXJQYW5lbC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0RlYnVnZ2VyU2lkZWJhclBhbmVsLmpzCmluZGV4IDNjY2FiMDRlLi5l MDg3MjIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9EZWJ1Z2dlclNpZGViYXJQYW5lbC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9EZWJ1Z2dlclNpZGViYXJQYW5lbC5qcwpAQCAtNDUxLDYgKzQ1 MSwxMCBAQCBXZWJJbnNwZWN0b3IuRGVidWdnZXJTaWRlYmFyUGFuZWwgPSBjbGFzcyBEZWJ1Z2dl clNpZGViYXJQYW5lbCBleHRlbmRzIFdlYkluc3BlYwogICAgICAgICBpZiAoIXNjcmlwdC51cmwg JiYgIXNjcmlwdC5zb3VyY2VVUkwpCiAgICAgICAgICAgICByZXR1cm4gbnVsbDsKIAorICAgICAg ICAvLyBJbiBnZW5lcmFsLCBkbyBub3Qgc2hvdyBkeW5hbWljYWxseSBhZGRlZCBzY3JpcHQgZWxl bWVudHMuCisgICAgICAgIGlmIChzY3JpcHQuZHluYW1pY2FsbHlBZGRlZFNjcmlwdEVsZW1lbnQp CisgICAgICAgICAgICByZXR1cm4gbnVsbDsKKwogICAgICAgICAvLyBEb24ndCBhZGQgYnJlYWtw b2ludHMgaWYgdGhlIHNjcmlwdCBpcyByZXByZXNlbnRlZCBieSBhIFJlc291cmNlLiBUaGV5IHdl cmUKICAgICAgICAgLy8gYWxyZWFkeSBhZGRlZCBieSBfcmVzb3VyY2VBZGRlZC4KICAgICAgICAg aWYgKHNjcmlwdC5yZXNvdXJjZSkK 277949 2016-05-02 17:19:29 -0700 2016-05-02 18:33:57 -0700 [PATCH] For Landing script-element-2.patch text/plain 1696 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGU4MGY0MGIuLjFlMTcwZDMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE2LTA1LTAyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVW5leHBl Y3RlZCAiU2NyaXB0IEVsZW1lbnQgIyIgcmVzb3VyY2VzIGluIERlYnVnZ2VyIFNpZGViYXIKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NzI4MAorCisg ICAgICAgIFJldmlld2VkIGJ5IFRpbW90aHkgSGF0Y2hlci4KKworICAgICAgICAqIFVzZXJJbnRl cmZhY2UvVmlld3MvRGVidWdnZXJTaWRlYmFyUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuRGVidWdnZXJTaWRlYmFyUGFuZWwucHJvdG90eXBlLl9hZGRTY3JpcHQpOgorICAgICAgICBE b24ndCBpbmNsdWRlIFNjcmlwdCBFbGVtZW50IHJlc291cmNlcyBpbiB0aGUgZGVidWdnZXIgc2lk ZWJhciBieSBkZWZhdWx0LgorCisyMDE2LTA1LTAyICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFy b0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogUHJlZmVyICJDb25zb2xlIEV2 YWx1YXRpb24iIHRvICJFdmFsIENvZGUiIGlmIHdlIGtub3cgaXQgd2FzIGEgY29uc29sZSBldmFs dWF0aW9uCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NTcyNzgKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvRGVidWdnZXJTaWRlYmFyUGFuZWwuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9EZWJ1Z2dlclNpZGViYXJQYW5lbC5qcwppbmRleCAzY2NhYjA0ZS4u NTA2NTNiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvRGVidWdnZXJTaWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvRGVidWdnZXJTaWRlYmFyUGFuZWwuanMKQEAgLTQ1MSw2ICs0 NTEsMTAgQEAgV2ViSW5zcGVjdG9yLkRlYnVnZ2VyU2lkZWJhclBhbmVsID0gY2xhc3MgRGVidWdn ZXJTaWRlYmFyUGFuZWwgZXh0ZW5kcyBXZWJJbnNwZWMKICAgICAgICAgaWYgKCFzY3JpcHQudXJs ICYmICFzY3JpcHQuc291cmNlVVJMKQogICAgICAgICAgICAgcmV0dXJuIG51bGw7CiAKKyAgICAg ICAgLy8gSW4gZ2VuZXJhbCwgZG8gbm90IHNob3cgZHluYW1pY2FsbHkgYWRkZWQgc2NyaXB0IGVs ZW1lbnRzLgorICAgICAgICBpZiAoc2NyaXB0LmR5bmFtaWNhbGx5QWRkZWRTY3JpcHRFbGVtZW50 ICYmICFzY3JpcHQuc291cmNlVVJMKQorICAgICAgICAgICAgcmV0dXJuIG51bGw7CisKICAgICAg ICAgLy8gRG9uJ3QgYWRkIGJyZWFrcG9pbnRzIGlmIHRoZSBzY3JpcHQgaXMgcmVwcmVzZW50ZWQg YnkgYSBSZXNvdXJjZS4gVGhleSB3ZXJlCiAgICAgICAgIC8vIGFscmVhZHkgYWRkZWQgYnkgX3Jl c291cmNlQWRkZWQuCiAgICAgICAgIGlmIChzY3JpcHQucmVzb3VyY2UpCg==