157272 2016-05-02 12:12:08 -0700 DataDetector underline color should be based on the text color 2016-05-07 19:07:01 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sam sam oldest_to_newest 1189465 0 sam 2016-05-02 12:12:08 -0700 DataDetector underline color should be based on the text color 1189466 1 277921 sam 2016-05-02 12:16:42 -0700 Created attachment 277921 Patch 1189470 2 sam 2016-05-02 12:33:18 -0700 Landed in http://trac.webkit.org/changeset/200331. 1190996 3 277921 ap 2016-05-07 19:07:01 -0700 Comment on attachment 277921 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277921&action=review > Source/WebCore/ChangeLog:6 > + Fixes: Two bugs fixed, but no test case? 277921 2016-05-02 12:16:42 -0700 2016-05-02 12:31:24 -0700 Patch bug-157272-20160502121719.patch text/plain 2946 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMDMzMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE2LTA1LTAyICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRGF0YURldGVjdG9yIHVuZGVybGluZSBj b2xvciBzaG91bGQgYmUgYmFzZWQgb24gdGhlIHRleHQgY29sb3IKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NzI3MgorCisgICAgICAgIEZpeGVzOgor ICAgICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI1NjYzOTMwPiBEYXRhRGV0ZWN0b3JzIGxpbmtz IHNob3VsZCB1c2UgdGhlIGRlZmF1bHQgdGV4dCBjb2xvciBmb3IgdGhlaXIgcGFyZW50IG5vZGVz CisgICAgICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjU2NjM5ODM+IERhdGFEZXRlY3RvcnMgbGlu a3MgdW5kZXJsaW5lIGNvbG9yIHVwZGF0ZQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogZWRpdGluZy9jb2NvYS9EYXRhRGV0ZWN0aW9uLm1tOgorICAg ICAgICAoV2ViQ29yZTo6RGF0YURldGVjdGlvbjo6ZGV0ZWN0Q29udGVudEluUmFuZ2UpOgorICAg ICAgICBXaGVuIHVzaW5nIGxpZ2h0IGxpbmtzLCB1c2UgdGhlIGNvbG9yIG9mIHRoZSBwYXJlbnQg ZWxlbWVudCBhcyB0aGUgdGV4dCBjb2xvciwgYW5kIHRoYXQgc2FtZSBjb2xvciB3aXRoCisgICAg ICAgIDIwJSBhbHBoYSBhcyB0aGUgdW5kZXJsaW5lIGNvbG9yLgorCiAyMDE2LTA1LTAxICBSeW9z dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIGRvY3VtZW50LmN1cnJlbnRT Y3JpcHQgbXVzdCBiZSBudWxsIHdoZW4gd2UncmUgZXhlY3V0aW5nIGEgc2NyaXB0IGluc2lkZSBh IHNoYWRvdyB0cmVlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL2NvY29hL0RhdGFEZXRl Y3Rpb24ubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZWRpdGluZy9jb2NvYS9EYXRh RGV0ZWN0aW9uLm1tCShyZXZpc2lvbiAyMDAzMjkpCisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5n L2NvY29hL0RhdGFEZXRlY3Rpb24ubW0JKHdvcmtpbmcgY29weSkKQEAgLTUzLDggKzUzLDYgQEAK ICNpbXBvcnQgPFdlYktpdEFkZGl0aW9ucy9EYXRhRGV0ZWN0b3JzQWRkaXRpb25zLmg+CiAjZW5k aWYKIAotY29uc3QgY2hhciogZGF0YURldGVjdG9yc0xpbmtTdHlsZSA9ICItd2Via2l0LXRleHQt ZGVjb3JhdGlvbi1jb2xvcjpyZ2IoMTk5LCAxOTksIDIwNCk7IGNvbG9yOmluaXRpYWw7IjsKLQog bmFtZXNwYWNlIFdlYkNvcmUgewogCiB1c2luZyBuYW1lc3BhY2UgSFRNTE5hbWVzOwpAQCAtNjM1 LDkgKzYzMywxOSBAQCBOU0FycmF5ICpEYXRhRGV0ZWN0aW9uOjpkZXRlY3RDb250ZW50SW5SCiAg ICAgICAgICAgICBSZWY8SFRNTEFuY2hvckVsZW1lbnQ+IGFuY2hvckVsZW1lbnQgPSBIVE1MQW5j aG9yRWxlbWVudDo6Y3JlYXRlKGRvY3VtZW50KTsKICAgICAgICAgICAgIGFuY2hvckVsZW1lbnQt PnNldEhyZWYoY29ycmVzcG9uZGluZ1VSTCk7CiAgICAgICAgICAgICBhbmNob3JFbGVtZW50LT5z ZXREaXIoImx0ciIpOwotICAgICAgICAgICAgaWYgKHNob3VsZFVzZUxpZ2h0TGlua3MpCi0gICAg ICAgICAgICAgICAgYW5jaG9yRWxlbWVudC0+c2V0QXR0cmlidXRlKHN0eWxlQXR0ciwgZGF0YURl dGVjdG9yc0xpbmtTdHlsZSk7Ci0gICAgICAgICAgICBlbHNlIGlmIChpczxTdHlsZWRFbGVtZW50 PigqcGFyZW50Tm9kZSkpIHsKKyAgICAgICAgICAgIGlmIChzaG91bGRVc2VMaWdodExpbmtzKSB7 CisgICAgICAgICAgICAgICAgZG9jdW1lbnQudXBkYXRlU3R5bGVJZk5lZWRlZCgpOworICAgICAg ICAgICAgICAgIGF1dG8qIHJlbmRlclN0eWxlID0gcGFyZW50Tm9kZS0+Y29tcHV0ZWRTdHlsZSgp OworICAgICAgICAgICAgICAgIGlmIChyZW5kZXJTdHlsZSkgeworICAgICAgICAgICAgICAgICAg ICBhdXRvIHRleHRDb2xvciA9IHJlbmRlclN0eWxlLT52aXNpdGVkRGVwZW5kZW50Q29sb3IoQ1NT UHJvcGVydHlDb2xvcik7CisgICAgICAgICAgICAgICAgICAgIGlmICh0ZXh0Q29sb3IuaXNWYWxp ZCgpKSB7CisgICAgICAgICAgICAgICAgICAgICAgICBhdXRvIHVuZGVybGluZUNvbG9yID0gQ29s b3IoY29sb3JXaXRoT3ZlcnJpZGVBbHBoYSh0ZXh0Q29sb3IucmdiKCksIDAuMikpOworCisgICAg ICAgICAgICAgICAgICAgICAgICBhbmNob3JFbGVtZW50LT5zZXRJbmxpbmVTdHlsZVByb3BlcnR5 KENTU1Byb3BlcnR5Q29sb3IsIHRleHRDb2xvci5jc3NUZXh0KCkpOworICAgICAgICAgICAgICAg ICAgICAgICAgYW5jaG9yRWxlbWVudC0+c2V0SW5saW5lU3R5bGVQcm9wZXJ0eShDU1NQcm9wZXJ0 eVdlYmtpdFRleHREZWNvcmF0aW9uQ29sb3IsIHVuZGVybGluZUNvbG9yLmNzc1RleHQoKSk7Cisg ICAgICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICB9IGVs c2UgaWYgKGlzPFN0eWxlZEVsZW1lbnQ+KCpwYXJlbnROb2RlKSkgewogICAgICAgICAgICAgICAg IGlmIChhdXRvKiBzdHlsZSA9IGRvd25jYXN0PFN0eWxlZEVsZW1lbnQ+KCpwYXJlbnROb2RlKS5w cmVzZW50YXRpb25BdHRyaWJ1dGVTdHlsZSgpKSB7CiAgICAgICAgICAgICAgICAgICAgIFN0cmlu ZyBjb2xvciA9IHN0eWxlLT5nZXRQcm9wZXJ0eVZhbHVlKENTU1Byb3BlcnR5Q29sb3IpOwogICAg ICAgICAgICAgICAgICAgICBpZiAoIWNvbG9yLmlzRW1wdHkoKSkK