157261 2016-05-02 02:41:01 -0700 Fix the Mac cmake clean build issue 2016-09-01 20:01:17 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy webkit-unassigned achristensen commit-queue darin dino fujii ossy rafaelff sam simon.fraser youennf oldest_to_newest 1189357 0 ossy 2016-05-02 02:41:01 -0700 clean build: https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/4733 error: ... [ 0%] Generating ../../DerivedSources/ForwardingHeaders/JavaScriptCore/Scripts/inline-and-minify-stylesheets-and-scripts.py make[2]: *** No rule to make target `DerivedSources/ForwardingHeaders/JavaScriptCore/Scripts/inline-and-minify-stylesheets-and-scripts.py', needed by `DerivedSources/WebCore/InspectorOverlayPage.h'. Stop. make[2]: *** Waiting for unfinished jobs.... [ 0%] Generating ../../DerivedSources/WebCore/CharsetData.cpp [ 0%] Generating ../../DerivedSources/ForwardingHeaders/JavaScriptCore/Scripts/jsmin.py make[1]: *** [Source/WebCore/CMakeFiles/WebCoreDerivedSources.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs.... ... 1223036 1 ossy 2016-08-25 05:52:56 -0700 this bug is still valid: https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/7808 1225295 2 287610 fujii 2016-09-01 01:54:38 -0700 Created attachment 287610 Patch 1225318 3 287610 mcatanzaro 2016-09-01 07:08:06 -0700 Comment on attachment 287610 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=287610&action=review > Source/WebCore/CMakeLists.txt:3870 > +add_dependencies(WebCoreDerivedSources JavaScriptCore) I wonder if we're missing this dependency anywhere else? 1225324 4 287610 commit-queue 2016-09-01 07:56:50 -0700 Comment on attachment 287610 Patch Clearing flags on attachment: 287610 Committed r205291: <http://trac.webkit.org/changeset/205291> 1225325 5 commit-queue 2016-09-01 07:56:54 -0700 All reviewed patches have been landed. Closing bug. 1225339 6 ysuzuki 2016-09-01 09:24:36 -0700 *** Bug 158852 has been marked as a duplicate of this bug. *** 1225669 7 fujii 2016-09-01 20:01:17 -0700 Thank you for reviewing my patch. (In reply to comment #3) > I wonder if we're missing this dependency anywhere else? This missing dependency problem can be reproduced with like following steps: 1) rm -rf WebKitBuild/Debug 2) ./Tools/Scripts/build-webkit --gtk --64-bit --debug 3) Ctrl-C to abort build after CMake finished. 4) ninja-build -C WebKitBuild/Debug WebCoreDerivedSources 5) Build fails 287610 2016-09-01 01:54:38 -0700 2016-09-01 07:56:50 -0700 Patch bug-157261-20160901015223.patch text/plain 1400 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjA1MTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGQwZjE4NzBlNDkxY2Uw ZjU4MmM3YmIyZTExM2M5ZGY4MjBhMGQ4NS4uZDE1ZjQ4MTNiMmMxNDg0MDA0YzAwZWU5MmJiZDNi NmZmMjA5NzNkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA5LTAxICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIEZpeCB0aGUg TWFjIGNtYWtlIGNsZWFuIGJ1aWxkIGlzc3VlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNTcyNjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBCdWlsZGluZyBXZWJDb3JlRGVyaXZlZFNvdXJjZXMgdGFyZ2V0 IGZhaWxlZCBkdWUgdG8gdGhlIHJhY2UKKyAgICAgICAgY29uZGl0aW9uIHdpdGggYnVpbGRpbmcg Rm9yd2FyZGluZ0hlYWRlcnMgb2YgSmF2YVNjcmlwdENvcmUuCisKKyAgICAgICAgKiBDTWFrZUxp c3RzLnR4dDogTWFrZSBXZWJDb3JlRGVyaXZlZFNvdXJjZXMgZGVwZW5kcyBvbiBKYXZhU2NyaXB0 Q29yZS4KKwogMjAxNi0wOC0yOSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJr aXQub3JnPgogCiAgICAgICAgIEZpeCBXaW5kb3dzIGJ1aWxkIGFmdGVyIHIyMDUxNjEKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dlYkNvcmUvQ01h a2VMaXN0cy50eHQKaW5kZXggNmY0ZDA4Y2QwNTFhMTg5ZTI1OWE1MTllZmNkOTE0NjUxZDAwZDVi Ni4uNThhZTY2NmJhMDE1NDczNmM2YzQxYjQzY2MzMDhjMWZjNDgzYzE2NyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dlYkNvcmUvQ01ha2VM aXN0cy50eHQKQEAgLTM4NjcsNiArMzg2Nyw3IEBAIGVuZGlmICgpCiAjIGZpbGVzIG9uIE9TIFgu CiBhZGRfbGlicmFyeShXZWJDb3JlRGVyaXZlZFNvdXJjZXMgU1RBVElDICR7V2ViQ29yZV9ERVJJ VkVEX1NPVVJDRVN9KQogc2V0X3RhcmdldF9wcm9wZXJ0aWVzKFdlYkNvcmVEZXJpdmVkU291cmNl cyBQUk9QRVJUSUVTIE9VVFBVVF9OQU1FIFdlYkNvcmVEZXJpdmVkU291cmNlcyR7REVCVUdfU1VG RklYfSkKK2FkZF9kZXBlbmRlbmNpZXMoV2ViQ29yZURlcml2ZWRTb3VyY2VzIEphdmFTY3JpcHRD b3JlKQogaWYgKE5PVCBXSU4zMikKICAgICBsaXN0KEFQUEVORCBXZWJDb3JlX0xJQlJBUklFUyBX ZWJDb3JlRGVyaXZlZFNvdXJjZXMpCiBlbmRpZiAoKQo=