15725 2007-10-27 20:37:34 -0700 [GTK] WebCore.pro header dependencies are incorrect 2007-10-29 15:40:02 -0700 1 1 1 Unclassified WebKit New Bugs 523.x (Safari 3) All All RESOLVED FIXED Gtk P2 Normal --- 1 alp webkit-unassigned mrowe oldest_to_newest 59649 0 alp 2007-10-27 20:37:34 -0700 The list of header directories is incomplete, and there are still some 'gdk' paths from before the port was renamed. This leads to failed builds and having to "make clean" quite often. 59650 1 16907 alp 2007-10-27 20:38:30 -0700 Created attachment 16907 Fix header dependencies in the build system INCLUDEPATH and DEPENDPATH are now up to date. --- WebCore/WebCore.pro | 37 ++++++++++++++++++++++++++----------- 1 files changed, 26 insertions(+), 11 deletions(-) 59651 2 alp 2007-10-27 21:22:30 -0700 (In reply to comment #1) > Created an attachment (id=16907) [edit] > Fix header dependencies in the build system > > > INCLUDEPATH and DEPENDPATH are now up to date. > --- > WebCore/WebCore.pro | 37 ++++++++++++++++++++++++++----------- > 1 files changed, 26 insertions(+), 11 deletions(-) > Addendum: diff --git a/WebCore/WebCore.pro b/WebCore/WebCore.pro index 271f296..7f5c0ff 100644 --- a/WebCore/WebCore.pro +++ b/WebCore/WebCore.pro @@ -131,6 +131,7 @@ INCLUDEPATH += $$PWD \ $$PWD/.. \ $$PWD/../JavaScriptCore/kjs \ $$PWD/../JavaScriptCore/bindings \ + $$PWD/../JavaScriptCore/wtf \ $$PWD/platform \ $$PWD/platform/network \ $$PWD/platform/graphics \ 59655 3 16907 aroben 2007-10-27 22:17:21 -0700 Comment on attachment 16907 Fix header dependencies in the build system r=me 59688 4 mrowe 2007-10-28 03:42:24 -0700 Alp, does this completely fix the problem or does it just improve the situation? 59703 5 alp 2007-10-28 11:18:51 -0700 Much improved, but I ended up with a crashy build and had to do a "make clean" earlier today, possibly following recent JSCore changes. 59811 6 alp 2007-10-29 15:40:02 -0700 Landed in r27234. Closing this bug, though not convinced all possible dependency issues are solved. 16907 2007-10-27 20:38:30 -0700 2007-10-27 22:17:21 -0700 Fix header dependencies in the build system -Fix-header-dependencies-in-the-build-system.patch text/plain 1810 alp Y2EzOTMzMjI4NDlmOTAzYTk0MTg3OWFiZTVjMjlmNDkwMjFhNDgxYQpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9XZWJDb3JlLnBybyBiL1dlYkNvcmUvV2ViQ29yZS5wcm8KaW5kZXggNTEwYzg4Zi4uMmJh MDdjMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9XZWJDb3JlLnBybworKysgYi9XZWJDb3JlL1dlYkNv cmUucHJvCkBAIC05MiwyMyArOTIsMzggQEAgREVQRU5EUEFUSCArPSBlZGl0aW5nL3F0IGhpc3Rv cnkvcXQgbG9hZGVyL3F0IHBhZ2UvcXQgXAogCiBndGstcG9ydCB7CiAgICAgSU5DTFVERVBBVEgg Kz0gXAorICAgICQkUFdEL3BsYXRmb3JtL2d0ayBcCisgICAgJCRQV0QvcGxhdGZvcm0vZ3JhcGhp Y3MvZ3RrIFwKKyAgICAkJFBXRC9wbGF0Zm9ybS9ncmFwaGljcy9jYWlybyBcCiAgICAgJCRQV0Qv cGxhdGZvcm0vZ3JhcGhpY3Mvc3ZnL2NhaXJvIFwKKyAgICAkJFBXRC9wbGF0Zm9ybS9uZXR3b3Jr L2N1cmwgXAogICAgICQkUFdEL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2JtcCBcCiAgICAgJCRQ V0QvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvZ2lmIFwKICAgICAkJFBXRC9wbGF0Zm9ybS9pbWFn ZS1kZWNvZGVycy9pY28gXAogICAgICQkUFdEL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2pwZWcg XAogICAgICQkUFdEL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL3BuZyBcCi0gICAgJCRQV0QvcGxh dGZvcm0vaW1hZ2UtZGVjb2RlcnMveGJtCi0KLSAgICBERVBFTkRQQVRIICs9IHBsYXRmb3JtL2dy YXBoaWNzL2dkayAgICAgICBcCi0gICAgICAgICAgICAgICAgICBwbGF0Zm9ybS9nZGsgICAgICAg ICAgICAgICAgXAotICAgICAgICAgICAgICAgICAgbG9hZGVyL2dkayAgICAgICAgICAgICAgICAg IFwKLSAgICAgICAgICAgICAgICAgIHBhZ2UvZ2RrICAgICAgICAgICAgICAgICAgICBcCi0gICAg ICAgICAgICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9jYWlybyAgICAgXAotICAgICAgICAgICAg ICAgICAgcGxhdGZvcm0vZ3JhcGhpY3Mvc3ZnL2NhaXJvIFwKLSAgICAgICAgICAgICAgICAgIHBs YXRmb3JtL25ldHdvcmsvY3VybCAgICAgICBcCi0gICAgICAgICAgICAgICAgICAuLi9XZWJLaXQv Z3RrL0FwaSAgICAgICAgICAgXAotICAgICAgICAgICAgICAgICAgLi4vV2ViS2l0L2d0ay9XZWJD b3JlU3VwcG9ydAorICAgICQkUFdEL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL3hibSBcCisgICAg JCRQV0QvbG9hZGVyL2d0ayBcCisgICAgJCRQV0QvcGFnZS9ndGsgXAorICAgICQkUFdELy4uL1dl YktpdC9ndGsvV2ViQ29yZVN1cHBvcnQgXAorICAgICQkUFdELy4uL1dlYktpdC9ndGsvQXBpCisK KyAgICBERVBFTkRQQVRIICs9IFwKKyAgICBwbGF0Zm9ybS9ndGsgXAorICAgIHBsYXRmb3JtL2dy YXBoaWNzL2d0ayBcCisgICAgcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8gXAorICAgIHBsYXRmb3Jt L2dyYXBoaWNzL3N2Zy9jYWlybyBcCisgICAgcGxhdGZvcm0vbmV0d29yay9jdXJsIFwKKyAgICBw bGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9ibXAgXAorICAgIHBsYXRmb3JtL2ltYWdlLWRlY29kZXJz L2dpZiBcCisgICAgcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvaWNvIFwKKyAgICBwbGF0Zm9ybS9p bWFnZS1kZWNvZGVycy9qcGVnIFwKKyAgICBwbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9wbmcgXAor ICAgIHBsYXRmb3JtL2ltYWdlLWRlY29kZXJzL3hibSBcCisgICAgbG9hZGVyL2d0ayBcCisgICAg cGFnZS9ndGsgXAorICAgIC4uL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQgXAorICAgIC4uL1dl YktpdC9ndGsvQXBpCiB9CiAKIElOQ0xVREVQQVRIICs9ICAkJFBXRCBcCg==