157240 2016-04-30 18:00:52 -0700 Web Inspector: Can't resume Debugger after breaking on exception in Promise 2016-05-19 23:31:05 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy joepeck bburg commit-queue graouts joepeck mark.lam mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1189148 0 timothy 2016-04-30 18:00:52 -0700 Steps: 1) Enable break on All Exceptions 2) Run this code in the console from bug 156114: crypto.webkitSubtle.generateKey({ name: "RSA-OAEP", modulusLength: 2048, publicExponent: new Uint8Array([0x01, 0x00, 0x01]), hash: {name: "SHA-256"} }, true, ["encrypt", "decrypt" ]).then((keypair) => { console.log("Generated Key Pair:", keypair); return crypto.webkitSubtle.exportKey("jwk", keypair.publicKey); }).then((keydata) => { console.log("Key Data:", keydata); }).catch((error) => { console.log("Error: ", error); }); 3) It should stop on the return line with an exception 4) Try to continue 5) console.log should be logged with the error from the Promise catch 6) Still appear paused, try to continue Results: Appears to stay paused, but it does resume. Error is logged when inspecting Inspector: [Error] DebuggerManager.resume failed: – Error: Can only perform operation while paused. Error: Can only perform operation while paused. _dispatchResponseToPromise — InspectorBackend.js:307 _dispatchResponse — InspectorBackend.js:272 dispatch — InspectorBackend.js:149 dispatchNextQueuedMessageFromBackend — MessageDispatcher.js:42 (anonymous function) (DebuggerManager.js:194) promiseReactionJob 1189149 1 webkit-bug-importer 2016-04-30 18:01:47 -0700 <rdar://problem/26030890> 1189150 2 timothy 2016-04-30 18:06:35 -0700 You might also need to click continue a couple times to get the console.log to appear. Then further continues will log the error in the Inspector. We need to make sure the debugger UI never gets out of sync with the backend, which is what appears to be happening here. You can use the Inspector when it is in this state, but a developer will think the page is still pauses and will be confused. 1194107 3 mark.lam 2016-05-17 19:09:22 -0700 The issue is due to the DebuggerManager not resuming the backend when it resumed the front end: In the test case, a Promise throws an exception on rejection. Since this is in builtin code, the DebuggerManager detects that there are no active frames on the stack, and chooses to resume the front-end. Unfortunately, it did not resume the back end as well. As a result, the backend sits in its event loop perpetually. A patch with the fix is coming shortly. 1194397 4 mark.lam 2016-05-18 13:10:56 -0700 (In reply to comment #3) > The issue is due to the DebuggerManager not resuming the backend when it > resumed the front end: > > In the test case, a Promise throws an exception on rejection. Since this is > in builtin code, the DebuggerManager detects that there are no active frames > on the stack, and chooses to resume the front-end. Unfortunately, it did > not resume the back end as well. As a result, the backend sits in its event > loop perpetually. > > A patch with the fix is coming shortly. Correction: there's more to this than what we thought above. With the explicit call to the resume the backend, the backend does get resumed. However, the front end still looks like it is stopped on a breakpoint. 1194400 5 mark.lam 2016-05-18 13:32:10 -0700 Joe suggested, for a test, that I change the bail check at the top of DebuggerManager's _didResumeInternal() to "if (!this._paused) return". With that plus the explicit call to DebuggerAgent.resume() added to debuggerDidPause(), the issue appears to be resolved. That said, I'm not sure that this is the proper fix though. Sending this bug over to Joe since the bug appears to be at the Inspector level. 1195091 6 279467 joepeck 2016-05-19 22:12:40 -0700 Created attachment 279467 [PATCH] Proposed Fix 1195102 7 279467 commit-queue 2016-05-19 23:31:00 -0700 Comment on attachment 279467 [PATCH] Proposed Fix Clearing flags on attachment: 279467 Committed r201211: <http://trac.webkit.org/changeset/201211> 1195103 8 commit-queue 2016-05-19 23:31:05 -0700 All reviewed patches have been landed. Closing bug. 279467 2016-05-19 22:12:40 -0700 2016-05-19 23:31:00 -0700 [PATCH] Proposed Fix pause-fix.patch text/plain 2814 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDVkZjMwM2UuLmIxZDg3NTcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDE2LTA1LTE5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ2FuJ3Qg cmVzdW1lIERlYnVnZ2VyIGFmdGVyIGJyZWFraW5nIG9uIGV4Y2VwdGlvbiBpbiBQcm9taXNlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTcyNDAKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI2MDMwODkwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIElmIHdlIHBhdXNlIGJ1dCBoYXZlIG5vIHNvdXJjZSBj b2RlIHRvIHNob3cgd2UgcGF1c2VkIGluIHB1cmVseSBpbnRlcm5hbAorICAgICAgICBjb2RlLiBJ biBzdWNoIGNhc2VzIHdlIHdlcmUgYXR0ZW1wdGluZyB0byByZXN1bWUgd2l0aG91dCBhY3R1YWxs eQorICAgICAgICB0ZWxsaW5nIHRoZSBiYWNrZW5kIHRvIHJlc3VtZSwgc28gdGhlIGJhY2tlbmQg YW5kIGZyb250ZW5kIHdlcmUgb3V0IG9mCisgICAgICAgIHN5bmMuIFRoZSBmcm9udGVuZCB0aGlu a2luZyBpdCBpcyAicGF1c2VkIiB3aXRob3V0IGFuIGFjdGl2ZUNhbGxGcmFtZQorICAgICAgICBh bmQgdGhlIGJhY2tlbmQgYWN0dWFsbHkgYmVpbmcgcGF1c2VkLgorCisgICAgICAgIFRoaXMgY2hh bmdlIG1vcmUgZ3JhY2VmdWxseSBoYW5kbGVzIHRoaXMgc2l0dWF0aW9uLiBJdCBhY3R1YWxseSBy ZXN1bWVzCisgICAgICAgIGJvdGggdGhlIGZyb250ZW5kIGFuZCB0aGUgYmFja2VuZC4KKworICAg ICAgICAqIFVzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRGVidWdnZXJNYW5hZ2VyLmpzOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLkRlYnVnZ2VyTWFuYWdlci5wcm90b3R5cGUuZGVidWdnZXJEaWRQ YXVzZSk6CisgICAgICAgIFJlc3VtZSB0aGUgYmFja2VuZCBhbmQgdGhlIGZyb250ZW5kLgorCisg ICAgICAgIChXZWJJbnNwZWN0b3IuRGVidWdnZXJNYW5hZ2VyLnByb3RvdHlwZS5fZGlkUmVzdW1l SW50ZXJuYWwpOgorICAgICAgICBEb24ndCBsb29rIGF0IHRoZSBhY3RpdmUgY2FsbCBmcmFtZSwg bG9vayBhdCB0aGUgcGF1c2VkIHN0YXRlLgorICAgICAgICBUaGlzIG1heSBpc3N1ZSBhIFJlc3Vt ZWQgZXZlbnQgd2l0aG91dCBhY3R1YWxseSB0cmlnZ2VyaW5nIGEKKyAgICAgICAgUGF1c2VkIGV2 ZW50IGlmIHRoaXMgd2FzIHRoZSBvbmx5IHBhdXNlLCBidXQgdGhhdCBpcyBoYXJtbGVzcy4KKwog MjAxNi0wNS0xOSAgTmlraXRhIFZhc2lseWV2ICA8bnZhc2lseWV2QGFwcGxlLmNvbT4KIAogICAg ICAgICBSRUdSRVNTSU9OIChyMTg5Mzg1KTogV2ViIEluc3BlY3RvcjogQ1NTIHByb3BlcnRpZXMg bW9kaWZpZWQgdmlhIEpTIGRvbid0IHVwZGF0ZSBpbiB0aGUgU3R5bGVzIHNpZGViYXIKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0Rl YnVnZ2VyTWFuYWdlci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Nv bnRyb2xsZXJzL0RlYnVnZ2VyTWFuYWdlci5qcwppbmRleCBkYTViYjA2Li5lMzhmZWM1IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9E ZWJ1Z2dlck1hbmFnZXIuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvQ29udHJvbGxlcnMvRGVidWdnZXJNYW5hZ2VyLmpzCkBAIC01MjEsNyArNTIxLDkgQEAgV2Vi SW5zcGVjdG9yLkRlYnVnZ2VyTWFuYWdlciA9IGNsYXNzIERlYnVnZ2VyTWFuYWdlciBleHRlbmRz IFdlYkluc3BlY3Rvci5PYmplY3QKICAgICAgICAgdGhpcy5fYWN0aXZlQ2FsbEZyYW1lID0gdGhp cy5fY2FsbEZyYW1lc1swXTsKIAogICAgICAgICBpZiAoIXRoaXMuX2FjdGl2ZUNhbGxGcmFtZSkg ewotICAgICAgICAgICAgY29uc29sZS53YXJuKCJXZSBzaG91bGQgYWx3YXlzIGhhdmUgb25lIGNh bGwgZnJhbWUuIFRoaXMgY291bGQgaW5kaWNhdGUgd2UgYXJlIGhpdHRpbmcgYW4gZXhjZXB0aW9u IG9yIGRlYnVnZ2VyIHN0YXRlbWVudCBpbiBhbiBpbnRlcm5hbCBpbmplY3RlZCBzY3JpcHQuIik7 CisgICAgICAgICAgICAvLyBUaGlzIGluZGljYXRlcyB3ZSB3ZXJlIHBhdXNpbmcgaW4gaW50ZXJu YWwgc2NyaXB0cyBvbmx5IChJbmplY3RlZCBTY3JpcHRzLCBidWlsdC1pbnMpLgorICAgICAgICAg ICAgLy8gSnVzdCByZXN1bWUgYW5kIHNraXAgcGFzdCB0aGlzIHBhdXNlLgorICAgICAgICAgICAg RGVidWdnZXJBZ2VudC5yZXN1bWUoKTsKICAgICAgICAgICAgIHRoaXMuX2RpZFJlc3VtZUludGVy bmFsKCk7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KQEAgLTkxNiw3ICs5MTgsNyBA QCBXZWJJbnNwZWN0b3IuRGVidWdnZXJNYW5hZ2VyID0gY2xhc3MgRGVidWdnZXJNYW5hZ2VyIGV4 dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogCiAgICAgX2RpZFJlc3VtZUludGVybmFsKCkKICAg ICB7Ci0gICAgICAgIGlmICghdGhpcy5fYWN0aXZlQ2FsbEZyYW1lKQorICAgICAgICBpZiAoIXRo aXMuX3BhdXNlZCkKICAgICAgICAgICAgIHJldHVybjsKIAogICAgICAgICBpZiAodGhpcy5fZGVs YXllZFJlc3VtZVRpbWVvdXQpIHsK