157234 2016-04-30 09:58:16 -0700 Web Inspector: Zooming of docked Web Inspector affects the webpage, but reset to 0 does not 2016-05-02 12:46:32 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1189058 0 timothy 2016-04-30 09:58:16 -0700 Zooming to max zoom will start zooming the page instead of the inspector. We should prevent default in all cases to avoid that and add explicit beeps when max/min is hit. <rdar://problem/25966010> 1189059 1 webkit-bug-importer 2016-04-30 09:58:30 -0700 <rdar://problem/26027177> 1189060 2 277810 timothy 2016-04-30 10:02:18 -0700 Created attachment 277810 Patch 1189061 3 timothy 2016-04-30 10:02:59 -0700 <rdar://problem/25966010> 1189442 4 277810 bburg 2016-05-02 11:33:55 -0700 Comment on attachment 277810 Patch r=me 1189472 5 277810 commit-queue 2016-05-02 12:46:28 -0700 Comment on attachment 277810 Patch Clearing flags on attachment: 277810 Committed r200332: <http://trac.webkit.org/changeset/200332> 1189473 6 commit-queue 2016-05-02 12:46:32 -0700 All reviewed patches have been landed. Closing bug. 277810 2016-04-30 10:02:18 -0700 2016-05-02 12:46:28 -0700 Patch bug-157234-20160430100253.patch text/plain 3500 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwMjY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA3 Njg5M2ViNjRmY2IyMWM0OGQ0Yjk4MTE3NmRiZjBkOWNkZDEwZjljLi40MzVlNTA4YzY4ZGRkNjFk YTI1NDI4ZDMwMjVjMTBmZDgxMTY4YmE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNi0wNC0zMCAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogWm9vbWluZyBvZiBkb2NrZWQgV2ViIEluc3Bl Y3RvciBhZmZlY3RzIHRoZSB3ZWJwYWdlLCBidXQgcmVzZXQgdG8gMCBkb2VzIG5vdAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3MjM0CisgICAgICAg IHJkYXI6Ly9wcm9ibGVtLzI2MDI3MTc3CisKKyAgICAgICAgQWx3YXlzIHByZXZlbnQgZGVmYXVs dCBmb3IgdGhlIHpvb20ga2V5Ym9hcmQgc2hvcnRjdXRzIHRvIGF2b2lkIHBhc3NpbmcgdGhlIGV2 ZW50IGJhY2sgdG8KKyAgICAgICAgU2FmYXJpIHRvIGhhbmRsZSBhbmQgYWRkIGV4cGxpY2l0IGJl ZXBzIHdoZW4gbWF4L21pbiBpcyBoaXQuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qczoKKyAgICAgICAg KFdlYkluc3BlY3Rvci5jb250ZW50TG9hZGVkKTogUmVtb3ZlZCBzZXR0aW5nIGltcGxpY2l0bHlQ cmV2ZW50c0RlZmF1bHQgb24gem9vbSBrZXlib2FyZCBzaG9ydGN1dHMuCisgICAgICAgIChXZWJJ bnNwZWN0b3IuX2luY3JlYXNlWm9vbSk6IEFkZCBleHBsaWNpdCBiZWVwIGFuZCByZW1vdmUgcHJl dmVudERlZmF1bHQgY2FsbC4KKyAgICAgICAgKFdlYkluc3BlY3Rvci5fZGVjcmVhc2Vab29tKTog RGl0dG8uCisKIDIwMTYtMDQtMjkgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29t PgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFNjcm9sbGluZyBpbiBUaW1lbGluZXMgY2F1c2Vz IGZsYXNoaW5nIG9mIHRoZSBEYXRhR3JpZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCmluZGV4IGE1MzNlOWM2MTZkMzY3YjgwNGRhNTViZTA3 ZDFiNzIxODI5MmIxNmMuLmFiYmM5MzdkNGE0Y2JkODU1YTk3MTY3OWQxMzEwOWMxZjdlZmEyYTcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFp bi5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4u anMKQEAgLTI2Myw4ICsyNjMsNiBAQCBXZWJJbnNwZWN0b3IuY29udGVudExvYWRlZCA9IGZ1bmN0 aW9uKCkKIAogICAgIHRoaXMuX2luY3JlYXNlWm9vbUtleWJvYXJkU2hvcnRjdXQgPSBuZXcgV2Vi SW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQoV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQu TW9kaWZpZXIuQ29tbWFuZE9yQ29udHJvbCwgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQu S2V5LlBsdXMsIHRoaXMuX2luY3JlYXNlWm9vbS5iaW5kKHRoaXMpKTsKICAgICB0aGlzLl9kZWNy ZWFzZVpvb21LZXlib2FyZFNob3J0Y3V0ID0gbmV3IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0 Y3V0KFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVyLkNvbW1hbmRPckNvbnRy b2wsIFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0LktleS5NaW51cywgdGhpcy5fZGVjcmVh c2Vab29tLmJpbmQodGhpcykpOwotICAgIHRoaXMuX2luY3JlYXNlWm9vbUtleWJvYXJkU2hvcnRj dXQuaW1wbGljaXRseVByZXZlbnRzRGVmYXVsdCA9IHRoaXMuX2RlY3JlYXNlWm9vbUtleWJvYXJk U2hvcnRjdXQuaW1wbGljaXRseVByZXZlbnRzRGVmYXVsdCA9IGZhbHNlOwotCiAgICAgdGhpcy5f cmVzZXRab29tS2V5Ym9hcmRTaG9ydGN1dCA9IG5ldyBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9y dGN1dChXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5Db21tYW5kT3JDb250 cm9sLCAiMCIsIHRoaXMuX3Jlc2V0Wm9vbS5iaW5kKHRoaXMpKTsKIAogICAgIHRoaXMuX3Nob3dU YWJBdEluZGV4S2V5Ym9hcmRTaG9ydGN1dHMgPSBbMSwgMiwgMywgNCwgNSwgNiwgNywgOCwgOV0u bWFwKChpKSA9PiBuZXcgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQoV2ViSW5zcGVjdG9y LktleWJvYXJkU2hvcnRjdXQuTW9kaWZpZXIuQ29tbWFuZE9yQ29udHJvbCwgYCR7aX1gLCB0aGlz Ll9zaG93VGFiQXRJbmRleC5iaW5kKHRoaXMsIGkpKSk7CkBAIC0xOTYwLDEyICsxOTU4LDEzIEBA IFdlYkluc3BlY3Rvci5faW5jcmVhc2Vab29tID0gZnVuY3Rpb24oZXZlbnQpCiAgICAgY29uc3Qg ZXBzaWxvbiA9IDAuMDAwMTsKICAgICBjb25zdCBtYXhpbXVtWm9vbSA9IDIuNDsKICAgICBsZXQg Y3VycmVudFpvb20gPSB0aGlzLl96b29tRmFjdG9yKCk7Ci0gICAgaWYgKGN1cnJlbnRab29tICsg ZXBzaWxvbiA+PSBtYXhpbXVtWm9vbSkKKyAgICBpZiAoY3VycmVudFpvb20gKyBlcHNpbG9uID49 IG1heGltdW1ab29tKSB7CisgICAgICAgIEluc3BlY3RvckZyb250ZW5kSG9zdC5iZWVwKCk7CiAg ICAgICAgIHJldHVybjsKKyAgICB9CiAKICAgICBsZXQgbmV3Wm9vbSA9IE1hdGgubWluKG1heGlt dW1ab29tLCBjdXJyZW50Wm9vbSArIDAuMik7CiAgICAgdGhpcy5fc2V0Wm9vbUZhY3RvcihuZXda b29tKTsKLSAgICBldmVudC5wcmV2ZW50RGVmYXVsdCgpOwogfTsKIAogV2ViSW5zcGVjdG9yLl9k ZWNyZWFzZVpvb20gPSBmdW5jdGlvbihldmVudCkKQEAgLTE5NzMsMTIgKzE5NzIsMTMgQEAgV2Vi SW5zcGVjdG9yLl9kZWNyZWFzZVpvb20gPSBmdW5jdGlvbihldmVudCkKICAgICBjb25zdCBlcHNp bG9uID0gMC4wMDAxOwogICAgIGNvbnN0IG1pbmltdW1ab29tID0gMC42OwogICAgIGxldCBjdXJy ZW50Wm9vbSA9IHRoaXMuX3pvb21GYWN0b3IoKTsKLSAgICBpZiAoY3VycmVudFpvb20gLSBlcHNp bG9uIDw9IG1pbmltdW1ab29tKQorICAgIGlmIChjdXJyZW50Wm9vbSAtIGVwc2lsb24gPD0gbWlu aW11bVpvb20pIHsKKyAgICAgICAgSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmJlZXAoKTsKICAgICAg ICAgcmV0dXJuOworICAgIH0KIAogICAgIGxldCBuZXdab29tID0gTWF0aC5tYXgobWluaW11bVpv b20sIGN1cnJlbnRab29tIC0gMC4yKTsKICAgICB0aGlzLl9zZXRab29tRmFjdG9yKG5ld1pvb20p OwotICAgIGV2ZW50LnByZXZlbnREZWZhdWx0KCk7CiB9OwogCiBXZWJJbnNwZWN0b3IuX3Jlc2V0 Wm9vbSA9IGZ1bmN0aW9uKGV2ZW50KQo=