157217 2016-04-29 16:58:37 -0700 [JSC][ARMv7S] Arithmetic module results change when tiering up to DFG 2016-04-29 18:50:16 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1188877 0 benjamin 2016-04-29 16:58:37 -0700 [JSC][ARMv7S] Arithmetic module results change when tiering up to DFG 1188893 1 277761 benjamin 2016-04-29 17:07:34 -0700 Created attachment 277761 Patch 1188925 2 277761 mark.lam 2016-04-29 18:04:52 -0700 Comment on attachment 277761 Patch r=me. I see that the op_mod.js test will test combinations of positive and negative numbers of interesting sizes. I trust that if this patch passes the op_mod.js test on ARMv7s, then your decision of when to use the integer math and when to defer to fmod is correct. 1188944 3 277761 commit-queue 2016-04-29 18:50:11 -0700 Comment on attachment 277761 Patch Clearing flags on attachment: 277761 Committed r200277: <http://trac.webkit.org/changeset/200277> 1188945 4 commit-queue 2016-04-29 18:50:16 -0700 All reviewed patches have been landed. Closing bug. 277761 2016-04-29 17:07:34 -0700 2016-04-29 18:50:11 -0700 Patch bug-157217-20160429170808.patch text/plain 6188 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwMTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 MGI3ZjRiYTcwOGExODZjZTU4YzM3NjcyNWQ1OTdjOWE1MzIxZjkzLi44YTkwNjRjZGRiZGQ1MDVk NzNmZGI0MGViY2UwMTVkYmQwZmQ5OTgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNyBAQAorMjAxNi0wNC0yOSAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICBbSlNDXVtBUk12N1NdIEFyaXRobWV0aWMgbW9kdWxlIHJlc3VsdHMg Y2hhbmdlIHdoZW4gdGllcmluZyB1cCB0byBERkcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NzIxNworICAgICAgICByZGFyOi8vcHJvYmxlbS8yNDcz MzQzMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFS TXY3J3MgZm1vZCgpIHJldHVybnMgbGVzcyBhY2N1cmF0ZSByZXN1bHRzIHRoYW4gYW4gaW50ZWdl ciBkaXZpc2lvbi4KKyAgICAgICAgU2luY2Ugd2UgaGF2ZSBpbnRlZ2VyIGRpdiBvbiBBUk12N3Ms IHRoZSByZXN1bHRzIHN0YXJ0IGNoYW5naW5nIHdoZW4KKyAgICAgICAgd2UgcmVhY2ggREZHLgor CisgICAgICAgIEluIHRoaXMgcGF0Y2gsIEkgY2hhbmdlIG91ciBmbW9kIHNsb3cgcGF0aCB0byBi ZWhhdmUgbGlrZSB0aGUgZmFzdCBwYXRoCisgICAgICAgIG9uIEFSTXY3cy4KKworICAgICAgICAq IGRmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRp dmVKSVQ6OmNvbXBpbGVBcml0aE1vZCk6CisgICAgICAgIChKU0M6OkRGRzo6Zm1vZEFzREZHT3Bl cmF0aW9uKTogRGVsZXRlZC4KKyAgICAgICAgKiBydW50aW1lL0NvbW1vblNsb3dQYXRocy5jcHA6 CisgICAgICAgIChKU0M6OlNMT1dfUEFUSF9ERUNMKToKKyAgICAgICAgKiBydW50aW1lL01hdGhD b21tb24uY3BwOgorICAgICAgICAoSlNDOjppc1N0cmljdEludDMyKToKKyAgICAgICAgKiBydW50 aW1lL01hdGhDb21tb24uaDoKKwogMjAxNi0wNC0yNiAgU2thY2hrb3YgT2xla3NhbmRyICA8Z3Nr YWNoa292QGdtYWlsLmNvbT4KIAogICAgICAgICBjYWxsaW5nIHN1cGVyKCkgYSBzZWNvbmQgdGlt ZSBpbiBhIGNvbnN0cnVjdG9yIHNob3VsZCB0aHJvdwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAppbmRleCBmMmYxYzc4OTkwYTVmZWRlZDUyM2I2 MmE3Yzc2MWQ0ODY3M2E5NzFlLi43ZTk1ODljMDgwYThmYjJkYjBhZGRmMDhiYzY0ZmE3NTA3YzA4 ZDVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZl SklULmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklU LmNwcApAQCAtMzYyLDE3ICszNjIsNiBAQCB2b2lkIFNwZWN1bGF0aXZlSklUOjpydW5TbG93UGF0 aEdlbmVyYXRvcnMoUENUb0NvZGVPcmlnaW5NYXBCdWlsZGVyJiBwY1RvQ29kZU9yaQogICAgIH0K IH0KIAotLy8gT24gV2luZG93cyB3ZSBuZWVkIHRvIHdyYXAgZm1vZDsgb24gb3RoZXIgcGxhdGZv cm1zIHdlIGNhbiBjYWxsIGl0IGRpcmVjdGx5LgotLy8gT24gQVJNdjcgd2UgYXNzZXJ0IHRoYXQg YWxsIGZ1bmN0aW9uIHBvaW50ZXJzIGhhdmUgdG8gbG93IGJpdCBzZXQgKHBvaW50IHRvIHRodW1i IGNvZGUpLgotI2lmIENBTExJTkdfQ09OVkVOVElPTl9JU19TVERDQUxMIHx8IENQVShBUk1fVEhV TUIyKQotc3RhdGljIGRvdWJsZSBKSVRfT1BFUkFUSU9OIGZtb2RBc0RGR09wZXJhdGlvbihkb3Vi bGUgeCwgZG91YmxlIHkpCi17Ci0gICAgcmV0dXJuIGZtb2QoeCwgeSk7Ci19Ci0jZWxzZQotI2Rl ZmluZSBmbW9kQXNERkdPcGVyYXRpb24gZm1vZAotI2VuZGlmCi0KIHZvaWQgU3BlY3VsYXRpdmVK SVQ6OmNsZWFyR2VuZXJhdGlvbkluZm8oKQogewogICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkg PCBtX2dlbmVyYXRpb25JbmZvLnNpemUoKTsgKytpKQpAQCAtNDY4MSw3ICs0NjcwLDcgQEAgdm9p ZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZUFyaXRoTW9kKE5vZGUqIG5vZGUpCiAgICAgICAgIAog ICAgICAgICBGUFJSZXN1bHQgcmVzdWx0KHRoaXMpOwogICAgICAgICAKLSAgICAgICAgY2FsbE9w ZXJhdGlvbihmbW9kQXNERkdPcGVyYXRpb24sIHJlc3VsdC5mcHIoKSwgb3AxRlBSLCBvcDJGUFIp OworICAgICAgICBjYWxsT3BlcmF0aW9uKGpzTW9kLCByZXN1bHQuZnByKCksIG9wMUZQUiwgb3Ay RlBSKTsKICAgICAgICAgCiAgICAgICAgIGRvdWJsZVJlc3VsdChyZXN1bHQuZnByKCksIG5vZGUp OwogICAgICAgICByZXR1cm47CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9Db21tb25TbG93UGF0aHMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv Q29tbW9uU2xvd1BhdGhzLmNwcAppbmRleCBhMTllNWUyNWM1MzFhNGE5ZDAwODY0ZGY4NWZkNGEx YWM3OTlmZDA5Li45NDY2ODA5MDQ0NWU1MjczOWRiNGJlNWExOGNkMzA3ZDE1YzlmYmI4IDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db21tb25TbG93UGF0aHMuY3Bw CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbW1vblNsb3dQYXRocy5jcHAK QEAgLTQ5LDYgKzQ5LDcgQEAKICNpbmNsdWRlICJMTEludENvbW1vbi5oIgogI2luY2x1ZGUgIkxM SW50RXhjZXB0aW9ucy5oIgogI2luY2x1ZGUgIkxvd0xldmVsSW50ZXJwcmV0ZXIuaCIKKyNpbmNs dWRlICJNYXRoQ29tbW9uLmgiCiAjaW5jbHVkZSAiT2JqZWN0Q29uc3RydWN0b3IuaCIKICNpbmNs dWRlICJTY29wZWRBcmd1bWVudHMuaCIKICNpbmNsdWRlICJTdHJ1Y3R1cmVSYXJlRGF0YUlubGlu ZXMuaCIKQEAgLTQ2Miw3ICs0NjMsNyBAQCBTTE9XX1BBVEhfREVDTChzbG93X3BhdGhfbW9kKQog ICAgIEJFR0lOKCk7CiAgICAgZG91YmxlIGEgPSBPUF9DKDIpLmpzVmFsdWUoKS50b051bWJlcihl eGVjKTsKICAgICBkb3VibGUgYiA9IE9QX0MoMykuanNWYWx1ZSgpLnRvTnVtYmVyKGV4ZWMpOwot ICAgIFJFVFVSTihqc051bWJlcihmbW9kKGEsIGIpKSk7CisgICAgUkVUVVJOKGpzTnVtYmVyKGpz TW9kKGEsIGIpKSk7CiB9CiAKIFNMT1dfUEFUSF9ERUNMKHNsb3dfcGF0aF9sc2hpZnQpCmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXRoQ29tbW9uLmNwcCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL01hdGhDb21tb24uY3BwCmluZGV4IGFlYzI5NmY4 YTg0YWE1YTQyZjRlMmI3ZGM5YTVmZWQ0Mjc0ODU2MzYuLmY1OTIzNTM5NmJlNGVmOWQ4OWZiYTZj NjU1N2FlMzIxNjhmMjk2MTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL01hdGhDb21tb24uY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL01h dGhDb21tb24uY3BwCkBAIC00MzEsMTIgKzQzMSw1MyBAQCBkb3VibGUgSklUX09QRVJBVElPTiBv cGVyYXRpb25NYXRoUG93KGRvdWJsZSB4LCBkb3VibGUgeSkKICAgICByZXR1cm4gcmVzdWx0Owog fQogCisjaWYgSEFWRShBUk1fSURJVl9JTlNUUlVDVElPTlMpCitzdGF0aWMgaW5saW5lIGJvb2wg aXNTdHJpY3RJbnQzMihkb3VibGUgdmFsdWUpCit7CisgICAgaW50MzJfdCB2YWx1ZUFzSW50MzIg PSBzdGF0aWNfY2FzdDxpbnQzMl90Pih2YWx1ZSk7CisgICAgaWYgKHZhbHVlICE9IHZhbHVlQXNJ bnQzMikKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgaWYgKCF2YWx1ZUFzSW50MzIpIHsK KyAgICAgICAgaWYgKHN0ZDo6c2lnbmJpdCh2YWx1ZSkpCisgICAgICAgICAgICByZXR1cm4gZmFs c2U7CisgICAgfQorICAgIHJldHVybiB0cnVlOworfQorI2VuZGlmCisKIGV4dGVybiAiQyIgewog ZG91YmxlIGpzUm91bmQoZG91YmxlIHZhbHVlKQogewogICAgIGRvdWJsZSBpbnRlZ2VyID0gY2Vp bCh2YWx1ZSk7CiAgICAgcmV0dXJuIGludGVnZXIgLSAoaW50ZWdlciAtIHZhbHVlID4gMC41KTsK IH0KKworI2lmIENBTExJTkdfQ09OVkVOVElPTl9JU19TVERDQUxMIHx8IENQVShBUk1fVEhVTUIy KQorZG91YmxlIGpzTW9kKGRvdWJsZSB4LCBkb3VibGUgeSkKK3sKKyNpZiBIQVZFKEFSTV9JRElW X0lOU1RSVUNUSU9OUykKKyAgICAvLyBmbW9kKCkgZG9lcyBub3QgaGF2ZSBleGFjdCByZXN1bHRz IGZvciBpbnRlZ2VyIG9uIEFSTXY3LgorICAgIC8vIFdoZW4gREZHL0ZUTCB1c2UgSURJViwgdGhl IHJlc3VsdCBvZiBvcF9tb2QgY2FuIGNoYW5nZSBpZiB3ZSB1c2UgZm1vZCgpLgorICAgIC8vCisg ICAgLy8gV2UgaW1wbGVtZW50IGhlcmUgdGhlIHNhbWUgYWxnb3JpdGhtIGFuZCBjb25kaXRpb25z IGFzIHRoZSB1cHBlciB0aWVyIHRvIGtlZXAKKyAgICAvLyBhIHN0YWJsZSByZXN1bHQgd2hlbiB0 aWVyaW5nIHVwLgorICAgIGlmICh5KSB7CisgICAgICAgIGlmIChpc1N0cmljdEludDMyKHgpICYm IGlzU3RyaWN0SW50MzIoeSkpIHsKKyAgICAgICAgICAgIGludDMyX3QgeEFzSW50MzIgPSBzdGF0 aWNfY2FzdDxpbnQzMl90Pih4KTsKKyAgICAgICAgICAgIGludDMyX3QgeUFzSW50MzIgPSBzdGF0 aWNfY2FzdDxpbnQzMl90Pih5KTsKKyAgICAgICAgICAgIGludDMyX3QgcXVvdGllbnQgPSB4QXNJ bnQzMiAvIHlBc0ludDMyOworICAgICAgICAgICAgaWYgKCFwcm9kdWN0T3ZlcmZsb3dzPGludDMy X3Q+KHF1b3RpZW50LCB5QXNJbnQzMikpIHsKKyAgICAgICAgICAgICAgICBpbnQzMl90IHJlbWFp bmRlciA9IHhBc0ludDMyIC0gKHF1b3RpZW50ICogeUFzSW50MzIpOworICAgICAgICAgICAgICAg IGlmIChyZW1haW5kZXIgfHwgeEFzSW50MzIgPj0gMCkKKyAgICAgICAgICAgICAgICAgICAgcmV0 dXJuIHJlbWFpbmRlcjsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQorICAgIH0KKyNlbmRpZgor ICAgIHJldHVybiBmbW9kKHgsIHkpOwogfQorI2VuZGlmCit9IC8vIGV4dGVybiAiQyIKIAogfSAv LyBuYW1lc3BhY2UgSlNDCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9NYXRoQ29tbW9uLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXRoQ29tbW9u LmgKaW5kZXggZjYyZThhNDk0ZDUyZGVhMDkyZWRmMTYwMjljMjJjNTQyYTg5ZTE5Yy4uNmFiOWE3 NjcxZDFhMTM4YzQwNDRlMTFjMTkxOGE3MWEzNjRlOTdlMiAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvTWF0aENvbW1vbi5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL01hdGhDb21tb24uaApAQCAtMjcsNiArMjcsNyBAQAogI2RlZmluZSBNYXRo Q29tbW9uX2gKIAogI2luY2x1ZGUgIkpJVE9wZXJhdGlvbnMuaCIKKyNpbmNsdWRlICJNYWNyb0Fz c2VtYmxlckNvZGVSZWYuaCIKICNpbmNsdWRlIDxjbWF0aD4KICNpbmNsdWRlIDx3dGYvT3B0aW9u YWwuaD4KIApAQCAtODYsNiArODcsMTQgQEAgaW5saW5lIE9wdGlvbmFsPGRvdWJsZT4gc2FmZVJl Y2lwcm9jYWxGb3JEaXZCeUNvbnN0KGRvdWJsZSBjb25zdGFudCkKIAogZXh0ZXJuICJDIiB7CiBk b3VibGUgSklUX09QRVJBVElPTiBqc1JvdW5kKGRvdWJsZSB2YWx1ZSkgUkVGRVJFTkNFRF9GUk9N X0FTTSBXVEZfSU5URVJOQUw7CisKKy8vIE9uIFdpbmRvd3Mgd2UgbmVlZCB0byB3cmFwIGZtb2Q7 IG9uIG90aGVyIHBsYXRmb3JtcyB3ZSBjYW4gY2FsbCBpdCBkaXJlY3RseS4KKy8vIE9uIEFSTXY3 IHdlIGFzc2VydCB0aGF0IGFsbCBmdW5jdGlvbiBwb2ludGVycyBoYXZlIHRvIGxvdyBiaXQgc2V0 IChwb2ludCB0byB0aHVtYiBjb2RlKS4KKyNpZiBDQUxMSU5HX0NPTlZFTlRJT05fSVNfU1REQ0FM TCB8fCBDUFUoQVJNX1RIVU1CMikKK2RvdWJsZSBKSVRfT1BFUkFUSU9OIGpzTW9kKGRvdWJsZSB4 LCBkb3VibGUgeSkgUkVGRVJFTkNFRF9GUk9NX0FTTSBXVEZfSU5URVJOQUw7CisjZWxzZQorI2Rl ZmluZSBqc01vZCBmbW9kCisjZW5kaWYKIH0KIAogfQo=