157211 2016-04-29 16:03:24 -0700 Node.nodeName should not be nullable 2016-04-29 17:12:10 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://dom.spec.whatwg.org/#interface-node P2 Normal --- 1 cdumez cdumez commit-queue darin esprehn+autocc kangil.han kondapallykalyan rniwa sam youennf oldest_to_newest 1188838 0 cdumez 2016-04-29 16:03:24 -0700 Node.nodeName should not be nullable as per the specification: https://dom.spec.whatwg.org/#interface-node Our implementation never returns null anyway. However, having it as nullable in the IDL means we use jsStringOrNull() instead of jsStringWithCache(), thus doing an unnecessary null check. 1188841 1 277748 cdumez 2016-04-29 16:08:28 -0700 Created attachment 277748 Patch 1188899 2 277748 commit-queue 2016-04-29 17:12:04 -0700 Comment on attachment 277748 Patch Clearing flags on attachment: 277748 Committed r200271: <http://trac.webkit.org/changeset/200271> 1188900 3 commit-queue 2016-04-29 17:12:10 -0700 All reviewed patches have been landed. Closing bug. 277748 2016-04-29 16:08:28 -0700 2016-04-29 17:12:04 -0700 Patch bug-157211-20160429160901.patch text/plain 1608 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwMjUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjgxMzM4MWJmN2I3ODVk MDk3MGUxMjZjYjVjODRiYzA2ZmMxYWQ2OC4uOGFlMmNjNWJjZTdlMDBmYTMyODMyYTg1OTYwYzAz YTVhNDQ1YjZmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE2LTA0LTI5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgTm9kZS5ub2RlTmFtZSBzaG91 bGQgbm90IGJlIG51bGxhYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNTcyMTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBOb2RlLm5vZGVOYW1lIHNob3VsZCBub3QgYmUgbnVsbGFibGUgYXMgcGVyIHRo ZSBzcGVjaWZpY2F0aW9uOgorICAgICAgICBodHRwczovL2RvbS5zcGVjLndoYXR3Zy5vcmcvI2lu dGVyZmFjZS1ub2RlCisKKyAgICAgICAgT3VyIGltcGxlbWVudGF0aW9uIG5ldmVyIHJldHVybnMg bnVsbCBhbnl3YXkuIEhvd2V2ZXIsIGhhdmluZworICAgICAgICBpdCBhcyBudWxsYWJsZSBpbiB0 aGUgSURMIG1lYW5zIHdlIHVzZSBqc1N0cmluZ09yTnVsbCgpIGluc3RlYWQKKyAgICAgICAgb2Yg anNTdHJpbmdXaXRoQ2FjaGUoKSwgdGh1cyBkb2luZyBhbiB1bm5lY2Vzc2FyeSBudWxsIGNoZWNr LgorCisgICAgICAgIFRoaXMgc2hvdWxkIG5vdCBiZSBvYnNlcnZhYmxlIGJ5IEpTLgorCisgICAg ICAgICogZG9tL05vZGUuaWRsOgorCiAyMDE2LTA0LTI5ICBKZXJlbXkgSHVkZGxlc3RvbiBTZXF1 b2lhICA8amVyZW15aHVAYXBwbGUuY29tPgogCiAgICAgICAgIFtHVEtdIEZpeCBidWlsZCBmYWls dXJlIGludHJvZHVjZWQgYnkgcjE5OTczOApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9t L05vZGUuaWRsIGIvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuaWRsCmluZGV4IDAwODljNWExNDQ0 NTc3ZDliMTI5NDQ2MDQ0ZjRhMDdhZDkxMWRlYWUuLmEzNzY0YzZmODE1MWU1OWFiNjNhNjk5YzZk ZTlmZTVlYWEwNDQwZjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmlkbAor KysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5pZGwKQEAgLTQ3LDcgKzQ3LDcgQEAKICAgICBj b25zdCB1bnNpZ25lZCBzaG9ydCAgICAgIERPQ1VNRU5UX0ZSQUdNRU5UX05PREUgICAgICAgICA9 IDExOwogICAgIGNvbnN0IHVuc2lnbmVkIHNob3J0ICAgICAgTk9UQVRJT05fTk9ERSAgICAgICAg ICAgICAgICAgID0gMTI7CiAKLSAgICByZWFkb25seSBhdHRyaWJ1dGUgRE9NU3RyaW5nPyAgICAg ICAgbm9kZU5hbWU7CisgICAgcmVhZG9ubHkgYXR0cmlidXRlIERPTVN0cmluZyBub2RlTmFtZTsK IAogICAgIC8vIEZJWE1FOiB0aGUgc3BlYyBzYXlzIHRoaXMgY2FuIGFsc28gcmFpc2Ugb24gcmV0 cmlldmFsLgogICAgIFtTZXR0ZXJSYWlzZXNFeGNlcHRpb25dIGF0dHJpYnV0ZSBET01TdHJpbmc/ IG5vZGVWYWx1ZTsK