157206 2016-04-29 15:17:16 -0700 Add null checks when comparing SSL certificates 2016-05-02 13:25:47 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen ap beidson oldest_to_newest 1188806 0 achristensen 2016-04-29 15:17:16 -0700 Add null checks when comparing SSL certificates 1188807 1 277736 achristensen 2016-04-29 15:18:28 -0700 Created attachment 277736 Patch 1188817 2 ap 2016-04-29 15:37:39 -0700 Is this rdar://problem/21723172? 1188885 3 achristensen 2016-04-29 17:03:12 -0700 (In reply to comment #2) > Is this rdar://problem/21723172? No. This has never shipped. 1188892 4 ap 2016-04-29 17:07:23 -0700 Hmm. But it still seems like the same logic for why we shouldn't add a null check would apply. What's the difference here? 1189471 5 277923 achristensen 2016-05-02 12:42:19 -0700 Created attachment 277923 Patch 1189484 6 277923 ap 2016-05-02 13:13:17 -0700 Comment on attachment 277923 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277923&action=review I do not have a particularly strong opinion on whether we should paper over the problem, or crash. This is clearly an improvement. > Source/WebKit2/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:343 > + RELEASE_ASSERT(cert1 && cert2) Please add separate assertions for each, to make it easier to see what failed. 1189492 7 achristensen 2016-05-02 13:25:47 -0700 http://trac.webkit.org/changeset/200335 277736 2016-04-29 15:18:28 -0700 2016-05-02 12:42:16 -0700 Patch bug-157206-20160429151902.patch text/plain 1637 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMDI2NSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA0LTI5ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQWRkIG51bGwg Y2hlY2tzIHdoZW4gY29tcGFyaW5nIFNTTCBjZXJ0aWZpY2F0ZXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NzIwNgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0 d29ya0RhdGFUYXNrQ29jb2EubW06CisgICAgICAgIChXZWJLaXQ6OmNlcnRpZmljYXRlc01hdGNo KToKKyAgICAgICAgU2VjVHJ1c3RHZXRDZXJ0aWZpY2F0ZUF0SW5kZXggY2FuIHJldHVybiBudWxs LiAgSSBkb24ndCB0aGluayB0aGlzIGNhbiBoYXBwZW4gYWZ0ZXIgdGhlIHJhbmdlIGNoZWNrCisg ICAgICAgIHJpZ2h0IGJlZm9yZSB0aGlzIGNvZGUsIGJ1dCB3ZSBzaG91bGQgZmFpbCBpZiB0aGlz IGV2ZXIgaGFwcGVucy4KKwogMjAxNi0wNC0yOCAgQWRhIENoYW4gIDxhZGFjaGFuQGFwcGxlLmNv bT4KIAogICAgICAgICBJbmRpY2F0ZSB3ZSBhcmUgcHJvY2Vzc2luZyB1c2VyIGdlc3R1cmUgd2hl biBoYW5kbGluZyBtZXNzYWdlcyBmcm9tIFdlYlBsYXliYWNrU2Vzc2lvbk1hbmFnZXJQcm94eSB0 byBXZWJQbGF5YmFja1Nlc3Npb25NYW5hZ2VyCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9OZXR3b3Jr UHJvY2Vzcy9jb2NvYS9OZXR3b3JrRGF0YVRhc2tDb2NvYS5tbQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrRGF0YVRhc2tDb2NvYS5tbQko cmV2aXNpb24gMjAwMDQ1KQorKysgU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY29jb2Ev TmV0d29ya0RhdGFUYXNrQ29jb2EubW0JKHdvcmtpbmcgY29weSkKQEAgLTMzOCw3ICszMzgsOSBA QCBzdGF0aWMgYm9vbCBjZXJ0aWZpY2F0ZXNNYXRjaChTZWNUcnVzdFJlCiAgICAgICAgIHJldHVy biBmYWxzZTsKIAogICAgIGZvciAoQ0ZJbmRleCBpID0gMDsgaSA8IGNvdW50MTsgaSsrKSB7Ci0g ICAgICAgIGlmICghQ0ZFcXVhbChTZWNUcnVzdEdldENlcnRpZmljYXRlQXRJbmRleCh0cnVzdDEs IGkpLCBTZWNUcnVzdEdldENlcnRpZmljYXRlQXRJbmRleCh0cnVzdDIsIGkpKSkKKyAgICAgICAg YXV0byBjZXJ0MSA9IFNlY1RydXN0R2V0Q2VydGlmaWNhdGVBdEluZGV4KHRydXN0MSwgaSk7Cisg ICAgICAgIGF1dG8gY2VydDIgPSBTZWNUcnVzdEdldENlcnRpZmljYXRlQXRJbmRleCh0cnVzdDIs IGkpOworICAgICAgICBpZiAoIWNlcnQxIHx8ICFjZXJ0MiB8fCAhQ0ZFcXVhbChjZXJ0MSwgY2Vy dDIpKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KIAo= 277923 2016-05-02 12:42:19 -0700 2016-05-02 13:13:17 -0700 Patch bug-157206-20160502124256.patch text/plain 1678 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMDI2NSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA1LTAyICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQ3Jhc2ggaWYg YSBjZXJ0aWZpY2F0ZSBjaGFpbiBoYXMgbnVsbCBjZXJ0aWZpY2F0ZXMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NzIwNgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY29jb2Ev TmV0d29ya0RhdGFUYXNrQ29jb2EubW06CisgICAgICAgIChXZWJLaXQ6OmNlcnRpZmljYXRlc01h dGNoKToKKyAgICAgICAgU2VjVHJ1c3RHZXRDZXJ0aWZpY2F0ZUF0SW5kZXggY2FuIHJldHVybiBu dWxsLgorICAgICAgICBJZiB0aGlzIGV2ZXIgaGFwcGVucywgc29tZXRoaW5nIGhhcyBnb25lIGhv cnJpYmx5IHdyb25nIGluIHRoZSBzZWN1cml0eSBjb2RlIGFuZCB3ZSBzaG91bGQgY3Jhc2guCisg ICAgICAgIFNlZSByZGFyOi8vcHJvYmxlbS8yMTcyMzE3MgorCiAyMDE2LTA0LTI4ICBBZGEgQ2hh biAgPGFkYWNoYW5AYXBwbGUuY29tPgogCiAgICAgICAgIEluZGljYXRlIHdlIGFyZSBwcm9jZXNz aW5nIHVzZXIgZ2VzdHVyZSB3aGVuIGhhbmRsaW5nIG1lc3NhZ2VzIGZyb20gV2ViUGxheWJhY2tT ZXNzaW9uTWFuYWdlclByb3h5IHRvIFdlYlBsYXliYWNrU2Vzc2lvbk1hbmFnZXIKSW5kZXg6IFNv dXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtEYXRhVGFza0NvY29hLm1t Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdv cmtEYXRhVGFza0NvY29hLm1tCShyZXZpc2lvbiAyMDAwNDUpCisrKyBTb3VyY2UvV2ViS2l0Mi9O ZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrRGF0YVRhc2tDb2NvYS5tbQkod29ya2luZyBjb3B5 KQpAQCAtMzM4LDcgKzMzOCwxMCBAQCBzdGF0aWMgYm9vbCBjZXJ0aWZpY2F0ZXNNYXRjaChTZWNU cnVzdFJlCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIGZvciAoQ0ZJbmRleCBpID0gMDsg aSA8IGNvdW50MTsgaSsrKSB7Ci0gICAgICAgIGlmICghQ0ZFcXVhbChTZWNUcnVzdEdldENlcnRp ZmljYXRlQXRJbmRleCh0cnVzdDEsIGkpLCBTZWNUcnVzdEdldENlcnRpZmljYXRlQXRJbmRleCh0 cnVzdDIsIGkpKSkKKyAgICAgICAgYXV0byBjZXJ0MSA9IFNlY1RydXN0R2V0Q2VydGlmaWNhdGVB dEluZGV4KHRydXN0MSwgaSk7CisgICAgICAgIGF1dG8gY2VydDIgPSBTZWNUcnVzdEdldENlcnRp ZmljYXRlQXRJbmRleCh0cnVzdDIsIGkpOworICAgICAgICBSRUxFQVNFX0FTU0VSVChjZXJ0MSAm JiBjZXJ0MikKKyAgICAgICAgaWYgKCFDRkVxdWFsKGNlcnQxLCBjZXJ0MikpCiAgICAgICAgICAg ICByZXR1cm4gZmFsc2U7CiAgICAgfQogCg==