157204 2016-04-29 14:54:55 -0700 Drop useless check in SpeculativeLoadManager::registerLoad() 2016-04-29 20:36:18 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez cgarcia commit-queue koivisto oldest_to_newest 1188799 0 cdumez 2016-04-29 14:54:55 -0700 Drop useless check in SpeculativeLoadManager::registerLoad() 1188801 1 277734 cdumez 2016-04-29 15:03:15 -0700 Created attachment 277734 Patch 1188978 2 277734 koivisto 2016-04-29 20:29:40 -0700 Comment on attachment 277734 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277734&action=review > Source/WebKit2/ChangeLog:14 > +2016-04-29 Chris Dumez <cdumez@apple.com> > + > + Drop useless check in SpeculativeLoadManager::registerLoad() > + https://bugs.webkit.org/show_bug.cgi?id=157204 > + > + Reviewed by NOBODY (OOPS!). > + > + Drop useless check in SpeculativeLoadManager::registerLoad(). There is > + no way to end up this code path with a non-HTTP family request. > + > + * NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp: > + (WebKit::NetworkCache::SpeculativeLoadManager::registerLoad): > + > +2016-04-29 Chris Dumez <cdumez@apple.com> ChangeLog repeats 1188982 3 cdumez 2016-04-29 20:36:18 -0700 Committed r200281: <http://trac.webkit.org/changeset/200281> 277734 2016-04-29 15:03:15 -0700 2016-04-29 20:29:40 -0700 Patch bug-157204-20160429150348.patch text/plain 2468 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwMjUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjE2NzcwMDE0ZTc4Njlh M2MyZmE3MTk5ZTBjZTJiMmIwMWJjNmIxOS4uMTAwYWRiNDgyNjgyMDk4ZTNhYjE2MjJkZjVkMjZm OGY3ZGIwZTY0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDE2LTA0LTI5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRHJvcCB1c2VsZXNzIGNoZWNr IGluIFNwZWN1bGF0aXZlTG9hZE1hbmFnZXI6OnJlZ2lzdGVyTG9hZCgpCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTcyMDQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEcm9wIHVzZWxlc3MgY2hlY2sgaW4g U3BlY3VsYXRpdmVMb2FkTWFuYWdlcjo6cmVnaXN0ZXJMb2FkKCkuIFRoZXJlIGlzCisgICAgICAg IG5vIHdheSB0byBlbmQgdXAgdGhpcyBjb2RlIHBhdGggd2l0aCBhIG5vbi1IVFRQIGZhbWlseSBy ZXF1ZXN0LgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3Bl Y3VsYXRpdmVMb2FkTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtDYWNoZTo6 U3BlY3VsYXRpdmVMb2FkTWFuYWdlcjo6cmVnaXN0ZXJMb2FkKToKKworMjAxNi0wNC0yOSAgQ2hy aXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCisgICAgICAgIERvIG5vdCBib3RoZXIgcmVn aXN0ZXJpbmcgbm9uLSJHRVQiIGxvYWRzIHdpdGggdGhlIHNwZWN1bGF0aXZlIGxvYWQgbWFuYWdl cgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3MjAy CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG8gbm90 IGJvdGhlciByZWdpc3RlcmluZyBub24tIkdFVCIgbG9hZHMgd2l0aCB0aGUgc3BlY3VsYXRpdmUg bG9hZCBtYW5hZ2VyCisgICAgICAgIGFzIHRoZXNlIHdpbGwgbm90IGJlIGNhY2hlZCBhbmQgdGhl cmUgd2lsbCBiZSB0aGVyZWZvcmUgbm90aGluZyB0bworICAgICAgICBzcGVjdWxhdGl2ZWx5IHJl dmFsaWRhdGUgbGF0ZXIuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3Jr Q2FjaGUuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrQ2FjaGU6OkNhY2hlOjpyZXRyaWV2 ZSk6CisKIDIwMTYtMDQtMjggIEFkYSBDaGFuICA8YWRhY2hhbkBhcHBsZS5jb20+CiAKICAgICAg ICAgSW5kaWNhdGUgd2UgYXJlIHByb2Nlc3NpbmcgdXNlciBnZXN0dXJlIHdoZW4gaGFuZGxpbmcg bWVzc2FnZXMgZnJvbSBXZWJQbGF5YmFja1Nlc3Npb25NYW5hZ2VyUHJveHkgdG8gV2ViUGxheWJh Y2tTZXNzaW9uTWFuYWdlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nl c3MvY2FjaGUvTmV0d29ya0NhY2hlU3BlY3VsYXRpdmVMb2FkTWFuYWdlci5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVTcGVjdWxhdGl2ZUxvYWRN YW5hZ2VyLmNwcAppbmRleCA5YzJlZTFhZDEyMDU0MDc0OGJhZDZjNDVhMWE0YmVjZGRkNTliZGYz Li5lYjdiYzU4ZGIyMGYwMTBjYTIyY2Q3ZTE1MWM2ZDY3Y2RiNDc3YmQ0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVTcGVjdWxhdGl2 ZUxvYWRNYW5hZ2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNo ZS9OZXR3b3JrQ2FjaGVTcGVjdWxhdGl2ZUxvYWRNYW5hZ2VyLmNwcApAQCAtMzU4LDggKzM1OCw5 IEBAIGJvb2wgU3BlY3VsYXRpdmVMb2FkTWFuYWdlcjo6cmV0cmlldmUoY29uc3QgR2xvYmFsRnJh bWVJRCYgZnJhbWVJRCwgY29uc3QgS2V5JiBzCiB2b2lkIFNwZWN1bGF0aXZlTG9hZE1hbmFnZXI6 OnJlZ2lzdGVyTG9hZChjb25zdCBHbG9iYWxGcmFtZUlEJiBmcmFtZUlELCBjb25zdCBSZXNvdXJj ZVJlcXVlc3QmIHJlcXVlc3QsIGNvbnN0IEtleSYgcmVzb3VyY2VLZXkpCiB7CiAgICAgQVNTRVJU KFJ1bkxvb3A6OmlzTWFpbigpKTsKKyAgICBBU1NFUlQocmVxdWVzdC51cmwoKS5wcm90b2NvbElz SW5IVFRQRmFtaWx5KCkpOwogCi0gICAgaWYgKCFyZXF1ZXN0LnVybCgpLnByb3RvY29sSXNJbkhU VFBGYW1pbHkoKSB8fCByZXF1ZXN0Lmh0dHBNZXRob2QoKSAhPSAiR0VUIikKKyAgICBpZiAocmVx dWVzdC5odHRwTWV0aG9kKCkgIT0gIkdFVCIpCiAgICAgICAgIHJldHVybjsKIAogICAgIGF1dG8g aXNNYWluUmVzb3VyY2UgPSByZXF1ZXN0LnJlcXVlc3RlcigpID09IFJlc291cmNlUmVxdWVzdDo6 UmVxdWVzdGVyOjpNYWluOwo=