157194 2016-04-29 11:19:24 -0700 Web Inspector: Jump to Line in auto formatted JavaScript does not work the first time 2016-04-29 14:08:15 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1188721 0 joepeck 2016-04-29 11:19:24 -0700 * SUMMARY Jump to Line in auto formatted JavaScript does not work the first time. * STEPS TO REPRODUCE 1. Inspect <http://bogojoker.com/shell/> 2. Set a breakpoint on formatted easySlider.min.js:56:21 ("if (autoplay)") 3. Select another resource in sidebar 4. Reload 5. Select the breakpoint => Jump to line fails to reveal the right line 6. Select the breakpoint again => Jump to line succeeds 1188722 1 webkit-bug-importer 2016-04-29 11:20:33 -0700 <rdar://problem/26008471> 1188740 2 277726 joepeck 2016-04-29 12:05:18 -0700 Created attachment 277726 [PATCH] Proposed Fix This is a quick solution. Really we should rework the interface between TextEditor and SourceCodeTextEditor quite a bit. 1188781 3 277726 commit-queue 2016-04-29 14:08:12 -0700 Comment on attachment 277726 [PATCH] Proposed Fix Clearing flags on attachment: 277726 Committed r200262: <http://trac.webkit.org/changeset/200262> 1188782 4 commit-queue 2016-04-29 14:08:15 -0700 All reviewed patches have been landed. Closing bug. 277726 2016-04-29 12:05:18 -0700 2016-04-29 14:08:12 -0700 [PATCH] Proposed Fix defer-reveal.patch text/plain 4104 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDVlNzI1YjEuLjkwZmRhM2QgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM0IEBACisyMDE2LTA0LTI5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogSnVtcCB0 byBMaW5lIGluIGF1dG8gZm9ybWF0dGVkIEphdmFTY3JpcHQgZG9lcyBub3Qgd29yayB0aGUgZmly c3QgdGltZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTU3MTk0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNjAwODQ3MT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGRvaW5nIGFzeW5jaHJvbm91 cyBmb3JtYXR0aW5nIHdlIHNldCB0aGUgY29udGVudCBvZiB0aGUgZWRpdG9yCisgICAgICAgIHR3 aWNlLiBGaXJzdCB0byBwcmltZSB0aGUgZWRpdG9ycyBiYWNrL2Zvd2FyZCBsaXN0IHdpdGggdGhl IG9yaWdpbmFsCisgICAgICAgIGNvbnRlbnQsIGFuZCB0aGVuIGFnYWluIGFmdGVyIHdlIGdldCB0 aGUgZm9ybWF0dGVkIGNvbnRlbnQgZnJvbSB0aGUKKyAgICAgICAgV29ya2VyLCBhbmQgdGhlbiBk aXNwbGF5IHRoZSBjb250ZW50LgorCisgICAgICAgIFRoZSBUZXh0RWRpdG9yIGF0dGVtcHRzIHRv IHJldmVhbCBhIHBvc2l0aW9uIHdoZW4gdGhlIGluaXRpYWwgc3RyaW5nCisgICAgICAgIGhhcyBi ZWVuIHNldC4gQmFjayB3aGVuIGF1dG9mb3JtYXR0aW5nIHdhcyBzeW5jaHJvbm91cyB0aGlzIHdh cyBmaW5lLgorICAgICAgICBBc3luY2hyb25vdXNseSBob3dldmVyLCB0aGlzIGVuZHMgdXAgaGFw cGVuaW5nIGJldHdlZW4gdGhlIG9yaWdpbmFsCisgICAgICAgIGFuZCBmb3JtYXR0ZWQgdmFsdWUu IEFsc28sIHRoZSBUZXh0RWRpdG9yIGhhcyBubyBpZGVhIHRoYXQgdGhlCisgICAgICAgIFNvdXJj ZUNvZGVUZXh0RWRpdG9yIGlzIGdvaW5nIHRvIGZvcm1hdCAvIGRlZmVyIGRpc3BsYXlpbmcgdGhl CisgICAgICAgIGNvbnRlbnRzLiBBZGQgYSAiZGVmZXIiIHByb3BlcnR5IHRvIHRoZSBUZXh0RWRp dG9yIHRoYXQgdGhlCisgICAgICAgIFNvdXJjZUNvZGVUZXh0RWRpdG9yIGNhbiB1c2UgaW4gdGhp cyBjaXJjdW1zdGFuY2UuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZUNv ZGVUZXh0RWRpdG9yLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNvdXJjZUNvZGVUZXh0RWRp dG9yLnByb3RvdHlwZS5fcG9wdWxhdGVXaXRoQ29udGVudCk6CisgICAgICAgIEF2b2lkIHJldmVh bGluZyBhIHBvc2l0aW9uIHdoZW4gc2V0dGluZyB0aGUgb3JpZ2luYWwgY29udGVudC4gV2Ugd2ls bAorICAgICAgICBiZSBmb3JtYXR0aW5nIGFuZCB3ZSB3aWxsIHdhbnQgdG8gcmV2ZWFsIHRoZSBw b3NpdGlvbiBhZnRlcndhcmRzLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UZXh0 RWRpdG9yLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRleHRFZGl0b3IpOgorICAgICAgICAo V2ViSW5zcGVjdG9yLlRleHRFZGl0b3IucHJvdG90eXBlLnNldCBkZWZlclJldmVhbCk6CisgICAg ICAgIFByb3ZpZGUgYW5vdGhlciByZWFzb24gdG8gZGVmZXIgcmV2ZWFsaW5nLgorCiAyMDE2LTA0 LTI4ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogRm9ybWF0dGVyV29ya2VyIGZhaWxzIHRvIGZpbmQgIkV4dGVybmFsL0VzcHJp bWEuanMiIGluIFByb2R1Y3Rpb24gYnVpbGRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Tb3VyY2VDb2RlVGV4dEVkaXRvci5qcyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZUNvZGVUZXh0RWRpdG9y LmpzCmluZGV4IDgxZGUzMjkuLjAxOWRhMWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZUNvZGVUZXh0RWRpdG9yLmpzCisrKyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZUNvZGVUZXh0RWRp dG9yLmpzCkBAIC0zOTQsNyArMzk0LDkgQEAgV2ViSW5zcGVjdG9yLlNvdXJjZUNvZGVUZXh0RWRp dG9yID0gY2xhc3MgU291cmNlQ29kZVRleHRFZGl0b3IgZXh0ZW5kcyBXZWJJbnNwZWMKICAgICAg ICAgaWYgKHRoaXMuX2F1dG9Gb3JtYXQpIHsKICAgICAgICAgICAgIGNvbnNvbGUuYXNzZXJ0KCF0 aGlzLmZvcm1hdHRlZCk7CiAgICAgICAgICAgICB0aGlzLl9hdXRvRm9ybWF0ID0gZmFsc2U7Cisg ICAgICAgICAgICB0aGlzLmRlZmVyUmV2ZWFsID0gdHJ1ZTsKICAgICAgICAgICAgIHRoaXMuc3Ry aW5nID0gY29udGVudDsKKyAgICAgICAgICAgIHRoaXMuZGVmZXJSZXZlYWwgPSBmYWxzZTsKICAg ICAgICAgICAgIHRoaXMudXBkYXRlRm9ybWF0dGVkU3RhdGUodHJ1ZSkudGhlbigoKSA9PiB7CiAg ICAgICAgICAgICAgICAgdGhpcy5fcHJvY2VlZFBvcHVsYXRlV2l0aENvbnRlbnQodGhpcy5zdHJp bmcpOwogICAgICAgICAgICAgfSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9UZXh0RWRpdG9yLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvVGV4dEVkaXRvci5qcwppbmRleCBjODEyMGY0Li4yYzgwOTA0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9U ZXh0RWRpdG9yLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL1RleHRFZGl0b3IuanMKQEAgLTY2LDYgKzY2LDcgQEAgV2ViSW5zcGVjdG9yLlRleHRFZGl0 b3IgPSBjbGFzcyBUZXh0RWRpdG9yIGV4dGVuZHMgV2ViSW5zcGVjdG9yLlZpZXcKICAgICAgICAg dGhpcy5fZm9ybWF0dGVkID0gZmFsc2U7CiAgICAgICAgIHRoaXMuX2Zvcm1hdHRpbmdQcm9taXNl ID0gbnVsbDsKICAgICAgICAgdGhpcy5fZm9ybWF0dGVyU291cmNlTWFwID0gbnVsbDsKKyAgICAg ICAgdGhpcy5fZGVmZXJSZXZlYWwgPSBmYWxzZTsKIAogICAgICAgICB0aGlzLl9kZWxlZ2F0ZSA9 IGRlbGVnYXRlIHx8IG51bGw7CiAgICAgfQpAQCAtMjU0LDYgKzI1NSwxMSBAQCBXZWJJbnNwZWN0 b3IuVGV4dEVkaXRvciA9IGNsYXNzIFRleHRFZGl0b3IgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuVmll dwogICAgICAgICB9CiAgICAgfQogCisgICAgc2V0IGRlZmVyUmV2ZWFsKGRlZmVyKQorICAgIHsK KyAgICAgICAgdGhpcy5fZGVmZXJSZXZlYWwgPSBkZWZlcjsKKyAgICB9CisKICAgICBwZXJmb3Jt U2VhcmNoKHF1ZXJ5KQogICAgIHsKICAgICAgICAgaWYgKHRoaXMuX3NlYXJjaFF1ZXJ5ID09PSBx dWVyeSkKQEAgLTQyMyw3ICs0MjksNyBAQCBXZWJJbnNwZWN0b3IuVGV4dEVkaXRvciA9IGNsYXNz IFRleHRFZGl0b3IgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuVmlldwogICAgICAgICAgICAgcmV0dXJu OwogCiAgICAgICAgIHZhciBsaW5lSGFuZGxlID0gdGhpcy5fY29kZU1pcnJvci5nZXRMaW5lSGFu ZGxlKHBvc2l0aW9uLmxpbmVOdW1iZXIpOwotICAgICAgICBpZiAoIWxpbmVIYW5kbGUgfHwgIXRo aXMuX3Zpc2libGUgfHwgdGhpcy5faW5pdGlhbFN0cmluZ05vdFNldCkgeworICAgICAgICBpZiAo IWxpbmVIYW5kbGUgfHwgIXRoaXMuX3Zpc2libGUgfHwgdGhpcy5faW5pdGlhbFN0cmluZ05vdFNl dCB8fCB0aGlzLl9kZWZlclJldmVhbCkgewogICAgICAgICAgICAgLy8gSWYgd2UgY2FuJ3QgZ2V0 IGEgbGluZSBoYW5kbGUgb3IgYXJlIG5vdCB2aXNpYmxlIHRoZW4gd2Ugd2FpdCB0byBkbyB0aGUg cmV2ZWFsLgogICAgICAgICAgICAgdGhpcy5fcG9zaXRpb25Ub1JldmVhbCA9IHBvc2l0aW9uOwog ICAgICAgICAgICAgdGhpcy5fdGV4dFJhbmdlVG9TZWxlY3QgPSB0ZXh0UmFuZ2VUb1NlbGVjdDsK