157192 2016-04-29 11:15:06 -0700 [Win] Enable IndexedDB. 2016-05-02 11:40:00 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned achristensen beidson bfulgham oldest_to_newest 1188717 0 peavo 2016-04-29 11:15:06 -0700 It would be nice to have this feature enabled on Windows. 1188732 1 277723 peavo 2016-04-29 11:31:50 -0700 Created attachment 277723 Patch 1188734 2 peavo 2016-04-29 11:33:53 -0700 This patch needs VS2015 Update 2 to compile. 1188768 3 277723 bfulgham 2016-04-29 13:15:58 -0700 Comment on attachment 277723 Patch Oh, nice! r=me, but please hold off landing until I get the bots updated. I'll do that today. 1188769 4 peavo 2016-04-29 13:22:47 -0700 (In reply to comment #3) > Comment on attachment 277723 [details] > Patch > > Oh, nice! r=me, but please hold off landing until I get the bots updated. > I'll do that today. Thanks for reviewing! 1188775 5 achristensen 2016-04-29 13:37:27 -0700 (In reply to comment #2) > This patch needs VS2015 Update 2 to compile. What exactly needs update 2? What happens if you compile without it? 1188780 6 peavo 2016-04-29 13:58:33 -0700 (In reply to comment #5) > (In reply to comment #2) > > This patch needs VS2015 Update 2 to compile. > What exactly needs update 2? What happens if you compile without it? I get a compile error in the method UniqueIDBDatabase::activateTransactionInBackingStore. error C2668: 'WebCore::IDBServer::UniqueIDBDatabase::storeCallback': ambiguous call to overloaded function void UniqueIDBDatabase::activateTransactionInBackingStore(UniqueIDBDatabaseTransaction& transaction) { LOG(IndexedDB, "(main) UniqueIDBDatabase::activateTransactionInBackingStore"); RefPtr<UniqueIDBDatabase> self(this); RefPtr<UniqueIDBDatabaseTransaction> refTransaction(&transaction); auto callback = [this, self, refTransaction](const IDBError& error) { refTransaction->didActivateInBackingStore(error); }; uint64_t callbackID = storeCallback(callback); m_server.postDatabaseTask(createCrossThreadTask(*this, &UniqueIDBDatabase::performActivateTransactionInBackingStore, callbackID, transaction.info())); } 1189443 7 peavo 2016-05-02 11:40:00 -0700 Committed r200328: <http://trac.webkit.org/changeset/200328> 277723 2016-04-29 11:31:50 -0700 2016-04-29 13:15:58 -0700 Patch bug-157192-20160429203218.patch text/plain 4406 peavo SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDIwMDIz NikKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE2LTA0 LTI5ICBQZXIgQXJuZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2lu XSBFbmFibGUgSW5kZXhlZERCLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTU3MTkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc1dpbi5jbWFrZToKKwogMjAxNi0wNC0y OSAgWW9hdiBXZWlzcyAgPHlvYXZAeW9hdi53cz4KIAogICAgICAgICBNb3ZlIFJlc291cmNlVGlt aW5nIGJlaGluZCBhIHJ1bnRpbWUgZmxhZwpJbmRleDogU291cmNlL1dURi9DaGFuZ2VMb2cKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dURi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMDI1MikKKysrIFNv dXJjZS9XVEYvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTYt MDQtMjkgIFBlciBBcm5lIFZvbGxhbiAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtX aW5dIEVuYWJsZSBJbmRleGVkREIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTcxOTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBGaXggY29tcGlsZSBlcnJvcnMgd2hlbiBmb3JtYXQgc3BlY2lmaWVycyBs aWtlIFBSSXU2NCBpcyB1c2VkLCBieSBkZWZpbmluZworICAgICAgICBfX1NURENfRk9STUFUX01B Q1JPUyBiZWZvcmUgaW50dHlwZXMuaCBpcyBpbmNsdWRlZC4KKworICAgICAgICAqIHd0Zi9QbGF0 Zm9ybS5oOiAKKwogMjAxNi0wNC0yNyAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+ CiAKICAgICAgICAgTW9kZXJuIElEQjogSW1wbGVtZW50IG5hdGl2ZSBJREJGYWN0b3J5LmdldEFs bERhdGFiYXNlTmFtZXMgZm9yIFdlYkluc3BlY3Rvci4KSW5kZXg6IFNvdXJjZS9XVEYvd3RmL1Bs YXRmb3JtLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAkocmV2aXNp b24gMjAwMjM2KQorKysgU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAkod29ya2luZyBjb3B5KQpA QCAtMTEwNSw2ICsxMTA1LDggQEAKICNlbmRpZgogCiAjaWYgQ09NUElMRVIoTVNWQykKKyN1bmRl ZiBfX1NURENfRk9STUFUX01BQ1JPUworI2RlZmluZSBfX1NURENfRk9STUFUX01BQ1JPUwogI3Vu ZGVmIF9fU1REQ19MSU1JVF9NQUNST1MKICNkZWZpbmUgX19TVERDX0xJTUlUX01BQ1JPUwogI2lm IF9NU0NfVkVSIDwgMTkwMApJbmRleDogU291cmNlL2NtYWtlL09wdGlvbnNXaW4uY21ha2UKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL2NtYWtlL09wdGlvbnNXaW4uY21ha2UJKHJldmlzaW9uIDIwMDIz NikKKysrIFNvdXJjZS9jbWFrZS9PcHRpb25zV2luLmNtYWtlCSh3b3JraW5nIGNvcHkpCkBAIC0z NSw3ICszNSw3IEBAIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV8KIFdF QktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9HQU1FUEFEIFBVQkxJQyBPRkYp CiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfR0VPTE9DQVRJT04gUFVC TElDIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0lDT05EQVRB QkFTRSBQVUJMSUMgT04pCi1XRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVf SU5ERVhFRF9EQVRBQkFTRSBQVUJMSUMgT0ZGKQorV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRf VkFMVUUoRU5BQkxFX0lOREVYRURfREFUQUJBU0UgUFVCTElDIE9OKQogV0VCS0lUX09QVElPTl9E RUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0lOUFVUX1RZUEVfQ09MT1IgUFVCTElDIE9GRikKIFdF QktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9JTlBVVF9UWVBFX0RBVEUgUFVC TElDIE9GRikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9JTlBVVF9U WVBFX0RBVEVUSU1FX0lOQ09NUExFVEUgUFVCTElDIE9GRikKSW5kZXg6IExheW91dFRlc3RzL0No YW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIw MDIzNikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDEyIEBACisyMDE2LTA0LTI5ICBQZXIgQXJuZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4K KworICAgICAgICBbV2luXSBFbmFibGUgSW5kZXhlZERCLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3MTkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS93aW4vVGVzdEV4cGVjdGF0aW9u czogVXBkYXRlIEluZGV4ZWREQiB0ZXN0IGV4cGVjdGF0aW9ucy4KKwogMjAxNi0wNC0yOSAgUnlv c3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBJbXBvcnQgVzNDIENTUyBX RyB0ZXN0cyBmb3Igc2hhZG93IERPTQpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1Rl c3RFeHBlY3RhdGlvbnMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1Rl c3RFeHBlY3RhdGlvbnMJKHJldmlzaW9uIDIwMDIzNikKKysrIExheW91dFRlc3RzL3BsYXRmb3Jt L3dpbi9UZXN0RXhwZWN0YXRpb25zCSh3b3JraW5nIGNvcHkpCkBAIC0yNDksOCArMjQ5LDIwIEBA IGZhc3QvYXV0b3Jlc2l6ZS8gWyBTa2lwIF0KICMgVE9ETyBOZWVkIHRvIGFkZCBmdW5jdGlvbmFs aXR5IHRvIER1bXBSZW5kZXJUcmVlIHRvIGhhbmRsZSBzY3JvbGxiYXIgcG9saWN5IGNoYW5nZXMK IGZhc3Qvb3ZlcmZsb3cvc2Nyb2xsYmFyLXJlc3RvcmVkLWFuZC10aGVuLWxvY2tlZC5odG1sIFsg U2tpcCBdCiAKLSMgVE9ETyBJbmRleGVkREIgaXMgbm90IHlldCBlbmFibGVkLgotc3RvcmFnZS9p bmRleGVkZGIvIFsgU2tpcCBdCitzdG9yYWdlL2luZGV4ZWRkYi9jbG9uZS1leGNlcHRpb24uaHRt bCBbIFRpbWVvdXQgXQorc3RvcmFnZS9pbmRleGVkZGIvZGF0YWJhc2Utb2RkLW5hbWVzLmh0bWwg WyBUaW1lb3V0IEZhaWx1cmUgXQorc3RvcmFnZS9pbmRleGVkZGIvcHJpbWFyeS1rZXktdW5pcXVl LXRvLW9iamVjdHN0b3JlLmh0bWwgWyBUaW1lb3V0IF0KK3N0b3JhZ2UvaW5kZXhlZGRiL3ZlcnNp b24tY2hhbmdlLWV2ZW50LWJhc2ljLmh0bWwgWyBUaW1lb3V0IF0KK3N0b3JhZ2UvaW5kZXhlZGRi L3Byb3BlcnRpZXMtZGlzYWJsZWQtYXQtcnVudGltZS5odG1sIFsgRmFpbHVyZSBdCitzdG9yYWdl L2luZGV4ZWRkYi9tb2Rlcm4vYmxvYi1zaW1wbGUuaHRtbCBbIEZhaWx1cmUgXQorc3RvcmFnZS9p bmRleGVkZGIvbW9kZXJuL2RhdGUtYmFzaWMtcHJpdmF0ZS5odG1sIFsgRmFpbHVyZSBdCitzdG9y YWdlL2luZGV4ZWRkYi9tb2Rlcm4vZGF0ZS1iYXNpYy5odG1sIFsgRmFpbHVyZSBdCitzdG9yYWdl L2luZGV4ZWRkYi9tb2Rlcm4vZ2V0LWtleXJhbmdlLXByaXZhdGUuaHRtbCBbIEZhaWx1cmUgXQor c3RvcmFnZS9pbmRleGVkZGIvbW9kZXJuL2dldC1rZXlyYW5nZS5odG1sIFsgRmFpbHVyZSBdCitz dG9yYWdlL2luZGV4ZWRkYi9tb2Rlcm4vaWRib2JqZWN0c3RvcmUtZGVsZXRlLTEtcHJpdmF0ZS5o dG1sIFsgRmFpbHVyZSBdCitzdG9yYWdlL2luZGV4ZWRkYi9tb2Rlcm4vaWRib2JqZWN0c3RvcmUt ZGVsZXRlLTEuaHRtbCBbIEZhaWx1cmUgXQorc3RvcmFnZS9pbmRleGVkZGIvbW9kZXJuL3dvcmtl cnMtZW5hYmxlLmh0bWwgWyBGYWlsdXJlIF0KKwogaW1wb3J0ZWQvdzNjL0luZGV4ZWREQi1wcml2 YXRlLWJyb3dzaW5nIFsgU2tpcCBdCiBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL0lu ZGV4ZWREQiBbIFNraXAgXQoganMvZG9tL2dsb2JhbC1jb25zdHJ1Y3RvcnMtYXR0cmlidXRlcy1p ZGIuaHRtbCBbIFNraXAgXQo=