<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>157191</bug_id>
          
          <creation_ts>2016-04-29 11:10:31 -0700</creation_ts>
          <short_desc>Allow contributors to edit the wiki</short_desc>
          <delta_ts>2018-04-25 18:42:45 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>CONFIGURATION CHANGED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Alberto Lopez Perez">clopez</reporter>
          <assigned_to name="Lucas Forschler">lforschler</assigned_to>
          <cc>cadubentzen</cc>
    
    <cc>lforschler</cc>
    
    <cc>magomez</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1188715</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2016-04-29 11:10:31 -0700</bug_when>
    <thetext>It would be nice if we allow contributors (as listed in the &quot;Contributors&quot; field of contributors.json) to edit the wiki at https://trac.webkit.org


This may be useful for example for WebKitGTK+ gardeners (some of them still not committers) can edit the wiki at https://trac.webkit.org/wiki/WebKitGTK/Gardening/Calendar


Since in the file contributors.json are also listed the committeers and reviewers, a possible implementation idea is to give wiki edit permissions to anyone listed on that file. That way there is only one source of information to check for this permission.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1188730</commentid>
    <comment_count>1</comment_count>
    <who name="Lucas Forschler">lforschler</who>
    <bug_when>2016-04-29 11:27:53 -0700</bug_when>
    <thetext>The current trac authenticate list is taken from the svn.webkit.org authz.conf file.
It should be fairly simple to supplement that list with the contributors list from source.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1188731</commentid>
    <comment_count>2</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2016-04-29 11:28:35 -0700</bug_when>
    <thetext>&lt;rdar://problem/26008806&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1193674</commentid>
    <comment_count>3</comment_count>
    <who name="Lucas Forschler">lforschler</who>
    <bug_when>2016-05-16 19:50:19 -0700</bug_when>
    <thetext>I&apos;ve manually added all of the &quot;Contributors&quot; in contributors.json.

We should consider adding a post-commit hook to svn.webkit.org to do this anytime the contributors.json file is updated. However, the hook will need a fair bit of testing. Also, we&apos;ll likely need to run an operation to remove permissions before adding them back in, such that we can cover cases where users are added or removed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1193675</commentid>
    <comment_count>4</comment_count>
    <who name="Lucas Forschler">lforschler</who>
    <bug_when>2016-05-16 19:51:27 -0700</bug_when>
    <thetext>And by manually, I mean I&apos;ve wrote a script which does this work for us... (however it is run manually, not via hook or other automation)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1346114</commentid>
    <comment_count>5</comment_count>
    <who name="Lucas Forschler">lforschler</who>
    <bug_when>2017-09-06 15:19:32 -0700</bug_when>
    <thetext>I&apos;ve updated our tools to take all emails from contributors.json and give them wiki permissions.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1417939</commentid>
    <comment_count>6</comment_count>
    <who name="Carlos Bentzen">cadubentzen</who>
    <bug_when>2018-04-25 18:42:45 -0700</bug_when>
    <thetext>Hi! I recently added myself as contributor on bug 184082 but I haven&apos;t got permission to edit the wiki yet.

Has the permissions script been updated and stopped granting permissions to contributors listed in contributors.json?</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>