157177 2016-04-29 05:44:31 -0700 Limit ResourceTiming to WEB_TIMING enabled builds 2016-04-29 12:21:48 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 157133 P2 Normal --- 1 yoav webkit-unassigned achristensen cdumez commit-queue esprehn+autocc kondapallykalyan ossy oldest_to_newest 1188593 0 yoav 2016-04-29 05:44:31 -0700 Limit ResourceTiming to WEB_TIMING enabled builds 1188594 1 277694 yoav 2016-04-29 05:47:50 -0700 Created attachment 277694 Patch 1188595 2 yoav 2016-04-29 05:50:44 -0700 When looking into why https://bugs.webkit.org/show_bug.cgi?id=157133 broke the Mac cmake build, I saw that the build breaks when WEB_TIMING is not enabled (which is the case for the Mac cmake build). This corrects such builds. As a next step, I also intend to turn on WEB_TIMING on the Mac cmake build by default. 1188671 3 277694 achristensen 2016-04-29 10:04:06 -0700 Comment on attachment 277694 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277694&action=review > Source/WebCore/page/PerformanceResourceTiming.h:88 > +#endif // !ENABLE(WEB_TIMING) no ! 1188746 4 yoav 2016-04-29 12:21:48 -0700 Since https://bugs.webkit.org/show_bug.cgi?id=157133 got reverted, this patch can no longer be applied. I'll merge it into the one in 157133 *** This bug has been marked as a duplicate of bug 157133 *** 277694 2016-04-29 05:47:50 -0700 2016-04-29 10:04:06 -0700 Patch bug-157177-20160429144821.patch text/plain 3113 yoav U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwMjM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTg1YWUwYzk4ODJjOWNj NGNhYjQ4NGQ3N2ViMDg3YzY1NzZkZjFkMC4uNzc3ZDkzMTNjYTNkZTJjODI3ODNkMDAwYjk3NWY0 OGE0MGY0MWE2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE2LTA0LTI5ICBZb2F2 IFdlaXNzICA8eW9hdkB5b2F2LndzPgorCisgICAgICAgIExpbWl0IFJlc291cmNlVGltaW5nIHRv IFdFQl9USU1JTkcgZW5hYmxlZCBidWlsZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE1NzE3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoaXMgY2hhbmdlIGxpbWl0cyBSZXNvdXJjZVRpbWluZyB0byBX RUJfVElNSU5HIGVuYWJsZWQgYnVpbGRzLAorICAgICAgICBhcyBpdCByZWxpZXMgb24gb3RoZXIg Y29tcG9uZW50cyB0aGF0IGFyZSBub3QgcHJlc2VudCBpbiBzdWNoIGJ1aWxkcywKKyAgICAgICAg KGUuZy4gUGVyZm9ybWFuY2VFbnRyeSkgYW5kIHRoZXJlZm9yZSBjYXVzZXMgYnVpbGQgaXNzdWVz IG90aGVyd2lzZS4KKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgdGhpcyBjaGFuZ2UgcG9zZXMg bm8gZnVuY3Rpb25hbCBjaGFuZ2UuCisKKyAgICAgICAgKiBwYWdlL1BlcmZvcm1hbmNlUmVzb3Vy Y2VUaW1pbmcuY3BwOiBBZGQgI2lmIGVuYWJsaW5nIHRoZSBjb2RlIG9ubHkgd2hlbiBXRUJfVElN SU5HIGlzIGVuYWJsZWQuCisgICAgICAgICogcGFnZS9QZXJmb3JtYW5jZVJlc291cmNlVGltaW5n Lmg6IEFkZCAjaWYgZW5hYmxpbmcgdGhlIGNvZGUgb25seSB3aGVuIFdFQl9USU1JTkcgaXMgZW5h YmxlZC4KKyAgICAgICAgKiBwYWdlL1BlcmZvcm1hbmNlUmVzb3VyY2VUaW1pbmcuaWRsOiBBZGQg V0VCX1RJTUlORyBhcyBhIENvbmRpdGlvbmFsLgorCiAyMDE2LTA0LTI5ICBZb3Vlbm4gRmFibGV0 ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CiAKICAgICAgICAgUmVtb3ZlIFVzZVBvaW50 ZXJzRXZlbkZvck5vbk51bGxhYmxlT2JqZWN0QXJndW1lbnRzIGtleXdvcmQKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGVyZm9ybWFuY2VSZXNvdXJjZVRpbWluZy5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL1BlcmZvcm1hbmNlUmVzb3VyY2VUaW1pbmcuY3BwCmluZGV4IDViYjYx NDA5NzE5OGZmNTYyMWM1MWM4Njk2YTZkMjc5MmQwZjA2MTIuLjYxNGM4NzgwMzFkNjI1OWE5ZGM1 MWNmZTFjNGNhMTM3M2U5NjVlYWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGVy Zm9ybWFuY2VSZXNvdXJjZVRpbWluZy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QZXJm b3JtYW5jZVJlc291cmNlVGltaW5nLmNwcApAQCAtMzIsNiArMzIsOCBAQAogI2luY2x1ZGUgImNv bmZpZy5oIgogI2luY2x1ZGUgIlBlcmZvcm1hbmNlUmVzb3VyY2VUaW1pbmcuaCIKIAorI2lmIEVO QUJMRShXRUJfVElNSU5HKQorCiAjaW5jbHVkZSAiRG9jdW1lbnQuaCIKICNpbmNsdWRlICJEb2N1 bWVudExvYWRUaW1pbmcuaCIKICNpbmNsdWRlICJEb2N1bWVudExvYWRlci5oIgpAQCAtMTk3LDMg KzE5OSw1IEBAIGRvdWJsZSBQZXJmb3JtYW5jZVJlc291cmNlVGltaW5nOjpyZXNvdXJjZVRpbWVU b0RvY3VtZW50TWlsbGlzZWNvbmRzKGludCBkZWx0YU1pCiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdl YkNvcmUKKworI2VuZGlmIC8vIEVOQUJMRShXRUJfVElNSU5HKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGFnZS9QZXJmb3JtYW5jZVJlc291cmNlVGltaW5nLmggYi9Tb3VyY2UvV2ViQ29y ZS9wYWdlL1BlcmZvcm1hbmNlUmVzb3VyY2VUaW1pbmcuaAppbmRleCAzN2I1YWU5MWVkZjA3NWFm NDliMjA1Nzk5NTQzOGRkOGVmNmFhNGZmLi40NzNhOTkyNTJhNjBjOGQzYjg1ZGUwODRlYzQ2NDli ZmI4NzZlYzE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BlcmZvcm1hbmNlUmVz b3VyY2VUaW1pbmcuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BlcmZvcm1hbmNlUmVzb3Vy Y2VUaW1pbmcuaApAQCAtMzIsNiArMzIsOCBAQAogI2lmbmRlZiBQZXJmb3JtYW5jZVJlc291cmNl VGltaW5nX2gKICNkZWZpbmUgUGVyZm9ybWFuY2VSZXNvdXJjZVRpbWluZ19oCiAKKyNpZiBFTkFC TEUoV0VCX1RJTUlORykKKwogI2luY2x1ZGUgIlBlcmZvcm1hbmNlRW50cnkuaCIKICNpbmNsdWRl ICJSZXNvdXJjZUxvYWRUaW1pbmcuaCIKICNpbmNsdWRlIDx3dGYvUGFzc1JlZlB0ci5oPgpAQCAt ODMsNCArODUsNSBAQCBwcml2YXRlOgogCiB9CiAKKyNlbmRpZiAvLyAhRU5BQkxFKFdFQl9USU1J TkcpCiAjZW5kaWYgLy8gIWRlZmluZWQoUGVyZm9ybWFuY2VSZXNvdXJjZVRpbWluZ19oKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9QZXJmb3JtYW5jZVJlc291cmNlVGltaW5nLmlk bCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGVyZm9ybWFuY2VSZXNvdXJjZVRpbWluZy5pZGwKaW5k ZXggM2YzMDllM2JhMmRiNjRiNDQ5NWVhZTYxODA4MjI5OWU5YjYyZDQ1Mi4uMjVhOTI4YjA5ZjJm YTYwY2NiMzdhNTM0YzY3MmYyZmRmZWZmMjg2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGFnZS9QZXJmb3JtYW5jZVJlc291cmNlVGltaW5nLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w YWdlL1BlcmZvcm1hbmNlUmVzb3VyY2VUaW1pbmcuaWRsCkBAIC0zMCw2ICszMCw3IEBACiAKIC8v IFNlZTogaHR0cHM6Ly9kdmNzLnczLm9yZy9oZy93ZWJwZXJmL3Jhdy1maWxlL3RpcC9zcGVjcy9S ZXNvdXJjZVRpbWluZy9PdmVydmlldy5odG1sCiBbCisgICAgQ29uZGl0aW9uYWw9V0VCX1RJTUlO RywKICAgICBFbmFibGVkQXRSdW50aW1lPVJlc291cmNlVGltaW5nCiBdIGludGVyZmFjZSBQZXJm b3JtYW5jZVJlc291cmNlVGltaW5nIDogUGVyZm9ybWFuY2VFbnRyeSB7CiAgICAgcmVhZG9ubHkg YXR0cmlidXRlIERPTVN0cmluZyBpbml0aWF0b3JUeXBlOwo=