157166 2016-04-29 00:16:54 -0700 [css-grid] Update Grid Layout properties in CSSKeywordCompletions.js 2016-05-09 09:08:34 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 60731 1 rego rego bburg commit-queue graouts jfernandez joepeck mattbaker nvasilyev rego svillar timothy webkit-bug-importer oldest_to_newest 1188534 0 rego 2016-04-29 00:16:54 -0700 We should update the grid layout properties in: http://trac.webkit.org/browser/trunk/Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js#L779 There're some strange thins like "grid-after" that are no longer in the spec since a lot of time ago. Other new stuff like grid gaps properties are missing. 1188538 1 webkit-bug-importer 2016-04-29 00:23:12 -0700 <rdar://problem/25998768> 1191183 2 278405 rego 2016-05-09 08:24:37 -0700 Created attachment 278405 Patch 1191189 3 278405 commit-queue 2016-05-09 09:08:30 -0700 Comment on attachment 278405 Patch Clearing flags on attachment: 278405 Committed r200575: <http://trac.webkit.org/changeset/200575> 1191190 4 commit-queue 2016-05-09 09:08:34 -0700 All reviewed patches have been landed. Closing bug. 278405 2016-05-09 08:24:37 -0700 2016-05-09 09:08:30 -0700 Patch bug-157166-20160509172522.patch text/plain 2911 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwNTcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAw OTAxYWI0OTUzYjM4YWU1MjVmOGM2MzQ5YTI3NzNiYWI2NGUzYTgwLi42M2RlNWZmYWU0ZjM0OTRm NDAzMzI2ODQzZTZhMjA0Yjg2M2U3NTBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNi0wNS0wOSAgTWFudWVsIFJlZ28gQ2FzYXNub3ZhcyAgPHJlZ29AaWdh bGlhLmNvbT4KKworICAgICAgICBbY3NzLWdyaWRdIFVwZGF0ZSBHcmlkIExheW91dCBwcm9wZXJ0 aWVzIGluIENTU0tleXdvcmRDb21wbGV0aW9ucy5qcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3MTY2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIENTUyBHcmlkIExheW91dCBwcm9wZXJ0aWVzIGhh dmUgYmVlbiBjaGFuZ2luZyBvbiB0aGUgc3BlYywKKyAgICAgICAgaG93ZXZlciB0aGV5IGhhdmVu J3QgYmVlbiB1cGRhdGVkIGluIENTU0tleXdvcmRDb21wbGV0aW9ucyBmb3IgYSBsb25nIHRpbWUu CisgICAgICAgIFVwZGF0ZSB0aGVtIHVzaW5nIHRoZSBsYXN0IHNwZWMgZHJhZnQ6CisgICAgICAg IGh0dHBzOi8vZHJhZnRzLmNzc3dnLm9yZy9jc3MtZ3JpZC8jcHJvcGVydHktaW5kZXgKKworICAg ICAgICAqIFVzZXJJbnRlcmZhY2UvTW9kZWxzL0NTU0tleXdvcmRDb21wbGV0aW9ucy5qczoKKwog MjAxNi0wNS0wOCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+CiAKICAgICAgICAg V2ViIEluc3BlY3RvcjogQWRkIEJyZWFrcG9pbnRzIGFuZCBTY3JpcHRzIGZvbGRlcnMgdG8gRGVi dWdnZXIgc2lkZWJhcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvTW9kZWxzL0NTU0tleXdvcmRDb21wbGV0aW9ucy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9DU1NLZXl3b3JkQ29tcGxldGlvbnMuanMKaW5kZXgg ZTc4ZmYzMzZlMmYxYTAwMDQ3ZTYxNmM0MTM2M2NhY2E5N2U4ZTJlNi4uNjllNGJlYzhmM2I3NzIx ZjRhZDMyYjkzZjRkNTZjYjU5ODhkY2IyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0NTU0tleXdvcmRDb21wbGV0aW9ucy5qcworKysgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQ1NTS2V5d29yZENvbXBs ZXRpb25zLmpzCkBAIC03NzYsMzIgKzc3Niw1MCBAQCBXZWJJbnNwZWN0b3IuQ1NTS2V5d29yZENv bXBsZXRpb25zLl9wcm9wZXJ0eUtleXdvcmRNYXAgPSB7CiAgICAgImZsZXgtYmFzaXMiOiBbCiAg ICAgICAgICJhdXRvIgogICAgIF0sCi0gICAgImdyaWQtYWZ0ZXIiOiBbCi0gICAgICAgICJhdXRv IgotICAgIF0sCi0gICAgImdyaWQtYmVmb3JlIjogWwotICAgICAgICAiYXV0byIKKyAgICAiZ3Jp ZCI6IFsKKyAgICAgICAgIm5vbmUiCiAgICAgXSwKLSAgICAiZ3JpZC1lbmQiOiBbCisgICAgImdy aWQtYXJlYSI6IFsKICAgICAgICAgImF1dG8iCiAgICAgXSwKLSAgICAiZ3JpZC1zdGFydCI6IFsK LSAgICAgICAgImF1dG8iCisgICAgImdyaWQtYXV0by1jb2x1bW5zIjogWworICAgICAgICAiYXV0 byIsICItd2Via2l0LW1heC1jb250ZW50IiwgIi13ZWJraXQtbWluLWNvbnRlbnQiLCAibWlubWF4 KCkiLAogICAgIF0sCiAgICAgImdyaWQtYXV0by1mbG93IjogWwogICAgICAgICAicm93IiwgImNv bHVtbiIsICJkZW5zZSIKICAgICBdLAorICAgICJncmlkLWF1dG8tcm93cyI6IFsKKyAgICAgICAg ImF1dG8iLCAiLXdlYmtpdC1tYXgtY29udGVudCIsICItd2Via2l0LW1pbi1jb250ZW50IiwgIm1p bm1heCgpIiwKKyAgICBdLAogICAgICJncmlkLWNvbHVtbiI6IFsKICAgICAgICAgImF1dG8iCiAg ICAgXSwKKyAgICAiZ3JpZC1jb2x1bW4tc3RhcnQiOiBbCisgICAgICAgICJhdXRvIgorICAgIF0s CisgICAgImdyaWQtY29sdW1uLWVuZCI6IFsKKyAgICAgICAgImF1dG8iCisgICAgXSwKICAgICAi Z3JpZC1yb3ciOiBbCiAgICAgICAgICJhdXRvIgogICAgIF0sCi0gICAgImdyaWQtY29sdW1ucyI6 IFsKLSAgICAgICAgImF1dG8iLCAiLXdlYmtpdC1tYXgtY29udGVudCIsICItd2Via2l0LW1pbi1j b250ZW50IgorICAgICJncmlkLXJvdy1zdGFydCI6IFsKKyAgICAgICAgImF1dG8iCisgICAgXSwK KyAgICAiZ3JpZC1yb3ctZW5kIjogWworICAgICAgICAiYXV0byIKKyAgICBdLAorICAgICJncmlk LXRlbXBsYXRlIjogWworICAgICAgICAibm9uZSIKKyAgICBdLAorICAgICJncmlkLXRlbXBsYXRl LWFyZWFzIjogWworICAgICAgICAibm9uZSIKKyAgICBdLAorICAgICJncmlkLXRlbXBsYXRlLWNv bHVtbnMiOiBbCisgICAgICAgICJub25lIiwgImF1dG8iLCAiLXdlYmtpdC1tYXgtY29udGVudCIs ICItd2Via2l0LW1pbi1jb250ZW50IiwgIm1pbm1heCgpIiwgInJlcGVhdCgpIgogICAgIF0sCi0g ICAgImdyaWQtcm93cyI6IFsKLSAgICAgICAgImF1dG8iLCAiLXdlYmtpdC1tYXgtY29udGVudCIs ICItd2Via2l0LW1pbi1jb250ZW50IgorICAgICJncmlkLXRlbXBsYXRlLXJvd3MiOiBbCisgICAg ICAgICJub25lIiwgImF1dG8iLCAiLXdlYmtpdC1tYXgtY29udGVudCIsICItd2Via2l0LW1pbi1j b250ZW50IiwgIm1pbm1heCgpIiwgInJlcGVhdCgpIgogICAgIF0sCiAgICAgIi13ZWJraXQtcnVi eS1wb3NpdGlvbiI6IFsKICAgICAgICAgImFmdGVyIiwgImJlZm9yZSIsICJpbnRlci1jaGFyYWN0 ZXIiCg==