157159 2016-04-28 17:27:24 -0700 RTL <select> popup menu is in the wrong location 2016-04-29 17:02:28 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 157183 1 dino dino commit-queue jonlee ossy ryanhaddad simon.fraser webkit-bug-importer oldest_to_newest 1188457 0 dino 2016-04-28 17:27:24 -0700 RTL <select> popup menu is in the wrong location 1188459 1 dino 2016-04-28 17:27:48 -0700 <rdar://problem/25894451> 1188460 2 277667 dino 2016-04-28 17:31:08 -0700 Created attachment 277667 Patch 1188466 3 dino 2016-04-28 17:42:03 -0700 Committed r200217: <http://trac.webkit.org/changeset/200217> 1188518 4 ossy 2016-04-28 23:17:41 -0700 (In reply to comment #3) > Committed r200217: <http://trac.webkit.org/changeset/200217> It broke the Apple Mac Yosemite build, see build.webkit.org for details. 1188641 5 commit-queue 2016-04-29 09:28:54 -0700 Re-opened since this is blocked by bug 157183 1188675 6 ryanhaddad 2016-04-29 10:13:01 -0700 Link to failing Yosemite build: <https://build.webkit.org/builders/Apple%20Yosemite%20Debug%20%28Build%29/builds/14561> /Volumes/Data/slave/yosemite-debug/build/Source/WebKit/mac/WebCoreSupport/PopupMenuMac.mm:158:11: error: 'NSMenu' may not respond to 'setUserInterfaceLayoutDirection:' [-Werror] 1188884 7 dino 2016-04-29 17:02:28 -0700 Back in r200268 277667 2016-04-28 17:31:08 -0700 2016-04-28 17:35:14 -0700 Patch bug-157159-20160429103138.patch text/plain 5693 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwMTY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggYjI4YTQxZmMy Y2U4MmZkMjhkNGIxNTkyYzQ3N2M3NzNjZmI0ZmYwNy4uZWU3ZDkzMjcxODBhMjlhNTdjMjBhZDhk NmM5Y2VhMzY0NDEyNTBmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE2 LTA0LTI4ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBSVEwgPHNl bGVjdD4gcG9wdXAgbWVudSBpcyBpbiB0aGUgd3JvbmcgbG9jYXRpb24KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NzE1OQorICAgICAgICA8cmRhcjov L3Byb2JsZW0vMjU4OTQ0NTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTWFrZSBzdXJlIGJvdGggdGhlIE5TUG9wdXBNZW51Q2VsbCBhbmQgdGhlIE5T UG9wdXBNZW51IHRha2UKKyAgICAgICAgdGhlIHRleHQgZGlyZWN0aW9uIGludG8gYWNjb3VudCwg YW5kIG9mZnNldCB0aGUgcG9zaXRpb24KKyAgICAgICAgb2YgdGhlIG1lbnUgc2xpZ2h0bHkgaWYg d2UncmUgaW4gUlRMIG1vZGUuCisKKyAgICAgICAgVW5mb3J0dW5hdGVseSBvdXIgdGVzdCBpbmZy YXN0cnVjdHVyZSBpcyB1bmFibGUgdG8gZXhlcmNpc2UKKyAgICAgICAgdGhpcyBiZWNhdXNlIGl0 IHJ1bnMgd2l0aG91dCBhIHdpbmRvdywgYW5kIHRoZSBwb3B1cCBtZW51CisgICAgICAgIGlzIG5v dCBjYXB0dXJlZCBpbiB0aGUgc2NyZWVuc2hvdC4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0 L1BvcHVwTWVudU1hYy5tbToKKyAgICAgICAgKFBvcHVwTWVudU1hYzo6c2hvdyk6CisKIDIwMTYt MDQtMjcgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIENTUDog QWRkIGFwcC1zcGVjaWZpYyB3b3JrYXJvdW5kIGZvciBFY29iZWUgYW5kIFF1b3JhCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cK aW5kZXggYTUzYzJmNjI2NGQ3M2I5MjIzMjYzNDM5YzQyYmViODcyNTMxYmM3Ni4uMGRmNWU0OTU0 YjRiMGVhZmMxMWU5MWU4ZTk3OGUwNDkzMWZhMDE2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDE2LTA0LTI4ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAg ICBSVEwgPHNlbGVjdD4gcG9wdXAgbWVudSBpcyBpbiB0aGUgd3JvbmcgbG9jYXRpb24KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NzE1OQorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMjU4OTQ0NTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTWFrZSBzdXJlIHRoZSBOU1BvcHVwTWVudSB0YWtlcyB0aGUg dGV4dCBkaXJlY3Rpb24KKyAgICAgICAgaW50byBhY2NvdW50LCBhbmQgb2Zmc2V0IHRoZSBwb3Np dGlvbgorICAgICAgICBvZiB0aGUgbWVudSBzbGlnaHRseSBpZiB3ZSdyZSBpbiBSVEwgbW9kZS4K KworICAgICAgICBVbmZvcnR1bmF0ZWx5IG91ciB0ZXN0IGluZnJhc3RydWN0dXJlIGlzIHVuYWJs ZSB0byBleGVyY2lzZQorICAgICAgICB0aGlzIGJlY2F1c2UgaXQgcnVucyB3aXRob3V0IGEgd2lu ZG93LCBhbmQgdGhlIHBvcHVwIG1lbnUKKyAgICAgICAgaXMgbm90IGNhcHR1cmVkIGluIHRoZSBz Y3JlZW5zaG90LgorCisgICAgICAgICogVUlQcm9jZXNzL21hYy9XZWJQb3B1cE1lbnVQcm94eU1h Yy5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUG9wdXBNZW51UHJveHlNYWM6OnNob3dQb3B1cE1l bnUpOgorCiAyMDE2LTA0LTI3ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAog ICAgICAgICBNb2Rlcm4gSURCOiBJbXBsZW1lbnQgbmF0aXZlIElEQkZhY3RvcnkuZ2V0QWxsRGF0 YWJhc2VOYW1lcyBmb3IgV2ViSW5zcGVjdG9yLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9t YWMvV2ViQ29yZVN1cHBvcnQvUG9wdXBNZW51TWFjLm1tIGIvU291cmNlL1dlYktpdC9tYWMvV2Vi Q29yZVN1cHBvcnQvUG9wdXBNZW51TWFjLm1tCmluZGV4IDczMzI4M2NjMzQ1N2Y2OGUwYWI5NDE4 ZWY5OTJjYzdhNGIyMWIzYWQuLjdmNDA1ZTM3ZmI0ZjA5NWQwMDU0ZjFiMDliMGMwMGZmNWQ5OGUz NzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1BvcHVwTWVu dU1hYy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9Qb3B1cE1lbnVN YWMubW0KQEAgLTE0OCwxMSArMTQ4LDE1IEBAIHZvaWQgUG9wdXBNZW51TWFjOjpzaG93KGNvbnN0 IEludFJlY3QmIHIsIEZyYW1lVmlldyogdiwgaW50IGluZGV4KQogCiAgICAgTlNWaWV3KiB2aWV3 ID0gdi0+ZG9jdW1lbnRWaWV3KCk7CiAKKyAgICBUZXh0RGlyZWN0aW9uIHRleHREaXJlY3Rpb24g PSBtX2NsaWVudC0+bWVudVN0eWxlKCkudGV4dERpcmVjdGlvbigpOworCiAgICAgW21fcG9wdXAg YXR0YWNoUG9wVXBXaXRoRnJhbWU6ciBpblZpZXc6dmlld107CiAgICAgW21fcG9wdXAgc2VsZWN0 SXRlbUF0SW5kZXg6aW5kZXhdOworICAgIFttX3BvcHVwIHNldFVzZXJJbnRlcmZhY2VMYXlvdXRE aXJlY3Rpb246dGV4dERpcmVjdGlvbiA9PSBMVFIgPyBOU1VzZXJJbnRlcmZhY2VMYXlvdXREaXJl Y3Rpb25MZWZ0VG9SaWdodCA6IE5TVXNlckludGVyZmFjZUxheW91dERpcmVjdGlvblJpZ2h0VG9M ZWZ0XTsKIAogICAgIE5TTWVudSogbWVudSA9IFttX3BvcHVwIG1lbnVdOwotICAgIAorICAgIFtt ZW51IHNldFVzZXJJbnRlcmZhY2VMYXlvdXREaXJlY3Rpb246dGV4dERpcmVjdGlvbiA9PSBMVFIg PyBOU1VzZXJJbnRlcmZhY2VMYXlvdXREaXJlY3Rpb25MZWZ0VG9SaWdodCA6IE5TVXNlckludGVy ZmFjZUxheW91dERpcmVjdGlvblJpZ2h0VG9MZWZ0XTsKKwogICAgIE5TUG9pbnQgbG9jYXRpb247 CiAgICAgTlNGb250KiBmb250ID0gbV9jbGllbnQtPm1lbnVTdHlsZSgpLmZvbnQoKS5wcmltYXJ5 Rm9udCgpLmdldE5TRm9udCgpOwogCkBAIC0xNjksOCArMTczLDkgQEAgdm9pZCBQb3B1cE1lbnVN YWM6OnNob3coY29uc3QgSW50UmVjdCYgciwgRnJhbWVWaWV3KiB2LCBpbnQgaW5kZXgpCiAgICAg ICAgIE5TRm9udCogZGVmYXVsdEZvbnQgPSBbTlNGb250IHN5c3RlbUZvbnRPZlNpemU6W2ZvbnQg cG9pbnRTaXplXV07CiAgICAgICAgIHZlcnRPZmZzZXQgKz0gW2ZvbnQgZGVzY2VuZGVyXSAtIFtk ZWZhdWx0Rm9udCBkZXNjZW5kZXJdOwogICAgICAgICB2ZXJ0T2Zmc2V0ID0gZm1pbmYoTlNIZWln aHQociksIHZlcnRPZmZzZXQpOwotICAgIAotICAgICAgICBsb2NhdGlvbiA9IE5TTWFrZVBvaW50 KE5TTWluWChyKSArIHBvcE92ZXJIb3Jpem9udGFsQWRqdXN0LCBOU01heFkocikgLSB2ZXJ0T2Zm c2V0KTsKKworICAgICAgICBmbG9hdCBob3Jpem9udGFsT2Zmc2V0ID0gdGV4dERpcmVjdGlvbiA9 PSBMVFIgPyBwb3BPdmVySG9yaXpvbnRhbEFkanVzdCA6IDA7CisgICAgICAgIGxvY2F0aW9uID0g TlNNYWtlUG9pbnQoTlNNaW5YKHIpICsgaG9yaXpvbnRhbE9mZnNldCwgTlNNYXhZKHIpIC0gdmVy dE9mZnNldCk7CiAgICAgfSBlbHNlCiAgICAgICAgIGxvY2F0aW9uID0gTlNNYWtlUG9pbnQoTlNN aW5YKHIpICsgcG9wVW5kZXJIb3Jpem9udGFsQWRqdXN0LCBOU01heFkocikgKyBwb3BVbmRlclZl cnRpY2FsQWRqdXN0KTsgICAgCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9tYWMvV2ViUG9wdXBNZW51UHJveHlNYWMubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv bWFjL1dlYlBvcHVwTWVudVByb3h5TWFjLm1tCmluZGV4IDI4M2IzOGFkMWFhMTZjMDViMjU5OTRh MzczMzZiZWRjYjcyMjg0OTAuLmM1MjkyNzZlZDJhMTk1YjdjY2Q2YzliNmQwZWNhZGIwYzEwZWFm YjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViUG9wdXBNZW51 UHJveHlNYWMubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XZWJQb3B1cE1l bnVQcm94eU1hYy5tbQpAQCAtMTE4LDYgKzExOCw3IEBAIHZvaWQgV2ViUG9wdXBNZW51UHJveHlN YWM6OnNob3dQb3B1cE1lbnUoY29uc3QgSW50UmVjdCYgcmVjdCwgVGV4dERpcmVjdGlvbiB0ZXh0 CiAgICAgW21fcG9wdXAgc2V0VXNlckludGVyZmFjZUxheW91dERpcmVjdGlvbjp0ZXh0RGlyZWN0 aW9uID09IExUUiA/IE5TVXNlckludGVyZmFjZUxheW91dERpcmVjdGlvbkxlZnRUb1JpZ2h0IDog TlNVc2VySW50ZXJmYWNlTGF5b3V0RGlyZWN0aW9uUmlnaHRUb0xlZnRdOwogCiAgICAgTlNNZW51 ICptZW51ID0gW21fcG9wdXAgbWVudV07CisgICAgW21lbnUgc2V0VXNlckludGVyZmFjZUxheW91 dERpcmVjdGlvbjp0ZXh0RGlyZWN0aW9uID09IExUUiA/IE5TVXNlckludGVyZmFjZUxheW91dERp cmVjdGlvbkxlZnRUb1JpZ2h0IDogTlNVc2VySW50ZXJmYWNlTGF5b3V0RGlyZWN0aW9uUmlnaHRU b0xlZnRdOwogCiAgICAgLy8gVGhlc2UgdmFsdWVzIHdlcmUgYm9ycm93ZWQgZnJvbSBBcHBLaXQg dG8gbWF0Y2ggdGhlaXIgcGxhY2VtZW50IG9mIHRoZSBtZW51LgogICAgIGNvbnN0IGludCBwb3BP dmVySG9yaXpvbnRhbEFkanVzdCA9IC0xMDsKQEAgLTEzMSw4ICsxMzIsOSBAQCB2b2lkIFdlYlBv cHVwTWVudVByb3h5TWFjOjpzaG93UG9wdXBNZW51KGNvbnN0IEludFJlY3QmIHJlY3QsIFRleHRE aXJlY3Rpb24gdGV4dAogICAgICAgICBOU1JlY3QgdGl0bGVGcmFtZSA9IFttX3BvcHVwICB0aXRs ZVJlY3RGb3JCb3VuZHM6cmVjdF07CiAgICAgICAgIGlmICh0aXRsZUZyYW1lLnNpemUud2lkdGgg PD0gMCB8fCB0aXRsZUZyYW1lLnNpemUuaGVpZ2h0IDw9IDApCiAgICAgICAgICAgICB0aXRsZUZy YW1lID0gcmVjdDsKLSAgICAgICAgZmxvYXQgdmVydE9mZnNldCA9IHJvdW5kZigoTlNNYXhZKHJl Y3QpIC0gTlNNYXhZKHRpdGxlRnJhbWUpKSArIE5TSGVpZ2h0KHRpdGxlRnJhbWUpKTsKLSAgICAg ICAgbG9jYXRpb24gPSBOU01ha2VQb2ludChOU01pblgocmVjdCkgKyBwb3BPdmVySG9yaXpvbnRh bEFkanVzdCwgTlNNYXhZKHJlY3QpIC0gdmVydE9mZnNldCk7CisgICAgICAgIGZsb2F0IHZlcnRp Y2FsT2Zmc2V0ID0gcm91bmRmKChOU01heFkocmVjdCkgLSBOU01heFkodGl0bGVGcmFtZSkpICsg TlNIZWlnaHQodGl0bGVGcmFtZSkpOworICAgICAgICBmbG9hdCBob3Jpem9udGFsT2Zmc2V0ID0g dGV4dERpcmVjdGlvbiA9PSBMVFIgPyBwb3BPdmVySG9yaXpvbnRhbEFkanVzdCA6IDA7CisgICAg ICAgIGxvY2F0aW9uID0gTlNNYWtlUG9pbnQoTlNNaW5YKHJlY3QpICsgaG9yaXpvbnRhbE9mZnNl dCwgTlNNYXhZKHJlY3QpIC0gdmVydGljYWxPZmZzZXQpOwogICAgIH0gZWxzZQogICAgICAgICBs b2NhdGlvbiA9IE5TTWFrZVBvaW50KE5TTWluWChyZWN0KSArIHBvcFVuZGVySG9yaXpvbnRhbEFk anVzdCwgTlNNYXhZKHJlY3QpICsgcG9wVW5kZXJWZXJ0aWNhbEFkanVzdCk7ICAKIAo=