157143 2016-04-28 11:05:08 -0700 DebuggerScope::className() should not assert scope->isValid(). 2016-04-28 11:34:40 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam benjamin fpizlo ggaren keith_miller msaboff saam oldest_to_newest 1188309 0 mark.lam 2016-04-28 11:05:08 -0700 DebuggerScope::className() should not assert scope->isValid() because the TypeProfiler logs objects it encounters, and may indirectly call JSObject::calculatedClassName() on those objects later, thereby calling DebuggerScope::className() on an invalidated DebuggerScope. The existing handling in DebuggerScope::className() for an invalidated scope (that returns a null string) is sufficient. 1188312 1 mark.lam 2016-04-28 11:10:32 -0700 <rdar://problem/20790971> 1188313 2 277634 mark.lam 2016-04-28 11:12:26 -0700 Created attachment 277634 proposed patch. 1188316 3 277634 keith_miller 2016-04-28 11:15:40 -0700 Comment on attachment 277634 proposed patch. r=me 1188319 4 mark.lam 2016-04-28 11:19:04 -0700 Thanks for the review. Landed in r200200: <http://trac.webkit.org/r200200>. 1188325 5 mark.lam 2016-04-28 11:30:24 -0700 Correction: this bug is not <rdar://problem/20790971>. There was a mis-aggregation. 1188328 6 webkit-bug-importer 2016-04-28 11:33:42 -0700 <rdar://problem/25985293> 1188330 7 webkit-bug-importer 2016-04-28 11:34:40 -0700 <rdar://problem/25985379> 277634 2016-04-28 11:12:26 -0700 2016-04-28 11:15:40 -0700 proposed patch. bug-157143.patch text/plain 1905 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAwMTk4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE2LTA0LTI4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBE ZWJ1Z2dlclNjb3BlOjpjbGFzc05hbWUoKSBzaG91bGQgbm90IGFzc2VydCBzY29wZS0+aXNWYWxp ZCgpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3 MTQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRGVi dWdnZXJTY29wZTo6Y2xhc3NOYW1lKCkgc2hvdWxkIG5vdCBhc3NlcnQgc2NvcGUtPmlzVmFsaWQo KSBiZWNhdXNlIHRoZQorICAgICAgICBUeXBlUHJvZmlsZXIgbG9ncyBvYmplY3RzIGl0IGVuY291 bnRlcnMsIGFuZCBtYXkgaW5kaXJlY3RseSBjYWxsCisgICAgICAgIEpTT2JqZWN0OjpjYWxjdWxh dGVkQ2xhc3NOYW1lKCkgb24gdGhvc2Ugb2JqZWN0cyBsYXRlciwgdGhlcmVieSBjYWxsaW5nCisg ICAgICAgIERlYnVnZ2VyU2NvcGU6OmNsYXNzTmFtZSgpIG9uIGFuIGludmFsaWRhdGVkIERlYnVn Z2VyU2NvcGUuCisKKyAgICAgICAgVGhlIGV4aXN0aW5nIGhhbmRsaW5nIGluIERlYnVnZ2VyU2Nv cGU6OmNsYXNzTmFtZSgpIGZvciBhbiBpbnZhbGlkYXRlZCBzY29wZQorICAgICAgICAodGhhdCBy ZXR1cm5zIGEgbnVsbCBzdHJpbmcpIGlzIHN1ZmZpY2llbnQuCisKKyAgICAgICAgKiBkZWJ1Z2dl ci9EZWJ1Z2dlclNjb3BlLmNwcDoKKyAgICAgICAgKEpTQzo6RGVidWdnZXJTY29wZTo6Y2xhc3NO YW1lKToKKwogMjAxNi0wNC0yOCAgQ2FpdGxpbiBQb3R0ZXIgIDxjYWl0cEBpZ2FsaWEuY29tPgog CiAgICAgICAgIFtKU0NdIGltcGxlbWVudCBzcGVjIGNoYW5nZXMgZm9yIFN0cmluZyNwYWRTdGFy dCBhbmQgU3RyaW5nI3BhZEVuZApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RlYnVnZ2Vy L0RlYnVnZ2VyU2NvcGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZWJ1Z2dlci9EZWJ1Z2dlclNjb3BlLmNwcAkocmV2aXNpb24gMjAwMTc2KQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL2RlYnVnZ2VyL0RlYnVnZ2VyU2NvcGUuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC02MCw3ICs2MCw4IEBAIHZvaWQgRGVidWdnZXJTY29wZTo6dmlzaXRDaGlsZHJlbihKU0NlbGwK IFN0cmluZyBEZWJ1Z2dlclNjb3BlOjpjbGFzc05hbWUoY29uc3QgSlNPYmplY3QqIG9iamVjdCkK IHsKICAgICBjb25zdCBEZWJ1Z2dlclNjb3BlKiBzY29wZSA9IGpzQ2FzdDxjb25zdCBEZWJ1Z2dl clNjb3BlKj4ob2JqZWN0KTsKLSAgICBBU1NFUlQoc2NvcGUtPmlzVmFsaWQoKSk7CisgICAgLy8g V2UgY2Fubm90IGFzc2VydCB0aGF0IHNjb3BlLT5pc1ZhbGlkKCkgYmVjYXVzZSB0aGUgVHlwZVBy b2ZpbGVyIG1heSBlbmNvdW50ZXIgYW4gaW52YWxpZGF0ZWQKKyAgICAvLyBEZWJ1Z2dlclNjb3Bl IGluIGl0cyBsb2cgZW50cmllcy4gV2UganVzdCBuZWVkIHRvIGhhbmRsZSBpdCBhcHByb3ByaWF0 ZWx5IGFzIGJlbG93LgogICAgIGlmICghc2NvcGUtPmlzVmFsaWQoKSkKICAgICAgICAgcmV0dXJu IFN0cmluZygpOwogICAgIEpTT2JqZWN0KiB0aGlzT2JqZWN0ID0gSlNTY29wZTo6b2JqZWN0QXRT Y29wZShzY29wZS0+anNTY29wZSgpKTsK