157141 2016-04-28 10:20:15 -0700 inspector/indexeddb/requestDatabaseNames.html is flaky on Mac 2016-05-11 13:40:53 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Mac Unspecified RESOLVED FIXED P2 Normal --- 149117 1 ryanhaddad beidson ap beidson oldest_to_newest 1188294 0 ryanhaddad 2016-04-28 10:20:15 -0700 Flakiness dashboard: <https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Findexeddb%2FrequestDatabaseNames.html> Most recent failure: <https://build.webkit.org/builders/Apple%20Yosemite%20Debug%20WK2%20(Tests)/builds/11744> --- /Volumes/Data/slave/yosemite-debug-tests-wk2/build/layout-test-results/inspector/indexeddb/requestDatabaseNames-expected.txt +++ /Volumes/Data/slave/yosemite-debug-tests-wk2/build/layout-test-results/inspector/indexeddb/requestDatabaseNames-actual.txt @@ -3,17 +3,17 @@ CONSOLE MESSAGE: line 10: Created Database 'ቍ' CONSOLE MESSAGE: line 10: Created Database '𐍆' -PASS: No IndexedDB databases should exist initially +FAIL: No IndexedDB databases should exist initially Created Database 'Database1' -PASS: A single IndexedDB database should exist -["Database1"] +FAIL: A single IndexedDB database should exist +["Database1","Page 20Cache 20Test"] Created Database 'Database2' -PASS: Two IndexedDB databases should exist -["Database1","Database2"] +FAIL: Two IndexedDB databases should exist +["Database1","Database2","Page 20Cache 20Test"] Created Database 'ቍ' -PASS: Two IndexedDB databases should exist -["Database1","Database2","ቍ"] +FAIL: Two IndexedDB databases should exist +["Database1","Database2","Page 20Cache 20Test","ቍ"] Created Database '𐍆' -PASS: Four IndexedDB databases should exist -["Database1","Database2","ቍ","𐍆"] +FAIL: Four IndexedDB databases should exist +["Database1","Database2","Page 20Cache 20Test","ቍ","𐍆"] 1188320 1 beidson 2016-04-28 11:20:52 -0700 INTERESTING. Test test appears to be conflicting with other tests running at the same time using either the same DatabaseProcess or same database directory. If multiple WKTR are using the same DatabaseProcess, they shouldn't - That's bad. If multiple WKTRs are pointing their DatabaseProcesses at the same database directory, they shouldn't - That's bad. I wonder if this is the source of many of the other WK2 flakes? 1188322 2 beidson 2016-04-28 11:22:52 -0700 I'm going to make a change to this test to try to prove or disprove this. 1188323 3 beidson 2016-04-28 11:25:08 -0700 Also, just to clarify, DRTs should *also* not share the same databases directory. I don't know if they are, but they shouldn't. 1188342 4 beidson 2016-04-28 12:22:57 -0700 Added one tiny additional bit of logging to help support this theory in http://trac.webkit.org/changeset/200202 In a little bit I'm going to turn on debug build logging to see if this is really happening. 1188352 5 beidson 2016-04-28 13:00:46 -0700 I did a "run-webkit-tests storage/indexeddb" which runs 3 WKTRs I also did a "run-webkit-tests -1 storage/indexeddb" which runs 3 DRTs I then monitored the filesystem using fs_usage. In either the WK1 or WK2 case, each unique DRT or WKTR did, in fact, have an independent directory for its databases. So that theory seems scratched... But the results here clearly show tests stomping on each other in some way. 1188379 6 beidson 2016-04-28 14:05:31 -0700 Aha. It's a page cache test (of course), and causes problems in the same process down the line. I can reliably reproduce like so: run-webkit-tests -1 fast/history/page-cache-indexed-opened-db.html inspector/indexeddb --child-processes=1 1188391 7 beidson 2016-04-28 14:41:22 -0700 This is actually a simple bug in the "get all database names" code that chokes on database names with spaces in them. 1188398 8 277652 beidson 2016-04-28 15:03:56 -0700 Created attachment 277652 Patch 1188400 9 beidson 2016-04-28 15:10:44 -0700 http://trac.webkit.org/changeset/200212 277652 2016-04-28 15:03:56 -0700 2016-04-28 15:07:26 -0700 Patch bug-157141-20160428150428.patch text/plain 6707 beidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwMjAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGExZTIwNDdkZmJiMTkw ODY0YTVkYmIzMDE4ZjllODk4ODgwZmQ4NC4uMGUzNmRlYzM4OTM5NDFlYmYwODRkNDNmZWVlMjgz MDYzMWEwNDljMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE2LTA0LTI4ICBCcmFk eSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAorICAgICAgICBpbnNwZWN0b3IvaW5kZXhl ZGRiL3JlcXVlc3REYXRhYmFzZU5hbWVzLmh0bWwgaXMgZmxha3kgb24gTWFjLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3MTQxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogaW5zcGVjdG9yL2lu ZGV4ZWRkYi9kZWxldGVEYXRhYmFzZU5hbWVzV2l0aFNwYWNlLmh0bWwKKworICAgICAgICAqIHBs YXRmb3JtL0ZpbGVTeXN0ZW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6ZGVjb2RlRnJvbUZpbGVu YW1lKTogQWR2YW5jZSBpdGVyYXRvciBhZnRlciBkZWNvZGluZy4KKworMjAxNi0wNC0yOCAgQnJh ZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CisKICAgICAgICAgTW9kZXJuIElEQjogUmVp bXBsZW1lbnQgV2ViIEluc3BlY3RvciBjb2RlIHRoYXQgd2FzIHRpZWQgdG8gTGVnYWN5IElEQi4K ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NDY4Ngog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9GaWxlU3lzdGVtLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL0ZpbGVTeXN0ZW0uY3BwCmluZGV4IDMxZTkyNzBiZTQyODgw NzBkZmI1ODdiYjJjODY5Y2VjMDk1NDU3NmUuLmY4MmI2MGQ3OTBlNjM2ZDlkN2JiZGRhZmFhOWU4 MjEzN2ZkYTViOGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0ZpbGVTeXN0 ZW0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0ZpbGVTeXN0ZW0uY3BwCkBAIC0x NjAsNiArMTYwLDggQEAgU3RyaW5nIGRlY29kZUZyb21GaWxlbmFtZShjb25zdCBTdHJpbmcmIGlu cHV0U3RyaW5nKQogICAgICAgICAgICAgICAgIHJldHVybiB7IH07CiAKICAgICAgICAgICAgIHJl c3VsdC5hcHBlbmQoY2hhcmFjdGVyIHwgdmFsdWUpOworICAgICAgICAgICAgaSArPSAyOworCiAg ICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgfQogCkBAIC0xODUsNiArMTg3LDcgQEAgU3Ry aW5nIGRlY29kZUZyb21GaWxlbmFtZShjb25zdCBTdHJpbmcmIGlucHV0U3RyaW5nKQogICAgICAg ICAgICAgcmV0dXJuIHsgfTsKIAogICAgICAgICByZXN1bHQuYXBwZW5kKGNoYXJhY3RlciB8IHZh bHVlKTsKKyAgICAgICAgaSArPSA1OwogICAgIH0KIAogICAgIHJldHVybiByZXN1bHQudG9TdHJp bmcoKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0No YW5nZUxvZwppbmRleCBjOTU1YmI1ZTU1NjgzNzlhZjhiOWU2ZDkyOGZkYzQ3MjVhMGExZmI4Li4x NTk3OTQ3MjQxYjg5OGNlNGExM2JkMDY5YTNjYjIyYWViNzA0YjBjIDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEs MTUgQEAKIDIwMTYtMDQtMjggIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCisg ICAgICAgIGluc3BlY3Rvci9pbmRleGVkZGIvcmVxdWVzdERhdGFiYXNlTmFtZXMuaHRtbCBpcyBm bGFreSBvbiBNYWMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNTcxNDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIGluc3BlY3Rvci9pbmRleGVkZGIvZGVsZXRlRGF0YWJhc2VOYW1lc1dpdGhTcGFjZS1l eHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGluc3BlY3Rvci9pbmRleGVkZGIvZGVsZXRl RGF0YWJhc2VOYW1lc1dpdGhTcGFjZS5odG1sOiBBZGRlZC4KKworMjAxNi0wNC0yOCAgQnJhZHkg RWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CisKICAgICAgICAgUkVHUkVTU0lPTihyMjAwMTYz KTogaW5zcGVjdG9yL2luZGV4ZWRkYi9yZXF1ZXN0RGF0YWJhc2VOYW1lcy5odG1sIGlzIGZsYWt5 IG9uIE1hYy4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE1NzE0MQogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvaW5kZXhlZGRiL2Rl bGV0ZURhdGFiYXNlTmFtZXNXaXRoU3BhY2UtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW5z cGVjdG9yL2luZGV4ZWRkYi9kZWxldGVEYXRhYmFzZU5hbWVzV2l0aFNwYWNlLWV4cGVjdGVkLnR4 dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwLi5hY2Q0YWMzMmRlMWQ5Y2MwNjNjOTY1MzhlOWUxODA0OGM5NTBjYjc4Ci0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2luZGV4ZWRkYi9kZWxldGVE YXRhYmFzZU5hbWVzV2l0aFNwYWNlLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDEwIEBACitDT05T T0xFIE1FU1NBR0U6IGxpbmUgMTE6IENyZWF0ZWQgRGF0YWJhc2UgJ0RhdGFiYXNlIFdpdGggU3Bh Y2UnCisKK1BBU1M6IE5vIEluZGV4ZWREQiBkYXRhYmFzZXMgc2hvdWxkIGV4aXN0IGluaXRpYWxs eQorW10KK0NyZWF0ZWQgRGF0YWJhc2UgJ0RhdGFiYXNlIFdpdGggU3BhY2UnCitQQVNTOiBBIHNp bmdsZSBJbmRleGVkREIgZGF0YWJhc2Ugc2hvdWxkIGV4aXN0CitbIkRhdGFiYXNlIFdpdGggU3Bh Y2UiXQorUEFTUzogTm8gSW5kZXhlZERCIGRhdGFiYXNlcyBzaG91bGQgZXhpc3QgYXQgdGhlIGVu ZCBiZWNhdXNlIHdlIGp1c3QgZGVsZXRlZCB0aGVtCitbXQorCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9pbnNwZWN0b3IvaW5kZXhlZGRiL2RlbGV0ZURhdGFiYXNlTmFtZXNXaXRoU3BhY2UuaHRt bCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9pbmRleGVkZGIvZGVsZXRlRGF0YWJhc2VOYW1lc1dp dGhTcGFjZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmMxNDEzZThiZDI4MDJkOThhOTQ5OTg3YmQxNjE1MzUw ZWY1ZGM3YjMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvaW5kZXhl ZGRiL2RlbGV0ZURhdGFiYXNlTmFtZXNXaXRoU3BhY2UuaHRtbApAQCAtMCwwICsxLDg4IEBACis8 IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vaHR0cC90 ZXN0cy9pbnNwZWN0b3IvcmVzb3VyY2VzL2luc3BlY3Rvci10ZXN0LmpzIj48L3NjcmlwdD4KKzxz Y3JpcHQ+CitmdW5jdGlvbiBjcmVhdGVEYXRhYmFzZShuYW1lKQoreworICAgIGxldCByZXF1ZXN0 ID0gd2luZG93LmluZGV4ZWREQi5vcGVuKG5hbWUsIDEpOworICAgIHJlcXVlc3QuYWRkRXZlbnRM aXN0ZW5lcignc3VjY2VzcycsIGZ1bmN0aW9uKGV2ZW50KSB7CisgICAgICAgIGV2ZW50LnRhcmdl dC5yZXN1bHQuY2xvc2UoKTsKKyAgICAgICAgY29uc29sZS5sb2coYENyZWF0ZWQgRGF0YWJhc2Ug JyR7bmFtZX0nYCk7CisgICAgfSk7Cit9CisKK2Z1bmN0aW9uIGRlbGV0ZURhdGFiYXNlTmFtZXMo bmFtZXMpCit7CisgICAgZm9yIChsZXQgbmFtZSBvZiBuYW1lcykKKyAgICAgICAgdmFyIHJlcXVl c3QgPSB3aW5kb3cuaW5kZXhlZERCLmRlbGV0ZURhdGFiYXNlKG5hbWUpOworfQorCitmdW5jdGlv biB0ZXN0KCkKK3sKKyAgICB2YXIgc3RlcHMgPSBbCisgICAgICAgIHsKKyAgICAgICAgICAgIGFj dGlvbjogZnVuY3Rpb24oKSB7CisgICAgICAgICAgICAgICAgLy8gRklYTUU6IFJlbW92ZSBhbnkg ZXhpc3RpbmcgSW5kZXhlZERCIGRhdGFiYXNlcyB0aGF0IG1pZ2h0IGV4aXN0IHRvIHdvcmthcm91 bmQ6CisgICAgICAgICAgICAgICAgLy8gPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE0ODAwNj4gRWFj aCB0ZXN0IHNob3VsZCBydW4gd2l0aCBpdHMgb3duIGNsZWFuIGRhdGEgc3RvcmUKKyAgICAgICAg ICAgICAgICBJbmRleGVkREJBZ2VudC5yZXF1ZXN0RGF0YWJhc2VOYW1lcyhXZWJJbnNwZWN0b3Iu ZnJhbWVSZXNvdXJjZU1hbmFnZXIubWFpbkZyYW1lLnNlY3VyaXR5T3JpZ2luLCBmdW5jdGlvbihl cnJvciwgbmFtZXMpIHsKKyAgICAgICAgICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5ldmFsdWF0 ZUluUGFnZSgiZGVsZXRlRGF0YWJhc2VOYW1lcygiICsgSlNPTi5zdHJpbmdpZnkobmFtZXMpICsg IikiKTsKKyAgICAgICAgICAgICAgICAgICAgbmV4dCgpOworICAgICAgICAgICAgICAgIH0pOwor ICAgICAgICAgICAgfQorICAgICAgICB9LAorICAgICAgICB7CisgICAgICAgICAgICBhY3Rpb246 IGZ1bmN0aW9uKCkgeworICAgICAgICAgICAgICAgIEluZGV4ZWREQkFnZW50LnJlcXVlc3REYXRh YmFzZU5hbWVzKFdlYkluc3BlY3Rvci5mcmFtZVJlc291cmNlTWFuYWdlci5tYWluRnJhbWUuc2Vj dXJpdHlPcmlnaW4sIGZ1bmN0aW9uKGVycm9yLCBuYW1lcykgeworICAgICAgICAgICAgICAgICAg ICBJbnNwZWN0b3JUZXN0LmV4cGVjdE5vRXJyb3IoZXJyb3IpOworICAgICAgICAgICAgICAgICAg ICBJbnNwZWN0b3JUZXN0LmV4cGVjdFRoYXQobmFtZXMubGVuZ3RoID09PSAwLCAiTm8gSW5kZXhl ZERCIGRhdGFiYXNlcyBzaG91bGQgZXhpc3QgaW5pdGlhbGx5Iik7CisgICAgICAgICAgICAgICAg ICAgIEluc3BlY3RvclRlc3QubG9nKEpTT04uc3RyaW5naWZ5KG5hbWVzKSk7CisgICAgICAgICAg ICAgICAgICAgIEluc3BlY3RvclRlc3QuZXZhbHVhdGVJblBhZ2UoImNyZWF0ZURhdGFiYXNlKCdE YXRhYmFzZSBXaXRoIFNwYWNlJykiKTsKKyAgICAgICAgICAgICAgICB9KTsKKyAgICAgICAgICAg IH0KKyAgICAgICAgfSwKKyAgICAgICAgeworICAgICAgICAgICAgYWN0aW9uOiBmdW5jdGlvbigp IHsKKyAgICAgICAgICAgICAgICBJbmRleGVkREJBZ2VudC5yZXF1ZXN0RGF0YWJhc2VOYW1lcyhX ZWJJbnNwZWN0b3IuZnJhbWVSZXNvdXJjZU1hbmFnZXIubWFpbkZyYW1lLnNlY3VyaXR5T3JpZ2lu LCBmdW5jdGlvbihlcnJvciwgbmFtZXMpIHsKKyAgICAgICAgICAgICAgICAgICAgSW5zcGVjdG9y VGVzdC5leHBlY3ROb0Vycm9yKGVycm9yKTsKKyAgICAgICAgICAgICAgICAgICAgSW5zcGVjdG9y VGVzdC5leHBlY3RUaGF0KG5hbWVzLmxlbmd0aCA9PT0gMSwgIkEgc2luZ2xlIEluZGV4ZWREQiBk YXRhYmFzZSBzaG91bGQgZXhpc3QiKTsKKyAgICAgICAgICAgICAgICAgICAgSW5zcGVjdG9yVGVz dC5sb2coSlNPTi5zdHJpbmdpZnkobmFtZXMpKTsKKyAgICAgICAgICAgICAgICAgICAgSW5zcGVj dG9yVGVzdC5ldmFsdWF0ZUluUGFnZSgiZGVsZXRlRGF0YWJhc2VOYW1lcyhbJ0RhdGFiYXNlIFdp dGggU3BhY2UnXSkiKTsKKyAgICAgICAgICAgICAgICAgICAgbmV4dCgpOworICAgICAgICAgICAg ICAgIH0pOworICAgICAgICAgICAgfQorICAgICAgICB9LAorICAgICAgICB7CisgICAgICAgICAg ICBhY3Rpb246IGZ1bmN0aW9uKCkgeworICAgICAgICAgICAgICAgIEluZGV4ZWREQkFnZW50LnJl cXVlc3REYXRhYmFzZU5hbWVzKFdlYkluc3BlY3Rvci5mcmFtZVJlc291cmNlTWFuYWdlci5tYWlu RnJhbWUuc2VjdXJpdHlPcmlnaW4sIGZ1bmN0aW9uKGVycm9yLCBuYW1lcykgeworICAgICAgICAg ICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmV4cGVjdE5vRXJyb3IoZXJyb3IpOworICAgICAgICAg ICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmV4cGVjdFRoYXQobmFtZXMubGVuZ3RoID09PSAwLCAi Tm8gSW5kZXhlZERCIGRhdGFiYXNlcyBzaG91bGQgZXhpc3QgYXQgdGhlIGVuZCBiZWNhdXNlIHdl IGp1c3QgZGVsZXRlZCB0aGVtIik7CisgICAgICAgICAgICAgICAgICAgIEluc3BlY3RvclRlc3Qu bG9nKEpTT04uc3RyaW5naWZ5KG5hbWVzKSk7CisgICAgICAgICAgICAgICAgICAgIG5leHQoKTsK KyAgICAgICAgICAgICAgICB9KTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfSwKKyAgICBdOwor CisgICAgZnVuY3Rpb24gbmV4dCgpIHsKKyAgICAgICAgbGV0IHN0ZXAgPSBzdGVwcy5zaGlmdCgp OworICAgICAgICBpZiAoIXN0ZXApIHsKKyAgICAgICAgICAgIEluc3BlY3RvclRlc3QuY29tcGxl dGVUZXN0KCk7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKyAgICAgICAgc3RlcC5h Y3Rpb24oKTsKKyAgICB9CisKKyAgICBXZWJJbnNwZWN0b3IubG9nTWFuYWdlci5hZGRFdmVudExp c3RlbmVyKFdlYkluc3BlY3Rvci5Mb2dNYW5hZ2VyLkV2ZW50Lk1lc3NhZ2VBZGRlZCwgZnVuY3Rp b24oZXZlbnQpIHsKKyAgICAgICAgSW5zcGVjdG9yVGVzdC5sb2coZXZlbnQuZGF0YS5tZXNzYWdl Lm1lc3NhZ2VUZXh0KTsKKyAgICAgICAgbmV4dCgpOworICAgIH0pOworCisgICAgSW5zcGVjdG9y VGVzdC5sb2coIiIpOworICAgIG5leHQoKTsKK30KKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkg b25sb2FkPSJydW5UZXN0KCkiPgorPC9ib2R5PgorPC9odG1sPgo=