157129 2016-04-28 04:43:55 -0700 [css-grid] Fix typo in CSS class for layout tests 2016-04-28 07:01:38 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60731 1 rego rego commit-queue jfernandez lforschler rego svillar oldest_to_newest 1188199 0 rego 2016-04-28 04:43:55 -0700 [css-grid] Fix typo in CSS class for layout tests 1188200 1 277610 rego 2016-04-28 04:44:31 -0700 Created attachment 277610 Patch 1188203 2 277610 svillar 2016-04-28 05:07:46 -0700 Comment on attachment 277610 Patch What about removing it? 1188222 3 rego 2016-04-28 06:13:31 -0700 Thanks for the review. (In reply to comment #2) > Comment on attachment 277610 [details] > Patch > > What about removing it? The class is called "secondRowFourthColumn", so I prefer to keep it. So if it's used in a future test (with less items) it'd work properly. Other option would be to change what's used in those tests for something like "autoRowFourthColumn", but I think it doesn't worth it. 1188232 4 277610 commit-queue 2016-04-28 07:01:34 -0700 Comment on attachment 277610 Patch Clearing flags on attachment: 277610 Committed r200189: <http://trac.webkit.org/changeset/200189> 1188233 5 commit-queue 2016-04-28 07:01:38 -0700 All reviewed patches have been landed. Closing bug. 277610 2016-04-28 04:44:31 -0700 2016-04-28 07:01:34 -0700 Patch bug-157129-20160428134502.patch text/plain 1461 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwMTQ1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMDFjODM4OTI0MmQzM2JlNmE1ODE1 ODQ0Y2FlODBlZjZhNGZjZTkxYi4uOWI2NGZhYTY2ZWQwZTdjZGNkNGM0MjU3NzhiOTYyZTJjMmY0 YmM5OCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE2LTA0LTI4ICBNYW51ZWwgUmVnbyBDYXNh c25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtjc3MtZ3JpZF0gRml4IHR5cG8g aW4gQ1NTIGNsYXNzIGZvciBsYXlvdXQgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NzEyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIENTUyBjbGFzcyAic2Vjb25kUm93Rm91cnRoQ29sdW1uIiB3 YXMgbm90IGFjdHVhbGx5IHNldHRpbmcKKyAgICAgICAgdGhlIHNlY29uZCByb3cgZHVlIHRvIGEg dHlwby4KKworICAgICAgICBUaGUgY2hhbmdlIGRvZXNuJ3QgYWZmZWN0IGFueSB0ZXN0IGp1c3Qg YnkgY2hhbmNlLAorICAgICAgICBhcyB0aGUgYXV0by1wbGFjZW1lbnQgYWxnb3JpdGhtIGlzIGFs cmVhZHkgcG9zaXRpb25pbmcKKyAgICAgICAgdGhvc2UgaXRlbXMgb24gdGhlIHNlY29uZCByb3cu CisKKyAgICAgICAgKiBmYXN0L2Nzcy1ncmlkLWxheW91dC9yZXNvdXJjZXMvZ3JpZC5jc3M6Cisg ICAgICAgICguc2Vjb25kUm93Rm91cnRoQ29sdW1uKToKKwogMjAxNi0wNC0yNyAgSm9obiBXaWxh bmRlciAgPHdpbGFuZGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgbGF5b3V0IHRlc3RzIGZv ciBsZWdhY3kgSFRUUCBoZWFkZXJzIGluIFdlYlNvY2tldHMKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2Zhc3QvY3NzLWdyaWQtbGF5b3V0L3Jlc291cmNlcy9ncmlkLmNzcyBiL0xheW91dFRlc3Rz L2Zhc3QvY3NzLWdyaWQtbGF5b3V0L3Jlc291cmNlcy9ncmlkLmNzcwppbmRleCA5NmY2NzQ2MGVl NmQ2Yzg3NjVkYTFkZTgyMTRiMzcxYmNlZWMyYTlhLi4yY2EzNjU0MjZjZGM0MzM3NDczZDE3NWRi OGM5NWZkZTI2YmNmZmIwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1ncmlkLWxh eW91dC9yZXNvdXJjZXMvZ3JpZC5jc3MKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ3JpZC1s YXlvdXQvcmVzb3VyY2VzL2dyaWQuY3NzCkBAIC04Myw3ICs4Myw3IEBACiAuc2Vjb25kUm93Rm91 cnRoQ29sdW1uIHsKICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBwaW5rOwogICAgIC13ZWJraXQtZ3Jp ZC1jb2x1bW46IDQ7Ci0gICAgLXdlYmtpdGdyaWQtcm93OiAyOworICAgIC13ZWJraXQtZ3JpZC1y b3c6IDI7CiB9CiAKIC50aGlyZFJvd0ZpcnN0Q29sdW1uIHsK