157124 2016-04-28 01:19:57 -0700 [ES6] RegExp.prototype.@@replace should use @isObject instead of `instanceof` for object guard 2016-05-02 03:47:44 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 157265 1 ysuzuki ysuzuki commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1188180 0 ysuzuki 2016-04-28 01:19:57 -0700 [ES6] RegExp.prototype.@@replace should use @isObject instead of `instanceof` for object guard 1188181 1 277606 ysuzuki 2016-04-28 01:22:46 -0700 Created attachment 277606 Patch 1188227 2 277606 keith_miller 2016-04-28 06:34:50 -0700 Comment on attachment 277606 Patch r=me 1188580 3 277606 ysuzuki 2016-04-29 03:46:23 -0700 Comment on attachment 277606 Patch Thank you for your review! 1188589 4 277606 commit-queue 2016-04-29 04:35:57 -0700 Comment on attachment 277606 Patch Clearing flags on attachment: 277606 Committed r200239: <http://trac.webkit.org/changeset/200239> 1188590 5 commit-queue 2016-04-29 04:36:02 -0700 All reviewed patches have been landed. Closing bug. 277606 2016-04-28 01:22:46 -0700 2016-04-29 04:35:57 -0700 Patch bug-157124-20160428172317.patch text/plain 3424 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwMTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 MjdiNWY0MDNkOTRlNzcwYzVkZjFlNWVkNWY1NmFiZTM5YzFkZjYzLi45OGE0ZDY3YWJhMzYwYWZh MzdiM2QyOWU3ZDBmZjg3OGJlZjE5YmQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxNi0wNC0yOCAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbRVM2XSBSZWdFeHAucHJvdG90eXBlLkBAcmVwbGFjZSBzaG91bGQg dXNlIEBpc09iamVjdCBpbnN0ZWFkIG9mIGBpbnN0YW5jZW9mYCBmb3Igb2JqZWN0IGd1YXJkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTcxMjQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgQGlzT2Jq ZWN0IGluc3RlYWQgb2YgYGluc3RhbmNlb2YgQE9iamVjdGAuCisgICAgICAgIFRoZSBgaW5zdGFu Y2VvZmAgY2hlY2sgaXMgbm90IGVub3VnaCB0byBjaGVjayBPYmplY3QgVHlwZS4KKyAgICAgICAg VGhpcyBmaXggaXRzZWxmIGlzIHRoZSBzYW1lIHRvIHIxOTk2NDcsIGFuZCB0aGlzIHBhdGNoIGlz IGZvciBSZWdFeHAucHJvdG90eXBlLkBAcmVwbGFjZS4KKworICAgICAgICAqIGJ1aWx0aW5zL1Jl Z0V4cFByb3RvdHlwZS5qczoKKyAgICAgICAgKHJlcGxhY2UpOgorICAgICAgICAqIHRlc3RzL3N0 cmVzcy9yZWdleHAtcmVwbGFjZS1pbi1vdGhlci1yZWFsbS1zaG91bGQtd29yay5qczogQWRkZWQu CisgICAgICAgIChzaG91bGRCZSk6CisgICAgICAgICogdGVzdHMvc3RyZXNzL3JlZ2V4cC1yZXBs YWNlLXNob3VsZC13b3JrLXdpdGgtb2JqZWN0cy1ub3QtaW5oZXJpdGluZy1vYmplY3QtcHJvdG90 eXBlLmpzOiBBZGRlZC4KKyAgICAgICAgKHNob3VsZEJlKToKKyAgICAgICAgKHJlZ2V4cC5leGVj KToKKwogMjAxNi0wNC0yNyAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAg ICAgVGhlIEdldHRlclNldHRlciBzdHJ1Y3R1cmUgbmVlZHMgYSBnbG9iYWxPYmplY3QuCmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvUmVnRXhwUHJvdG90eXBlLmpz IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J1aWx0aW5zL1JlZ0V4cFByb3RvdHlwZS5qcwppbmRl eCBmMGNkYjE0OTYzM2U3M2Y1YWJhODgwN2Q2NTliM2NjOTE5NDFmMTE3Li42ZDZmYWZiZDIxMzIy MWI5YjQyNDZhOGMyZjUyMmUwMjliNDI0ZDBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvYnVpbHRpbnMvUmVnRXhwUHJvdG90eXBlLmpzCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9idWlsdGlucy9SZWdFeHBQcm90b3R5cGUuanMKQEAgLTE5Nyw3ICsxOTcsNyBAQCBmdW5j dGlvbiBnZXRTdWJzdGl0dXRpb24obWF0Y2hlZCwgc3RyLCBwb3NpdGlvbiwgY2FwdHVyZXMsIHJl cGxhY2VtZW50KQogICAgICAgICByZXR1cm4gcmVzdWx0ICsgcmVwbGFjZW1lbnQuc3Vic3RyaW5n KGxhc3RTdGFydCk7CiAgICAgfQogCi0gICAgaWYgKCEodGhpcyBpbnN0YW5jZW9mIEBPYmplY3Qp KQorICAgIGlmICghQGlzT2JqZWN0KHRoaXMpKQogICAgICAgICB0aHJvdyBuZXcgQFR5cGVFcnJv cigiUmVnRXhwLnByb3RvdHlwZS5AQHJlcGxhY2UgcmVxdWlyZXMgdGhhdCB8dGhpc3wgYmUgYW4g T2JqZWN0Iik7CiAKICAgICBsZXQgcmVnZXhwID0gdGhpczsKZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3MvcmVnZXhwLXJlcGxhY2UtaW4tb3RoZXItcmVhbG0t c2hvdWxkLXdvcmsuanMgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL3JlZ2V4 cC1yZXBsYWNlLWluLW90aGVyLXJlYWxtLXNob3VsZC13b3JrLmpzCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjBlOGNj NWRiMDJiMzY3NTQzOGVmMTcyNTVjNTBmYTYwNzAyYmEzYzQKLS0tIC9kZXYvbnVsbAorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL3JlZ2V4cC1yZXBsYWNlLWluLW90aGVy LXJlYWxtLXNob3VsZC13b3JrLmpzCkBAIC0wLDAgKzEsMTAgQEAKK2Z1bmN0aW9uIHNob3VsZEJl KGFjdHVhbCwgZXhwZWN0ZWQpIHsKKyAgICBpZiAoYWN0dWFsICE9PSBleHBlY3RlZCkKKyAgICAg ICAgdGhyb3cgbmV3IEVycm9yKGBiYWQgdmFsdWU6ICR7U3RyaW5nKGFjdHVhbCl9YCk7Cit9CisK K3ZhciByZWdleHAgPSAvSGVsbG8vOwordmFyIHN0cmluZyA9ICJIZWxsbyI7Cit2YXIgb3RoZXJS ZWFsbSA9IGNyZWF0ZUdsb2JhbE9iamVjdCgpOworc2hvdWxkQmUob3RoZXJSZWFsbS5SZWdFeHAu cHJvdG90eXBlW1N5bWJvbC5yZXBsYWNlXS5jYWxsKHJlZ2V4cCwgc3RyaW5nLCAiT0siKSwgIk9L IikKKwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9yZWdl eHAtcmVwbGFjZS1zaG91bGQtd29yay13aXRoLW9iamVjdHMtbm90LWluaGVyaXRpbmctb2JqZWN0 LXByb3RvdHlwZS5qcyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3MvcmVnZXhw LXJlcGxhY2Utc2hvdWxkLXdvcmstd2l0aC1vYmplY3RzLW5vdC1pbmhlcml0aW5nLW9iamVjdC1w cm90b3R5cGUuanMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNmExNzgyNTBjMTA3MzMwYzE3NWFkMGRlNWE1OGFjZTIy NjliYjQwMAotLS0gL2Rldi9udWxsCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9z dHJlc3MvcmVnZXhwLXJlcGxhY2Utc2hvdWxkLXdvcmstd2l0aC1vYmplY3RzLW5vdC1pbmhlcml0 aW5nLW9iamVjdC1wcm90b3R5cGUuanMKQEAgLTAsMCArMSwxMSBAQAorZnVuY3Rpb24gc2hvdWxk QmUoYWN0dWFsLCBleHBlY3RlZCkgeworICAgIGlmIChhY3R1YWwgIT09IGV4cGVjdGVkKQorICAg ICAgICB0aHJvdyBuZXcgRXJyb3IoYGJhZCB2YWx1ZTogJHtTdHJpbmcoYWN0dWFsKX1gKTsKK30K K3ZhciByZWdleHAgPSBPYmplY3QuY3JlYXRlKG51bGwpOworcmVnZXhwLnJlZyA9IC9IZWxsby87 CityZWdleHAuZXhlYyA9IGZ1bmN0aW9uICh2YWx1ZSkgeworICAgIHJldHVybiByZWdleHAucmVn LmV4ZWModmFsdWUpOworfTsKK3ZhciBzdHJpbmcgPSAiSGVsbG8iOworc2hvdWxkQmUoUmVnRXhw LnByb3RvdHlwZVtTeW1ib2wucmVwbGFjZV0uY2FsbChyZWdleHAsIHN0cmluZywgIk9LIiksICJP SyIpCg==