157108 2016-04-27 16:55:40 -0700 Don't throttle GuardMalloc on 8-core Macs 2016-04-27 23:46:26 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=156614 P2 Normal --- 1 ap ap commit-queue ddkilzer glenn lforschler oldest_to_newest 1188020 0 ap 2016-04-27 16:55:40 -0700 Bug 156614 has change the throttle factor for GuardMalloc WK2 to 1/2. But that doesn't seem necessary for 8-core Macs, only 12-core ones time out with 3/4 factor. 1188022 1 277549 ap 2016-04-27 16:58:34 -0700 Created attachment 277549 proposed patch 1188029 2 277551 ap 2016-04-27 17:15:11 -0700 Created attachment 277551 proposed patch Accidentally sent with a change I used for testing. 1188149 3 277551 commit-queue 2016-04-27 23:46:21 -0700 Comment on attachment 277551 proposed patch Clearing flags on attachment: 277551 Committed r200175: <http://trac.webkit.org/changeset/200175> 1188150 4 commit-queue 2016-04-27 23:46:26 -0700 All reviewed patches have been landed. Closing bug. 277549 2016-04-27 16:58:34 -0700 2016-04-27 17:15:11 -0700 proposed patch throttle.txt text/plain 2078 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwMDE2MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE2LTA0LTI3ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIERvbid0IHRocm90dGxlIEd1YXJkTWFsbG9jIG9uIDgtY29yZSBNYWNzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTcxMDgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHdhcyBt YWtpbmcgdGhlbSBzbG93ZXIgdW5uZWNlc3NhcmlseS4KKworICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0cHkvcG9ydC9tYWMucHk6IChNYWNQb3J0LmRlZmF1bHRfY2hpbGRfcHJvY2Vzc2VzKToKKwog MjAxNi0wNC0yNiAgS29uc3RhbnRpbiBUb2thcmV2ICA8YW5udWxlbkB5YW5kZXgucnU+CiAKICAg ICAgICAgVW5yZXZpZXdlZDogYWRkIG15c2VsZiB0byB0aGUgY29tbWl0dGVycyBsaXN0LgpJbmRl eDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L21hYy5weQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvbWFjLnB5CShyZXZpc2lvbiAyMDAwNDApCisrKyBUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvbWFjLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xNTUsMTIg KzE1NSwxMiBAQCBjbGFzcyBNYWNQb3J0KEFwcGxlUG9ydCk6CiAgICAgICAgIHNob3VsZF90aHJv dHRsZV9mb3Jfd2syID0gc2VsZi5nZXRfb3B0aW9uKCd3ZWJraXRfdGVzdF9ydW5uZXInKSBhbmQg ZGVmYXVsdF9jb3VudCA+IDQKICAgICAgICAgIyBXZSBhbHNvIHdhbnQgdG8gdGhyb3R0bGUgZm9y IGxlYWtzIGJvdHMuCiAgICAgICAgIGlmIHNob3VsZF90aHJvdHRsZV9mb3Jfd2syIG9yIHNlbGYu Z2V0X29wdGlvbignbGVha3MnKToKLSAgICAgICAgICAgIGlmIHNlbGYuZ2V0X29wdGlvbignZ3Vh cmRfbWFsbG9jJyk6Ci0gICAgICAgICAgICAgICAgIyBTb21lIDEyIGNvcmUgTWFjcyBnZXQgYSBs b3Qgb2YgdGVzdHMgdGltZSBvdXQgd2hlbiBydW5uaW5nIDE4IFdlYktpdFRlc3RSdW5uZXIgcHJv Y2Vzc2VzIChpdCdzIG5vdCBjbGVhciB3aGF0IHRoaXMgZGVwZW5kcyBvbikuCi0gICAgICAgICAg ICAgICAgIyBSdW5uaW5nIDEyIHByb2Nlc3NlcyByZXNvbHZlcyB0aGlzLCBhbmQgZG9lc24ndCBz ZWVtIHRvIGludHJvZHVjZSBhIG1lYXN1cmFibGUgcGVyZm9ybWFuY2UgZGVncmFkYXRpb24gb24g b3RoZXIgbWFjaGluZXMuCi0gICAgICAgICAgICAgICAgZGVmYXVsdF9jb3VudCA9IGludCguNSAq IGRlZmF1bHRfY291bnQpCi0gICAgICAgICAgICBlbHNlOgotICAgICAgICAgICAgICAgIGRlZmF1 bHRfY291bnQgPSBpbnQoLjc1ICogZGVmYXVsdF9jb3VudCkKKyAgICAgICAgICAgIGRlZmF1bHRf Y291bnQgPSBpbnQoLjc1ICogZGVmYXVsdF9jb3VudCkKKworICAgICAgICBpZiBzaG91bGRfdGhy b3R0bGVfZm9yX3drMiBhbmQgc2VsZi5nZXRfb3B0aW9uKCdndWFyZF9tYWxsb2MnKToKKyAgICAg ICAgICAgICMgU29tZSAxMiBjb3JlIE1hY3MgZ2V0IGEgbG90IG9mIHRlc3RzIHRpbWUgb3V0IHdo ZW4gcnVubmluZyAxOCBXZWJLaXRUZXN0UnVubmVyIHByb2Nlc3NlcyAoaXQncyBub3QgY2xlYXIg d2hhdCB0aGlzIGRlcGVuZHMgb24pLgorICAgICAgICAgICAgIyA8cmRhcjovL3Byb2JsZW0vMjU3 NTAzMDI+CisgICAgICAgICAgICBkZWZhdWx0X2NvdW50ID0gbWF4KGRlZmF1bHRfY291bnQsIDEy KQogCiAgICAgICAgICMgTWFrZSBzdXJlIHdlIGhhdmUgZW5vdWdoIHJhbSB0byBzdXBwb3J0IHRo YXQgbWFueSBpbnN0YW5jZXM6CiAgICAgICAgIHRvdGFsX21lbW9yeSA9IHNlbGYuaG9zdC5wbGF0 Zm9ybS50b3RhbF9ieXRlc19tZW1vcnkoKQo= 277551 2016-04-27 17:15:11 -0700 2016-04-27 23:46:21 -0700 proposed patch throttle.txt text/plain 2078 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwMDE2MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE2LTA0LTI3ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIERvbid0IHRocm90dGxlIEd1YXJkTWFsbG9jIG9uIDgtY29yZSBNYWNzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTcxMDgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHdhcyBt YWtpbmcgdGhlbSBzbG93ZXIgdW5uZWNlc3NhcmlseS4KKworICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0cHkvcG9ydC9tYWMucHk6IChNYWNQb3J0LmRlZmF1bHRfY2hpbGRfcHJvY2Vzc2VzKToKKwog MjAxNi0wNC0yNiAgS29uc3RhbnRpbiBUb2thcmV2ICA8YW5udWxlbkB5YW5kZXgucnU+CiAKICAg ICAgICAgVW5yZXZpZXdlZDogYWRkIG15c2VsZiB0byB0aGUgY29tbWl0dGVycyBsaXN0LgpJbmRl eDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L21hYy5weQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvbWFjLnB5CShyZXZpc2lvbiAyMDAwNDApCisrKyBUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvbWFjLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xNTUsMTIg KzE1NSwxMiBAQCBjbGFzcyBNYWNQb3J0KEFwcGxlUG9ydCk6CiAgICAgICAgIHNob3VsZF90aHJv dHRsZV9mb3Jfd2syID0gc2VsZi5nZXRfb3B0aW9uKCd3ZWJraXRfdGVzdF9ydW5uZXInKSBhbmQg ZGVmYXVsdF9jb3VudCA+IDQKICAgICAgICAgIyBXZSBhbHNvIHdhbnQgdG8gdGhyb3R0bGUgZm9y IGxlYWtzIGJvdHMuCiAgICAgICAgIGlmIHNob3VsZF90aHJvdHRsZV9mb3Jfd2syIG9yIHNlbGYu Z2V0X29wdGlvbignbGVha3MnKToKLSAgICAgICAgICAgIGlmIHNlbGYuZ2V0X29wdGlvbignZ3Vh cmRfbWFsbG9jJyk6Ci0gICAgICAgICAgICAgICAgIyBTb21lIDEyIGNvcmUgTWFjcyBnZXQgYSBs b3Qgb2YgdGVzdHMgdGltZSBvdXQgd2hlbiBydW5uaW5nIDE4IFdlYktpdFRlc3RSdW5uZXIgcHJv Y2Vzc2VzIChpdCdzIG5vdCBjbGVhciB3aGF0IHRoaXMgZGVwZW5kcyBvbikuCi0gICAgICAgICAg ICAgICAgIyBSdW5uaW5nIDEyIHByb2Nlc3NlcyByZXNvbHZlcyB0aGlzLCBhbmQgZG9lc24ndCBz ZWVtIHRvIGludHJvZHVjZSBhIG1lYXN1cmFibGUgcGVyZm9ybWFuY2UgZGVncmFkYXRpb24gb24g b3RoZXIgbWFjaGluZXMuCi0gICAgICAgICAgICAgICAgZGVmYXVsdF9jb3VudCA9IGludCguNSAq IGRlZmF1bHRfY291bnQpCi0gICAgICAgICAgICBlbHNlOgotICAgICAgICAgICAgICAgIGRlZmF1 bHRfY291bnQgPSBpbnQoLjc1ICogZGVmYXVsdF9jb3VudCkKKyAgICAgICAgICAgIGRlZmF1bHRf Y291bnQgPSBpbnQoLjc1ICogZGVmYXVsdF9jb3VudCkKKworICAgICAgICBpZiBzaG91bGRfdGhy b3R0bGVfZm9yX3drMiBhbmQgc2VsZi5nZXRfb3B0aW9uKCdndWFyZF9tYWxsb2MnKToKKyAgICAg ICAgICAgICMgU29tZSAxMiBjb3JlIE1hY3MgZ2V0IGEgbG90IG9mIHRlc3RzIHRpbWUgb3V0IHdo ZW4gcnVubmluZyAxOCBXZWJLaXRUZXN0UnVubmVyIHByb2Nlc3NlcyAoaXQncyBub3QgY2xlYXIg d2hhdCB0aGlzIGRlcGVuZHMgb24pLgorICAgICAgICAgICAgIyA8cmRhcjovL3Byb2JsZW0vMjU3 NTAzMDI+CisgICAgICAgICAgICBkZWZhdWx0X2NvdW50ID0gbWluKGRlZmF1bHRfY291bnQsIDEy KQogCiAgICAgICAgICMgTWFrZSBzdXJlIHdlIGhhdmUgZW5vdWdoIHJhbSB0byBzdXBwb3J0IHRo YXQgbWFueSBpbnN0YW5jZXM6CiAgICAgICAgIHRvdGFsX21lbW9yeSA9IHNlbGYuaG9zdC5wbGF0 Zm9ybS50b3RhbF9ieXRlc19tZW1vcnkoKQo=